[INFO] updating cached repository alocquet/aoc-2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/alocquet/aoc-2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/alocquet/aoc-2018" "work/ex/clippy-test-run/sources/stable/gh/alocquet/aoc-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/alocquet/aoc-2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/alocquet/aoc-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alocquet/aoc-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alocquet/aoc-2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] edb33bf0010138de4f202c98946f54e7b4b5e932 [INFO] sha for GitHub repo alocquet/aoc-2018: edb33bf0010138de4f202c98946f54e7b4b5e932 [INFO] validating manifest of alocquet/aoc-2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of alocquet/aoc-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing alocquet/aoc-2018 [INFO] finished frobbing alocquet/aoc-2018 [INFO] frobbed toml for alocquet/aoc-2018 written to work/ex/clippy-test-run/sources/stable/gh/alocquet/aoc-2018/Cargo.toml [INFO] started frobbing alocquet/aoc-2018 [INFO] finished frobbing alocquet/aoc-2018 [INFO] frobbed toml for alocquet/aoc-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alocquet/aoc-2018/Cargo.toml [INFO] crate alocquet/aoc-2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting alocquet/aoc-2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/alocquet/aoc-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e0719d3ae5ceb8e4fe1d2b1fc57ba05d0d912a36a6596f255b97f516a9f8516c [INFO] running `"docker" "start" "-a" "e0719d3ae5ceb8e4fe1d2b1fc57ba05d0d912a36a6596f255b97f516a9f8516c"` [INFO] [stderr] Checking aoc-2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algos/day03.rs:108:28 [INFO] [stderr] | [INFO] [stderr] 108 | assert_eq!(run(), (121259, 239)); [INFO] [stderr] | ^^^^^^ help: consider: `121_259` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algos/day04.rs:138:28 [INFO] [stderr] | [INFO] [stderr] 138 | assert_eq!(run(), (109659, 36371)); [INFO] [stderr] | ^^^^^^ help: consider: `109_659` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algos/day09.rs:53:50 [INFO] [stderr] | [INFO] [stderr] 53 | assert_eq!(compute_best_score(13, 7999), 146373); [INFO] [stderr] | ^^^^^^ help: consider: `146_373` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algos/day09.rs:61:28 [INFO] [stderr] | [INFO] [stderr] 61 | assert_eq!(run(), (371284, 3038972494)); [INFO] [stderr] | ^^^^^^ help: consider: `371_284` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algos/day09.rs:61:36 [INFO] [stderr] | [INFO] [stderr] 61 | assert_eq!(run(), (371284, 3038972494)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_038_972_494` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algos/day12.rs:82:34 [INFO] [stderr] | [INFO] [stderr] 82 | assert_eq!(run(), (2045, 2100000000428)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `2_100_000_000_428` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algos/day14.rs:66:53 [INFO] [stderr] | [INFO] [stderr] 66 | assert_eq!(run(), ("1221283494".to_owned(), 20261485)); [INFO] [stderr] | ^^^^^^^^ help: consider: `20_261_485` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algos/day15.rs:147:28 [INFO] [stderr] | [INFO] [stderr] 147 | assert_eq!(run(), (213692, 52688)); [INFO] [stderr] | ^^^^^^ help: consider: `213_692` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/algos/day01.rs:40:44 [INFO] [stderr] | [INFO] [stderr] 40 | assert_eq!(compute_final_frequency(&vec!(1, -2, 3, 1)), 3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, -2, 3, 1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/algos/day01.rs:45:44 [INFO] [stderr] | [INFO] [stderr] 45 | assert_eq!(compute_final_frequency(&vec!(1, 1, 1)), 3); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 1, 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/algos/day01.rs:50:44 [INFO] [stderr] | [INFO] [stderr] 50 | assert_eq!(compute_final_frequency(&vec!(1, 1, -2)), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 1, -2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/algos/day01.rs:55:44 [INFO] [stderr] | [INFO] [stderr] 55 | assert_eq!(compute_final_frequency(&vec!(-1, -2, -3)), -6); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[-1, -2, -3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/algos/day01.rs:65:58 [INFO] [stderr] | [INFO] [stderr] 65 | assert_eq!(compute_first_frequency_reached_twice(&vec!(1, -2, 3, 1)), 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, -2, 3, 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/algos/day01.rs:70:58 [INFO] [stderr] | [INFO] [stderr] 70 | assert_eq!(compute_first_frequency_reached_twice(&vec!(1, -1)), 0); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&[1, -1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/algos/day01.rs:71:58 [INFO] [stderr] | [INFO] [stderr] 71 | assert_eq!(compute_first_frequency_reached_twice(&vec!(3, 3, 4, -2, -4)), 10); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[3, 3, 4, -2, -4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/algos/day01.rs:72:58 [INFO] [stderr] | [INFO] [stderr] 72 | assert_eq!(compute_first_frequency_reached_twice(&vec!(-6, 3, 8, 5, -6)), 5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[-6, 3, 8, 5, -6]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/algos/day01.rs:73:58 [INFO] [stderr] | [INFO] [stderr] 73 | assert_eq!(compute_first_frequency_reached_twice(&vec!(7, 7, -2, -7, -4)), 14); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[7, 7, -2, -7, -4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/algos/day02.rs:108:29 [INFO] [stderr] | [INFO] [stderr] 108 | assert_eq!(checksum(&vec!("abcdef", "bababc", "abbcde", "abcccd", "aabcdd", "abcdee", "ababab")), 12); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["abcdef", "bababc", "abbcde", "abcccd", "aabcdd", "abcdee", "ababab"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/algos/day02.rs:123:40 [INFO] [stderr] | [INFO] [stderr] 123 | assert_eq!(find_correct_box_id(&vec!("abcde", "fghij", "klmno", "pqrst", "fguij", "axcye", "wvxyz")).unwrap(), "fgij".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["abcde", "fghij", "klmno", "pqrst", "fguij", "axcye", "wvxyz"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/algos/day02.rs:128:40 [INFO] [stderr] | [INFO] [stderr] 128 | assert_eq!(find_correct_box_id(&vec!("abcde", "fghij")), None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["abcde", "fghij"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/algos/day03.rs:103:39 [INFO] [stderr] | [INFO] [stderr] 103 | assert_eq!(execute_from_input(&vec!("#1 @ 1,3: 4x4", "#2 @ 3,1: 4x4", "#3 @ 5,5: 2x2")), (4, 3)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["#1 @ 1,3: 4x4", "#2 @ 3,1: 4x4", "#3 @ 5,5: 2x2"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.44s [INFO] running `"docker" "inspect" "e0719d3ae5ceb8e4fe1d2b1fc57ba05d0d912a36a6596f255b97f516a9f8516c"` [INFO] running `"docker" "rm" "-f" "e0719d3ae5ceb8e4fe1d2b1fc57ba05d0d912a36a6596f255b97f516a9f8516c"` [INFO] [stdout] e0719d3ae5ceb8e4fe1d2b1fc57ba05d0d912a36a6596f255b97f516a9f8516c