[INFO] updating cached repository allonsy/git-cred [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/allonsy/git-cred [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/allonsy/git-cred" "work/ex/clippy-test-run/sources/stable/gh/allonsy/git-cred"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/allonsy/git-cred'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/allonsy/git-cred" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/allonsy/git-cred"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/allonsy/git-cred'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fd277b36671ccbabed8dc7a1b36f71b4579e6e54 [INFO] sha for GitHub repo allonsy/git-cred: fd277b36671ccbabed8dc7a1b36f71b4579e6e54 [INFO] validating manifest of allonsy/git-cred on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of allonsy/git-cred on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing allonsy/git-cred [INFO] finished frobbing allonsy/git-cred [INFO] frobbed toml for allonsy/git-cred written to work/ex/clippy-test-run/sources/stable/gh/allonsy/git-cred/Cargo.toml [INFO] started frobbing allonsy/git-cred [INFO] finished frobbing allonsy/git-cred [INFO] frobbed toml for allonsy/git-cred written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/allonsy/git-cred/Cargo.toml [INFO] crate allonsy/git-cred has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting allonsy/git-cred against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/allonsy/git-cred:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 04ad74f2e54171fa7f83610612f3ec004ad75ec201b2ddb835dad55757b0d161 [INFO] running `"docker" "start" "-a" "04ad74f2e54171fa7f83610612f3ec004ad75ec201b2ddb835dad55757b0d161"` [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking hyper v0.12.16 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.5 [INFO] [stderr] Checking git-cred v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git_utils.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | return path.parent().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `path.parent().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git_utils.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return path; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git_utils.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | return path; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git_utils.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return location; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `location` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/git_config.rs:4:27 [INFO] [stderr] | [INFO] [stderr] 4 | const LOCATION_KEY_NAME: &'static str = "creds.location"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git_config.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return Some(possible_location.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(possible_location.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git_config.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return Some(possible_email.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(possible_email.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gpg.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | return Ok(String::from_utf8(output_unwrapped.stdout).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(String::from_utf8(output_unwrapped.stdout).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gpg.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return Err(io::Error::new(io::ErrorKind::Other, "Encryption failed")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::Error::new(io::ErrorKind::Other, "Encryption failed"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gpg.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gpg.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | return output.status.success(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `output.status.success()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gpg.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return import_key_bytes(&key_contents.to_string().into_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `import_key_bytes(&key_contents.to_string().into_bytes())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gpg.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | return get_key_id(&short_id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `get_key_id(&short_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gpg.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | return Some(String::from_utf8(output.unwrap().stdout).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(String::from_utf8(output.unwrap().stdout).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encrypt.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | return resolved_gpgs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `resolved_gpgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encrypt.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | return Some(gpg_ids); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(gpg_ids)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/decrypt.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return contents.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `contents.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/resolver.rs:9:25 [INFO] [stderr] | [INFO] [stderr] 9 | const KEY_FOLDER_NAME: &'static str = ".keys"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/resolver.rs:10:26 [INFO] [stderr] | [INFO] [stderr] 10 | const LOCK_FOLDER_NAME: &'static str = "locks"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/resolver.rs:11:32 [INFO] [stderr] | [INFO] [stderr] 11 | const PUBLIC_KEY_FOLDER_NAME: &'static str = "keys"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/resolver.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | return Some(contents.trim().to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(contents.trim().to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/resolver.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | return lock_path; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `lock_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/resolver.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | return Some(gpg::import_key(&contents.unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(gpg::import_key(&contents.unwrap()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/github.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/github.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 40 | | if omap.contains_key("key_id") { [INFO] [stderr] 41 | | let omap_key_id = omap.get("key_id").unwrap(); [INFO] [stderr] 42 | | if omap_key_id.is_string() { [INFO] [stderr] ... | [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 39 | } else if omap.contains_key("key_id") { [INFO] [stderr] 40 | let omap_key_id = omap.get("key_id").unwrap(); [INFO] [stderr] 41 | if omap_key_id.is_string() { [INFO] [stderr] 42 | if key_id.as_ref().unwrap().ends_with(omap_key_id.as_str().unwrap()) { [INFO] [stderr] 43 | if omap.contains_key("raw_key") { [INFO] [stderr] 44 | let mut key_string = omap.get("raw_key").as_ref().unwrap().to_string(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/github.rs:42:25 [INFO] [stderr] | [INFO] [stderr] 42 | / if omap_key_id.is_string() { [INFO] [stderr] 43 | | if key_id.as_ref().unwrap().ends_with(omap_key_id.as_str().unwrap()) { [INFO] [stderr] 44 | | if omap.contains_key("raw_key") { [INFO] [stderr] 45 | | let mut key_string = omap.get("raw_key").as_ref().unwrap().to_string(); [INFO] [stderr] ... | [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 42 | if omap_key_id.is_string() && key_id.as_ref().unwrap().ends_with(omap_key_id.as_str().unwrap()) { [INFO] [stderr] 43 | if omap.contains_key("raw_key") { [INFO] [stderr] 44 | let mut key_string = omap.get("raw_key").as_ref().unwrap().to_string(); [INFO] [stderr] 45 | key_string = key_string.replace("\"", ""); [INFO] [stderr] 46 | key_string = key_string.replace("\\r\\n", "\n"); [INFO] [stderr] 47 | return Some(key_string); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/github.rs:43:29 [INFO] [stderr] | [INFO] [stderr] 43 | / if key_id.as_ref().unwrap().ends_with(omap_key_id.as_str().unwrap()) { [INFO] [stderr] 44 | | if omap.contains_key("raw_key") { [INFO] [stderr] 45 | | let mut key_string = omap.get("raw_key").as_ref().unwrap().to_string(); [INFO] [stderr] 46 | | key_string = key_string.replace("\"", ""); [INFO] [stderr] ... | [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 43 | if key_id.as_ref().unwrap().ends_with(omap_key_id.as_str().unwrap()) && omap.contains_key("raw_key") { [INFO] [stderr] 44 | let mut key_string = omap.get("raw_key").as_ref().unwrap().to_string(); [INFO] [stderr] 45 | key_string = key_string.replace("\"", ""); [INFO] [stderr] 46 | key_string = key_string.replace("\\r\\n", "\n"); [INFO] [stderr] 47 | return Some(key_string); [INFO] [stderr] 48 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git_utils.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | return path.parent().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `path.parent().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git_utils.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return path; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git_utils.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | return path; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git_utils.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return location; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `location` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/git_config.rs:4:27 [INFO] [stderr] | [INFO] [stderr] 4 | const LOCATION_KEY_NAME: &'static str = "creds.location"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git_config.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return Some(possible_location.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(possible_location.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git_config.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return Some(possible_email.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(possible_email.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gpg.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | return Ok(String::from_utf8(output_unwrapped.stdout).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(String::from_utf8(output_unwrapped.stdout).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gpg.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return Err(io::Error::new(io::ErrorKind::Other, "Encryption failed")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::Error::new(io::ErrorKind::Other, "Encryption failed"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gpg.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gpg.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | return output.status.success(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `output.status.success()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gpg.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return import_key_bytes(&key_contents.to_string().into_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `import_key_bytes(&key_contents.to_string().into_bytes())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gpg.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | return get_key_id(&short_id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `get_key_id(&short_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gpg.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | return Some(String::from_utf8(output.unwrap().stdout).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(String::from_utf8(output.unwrap().stdout).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encrypt.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | return resolved_gpgs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `resolved_gpgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encrypt.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | return Some(gpg_ids); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(gpg_ids)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/decrypt.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return contents.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `contents.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/resolver.rs:9:25 [INFO] [stderr] | [INFO] [stderr] 9 | const KEY_FOLDER_NAME: &'static str = ".keys"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/resolver.rs:10:26 [INFO] [stderr] | [INFO] [stderr] 10 | const LOCK_FOLDER_NAME: &'static str = "locks"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/resolver.rs:11:32 [INFO] [stderr] | [INFO] [stderr] 11 | const PUBLIC_KEY_FOLDER_NAME: &'static str = "keys"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/resolver.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | return Some(contents.trim().to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(contents.trim().to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/resolver.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | return lock_path; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `lock_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/resolver.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | return Some(gpg::import_key(&contents.unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(gpg::import_key(&contents.unwrap()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/github.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/github.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 40 | | if omap.contains_key("key_id") { [INFO] [stderr] 41 | | let omap_key_id = omap.get("key_id").unwrap(); [INFO] [stderr] 42 | | if omap_key_id.is_string() { [INFO] [stderr] ... | [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 39 | } else if omap.contains_key("key_id") { [INFO] [stderr] 40 | let omap_key_id = omap.get("key_id").unwrap(); [INFO] [stderr] 41 | if omap_key_id.is_string() { [INFO] [stderr] 42 | if key_id.as_ref().unwrap().ends_with(omap_key_id.as_str().unwrap()) { [INFO] [stderr] 43 | if omap.contains_key("raw_key") { [INFO] [stderr] 44 | let mut key_string = omap.get("raw_key").as_ref().unwrap().to_string(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/github.rs:42:25 [INFO] [stderr] | [INFO] [stderr] 42 | / if omap_key_id.is_string() { [INFO] [stderr] 43 | | if key_id.as_ref().unwrap().ends_with(omap_key_id.as_str().unwrap()) { [INFO] [stderr] 44 | | if omap.contains_key("raw_key") { [INFO] [stderr] 45 | | let mut key_string = omap.get("raw_key").as_ref().unwrap().to_string(); [INFO] [stderr] ... | [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 42 | if omap_key_id.is_string() && key_id.as_ref().unwrap().ends_with(omap_key_id.as_str().unwrap()) { [INFO] [stderr] 43 | if omap.contains_key("raw_key") { [INFO] [stderr] 44 | let mut key_string = omap.get("raw_key").as_ref().unwrap().to_string(); [INFO] [stderr] 45 | key_string = key_string.replace("\"", ""); [INFO] [stderr] 46 | key_string = key_string.replace("\\r\\n", "\n"); [INFO] [stderr] 47 | return Some(key_string); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/github.rs:43:29 [INFO] [stderr] | [INFO] [stderr] 43 | / if key_id.as_ref().unwrap().ends_with(omap_key_id.as_str().unwrap()) { [INFO] [stderr] 44 | | if omap.contains_key("raw_key") { [INFO] [stderr] 45 | | let mut key_string = omap.get("raw_key").as_ref().unwrap().to_string(); [INFO] [stderr] 46 | | key_string = key_string.replace("\"", ""); [INFO] [stderr] ... | [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 43 | if key_id.as_ref().unwrap().ends_with(omap_key_id.as_str().unwrap()) && omap.contains_key("raw_key") { [INFO] [stderr] 44 | let mut key_string = omap.get("raw_key").as_ref().unwrap().to_string(); [INFO] [stderr] 45 | key_string = key_string.replace("\"", ""); [INFO] [stderr] 46 | key_string = key_string.replace("\\r\\n", "\n"); [INFO] [stderr] 47 | return Some(key_string); [INFO] [stderr] 48 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/git_utils.rs:61:27 [INFO] [stderr] | [INFO] [stderr] 61 | string_to_write = git_config::get_email(repo).unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `git_config::get_email(repo).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/gpg.rs:22:78 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn encrypt_string>(path: P, contents: String, recipients: &Vec<&str>) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/gpg.rs:46:55 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn reencrypt>(path: P, recipients: &Vec<&str>) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/gpg.rs:72:39 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn import_key_bytes(key_contents: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/gpg.rs:95:45 [INFO] [stderr] | [INFO] [stderr] 95 | let words: Vec<&str> = first_line.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/encrypt.rs:52:35 [INFO] [stderr] | [INFO] [stderr] 52 | if !file_name.starts_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:65:8 [INFO] [stderr] | [INFO] [stderr] 65 | if args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:90:8 [INFO] [stderr] | [INFO] [stderr] 90 | if args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:100:19 [INFO] [stderr] | [INFO] [stderr] 100 | if args[1] == "-f".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `"-f"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:112:8 [INFO] [stderr] | [INFO] [stderr] 112 | if args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/git_utils.rs:61:27 [INFO] [stderr] | [INFO] [stderr] 61 | string_to_write = git_config::get_email(repo).unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `git_config::get_email(repo).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/gpg.rs:22:78 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn encrypt_string>(path: P, contents: String, recipients: &Vec<&str>) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/gpg.rs:46:55 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn reencrypt>(path: P, recipients: &Vec<&str>) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/gpg.rs:72:39 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn import_key_bytes(key_contents: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/gpg.rs:95:45 [INFO] [stderr] | [INFO] [stderr] 95 | let words: Vec<&str> = first_line.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/encrypt.rs:52:35 [INFO] [stderr] | [INFO] [stderr] 52 | if !file_name.starts_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:65:8 [INFO] [stderr] | [INFO] [stderr] 65 | if args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:90:8 [INFO] [stderr] | [INFO] [stderr] 90 | if args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:100:19 [INFO] [stderr] | [INFO] [stderr] 100 | if args[1] == "-f".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `"-f"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:112:8 [INFO] [stderr] | [INFO] [stderr] 112 | if args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 35.79s [INFO] running `"docker" "inspect" "04ad74f2e54171fa7f83610612f3ec004ad75ec201b2ddb835dad55757b0d161"` [INFO] running `"docker" "rm" "-f" "04ad74f2e54171fa7f83610612f3ec004ad75ec201b2ddb835dad55757b0d161"` [INFO] [stdout] 04ad74f2e54171fa7f83610612f3ec004ad75ec201b2ddb835dad55757b0d161