[INFO] updating cached repository aleyan/langtonsant [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aleyan/langtonsant [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aleyan/langtonsant" "work/ex/clippy-test-run/sources/stable/gh/aleyan/langtonsant"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aleyan/langtonsant'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aleyan/langtonsant" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aleyan/langtonsant"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aleyan/langtonsant'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f805a70044475492ef5af3a3b9dfefc0f804373f [INFO] sha for GitHub repo aleyan/langtonsant: f805a70044475492ef5af3a3b9dfefc0f804373f [INFO] validating manifest of aleyan/langtonsant on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aleyan/langtonsant on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aleyan/langtonsant [INFO] finished frobbing aleyan/langtonsant [INFO] frobbed toml for aleyan/langtonsant written to work/ex/clippy-test-run/sources/stable/gh/aleyan/langtonsant/Cargo.toml [INFO] started frobbing aleyan/langtonsant [INFO] finished frobbing aleyan/langtonsant [INFO] frobbed toml for aleyan/langtonsant written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aleyan/langtonsant/Cargo.toml [INFO] crate aleyan/langtonsant has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aleyan/langtonsant against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/aleyan/langtonsant:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8a92bfca180faea4b4d0987fdbde1b873db340d14da68552094f6778cb0e94ec [INFO] running `"docker" "start" "-a" "8a92bfca180faea4b4d0987fdbde1b873db340d14da68552094f6778cb0e94ec"` [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking alga v0.7.2 [INFO] [stderr] Checking nalgebra v0.16.8 [INFO] [stderr] Compiling palette_derive v0.4.1 [INFO] [stderr] Checking palette v0.4.1 [INFO] [stderr] Checking langtonsant v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/canvas.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | '▀' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/canvas.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | '▀' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/canvas.rs:25:31 [INFO] [stderr] | [INFO] [stderr] 25 | let (columns, rows) = match fill_terminal { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 26 | | true => (i32::from(size.0), i32::from(size.1)), [INFO] [stderr] 27 | | false => (i32::from(size.0), i32::from(size.1 - 1)), [INFO] [stderr] 28 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if fill_terminal { (i32::from(size.0), i32::from(size.1)) } else { (i32::from(size.0), i32::from(size.1 - 1)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/canvas.rs:40:20 [INFO] [stderr] | [INFO] [stderr] 40 | for row in 1..(rows + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `1..=rows` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/canvas.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | / write!( [INFO] [stderr] 175 | | out, [INFO] [stderr] 176 | | "{}{}{}", [INFO] [stderr] 177 | | cursor::Goto(1, (self.rows + 1) as u16), [INFO] [stderr] 178 | | style::Reset, [INFO] [stderr] 179 | | cursor::Show [INFO] [stderr] 180 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/canvas.rs:25:31 [INFO] [stderr] | [INFO] [stderr] 25 | let (columns, rows) = match fill_terminal { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 26 | | true => (i32::from(size.0), i32::from(size.1)), [INFO] [stderr] 27 | | false => (i32::from(size.0), i32::from(size.1 - 1)), [INFO] [stderr] 28 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if fill_terminal { (i32::from(size.0), i32::from(size.1)) } else { (i32::from(size.0), i32::from(size.1 - 1)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/canvas.rs:40:20 [INFO] [stderr] | [INFO] [stderr] 40 | for row in 1..(rows + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `1..=rows` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/canvas.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | / write!( [INFO] [stderr] 175 | | out, [INFO] [stderr] 176 | | "{}{}{}", [INFO] [stderr] 177 | | cursor::Goto(1, (self.rows + 1) as u16), [INFO] [stderr] 178 | | style::Reset, [INFO] [stderr] 179 | | cursor::Show [INFO] [stderr] 180 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 44.36s [INFO] running `"docker" "inspect" "8a92bfca180faea4b4d0987fdbde1b873db340d14da68552094f6778cb0e94ec"` [INFO] running `"docker" "rm" "-f" "8a92bfca180faea4b4d0987fdbde1b873db340d14da68552094f6778cb0e94ec"` [INFO] [stdout] 8a92bfca180faea4b4d0987fdbde1b873db340d14da68552094f6778cb0e94ec