[INFO] updating cached repository alexwlchan/safari.rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/alexwlchan/safari.rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/alexwlchan/safari.rs" "work/ex/clippy-test-run/sources/stable/gh/alexwlchan/safari.rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/alexwlchan/safari.rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/alexwlchan/safari.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexwlchan/safari.rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexwlchan/safari.rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 719dabed2994b7345792d566e7b8de8d59ce1cd9
[INFO] sha for GitHub repo alexwlchan/safari.rs: 719dabed2994b7345792d566e7b8de8d59ce1cd9
[INFO] validating manifest of alexwlchan/safari.rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of alexwlchan/safari.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing alexwlchan/safari.rs
[INFO] finished frobbing alexwlchan/safari.rs
[INFO] frobbed toml for alexwlchan/safari.rs written to work/ex/clippy-test-run/sources/stable/gh/alexwlchan/safari.rs/Cargo.toml
[INFO] started frobbing alexwlchan/safari.rs
[INFO] finished frobbing alexwlchan/safari.rs
[INFO] frobbed toml for alexwlchan/safari.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexwlchan/safari.rs/Cargo.toml
[INFO] crate alexwlchan/safari.rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting alexwlchan/safari.rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/alexwlchan/safari.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 10014cb8f5810c3246752b865009bc0e50b25d31d3e0fc12bb7067e371720d3c
[INFO] running `"docker" "start" "-a" "10014cb8f5810c3246752b865009bc0e50b25d31d3e0fc12bb7067e371720d3c"`
[INFO] [stderr]    Compiling plist v0.2.2
[INFO] [stderr]     Checking humansize v1.0.1
[INFO] [stderr]     Checking urlparse v0.7.3
[INFO] [stderr]     Checking serde_urlencoded v0.5.1
[INFO] [stderr]     Checking chrono v0.3.1
[INFO] [stderr]     Checking docopt v0.8.0
[INFO] [stderr]     Checking hyper-native-tls v0.2.4
[INFO] [stderr]     Checking reqwest v0.6.2
[INFO] [stderr]     Checking tera v0.10.6
[INFO] [stderr]     Checking safari v2.2.3 (/opt/crater/workdir)
[INFO] [stderr] error: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/safari.rs:110:10
[INFO] [stderr]     |
[INFO] [stderr] 110 |     } else {
[INFO] [stderr]     |  __________^
[INFO] [stderr] 111 | |     if output.stderr.contains("Invalid index") {
[INFO] [stderr] 112 | |       error!("Invalid index: no such window or tab.")
[INFO] [stderr] 113 | |     } else {
[INFO] [stderr] 114 | |       error!("Unexpected error from osascript: {:?}", output.stderr)
[INFO] [stderr] 115 | |     }
[INFO] [stderr] 116 | |   }
[INFO] [stderr]     | |___^
[INFO] [stderr]     |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]    --> src/main.rs:1:9
[INFO] [stderr]     |
[INFO] [stderr] 1   | #![deny(warnings)]
[INFO] [stderr]     |         ^^^^^^^^
[INFO] [stderr]     = note: #[deny(clippy::collapsible_if)] implied by #[deny(warnings)]
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 110 |   } else if output.stderr.contains("Invalid index") {
[INFO] [stderr] 111 |   error!("Invalid index: no such window or tab.")
[INFO] [stderr] 112 | } else {
[INFO] [stderr] 113 |   error!("Unexpected error from osascript: {:?}", output.stderr)
[INFO] [stderr] 114 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: this if statement can be collapsed
[INFO] [stderr]    --> src/urls.rs:130:3
[INFO] [stderr]     |
[INFO] [stderr] 130 | /   if parsed_url.netloc == "github.com" {
[INFO] [stderr] 131 | |     if parsed_url.path.ends_with("/files") {
[INFO] [stderr] 132 | |       parsed_url.path = parsed_url.path.replace("/files", "");
[INFO] [stderr] 133 | |     }
[INFO] [stderr] 134 | |   }
[INFO] [stderr]     | |___^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 130 |   if parsed_url.netloc == "github.com" && parsed_url.path.ends_with("/files") {
[INFO] [stderr] 131 |   parsed_url.path = parsed_url.path.replace("/files", "");
[INFO] [stderr] 132 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/safari.rs:218:30
[INFO] [stderr]     |
[INFO] [stderr] 218 |   let mut plist_path = match env::home_dir() {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]    --> src/main.rs:1:9
[INFO] [stderr]     |
[INFO] [stderr] 1   | #![deny(warnings)]
[INFO] [stderr]     |         ^^^^^^^^
[INFO] [stderr]     = note: #[deny(deprecated)] implied by #[deny(warnings)]
[INFO] [stderr] 
[INFO] [stderr] error: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/safari.rs:328:30
[INFO] [stderr]     |
[INFO] [stderr] 328 |   let mut plist_path = match env::home_dir() {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 4 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `safari`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/safari.rs:110:10
[INFO] [stderr]     |
[INFO] [stderr] 110 |     } else {
[INFO] [stderr]     |  __________^
[INFO] [stderr] 111 | |     if output.stderr.contains("Invalid index") {
[INFO] [stderr] 112 | |       error!("Invalid index: no such window or tab.")
[INFO] [stderr] 113 | |     } else {
[INFO] [stderr] 114 | |       error!("Unexpected error from osascript: {:?}", output.stderr)
[INFO] [stderr] 115 | |     }
[INFO] [stderr] 116 | |   }
[INFO] [stderr]     | |___^
[INFO] [stderr]     |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]    --> src/main.rs:1:9
[INFO] [stderr]     |
[INFO] [stderr] 1   | #![deny(warnings)]
[INFO] [stderr]     |         ^^^^^^^^
[INFO] [stderr]     = note: #[deny(clippy::collapsible_if)] implied by #[deny(warnings)]
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 110 |   } else if output.stderr.contains("Invalid index") {
[INFO] [stderr] 111 |   error!("Invalid index: no such window or tab.")
[INFO] [stderr] 112 | } else {
[INFO] [stderr] 113 |   error!("Unexpected error from osascript: {:?}", output.stderr)
[INFO] [stderr] 114 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: this if statement can be collapsed
[INFO] [stderr]    --> src/urls.rs:130:3
[INFO] [stderr]     |
[INFO] [stderr] 130 | /   if parsed_url.netloc == "github.com" {
[INFO] [stderr] 131 | |     if parsed_url.path.ends_with("/files") {
[INFO] [stderr] 132 | |       parsed_url.path = parsed_url.path.replace("/files", "");
[INFO] [stderr] 133 | |     }
[INFO] [stderr] 134 | |   }
[INFO] [stderr]     | |___^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 130 |   if parsed_url.netloc == "github.com" && parsed_url.path.ends_with("/files") {
[INFO] [stderr] 131 |   parsed_url.path = parsed_url.path.replace("/files", "");
[INFO] [stderr] 132 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/safari.rs:218:30
[INFO] [stderr]     |
[INFO] [stderr] 218 |   let mut plist_path = match env::home_dir() {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]    --> src/main.rs:1:9
[INFO] [stderr]     |
[INFO] [stderr] 1   | #![deny(warnings)]
[INFO] [stderr]     |         ^^^^^^^^
[INFO] [stderr]     = note: #[deny(deprecated)] implied by #[deny(warnings)]
[INFO] [stderr] 
[INFO] [stderr] error: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/safari.rs:328:30
[INFO] [stderr]     |
[INFO] [stderr] 328 |   let mut plist_path = match env::home_dir() {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 4 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `safari`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "10014cb8f5810c3246752b865009bc0e50b25d31d3e0fc12bb7067e371720d3c"`
[INFO] running `"docker" "rm" "-f" "10014cb8f5810c3246752b865009bc0e50b25d31d3e0fc12bb7067e371720d3c"`
[INFO] [stdout] 10014cb8f5810c3246752b865009bc0e50b25d31d3e0fc12bb7067e371720d3c