[INFO] updating cached repository alexpearce/adventofcode_2017 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/alexpearce/adventofcode_2017 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/alexpearce/adventofcode_2017" "work/ex/clippy-test-run/sources/stable/gh/alexpearce/adventofcode_2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/alexpearce/adventofcode_2017'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/alexpearce/adventofcode_2017" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexpearce/adventofcode_2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexpearce/adventofcode_2017'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f33547cc06c950d617f3c4ba4ee87d3546700ad8 [INFO] sha for GitHub repo alexpearce/adventofcode_2017: f33547cc06c950d617f3c4ba4ee87d3546700ad8 [INFO] validating manifest of alexpearce/adventofcode_2017 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of alexpearce/adventofcode_2017 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing alexpearce/adventofcode_2017 [INFO] finished frobbing alexpearce/adventofcode_2017 [INFO] frobbed toml for alexpearce/adventofcode_2017 written to work/ex/clippy-test-run/sources/stable/gh/alexpearce/adventofcode_2017/Cargo.toml [INFO] started frobbing alexpearce/adventofcode_2017 [INFO] finished frobbing alexpearce/adventofcode_2017 [INFO] frobbed toml for alexpearce/adventofcode_2017 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexpearce/adventofcode_2017/Cargo.toml [INFO] crate alexpearce/adventofcode_2017 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting alexpearce/adventofcode_2017 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/alexpearce/adventofcode_2017:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7330f8c7f28beefb32ccb0eac104da598f63ce3d2fb4d55acc06d0a0cfc3bdfb [INFO] running `"docker" "start" "-a" "7330f8c7f28beefb32ccb0eac104da598f63ce3d2fb4d55acc06d0a0cfc3bdfb"` [INFO] [stderr] Checking adventofcode_2017 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: value assigned to `inner` is never read [INFO] [stderr] --> src/day6/mod.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | let mut inner = 0; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/day3/mod.rs:171:22 [INFO] [stderr] | [INFO] [stderr] 171 | d.insert(current_coordinate.clone(), val); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current_coordinate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4/mod.rs:21:36 [INFO] [stderr] | [INFO] [stderr] 21 | let subs : Vec<&str> = s.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/day4/mod.rs:25:12 [INFO] [stderr] | [INFO] [stderr] 25 | if *counter == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `*counter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4/mod.rs:54:36 [INFO] [stderr] | [INFO] [stderr] 54 | let subs : Vec<&str> = s.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/day4/mod.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | if *counter == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `*counter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day13/mod.rs:48:28 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn severity(firewall : &Vec<(usize, usize)>, delay : usize) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, usize)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day13/mod.rs:77:31 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn transmitted(firewall : &Vec<(usize, usize)>, delay : usize) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, usize)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: value assigned to `inner` is never read [INFO] [stderr] --> src/day6/mod.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | let mut inner = 0; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/day3/mod.rs:171:22 [INFO] [stderr] | [INFO] [stderr] 171 | d.insert(current_coordinate.clone(), val); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current_coordinate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4/mod.rs:21:36 [INFO] [stderr] | [INFO] [stderr] 21 | let subs : Vec<&str> = s.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/day4/mod.rs:25:12 [INFO] [stderr] | [INFO] [stderr] 25 | if *counter == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `*counter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day4/mod.rs:54:36 [INFO] [stderr] | [INFO] [stderr] 54 | let subs : Vec<&str> = s.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/day4/mod.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | if *counter == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `*counter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day13/mod.rs:48:28 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn severity(firewall : &Vec<(usize, usize)>, delay : usize) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, usize)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day13/mod.rs:77:31 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn transmitted(firewall : &Vec<(usize, usize)>, delay : usize) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, usize)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/day3.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | let puzzle = 265149; [INFO] [stderr] | ^^^^^^ help: consider: `265_149` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/day3.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | let puzzle = 265149; [INFO] [stderr] | ^^^^^^ help: consider: `265_149` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.56s [INFO] running `"docker" "inspect" "7330f8c7f28beefb32ccb0eac104da598f63ce3d2fb4d55acc06d0a0cfc3bdfb"` [INFO] running `"docker" "rm" "-f" "7330f8c7f28beefb32ccb0eac104da598f63ce3d2fb4d55acc06d0a0cfc3bdfb"` [INFO] [stdout] 7330f8c7f28beefb32ccb0eac104da598f63ce3d2fb4d55acc06d0a0cfc3bdfb