[INFO] updating cached repository alexkursell/tonal [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/alexkursell/tonal [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/alexkursell/tonal" "work/ex/clippy-test-run/sources/stable/gh/alexkursell/tonal"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/alexkursell/tonal'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/alexkursell/tonal" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexkursell/tonal"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexkursell/tonal'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9c77a07ead7aa3064bbaacad69174ac72a255f32 [INFO] sha for GitHub repo alexkursell/tonal: 9c77a07ead7aa3064bbaacad69174ac72a255f32 [INFO] validating manifest of alexkursell/tonal on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of alexkursell/tonal on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing alexkursell/tonal [INFO] finished frobbing alexkursell/tonal [INFO] frobbed toml for alexkursell/tonal written to work/ex/clippy-test-run/sources/stable/gh/alexkursell/tonal/Cargo.toml [INFO] started frobbing alexkursell/tonal [INFO] finished frobbing alexkursell/tonal [INFO] frobbed toml for alexkursell/tonal written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexkursell/tonal/Cargo.toml [INFO] crate alexkursell/tonal has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting alexkursell/tonal against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/alexkursell/tonal:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9310d093e7a2d152bf90ed7d9b08acd4690e2589a80b9394512e77c667aaa73f [INFO] running `"docker" "start" "-a" "9310d093e7a2d152bf90ed7d9b08acd4690e2589a80b9394512e77c667aaa73f"` [INFO] [stderr] Compiling minimp3-sys v0.3.0 [INFO] [stderr] Checking slice-deque v0.1.13 [INFO] [stderr] Checking ogg v0.4.1 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking twox-hash v1.1.1 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Checking cpal v0.8.2 [INFO] [stderr] Checking rusttype v0.5.2 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking nalgebra v0.14.4 [INFO] [stderr] Checking lewton v0.5.2 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking minimp3 v0.3.0 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Checking rodio v0.7.0 [INFO] [stderr] Checking rodio v0.8.0 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_window_sdl v0.8.0 [INFO] [stderr] Checking gfx_glyph v0.10.2 [INFO] [stderr] Checking ggez v0.4.4 [INFO] [stderr] Checking tonal v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `ggez::conf` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | use ggez::conf; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `ggez::conf` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | use ggez::conf; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:269:13 [INFO] [stderr] | [INFO] [stderr] 269 | let mut s = MainState { [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:269:13 [INFO] [stderr] | [INFO] [stderr] 269 | let mut s = MainState { [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `square_wave` [INFO] [stderr] --> src/waves.rs:59:1 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn square_wave(fraction_through: f32) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `saw_wave` [INFO] [stderr] --> src/waves.rs:68:1 [INFO] [stderr] | [INFO] [stderr] 68 | fn saw_wave(fraction_through: f32) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `text` [INFO] [stderr] --> src/main.rs:249:5 [INFO] [stderr] | [INFO] [stderr] 249 | text: graphics::Text, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `square_wave` [INFO] [stderr] --> src/waves.rs:59:1 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn square_wave(fraction_through: f32) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `saw_wave` [INFO] [stderr] --> src/waves.rs:68:1 [INFO] [stderr] | [INFO] [stderr] 68 | fn saw_wave(fraction_through: f32) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `text` [INFO] [stderr] --> src/main.rs:249:5 [INFO] [stderr] | [INFO] [stderr] 249 | text: graphics::Text, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/waves.rs:204:6 [INFO] [stderr] | [INFO] [stderr] 204 | if self.waves.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.waves.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/waves.rs:204:6 [INFO] [stderr] | [INFO] [stderr] 204 | if self.waves.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.waves.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:296:16 [INFO] [stderr] | [INFO] [stderr] 296 | if self.enemies.len() < 1 && self.levels.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.enemies.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:296:42 [INFO] [stderr] | [INFO] [stderr] 296 | if self.enemies.len() < 1 && self.levels.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.levels.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:424:49 [INFO] [stderr] | [INFO] [stderr] 424 | fn update_player_sound(player: &Actor, enemies: &Vec, swave: &Sender){ [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Actor]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:477:19 [INFO] [stderr] | [INFO] [stderr] 477 | let idx = (0..state.enemies.len()) [INFO] [stderr] | ___________________^ [INFO] [stderr] 478 | | .into_iter() [INFO] [stderr] | |____________________^ help: consider removing `.into_iter()`: `(0..state.enemies.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:481:13 [INFO] [stderr] | [INFO] [stderr] 481 | / if e.pos.x < state.player.center().x && e.pos.x + e.width as f32 > state.player.center().x { [INFO] [stderr] 482 | | true [INFO] [stderr] 483 | | } else { [INFO] [stderr] 484 | | false [INFO] [stderr] 485 | | } [INFO] [stderr] | |_____________^ help: you can reduce it to: `e.pos.x < state.player.center().x && e.pos.x + e.width as f32 > state.player.center().x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:488:9 [INFO] [stderr] | [INFO] [stderr] 488 | / match idx { [INFO] [stderr] 489 | | Some(i) => destroy_enemy(state.enemies.remove(i), &state.swave), [INFO] [stderr] 490 | | None => () [INFO] [stderr] 491 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(i) = idx { destroy_enemy(state.enemies.remove(i), &state.swave) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:296:16 [INFO] [stderr] | [INFO] [stderr] 296 | if self.enemies.len() < 1 && self.levels.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.enemies.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:296:42 [INFO] [stderr] | [INFO] [stderr] 296 | if self.enemies.len() < 1 && self.levels.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.levels.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:424:49 [INFO] [stderr] | [INFO] [stderr] 424 | fn update_player_sound(player: &Actor, enemies: &Vec, swave: &Sender){ [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Actor]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:477:19 [INFO] [stderr] | [INFO] [stderr] 477 | let idx = (0..state.enemies.len()) [INFO] [stderr] | ___________________^ [INFO] [stderr] 478 | | .into_iter() [INFO] [stderr] | |____________________^ help: consider removing `.into_iter()`: `(0..state.enemies.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:481:13 [INFO] [stderr] | [INFO] [stderr] 481 | / if e.pos.x < state.player.center().x && e.pos.x + e.width as f32 > state.player.center().x { [INFO] [stderr] 482 | | true [INFO] [stderr] 483 | | } else { [INFO] [stderr] 484 | | false [INFO] [stderr] 485 | | } [INFO] [stderr] | |_____________^ help: you can reduce it to: `e.pos.x < state.player.center().x && e.pos.x + e.width as f32 > state.player.center().x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:488:9 [INFO] [stderr] | [INFO] [stderr] 488 | / match idx { [INFO] [stderr] 489 | | Some(i) => destroy_enemy(state.enemies.remove(i), &state.swave), [INFO] [stderr] 490 | | None => () [INFO] [stderr] 491 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(i) = idx { destroy_enemy(state.enemies.remove(i), &state.swave) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 22s [INFO] running `"docker" "inspect" "9310d093e7a2d152bf90ed7d9b08acd4690e2589a80b9394512e77c667aaa73f"` [INFO] running `"docker" "rm" "-f" "9310d093e7a2d152bf90ed7d9b08acd4690e2589a80b9394512e77c667aaa73f"` [INFO] [stdout] 9310d093e7a2d152bf90ed7d9b08acd4690e2589a80b9394512e77c667aaa73f