[INFO] updating cached repository alexeyden/ecmascript_toy [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/alexeyden/ecmascript_toy [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/alexeyden/ecmascript_toy" "work/ex/clippy-test-run/sources/stable/gh/alexeyden/ecmascript_toy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/alexeyden/ecmascript_toy'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/alexeyden/ecmascript_toy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexeyden/ecmascript_toy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexeyden/ecmascript_toy'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0297435df3d80bbb8f73289add0fb87038cd6330 [INFO] sha for GitHub repo alexeyden/ecmascript_toy: 0297435df3d80bbb8f73289add0fb87038cd6330 [INFO] validating manifest of alexeyden/ecmascript_toy on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of alexeyden/ecmascript_toy on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing alexeyden/ecmascript_toy [INFO] finished frobbing alexeyden/ecmascript_toy [INFO] frobbed toml for alexeyden/ecmascript_toy written to work/ex/clippy-test-run/sources/stable/gh/alexeyden/ecmascript_toy/Cargo.toml [INFO] started frobbing alexeyden/ecmascript_toy [INFO] finished frobbing alexeyden/ecmascript_toy [INFO] frobbed toml for alexeyden/ecmascript_toy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexeyden/ecmascript_toy/Cargo.toml [INFO] crate alexeyden/ecmascript_toy has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting alexeyden/ecmascript_toy against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/alexeyden/ecmascript_toy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 49fae90809bcd9e01bc89d26fe5ab21ec6f9296d564059ee96b35204ab32c30d [INFO] running `"docker" "start" "-a" "49fae90809bcd9e01bc89d26fe5ab21ec6f9296d564059ee96b35204ab32c30d"` [INFO] [stderr] Checking ecmascript_toy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:35:7 [INFO] [stderr] | [INFO] [stderr] 35 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:36:7 [INFO] [stderr] | [INFO] [stderr] 36 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:37:7 [INFO] [stderr] | [INFO] [stderr] 37 | col: col [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:71:7 [INFO] [stderr] | [INFO] [stderr] 71 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/syntax_tree.rs:81:12 [INFO] [stderr] | [INFO] [stderr] 81 | Node { type_: type_, body: vec![] } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `type_` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame_stack.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | frame_offset: frame_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/var_analyzer.rs:23:7 [INFO] [stderr] | [INFO] [stderr] 23 | fstack: fstack [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fstack` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/var_analyzer.rs:63:7 [INFO] [stderr] | [INFO] [stderr] 63 | fstack: fstack [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fstack` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:35:7 [INFO] [stderr] | [INFO] [stderr] 35 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:36:7 [INFO] [stderr] | [INFO] [stderr] 36 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:37:7 [INFO] [stderr] | [INFO] [stderr] 37 | col: col [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:71:7 [INFO] [stderr] | [INFO] [stderr] 71 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/syntax_tree.rs:81:12 [INFO] [stderr] | [INFO] [stderr] 81 | Node { type_: type_, body: vec![] } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `type_` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame_stack.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | frame_offset: frame_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/var_analyzer.rs:23:7 [INFO] [stderr] | [INFO] [stderr] 23 | fstack: fstack [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fstack` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/var_analyzer.rs:63:7 [INFO] [stderr] | [INFO] [stderr] 63 | fstack: fstack [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fstack` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame_stack.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | return parents; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `parents` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/compiler.rs:142:16 [INFO] [stderr] | [INFO] [stderr] 142 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 143 | | if let NodeType::Number(n) = node.body.get(0).unwrap().type_ { [INFO] [stderr] 144 | | self.assembler.push_float(-n); [INFO] [stderr] 145 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 149 | | } [INFO] [stderr] 150 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 142 | } else if let NodeType::Number(n) = node.body.get(0).unwrap().type_ { [INFO] [stderr] 143 | self.assembler.push_float(-n); [INFO] [stderr] 144 | } else { [INFO] [stderr] 145 | self.compile_expr(node.body.get(0).unwrap()); [INFO] [stderr] 146 | self.take_value(node.body.get(0).unwrap()); [INFO] [stderr] 147 | self.assembler.op_unary(&node.type_); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/compiler.rs:194:16 [INFO] [stderr] | [INFO] [stderr] 194 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 195 | | if let Some(var) = self.frame_stack.find_var(s) { [INFO] [stderr] 196 | | let sp_offset = self.assembler.get_sp() as u32 - var.frame_offset as u32; [INFO] [stderr] 197 | | [INFO] [stderr] ... | [INFO] [stderr] 203 | | } [INFO] [stderr] 204 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 194 | } else if let Some(var) = self.frame_stack.find_var(s) { [INFO] [stderr] 195 | let sp_offset = self.assembler.get_sp() as u32 - var.frame_offset as u32; [INFO] [stderr] 196 | [INFO] [stderr] 197 | self.assembler.take(sp_offset); [INFO] [stderr] 198 | self.assembler.push_int(var.var_offset as u32); [INFO] [stderr] 199 | self.assembler.op_binary(&NodeType::Op(OpType::OpPlus)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame_stack.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | return parents; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `parents` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/compiler.rs:142:16 [INFO] [stderr] | [INFO] [stderr] 142 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 143 | | if let NodeType::Number(n) = node.body.get(0).unwrap().type_ { [INFO] [stderr] 144 | | self.assembler.push_float(-n); [INFO] [stderr] 145 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 149 | | } [INFO] [stderr] 150 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 142 | } else if let NodeType::Number(n) = node.body.get(0).unwrap().type_ { [INFO] [stderr] 143 | self.assembler.push_float(-n); [INFO] [stderr] 144 | } else { [INFO] [stderr] 145 | self.compile_expr(node.body.get(0).unwrap()); [INFO] [stderr] 146 | self.take_value(node.body.get(0).unwrap()); [INFO] [stderr] 147 | self.assembler.op_unary(&node.type_); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/compiler.rs:194:16 [INFO] [stderr] | [INFO] [stderr] 194 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 195 | | if let Some(var) = self.frame_stack.find_var(s) { [INFO] [stderr] 196 | | let sp_offset = self.assembler.get_sp() as u32 - var.frame_offset as u32; [INFO] [stderr] 197 | | [INFO] [stderr] ... | [INFO] [stderr] 203 | | } [INFO] [stderr] 204 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 194 | } else if let Some(var) = self.frame_stack.find_var(s) { [INFO] [stderr] 195 | let sp_offset = self.assembler.get_sp() as u32 - var.frame_offset as u32; [INFO] [stderr] 196 | [INFO] [stderr] 197 | self.assembler.take(sp_offset); [INFO] [stderr] 198 | self.assembler.push_int(var.var_offset as u32); [INFO] [stderr] 199 | self.assembler.op_binary(&NodeType::Op(OpType::OpPlus)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:287:34 [INFO] [stderr] | [INFO] [stderr] 287 | fn parse_expression(&mut self, mut parent: &mut Node) { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:312:37 [INFO] [stderr] | [INFO] [stderr] 312 | fn parse_condition_cmp(&mut self, mut parent: &mut Node) { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:341:37 [INFO] [stderr] | [INFO] [stderr] 341 | fn parse_condition_and(&mut self, mut parent: &mut Node) { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:365:33 [INFO] [stderr] | [INFO] [stderr] 365 | fn parse_condition(&mut self, mut parent: &mut Node) { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/frame_stack.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | let mut offsets = &mut self.frames[self.cur_frame].var_offsets; [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 36 [INFO] [stderr] --> src/tokenizer.rs:78:3 [INFO] [stderr] | [INFO] [stderr] 78 | / pub fn tokenize(&mut self) -> Result<&LinkedList, String> { [INFO] [stderr] 79 | | loop { [INFO] [stderr] 80 | | let c = match self.peek_char() { [INFO] [stderr] 81 | | Some(ch) => ch, [INFO] [stderr] ... | [INFO] [stderr] 303 | | Ok(&self.tokens) [INFO] [stderr] 304 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/tokenizer.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / loop { [INFO] [stderr] 80 | | let c = match self.peek_char() { [INFO] [stderr] 81 | | Some(ch) => ch, [INFO] [stderr] 82 | | None => break [INFO] [stderr] ... | [INFO] [stderr] 297 | | } [INFO] [stderr] 298 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(ch) = self.peek_char() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:99:39 [INFO] [stderr] | [INFO] [stderr] 99 | c == '.' && !cur.contains("."); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tokenizer.rs:340:34 [INFO] [stderr] | [INFO] [stderr] 340 | self.start = self.peek_pos().unwrap_or(self.text.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.text.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:287:34 [INFO] [stderr] | [INFO] [stderr] 287 | fn parse_expression(&mut self, mut parent: &mut Node) { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:312:37 [INFO] [stderr] | [INFO] [stderr] 312 | fn parse_condition_cmp(&mut self, mut parent: &mut Node) { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:341:37 [INFO] [stderr] | [INFO] [stderr] 341 | fn parse_condition_and(&mut self, mut parent: &mut Node) { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:365:33 [INFO] [stderr] | [INFO] [stderr] 365 | fn parse_condition(&mut self, mut parent: &mut Node) { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/syntax_tree.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | for ref mut ch in self.body.iter_mut() { [INFO] [stderr] | ^^^^^^^^^^ -------------------- help: try: `let ch = &mut self.body.iter_mut();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/frame_stack.rs:93:36 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn find_var(&mut self, name: &String) -> Option [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/frame_stack.rs:120:35 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn put_var(&mut self, name: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/frame_stack.rs:128:42 [INFO] [stderr] | [INFO] [stderr] 128 | pub fn put_var_global(&mut self, name: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/assembler.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / match nt { [INFO] [stderr] 58 | | &NodeType::Op(OpType::OpMul) => Some(OpCode::Mul), [INFO] [stderr] 59 | | &NodeType::Op(OpType::OpDiv) => Some(OpCode::Div), [INFO] [stderr] 60 | | &NodeType::Op(OpType::OpMod) => Some(OpCode::Mod), [INFO] [stderr] ... | [INFO] [stderr] 72 | | _ => None [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 57 | match *nt { [INFO] [stderr] 58 | NodeType::Op(OpType::OpMul) => Some(OpCode::Mul), [INFO] [stderr] 59 | NodeType::Op(OpType::OpDiv) => Some(OpCode::Div), [INFO] [stderr] 60 | NodeType::Op(OpType::OpMod) => Some(OpCode::Mod), [INFO] [stderr] 61 | NodeType::Op(OpType::OpOr) => Some(OpCode::Or), [INFO] [stderr] 62 | NodeType::Op(OpType::OpAnd) => Some(OpCode::And), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/frame_stack.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | let mut offsets = &mut self.frames[self.cur_frame].var_offsets; [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/assembler.rs:226:14 [INFO] [stderr] | [INFO] [stderr] 226 | let op = match op { [INFO] [stderr] | ______________^ [INFO] [stderr] 227 | | &NodeType::Op(OpType::OpPlus) => return, [INFO] [stderr] 228 | | &NodeType::Op(OpType::OpMinus) => OpCode::Neg, [INFO] [stderr] 229 | | &NodeType::Op(OpType::OpNot) => OpCode::Not, [INFO] [stderr] 230 | | _ => panic!() [INFO] [stderr] 231 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 226 | let op = match *op { [INFO] [stderr] 227 | NodeType::Op(OpType::OpPlus) => return, [INFO] [stderr] 228 | NodeType::Op(OpType::OpMinus) => OpCode::Neg, [INFO] [stderr] 229 | NodeType::Op(OpType::OpNot) => OpCode::Not, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/assembler.rs:256:38 [INFO] [stderr] | [INFO] [stderr] 256 | self.file.seek(SeekFrom::Start(*pos as u64)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(*pos)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/compiler.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | for ref stmt in &node.body { [INFO] [stderr] | ^^^^^^^^ ---------- help: try: `let stmt = &&node.body;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:79:22 [INFO] [stderr] | [INFO] [stderr] 79 | let lhand_node = node.body.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:80:22 [INFO] [stderr] | [INFO] [stderr] 80 | let rhand_node = node.body.get(1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/compiler.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | / match &node.type_ { [INFO] [stderr] 103 | | &NodeType::Op(OpType::OpMul) | [INFO] [stderr] 104 | | &NodeType::Op(OpType::OpDiv) | [INFO] [stderr] 105 | | &NodeType::Op(OpType::OpMod) | [INFO] [stderr] ... | [INFO] [stderr] 212 | | _ => panic!() [INFO] [stderr] 213 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 102 | match node.type_ { [INFO] [stderr] 103 | NodeType::Op(OpType::OpMul) | [INFO] [stderr] 104 | NodeType::Op(OpType::OpDiv) | [INFO] [stderr] 105 | NodeType::Op(OpType::OpMod) | [INFO] [stderr] 106 | NodeType::Op(OpType::OpOr) | [INFO] [stderr] 107 | NodeType::Op(OpType::OpAnd) | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:114:27 [INFO] [stderr] | [INFO] [stderr] 114 | self.compile_expr(node.body.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:115:25 [INFO] [stderr] | [INFO] [stderr] 115 | self.take_value(node.body.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:117:27 [INFO] [stderr] | [INFO] [stderr] 117 | self.compile_expr(node.body.get(1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:118:25 [INFO] [stderr] | [INFO] [stderr] 118 | self.take_value(node.body.get(1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:124:27 [INFO] [stderr] | [INFO] [stderr] 124 | self.compile_expr(node.body.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:125:25 [INFO] [stderr] | [INFO] [stderr] 125 | self.take_value(node.body.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:137:29 [INFO] [stderr] | [INFO] [stderr] 137 | self.compile_expr(node.body.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:138:27 [INFO] [stderr] | [INFO] [stderr] 138 | self.take_value(node.body.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:143:40 [INFO] [stderr] | [INFO] [stderr] 143 | if let NodeType::Number(n) = node.body.get(0).unwrap().type_ { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:146:31 [INFO] [stderr] | [INFO] [stderr] 146 | self.compile_expr(node.body.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:147:29 [INFO] [stderr] | [INFO] [stderr] 147 | self.take_value(node.body.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:153:27 [INFO] [stderr] | [INFO] [stderr] 153 | self.compile_expr(node.body.get(1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | self.take_value(node.body.get(1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:156:31 [INFO] [stderr] | [INFO] [stderr] 156 | self.compile_dict_key(node.body.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:161:27 [INFO] [stderr] | [INFO] [stderr] 161 | self.compile_expr(node.body.get(1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:162:25 [INFO] [stderr] | [INFO] [stderr] 162 | self.take_value(node.body.get(1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:164:27 [INFO] [stderr] | [INFO] [stderr] 164 | self.compile_expr(node.body.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:165:25 [INFO] [stderr] | [INFO] [stderr] 165 | self.take_value(node.body.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:248:16 [INFO] [stderr] | [INFO] [stderr] 248 | let body = node.body.get(1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/compiler.rs:271:8 [INFO] [stderr] | [INFO] [stderr] 271 | if node.body.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!node.body.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/compiler.rs:294:9 [INFO] [stderr] | [INFO] [stderr] 294 | for ref n in &args_node.body { [INFO] [stderr] | ^^^^^ --------------- help: try: `let n = &&args_node.body;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:307:16 [INFO] [stderr] | [INFO] [stderr] 307 | let cond = node.body.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:308:19 [INFO] [stderr] | [INFO] [stderr] 308 | let if_body = node.body.get(1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:333:16 [INFO] [stderr] | [INFO] [stderr] 333 | let cond = node.body.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:334:16 [INFO] [stderr] | [INFO] [stderr] 334 | let body = node.body.get(1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | let tokens = match &tokenizer.tokenize() { [INFO] [stderr] | ________________^ [INFO] [stderr] 36 | | &Ok(tokens) => tokens, [INFO] [stderr] 37 | | &Err(ref msg) => { [INFO] [stderr] 38 | | println!("Tokenizer error:\n{}", msg); [INFO] [stderr] 39 | | return; [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | }; [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 35 | let tokens = match tokenizer.tokenize() { [INFO] [stderr] 36 | Ok(tokens) => tokens, [INFO] [stderr] 37 | Err(ref msg) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | for ref t in tokens.iter() { [INFO] [stderr] | ^^^^^ ------------- help: try: `let t = &tokens.iter();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:125:6 [INFO] [stderr] | [INFO] [stderr] 125 | if matches.free.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `matches.free.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 36 [INFO] [stderr] --> src/tokenizer.rs:78:3 [INFO] [stderr] | [INFO] [stderr] 78 | / pub fn tokenize(&mut self) -> Result<&LinkedList, String> { [INFO] [stderr] 79 | | loop { [INFO] [stderr] 80 | | let c = match self.peek_char() { [INFO] [stderr] 81 | | Some(ch) => ch, [INFO] [stderr] ... | [INFO] [stderr] 303 | | Ok(&self.tokens) [INFO] [stderr] 304 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/tokenizer.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / loop { [INFO] [stderr] 80 | | let c = match self.peek_char() { [INFO] [stderr] 81 | | Some(ch) => ch, [INFO] [stderr] 82 | | None => break [INFO] [stderr] ... | [INFO] [stderr] 297 | | } [INFO] [stderr] 298 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(ch) = self.peek_char() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tokenizer.rs:99:39 [INFO] [stderr] | [INFO] [stderr] 99 | c == '.' && !cur.contains("."); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tokenizer.rs:340:34 [INFO] [stderr] | [INFO] [stderr] 340 | self.start = self.peek_pos().unwrap_or(self.text.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.text.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/syntax_tree.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | for ref mut ch in self.body.iter_mut() { [INFO] [stderr] | ^^^^^^^^^^ -------------------- help: try: `let ch = &mut self.body.iter_mut();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/frame_stack.rs:93:36 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn find_var(&mut self, name: &String) -> Option [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/frame_stack.rs:120:35 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn put_var(&mut self, name: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/frame_stack.rs:128:42 [INFO] [stderr] | [INFO] [stderr] 128 | pub fn put_var_global(&mut self, name: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/var_analyzer.rs:112:42 [INFO] [stderr] | [INFO] [stderr] 112 | let frame_has_var = |f : &Frame, st| f.var_offsets.iter().find(|&s| s == st).is_some(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|&s| s == st).is_some()` with `any(|&s| s == st)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/assembler.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / match nt { [INFO] [stderr] 58 | | &NodeType::Op(OpType::OpMul) => Some(OpCode::Mul), [INFO] [stderr] 59 | | &NodeType::Op(OpType::OpDiv) => Some(OpCode::Div), [INFO] [stderr] 60 | | &NodeType::Op(OpType::OpMod) => Some(OpCode::Mod), [INFO] [stderr] ... | [INFO] [stderr] 72 | | _ => None [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 57 | match *nt { [INFO] [stderr] 58 | NodeType::Op(OpType::OpMul) => Some(OpCode::Mul), [INFO] [stderr] 59 | NodeType::Op(OpType::OpDiv) => Some(OpCode::Div), [INFO] [stderr] 60 | NodeType::Op(OpType::OpMod) => Some(OpCode::Mod), [INFO] [stderr] 61 | NodeType::Op(OpType::OpOr) => Some(OpCode::Or), [INFO] [stderr] 62 | NodeType::Op(OpType::OpAnd) => Some(OpCode::And), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/assembler.rs:226:14 [INFO] [stderr] | [INFO] [stderr] 226 | let op = match op { [INFO] [stderr] | ______________^ [INFO] [stderr] 227 | | &NodeType::Op(OpType::OpPlus) => return, [INFO] [stderr] 228 | | &NodeType::Op(OpType::OpMinus) => OpCode::Neg, [INFO] [stderr] 229 | | &NodeType::Op(OpType::OpNot) => OpCode::Not, [INFO] [stderr] 230 | | _ => panic!() [INFO] [stderr] 231 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 226 | let op = match *op { [INFO] [stderr] 227 | NodeType::Op(OpType::OpPlus) => return, [INFO] [stderr] 228 | NodeType::Op(OpType::OpMinus) => OpCode::Neg, [INFO] [stderr] 229 | NodeType::Op(OpType::OpNot) => OpCode::Not, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/assembler.rs:256:38 [INFO] [stderr] | [INFO] [stderr] 256 | self.file.seek(SeekFrom::Start(*pos as u64)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(*pos)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/compiler.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | for ref stmt in &node.body { [INFO] [stderr] | ^^^^^^^^ ---------- help: try: `let stmt = &&node.body;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:79:22 [INFO] [stderr] | [INFO] [stderr] 79 | let lhand_node = node.body.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:80:22 [INFO] [stderr] | [INFO] [stderr] 80 | let rhand_node = node.body.get(1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/compiler.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | / match &node.type_ { [INFO] [stderr] 103 | | &NodeType::Op(OpType::OpMul) | [INFO] [stderr] 104 | | &NodeType::Op(OpType::OpDiv) | [INFO] [stderr] 105 | | &NodeType::Op(OpType::OpMod) | [INFO] [stderr] ... | [INFO] [stderr] 212 | | _ => panic!() [INFO] [stderr] 213 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 102 | match node.type_ { [INFO] [stderr] 103 | NodeType::Op(OpType::OpMul) | [INFO] [stderr] 104 | NodeType::Op(OpType::OpDiv) | [INFO] [stderr] 105 | NodeType::Op(OpType::OpMod) | [INFO] [stderr] 106 | NodeType::Op(OpType::OpOr) | [INFO] [stderr] 107 | NodeType::Op(OpType::OpAnd) | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:114:27 [INFO] [stderr] | [INFO] [stderr] 114 | self.compile_expr(node.body.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:115:25 [INFO] [stderr] | [INFO] [stderr] 115 | self.take_value(node.body.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:117:27 [INFO] [stderr] | [INFO] [stderr] 117 | self.compile_expr(node.body.get(1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:118:25 [INFO] [stderr] | [INFO] [stderr] 118 | self.take_value(node.body.get(1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:124:27 [INFO] [stderr] | [INFO] [stderr] 124 | self.compile_expr(node.body.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:125:25 [INFO] [stderr] | [INFO] [stderr] 125 | self.take_value(node.body.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:137:29 [INFO] [stderr] | [INFO] [stderr] 137 | self.compile_expr(node.body.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:138:27 [INFO] [stderr] | [INFO] [stderr] 138 | self.take_value(node.body.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:143:40 [INFO] [stderr] | [INFO] [stderr] 143 | if let NodeType::Number(n) = node.body.get(0).unwrap().type_ { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:146:31 [INFO] [stderr] | [INFO] [stderr] 146 | self.compile_expr(node.body.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:147:29 [INFO] [stderr] | [INFO] [stderr] 147 | self.take_value(node.body.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:153:27 [INFO] [stderr] | [INFO] [stderr] 153 | self.compile_expr(node.body.get(1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | self.take_value(node.body.get(1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:156:31 [INFO] [stderr] | [INFO] [stderr] 156 | self.compile_dict_key(node.body.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:161:27 [INFO] [stderr] | [INFO] [stderr] 161 | self.compile_expr(node.body.get(1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:162:25 [INFO] [stderr] | [INFO] [stderr] 162 | self.take_value(node.body.get(1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:164:27 [INFO] [stderr] | [INFO] [stderr] 164 | self.compile_expr(node.body.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:165:25 [INFO] [stderr] | [INFO] [stderr] 165 | self.take_value(node.body.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:248:16 [INFO] [stderr] | [INFO] [stderr] 248 | let body = node.body.get(1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/compiler.rs:271:8 [INFO] [stderr] | [INFO] [stderr] 271 | if node.body.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!node.body.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/compiler.rs:294:9 [INFO] [stderr] | [INFO] [stderr] 294 | for ref n in &args_node.body { [INFO] [stderr] | ^^^^^ --------------- help: try: `let n = &&args_node.body;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:307:16 [INFO] [stderr] | [INFO] [stderr] 307 | let cond = node.body.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:308:19 [INFO] [stderr] | [INFO] [stderr] 308 | let if_body = node.body.get(1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:333:16 [INFO] [stderr] | [INFO] [stderr] 333 | let cond = node.body.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/compiler.rs:334:16 [INFO] [stderr] | [INFO] [stderr] 334 | let body = node.body.get(1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node.body[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | let tokens = match &tokenizer.tokenize() { [INFO] [stderr] | ________________^ [INFO] [stderr] 36 | | &Ok(tokens) => tokens, [INFO] [stderr] 37 | | &Err(ref msg) => { [INFO] [stderr] 38 | | println!("Tokenizer error:\n{}", msg); [INFO] [stderr] 39 | | return; [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | }; [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 35 | let tokens = match tokenizer.tokenize() { [INFO] [stderr] 36 | Ok(tokens) => tokens, [INFO] [stderr] 37 | Err(ref msg) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | for ref t in tokens.iter() { [INFO] [stderr] | ^^^^^ ------------- help: try: `let t = &tokens.iter();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:125:6 [INFO] [stderr] | [INFO] [stderr] 125 | if matches.free.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `matches.free.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.22s [INFO] running `"docker" "inspect" "49fae90809bcd9e01bc89d26fe5ab21ec6f9296d564059ee96b35204ab32c30d"` [INFO] running `"docker" "rm" "-f" "49fae90809bcd9e01bc89d26fe5ab21ec6f9296d564059ee96b35204ab32c30d"` [INFO] [stdout] 49fae90809bcd9e01bc89d26fe5ab21ec6f9296d564059ee96b35204ab32c30d