[INFO] updating cached repository alexcrichton/rustc-compile-time-analyze [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/alexcrichton/rustc-compile-time-analyze [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/alexcrichton/rustc-compile-time-analyze" "work/ex/clippy-test-run/sources/stable/gh/alexcrichton/rustc-compile-time-analyze"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/alexcrichton/rustc-compile-time-analyze'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/alexcrichton/rustc-compile-time-analyze" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexcrichton/rustc-compile-time-analyze"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexcrichton/rustc-compile-time-analyze'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dd3a891e231fdc8e3bd4f66896774a6d3794becd [INFO] sha for GitHub repo alexcrichton/rustc-compile-time-analyze: dd3a891e231fdc8e3bd4f66896774a6d3794becd [INFO] validating manifest of alexcrichton/rustc-compile-time-analyze on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of alexcrichton/rustc-compile-time-analyze on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing alexcrichton/rustc-compile-time-analyze [INFO] finished frobbing alexcrichton/rustc-compile-time-analyze [INFO] frobbed toml for alexcrichton/rustc-compile-time-analyze written to work/ex/clippy-test-run/sources/stable/gh/alexcrichton/rustc-compile-time-analyze/Cargo.toml [INFO] started frobbing alexcrichton/rustc-compile-time-analyze [INFO] finished frobbing alexcrichton/rustc-compile-time-analyze [INFO] frobbed toml for alexcrichton/rustc-compile-time-analyze written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexcrichton/rustc-compile-time-analyze/Cargo.toml [INFO] crate alexcrichton/rustc-compile-time-analyze has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting alexcrichton/rustc-compile-time-analyze against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/alexcrichton/rustc-compile-time-analyze:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f80075879d509b3ef83dca25279b9eb924e2314ae2a6c860d9bd7d3b22cad718 [INFO] running `"docker" "start" "-a" "f80075879d509b3ef83dca25279b9eb924e2314ae2a6c860d9bd7d3b22cad718"` [INFO] [stderr] Checking jobserver v0.1.6 [INFO] [stderr] Checking socket2 v0.2.2 [INFO] [stderr] Checking tempdir v0.3.5 [INFO] [stderr] Checking libz-sys v1.0.16 [INFO] [stderr] Checking openssl-sys v0.9.15 [INFO] [stderr] Checking mio-uds v0.6.4 [INFO] [stderr] Checking tokio-signal v0.1.2 [INFO] [stderr] Checking curl-sys v0.3.14 [INFO] [stderr] Checking curl v0.4.8 [INFO] [stderr] Checking tokio-process v0.1.4 [INFO] [stderr] Checking tokio-curl v0.1.9 [INFO] [stderr] Checking rustc-compile-time-analyze v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:173:17 [INFO] [stderr] | [INFO] [stderr] 173 | krate: krate, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `krate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:176:17 [INFO] [stderr] | [INFO] [stderr] 176 | upstream_deps: upstream_deps, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `upstream_deps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:218:59 [INFO] [stderr] | [INFO] [stderr] 218 | state = State::Define { name: symbol, dbg: dbg, lines: 0 }; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dbg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:237:25 [INFO] [stderr] | [INFO] [stderr] 237 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:239:25 [INFO] [stderr] | [INFO] [stderr] 239 | dbg: dbg, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dbg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:311:13 [INFO] [stderr] | [INFO] [stderr] 311 | session: session, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `session` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:173:17 [INFO] [stderr] | [INFO] [stderr] 173 | krate: krate, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `krate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:176:17 [INFO] [stderr] | [INFO] [stderr] 176 | upstream_deps: upstream_deps, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `upstream_deps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:218:59 [INFO] [stderr] | [INFO] [stderr] 218 | state = State::Define { name: symbol, dbg: dbg, lines: 0 }; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dbg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:237:25 [INFO] [stderr] | [INFO] [stderr] 237 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:239:25 [INFO] [stderr] | [INFO] [stderr] 239 | dbg: dbg, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dbg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:311:13 [INFO] [stderr] | [INFO] [stderr] 311 | session: session, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `session` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:323:9 [INFO] [stderr] | [INFO] [stderr] 323 | return true [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:323:9 [INFO] [stderr] | [INFO] [stderr] 323 | return true [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:219:44 [INFO] [stderr] | [INFO] [stderr] 219 | } else if line.starts_with("!") { [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:221:43 [INFO] [stderr] | [INFO] [stderr] 221 | let space = line.find(" ").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:232:37 [INFO] [stderr] | [INFO] [stderr] 232 | if line.starts_with("}") { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:319:12 [INFO] [stderr] | [INFO] [stderr] 319 | if crates.crates.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `crates.crates.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:219:44 [INFO] [stderr] | [INFO] [stderr] 219 | } else if line.starts_with("!") { [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:221:43 [INFO] [stderr] | [INFO] [stderr] 221 | let space = line.find(" ").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:232:37 [INFO] [stderr] | [INFO] [stderr] 232 | if line.starts_with("}") { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:319:12 [INFO] [stderr] | [INFO] [stderr] 319 | if crates.crates.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `crates.crates.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.05s [INFO] running `"docker" "inspect" "f80075879d509b3ef83dca25279b9eb924e2314ae2a6c860d9bd7d3b22cad718"` [INFO] running `"docker" "rm" "-f" "f80075879d509b3ef83dca25279b9eb924e2314ae2a6c860d9bd7d3b22cad718"` [INFO] [stdout] f80075879d509b3ef83dca25279b9eb924e2314ae2a6c860d9bd7d3b22cad718