[INFO] updating cached repository alexcrichton/cargo-local-registry [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/alexcrichton/cargo-local-registry [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/alexcrichton/cargo-local-registry" "work/ex/clippy-test-run/sources/stable/gh/alexcrichton/cargo-local-registry"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/alexcrichton/cargo-local-registry'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/alexcrichton/cargo-local-registry" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexcrichton/cargo-local-registry"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexcrichton/cargo-local-registry'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9fab4768fa8f0324654840e8cfc6f300cea1d96e [INFO] sha for GitHub repo alexcrichton/cargo-local-registry: 9fab4768fa8f0324654840e8cfc6f300cea1d96e [INFO] validating manifest of alexcrichton/cargo-local-registry on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of alexcrichton/cargo-local-registry on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing alexcrichton/cargo-local-registry [INFO] finished frobbing alexcrichton/cargo-local-registry [INFO] frobbed toml for alexcrichton/cargo-local-registry written to work/ex/clippy-test-run/sources/stable/gh/alexcrichton/cargo-local-registry/Cargo.toml [INFO] started frobbing alexcrichton/cargo-local-registry [INFO] finished frobbing alexcrichton/cargo-local-registry [INFO] frobbed toml for alexcrichton/cargo-local-registry written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexcrichton/cargo-local-registry/Cargo.toml [INFO] crate alexcrichton/cargo-local-registry has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting alexcrichton/cargo-local-registry against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/alexcrichton/cargo-local-registry:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 261f71b39ee89da282d1ba9470c7a278dfbb7bee68df1a2d8f9f7b4692345efe [INFO] running `"docker" "start" "-a" "261f71b39ee89da282d1ba9470c7a278dfbb7bee68df1a2d8f9f7b4692345efe"` [INFO] [stderr] Checking home v0.3.3 [INFO] [stderr] Checking rustc-workspace-hack v1.0.0 [INFO] [stderr] Checking bytesize v1.0.0 [INFO] [stderr] Compiling libnghttp2-sys v0.1.1 [INFO] [stderr] Compiling curl-sys v0.4.15 [INFO] [stderr] Compiling serde v1.0.82 [INFO] [stderr] Checking lock_api v0.1.5 [INFO] [stderr] Checking crossbeam-epoch v0.6.1 [INFO] [stderr] Checking toml v0.4.10 [INFO] [stderr] Checking serde_ignored v0.0.4 [INFO] [stderr] Checking semver v0.9.0 [INFO] [stderr] Compiling libssh2-sys v0.2.11 [INFO] [stderr] Checking socket2 v0.3.8 [INFO] [stderr] Checking xattr v0.2.2 [INFO] [stderr] Checking jobserver v0.1.12 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking serde_json v1.0.33 [INFO] [stderr] Checking flate2 v1.0.6 [INFO] [stderr] Checking tar v0.4.20 [INFO] [stderr] Compiling serde_derive v1.0.82 [INFO] [stderr] Checking crypto-hash v0.3.1 [INFO] [stderr] Checking globset v0.4.2 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking opener v0.3.2 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling parking_lot_core v0.3.1 [INFO] [stderr] Compiling rand_chacha v0.1.0 [INFO] [stderr] Compiling rand_pcg v0.1.1 [INFO] [stderr] Compiling rand v0.6.1 [INFO] [stderr] Checking rustfix v0.4.2 [INFO] [stderr] Checking docopt v1.0.2 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Compiling libgit2-sys v0.7.10 [INFO] [stderr] Checking curl v0.4.19 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking crates-io v0.20.0 [INFO] [stderr] Checking tempfile v3.0.5 [INFO] [stderr] Checking ignore v0.4.4 [INFO] [stderr] Checking git2 v0.7.5 [INFO] [stderr] Checking git2-curl v0.8.2 [INFO] [stderr] Checking cargo v0.32.0 [INFO] [stderr] Checking cargo-local-registry v0.1.6 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:329:9 [INFO] [stderr] | [INFO] [stderr] 329 | deps: deps, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `deps` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:330:9 [INFO] [stderr] | [INFO] [stderr] 330 | features: features, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `features` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:329:9 [INFO] [stderr] | [INFO] [stderr] 329 | deps: deps, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `deps` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:330:9 [INFO] [stderr] | [INFO] [stderr] 330 | features: features, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `features` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/all.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | return cmd [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cmd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:151:56 [INFO] [stderr] | [INFO] [stderr] 151 | let canonical_local_dst = local_dst.canonicalize().unwrap_or(local_dst.to_path_buf()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| local_dst.to_path_buf())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:206:13 [INFO] [stderr] | [INFO] [stderr] 206 | read(&dst).unwrap_or(String::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `read(&dst).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the BTreeMap [INFO] [stderr] --> src/main.rs:316:24 [INFO] [stderr] | [INFO] [stderr] 316 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:151:56 [INFO] [stderr] | [INFO] [stderr] 151 | let canonical_local_dst = local_dst.canonicalize().unwrap_or(local_dst.to_path_buf()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| local_dst.to_path_buf())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:206:13 [INFO] [stderr] | [INFO] [stderr] 206 | read(&dst).unwrap_or(String::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `read(&dst).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the BTreeMap [INFO] [stderr] --> src/main.rs:316:24 [INFO] [stderr] | [INFO] [stderr] 316 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 54s [INFO] running `"docker" "inspect" "261f71b39ee89da282d1ba9470c7a278dfbb7bee68df1a2d8f9f7b4692345efe"` [INFO] running `"docker" "rm" "-f" "261f71b39ee89da282d1ba9470c7a278dfbb7bee68df1a2d8f9f7b4692345efe"` [INFO] [stdout] 261f71b39ee89da282d1ba9470c7a278dfbb7bee68df1a2d8f9f7b4692345efe