[INFO] updating cached repository alexcrichton/cargo-edit-locally
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/alexcrichton/cargo-edit-locally
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/alexcrichton/cargo-edit-locally" "work/ex/clippy-test-run/sources/stable/gh/alexcrichton/cargo-edit-locally"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/alexcrichton/cargo-edit-locally'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/alexcrichton/cargo-edit-locally" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexcrichton/cargo-edit-locally"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexcrichton/cargo-edit-locally'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 0d920ced75b09ea2484334f5b72f31ebe1028864
[INFO] sha for GitHub repo alexcrichton/cargo-edit-locally: 0d920ced75b09ea2484334f5b72f31ebe1028864
[INFO] validating manifest of alexcrichton/cargo-edit-locally on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of alexcrichton/cargo-edit-locally on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing alexcrichton/cargo-edit-locally
[INFO] finished frobbing alexcrichton/cargo-edit-locally
[INFO] frobbed toml for alexcrichton/cargo-edit-locally written to work/ex/clippy-test-run/sources/stable/gh/alexcrichton/cargo-edit-locally/Cargo.toml
[INFO] started frobbing alexcrichton/cargo-edit-locally
[INFO] finished frobbing alexcrichton/cargo-edit-locally
[INFO] frobbed toml for alexcrichton/cargo-edit-locally written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexcrichton/cargo-edit-locally/Cargo.toml
[INFO] crate alexcrichton/cargo-edit-locally has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting alexcrichton/cargo-edit-locally against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/alexcrichton/cargo-edit-locally:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b33b2992b177b2663d76eda1f8ff069b676de78f5a34dba024dcbeb1157faf24
[INFO] running `"docker" "start" "-a" "b33b2992b177b2663d76eda1f8ff069b676de78f5a34dba024dcbeb1157faf24"`
[INFO] [stderr]    Compiling openssl v0.10.16
[INFO] [stderr]     Checking bytesize v1.0.0
[INFO] [stderr]    Compiling libnghttp2-sys v0.1.1
[INFO] [stderr]    Compiling openssl-sys v0.9.40
[INFO] [stderr]    Compiling libz-sys v1.0.22
[INFO] [stderr]    Compiling curl-sys v0.4.15
[INFO] [stderr]    Compiling libgit2-sys v0.7.11
[INFO] [stderr]     Checking lock_api v0.1.3
[INFO] [stderr]     Checking env_logger v0.6.0
[INFO] [stderr]     Checking tar v0.4.16
[INFO] [stderr]     Checking crc32fast v1.1.2
[INFO] [stderr]    Compiling semver v0.9.0
[INFO] [stderr]     Checking serde_ignored v0.0.4
[INFO] [stderr]     Checking toml v0.4.10
[INFO] [stderr]     Checking serde_json v1.0.33
[INFO] [stderr]    Compiling syn v0.15.22
[INFO] [stderr]     Checking crossbeam-epoch v0.6.0
[INFO] [stderr]     Checking flate2 v1.0.6
[INFO] [stderr]    Compiling libssh2-sys v0.2.11
[INFO] [stderr]    Compiling rustc_version v0.2.3
[INFO] [stderr]     Checking globset v0.4.2
[INFO] [stderr]     Checking env_logger v0.5.13
[INFO] [stderr]    Compiling parking_lot_core v0.3.1
[INFO] [stderr]     Checking parking_lot v0.6.4
[INFO] [stderr]     Checking crossbeam-channel v0.2.6
[INFO] [stderr]     Checking crypto-hash v0.3.1
[INFO] [stderr]     Checking ignore v0.4.4
[INFO] [stderr]    Compiling synstructure v0.10.0
[INFO] [stderr]    Compiling serde_derive v1.0.82
[INFO] [stderr]    Compiling failure_derive v0.1.3
[INFO] [stderr]     Checking failure v0.1.3
[INFO] [stderr]     Checking curl v0.4.19
[INFO] [stderr]     Checking opener v0.3.0
[INFO] [stderr]     Checking crates-io v0.20.0
[INFO] [stderr]     Checking rustfix v0.4.2
[INFO] [stderr]     Checking docopt v1.0.2
[INFO] [stderr]     Checking git2 v0.7.5
[INFO] [stderr]     Checking git2 v0.8.0
[INFO] [stderr]     Checking git2-curl v0.8.1
[INFO] [stderr]     Checking cargo v0.32.0
[INFO] [stderr]     Checking cargo-edit-locally v0.1.3 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> tests/log.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 |     return cmd
[INFO] [stderr]    |     ^^^^^^^^^^ help: remove `return` as shown: `cmd`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> tests/log.rs:37:5
[INFO] [stderr]    |
[INFO] [stderr] 37 |     return dir
[INFO] [stderr]    |     ^^^^^^^^^^ help: remove `return` as shown: `dir`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:140:8
[INFO] [stderr]     |
[INFO] [stderr] 140 |     if candidates.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `candidates.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:146:27
[INFO] [stderr]     |
[INFO] [stderr] 146 |             msg.push_str(&format!("perhaps a different branch/tag is needed?"));
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"perhaps a different branch/tag is needed?".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:148:27
[INFO] [stderr]     |
[INFO] [stderr] 148 |             msg.push_str(&format!("perhaps this path contains the wrong version?"));
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"perhaps this path contains the wrong version?".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:192:42
[INFO] [stderr]     |
[INFO] [stderr] 192 |             match manifest[i + 1..].find("\n") {
[INFO] [stderr]     |                                          ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:140:8
[INFO] [stderr]     |
[INFO] [stderr] 140 |     if candidates.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `candidates.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:146:27
[INFO] [stderr]     |
[INFO] [stderr] 146 |             msg.push_str(&format!("perhaps a different branch/tag is needed?"));
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"perhaps a different branch/tag is needed?".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:148:27
[INFO] [stderr]     |
[INFO] [stderr] 148 |             msg.push_str(&format!("perhaps this path contains the wrong version?"));
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"perhaps this path contains the wrong version?".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:192:42
[INFO] [stderr]     |
[INFO] [stderr] 192 |             match manifest[i + 1..].find("\n") {
[INFO] [stderr]     |                                          ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 50s
[INFO] running `"docker" "inspect" "b33b2992b177b2663d76eda1f8ff069b676de78f5a34dba024dcbeb1157faf24"`
[INFO] running `"docker" "rm" "-f" "b33b2992b177b2663d76eda1f8ff069b676de78f5a34dba024dcbeb1157faf24"`
[INFO] [stdout] b33b2992b177b2663d76eda1f8ff069b676de78f5a34dba024dcbeb1157faf24