[INFO] updating cached repository alexcrichton/appveyor-scrape [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/alexcrichton/appveyor-scrape [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/alexcrichton/appveyor-scrape" "work/ex/clippy-test-run/sources/stable/gh/alexcrichton/appveyor-scrape"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/alexcrichton/appveyor-scrape'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/alexcrichton/appveyor-scrape" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexcrichton/appveyor-scrape"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexcrichton/appveyor-scrape'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0f54c6fa477c6b3ed7fe6ecbbcf308764d018966 [INFO] sha for GitHub repo alexcrichton/appveyor-scrape: 0f54c6fa477c6b3ed7fe6ecbbcf308764d018966 [INFO] validating manifest of alexcrichton/appveyor-scrape on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of alexcrichton/appveyor-scrape on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing alexcrichton/appveyor-scrape [INFO] finished frobbing alexcrichton/appveyor-scrape [INFO] frobbed toml for alexcrichton/appveyor-scrape written to work/ex/clippy-test-run/sources/stable/gh/alexcrichton/appveyor-scrape/Cargo.toml [INFO] started frobbing alexcrichton/appveyor-scrape [INFO] finished frobbing alexcrichton/appveyor-scrape [INFO] frobbed toml for alexcrichton/appveyor-scrape written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexcrichton/appveyor-scrape/Cargo.toml [INFO] crate alexcrichton/appveyor-scrape has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting alexcrichton/appveyor-scrape against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/alexcrichton/appveyor-scrape:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 064a7b9c4a88116f43dbbf8092eca9b43c6023803491de0a33054b36105a01ed [INFO] running `"docker" "start" "-a" "064a7b9c4a88116f43dbbf8092eca9b43c6023803491de0a33054b36105a01ed"` [INFO] [stderr] Compiling curl-sys v0.4.1 [INFO] [stderr] Checking iovec v0.1.1 [INFO] [stderr] Checking net2 v0.2.31 [INFO] [stderr] Checking socket2 v0.3.0 [INFO] [stderr] Checking serde_json v0.9.10 [INFO] [stderr] Checking openssl-sys v0.9.24 [INFO] [stderr] Checking libz-sys v1.0.18 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking bytes v0.4.6 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking mio v0.6.12 [INFO] [stderr] Checking tokio-io v0.1.4 [INFO] [stderr] Checking tokio-core v0.1.12 [INFO] [stderr] Checking curl v0.4.11 [INFO] [stderr] Checking tokio-curl v0.1.11 [INFO] [stderr] Checking appveyor-scrape v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/download-logs.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | session: session, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `session` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/download-logs.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/download-logs.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | branch: branch, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `branch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/download-logs.rs:276:29 [INFO] [stderr] | [INFO] [stderr] 276 | easy: easy, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `easy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/download-logs.rs:277:29 [INFO] [stderr] | [INFO] [stderr] 277 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/download-logs.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | session: session, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `session` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/download-logs.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/download-logs.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | branch: branch, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `branch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/download-logs.rs:276:29 [INFO] [stderr] | [INFO] [stderr] 276 | easy: easy, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `easy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/download-logs.rs:277:29 [INFO] [stderr] | [INFO] [stderr] 277 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bin/plot-total-time.rs:30:12 [INFO] [stderr] | [INFO] [stderr] 30 | if num < MIN || num > MAX { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because MIN is the minimum value for this type, this comparison is always false [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `appveyor-scrape`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/compare-two-logs.rs:18:12 [INFO] [stderr] | [INFO] [stderr] 18 | if l.trim().len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `l.trim().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/bin/compare-two-logs.rs:21:25 [INFO] [stderr] | [INFO] [stderr] 21 | alines.entry(l).or_insert(Vec::new()).push(dur); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/compare-two-logs.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if times.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `times.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bin/plot-total-time.rs:30:12 [INFO] [stderr] | [INFO] [stderr] 30 | if num < MIN || num > MAX { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because MIN is the minimum value for this type, this comparison is always false [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/bin/plot-two-log-statements.rs:81:24 [INFO] [stderr] | [INFO] [stderr] 81 | } else if durs.1 == zero { [INFO] [stderr] | ________________________^ [INFO] [stderr] 82 | | if line.contains(series.1) { [INFO] [stderr] 83 | | durs.1 = last; [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 81 | } else if durs.1 == zero && line.contains(series.1) { [INFO] [stderr] 82 | durs.1 = last; [INFO] [stderr] 83 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `appveyor-scrape`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/bin/plot-two-log-statements.rs:81:24 [INFO] [stderr] | [INFO] [stderr] 81 | } else if durs.1 == zero { [INFO] [stderr] | ________________________^ [INFO] [stderr] 82 | | if line.contains(series.1) { [INFO] [stderr] 83 | | durs.1 = last; [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 81 | } else if durs.1 == zero && line.contains(series.1) { [INFO] [stderr] 82 | durs.1 = last; [INFO] [stderr] 83 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bin/plot-two-log-statements.rs:59:12 [INFO] [stderr] | [INFO] [stderr] 59 | if num < MIN || num > MAX { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because MIN is the minimum value for this type, this comparison is always false [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `appveyor-scrape`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bin/plot-two-log-statements.rs:59:12 [INFO] [stderr] | [INFO] [stderr] 59 | if num < MIN || num > MAX { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because MIN is the minimum value for this type, this comparison is always false [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `appveyor-scrape`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/compare-two-logs.rs:18:12 [INFO] [stderr] | [INFO] [stderr] 18 | if l.trim().len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `l.trim().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/bin/compare-two-logs.rs:21:25 [INFO] [stderr] | [INFO] [stderr] 21 | alines.entry(l).or_insert(Vec::new()).push(dur); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/compare-two-logs.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if times.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `times.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/download-logs.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | format!("Accept: application/json"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Accept: application/json".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/download-logs.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | format!("Accept: application/json"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Accept: application/json".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "064a7b9c4a88116f43dbbf8092eca9b43c6023803491de0a33054b36105a01ed"` [INFO] running `"docker" "rm" "-f" "064a7b9c4a88116f43dbbf8092eca9b43c6023803491de0a33054b36105a01ed"` [INFO] [stdout] 064a7b9c4a88116f43dbbf8092eca9b43c6023803491de0a33054b36105a01ed