[INFO] updating cached repository alexanderwe/bandwidth-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/alexanderwe/bandwidth-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/alexanderwe/bandwidth-rs" "work/ex/clippy-test-run/sources/stable/gh/alexanderwe/bandwidth-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/alexanderwe/bandwidth-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/alexanderwe/bandwidth-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexanderwe/bandwidth-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexanderwe/bandwidth-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5afd10ed38a27f04da56ede9f47162205f67bc0e [INFO] sha for GitHub repo alexanderwe/bandwidth-rs: 5afd10ed38a27f04da56ede9f47162205f67bc0e [INFO] validating manifest of alexanderwe/bandwidth-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of alexanderwe/bandwidth-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing alexanderwe/bandwidth-rs [INFO] finished frobbing alexanderwe/bandwidth-rs [INFO] frobbed toml for alexanderwe/bandwidth-rs written to work/ex/clippy-test-run/sources/stable/gh/alexanderwe/bandwidth-rs/Cargo.toml [INFO] started frobbing alexanderwe/bandwidth-rs [INFO] finished frobbing alexanderwe/bandwidth-rs [INFO] frobbed toml for alexanderwe/bandwidth-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexanderwe/bandwidth-rs/Cargo.toml [INFO] crate alexanderwe/bandwidth-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting alexanderwe/bandwidth-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/alexanderwe/bandwidth-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 384cbf30bc9fcab419e2a1d7da37830ab9058b722dc169833780d9e76f684c7b [INFO] running `"docker" "start" "-a" "384cbf30bc9fcab419e2a1d7da37830ab9058b722dc169833780d9e76f684c7b"` [INFO] [stderr] Checking pretty-bytes v0.2.2 [INFO] [stderr] Compiling syn v0.14.7 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling serde_derive v1.0.70 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking bandwidth-monitor v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/proc.rs:11:21 [INFO] [stderr] | [INFO] [stderr] 11 | const UPTIME_FILE: &'static str = "/proc/uptime"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/proc.rs:12:22 [INFO] [stderr] | [INFO] [stderr] 12 | const NET_DEV_FILE: &'static str = "/proc/net/dev"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/proc.rs:11:21 [INFO] [stderr] | [INFO] [stderr] 11 | const UPTIME_FILE: &'static str = "/proc/uptime"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/proc.rs:12:22 [INFO] [stderr] | [INFO] [stderr] 12 | const NET_DEV_FILE: &'static str = "/proc/net/dev"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/monitor.rs:64:25 [INFO] [stderr] | [INFO] [stderr] 64 | convert((interface.received_bytes - &stats_vec[0].parse::().unwrap()) as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------------------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `stats_vec[0].parse::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/monitor.rs:66:25 [INFO] [stderr] | [INFO] [stderr] 66 | convert((interface.transmit_bytes - &stats_vec[1].parse::().unwrap()) as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------------------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `stats_vec[1].parse::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/monitor.rs:75:8 [INFO] [stderr] | [INFO] [stderr] 75 | if result.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!result.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/proc.rs:64:45 [INFO] [stderr] | [INFO] [stderr] 64 | let split = file_content.unwrap().split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/proc.rs:72:12 [INFO] [stderr] | [INFO] [stderr] 72 | if s.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/monitor.rs:64:25 [INFO] [stderr] | [INFO] [stderr] 64 | convert((interface.received_bytes - &stats_vec[0].parse::().unwrap()) as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------------------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `stats_vec[0].parse::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/monitor.rs:66:25 [INFO] [stderr] | [INFO] [stderr] 66 | convert((interface.transmit_bytes - &stats_vec[1].parse::().unwrap()) as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------------------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `stats_vec[1].parse::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/monitor.rs:75:8 [INFO] [stderr] | [INFO] [stderr] 75 | if result.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!result.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/proc.rs:64:45 [INFO] [stderr] | [INFO] [stderr] 64 | let split = file_content.unwrap().split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/proc.rs:72:12 [INFO] [stderr] | [INFO] [stderr] 72 | if s.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 27.96s [INFO] running `"docker" "inspect" "384cbf30bc9fcab419e2a1d7da37830ab9058b722dc169833780d9e76f684c7b"` [INFO] running `"docker" "rm" "-f" "384cbf30bc9fcab419e2a1d7da37830ab9058b722dc169833780d9e76f684c7b"` [INFO] [stdout] 384cbf30bc9fcab419e2a1d7da37830ab9058b722dc169833780d9e76f684c7b