[INFO] updating cached repository alexander-smoktal/rust-patterns [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/alexander-smoktal/rust-patterns [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/alexander-smoktal/rust-patterns" "work/ex/clippy-test-run/sources/stable/gh/alexander-smoktal/rust-patterns"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/alexander-smoktal/rust-patterns'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/alexander-smoktal/rust-patterns" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexander-smoktal/rust-patterns"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexander-smoktal/rust-patterns'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 351757356846d4b50d614316b3e53d5a3cf6dea9 [INFO] sha for GitHub repo alexander-smoktal/rust-patterns: 351757356846d4b50d614316b3e53d5a3cf6dea9 [INFO] validating manifest of alexander-smoktal/rust-patterns on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of alexander-smoktal/rust-patterns on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing alexander-smoktal/rust-patterns [INFO] finished frobbing alexander-smoktal/rust-patterns [INFO] frobbed toml for alexander-smoktal/rust-patterns written to work/ex/clippy-test-run/sources/stable/gh/alexander-smoktal/rust-patterns/Cargo.toml [INFO] started frobbing alexander-smoktal/rust-patterns [INFO] finished frobbing alexander-smoktal/rust-patterns [INFO] frobbed toml for alexander-smoktal/rust-patterns written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alexander-smoktal/rust-patterns/Cargo.toml [INFO] crate alexander-smoktal/rust-patterns has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting alexander-smoktal/rust-patterns against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/alexander-smoktal/rust-patterns:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1668dac9903cb276da4b228788387bf85911cafa0972629a73cf27ff2c9e4fdb [INFO] running `"docker" "start" "-a" "1668dac9903cb276da4b228788387bf85911cafa0972629a73cf27ff2c9e4fdb"` [INFO] [stderr] Checking rust-patterns v0.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Debts` [INFO] [stderr] --> src/structural/proxy.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> Self { [INFO] [stderr] 34 | | Debts { [INFO] [stderr] 35 | | wallet: USDWallet(0f32), [INFO] [stderr] 36 | | debt: 0f32, [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | impl Default for Debts { [INFO] [stderr] 33 | fn default() -> Self { [INFO] [stderr] 34 | Self::new() [INFO] [stderr] 35 | } [INFO] [stderr] 36 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Logger` [INFO] [stderr] --> src/behavioral/command.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Self { [INFO] [stderr] 21 | | Logger { state: LogState::On } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 19 | impl Default for Logger { [INFO] [stderr] 20 | fn default() -> Self { [INFO] [stderr] 21 | Self::new() [INFO] [stderr] 22 | } [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/creational/prototype.rs:51:58 [INFO] [stderr] | [INFO] [stderr] 51 | .add_incoming_transaction(Transaction::new(5f32, 0x12345678)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/creational/prototype.rs:52:59 [INFO] [stderr] | [INFO] [stderr] 52 | .add_outgoing_transaction(Transaction::new(10f32, 0x12345678)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/creational/prototype.rs:55:33 [INFO] [stderr] | [INFO] [stderr] 55 | Transaction::new(42f32, 0x12345679), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5679` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Block` [INFO] [stderr] --> src/creational/prototype.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> Self { [INFO] [stderr] 22 | | Block { [INFO] [stderr] 23 | | hash: 0u64, [INFO] [stderr] 24 | | incoming_txs: vec![], [INFO] [stderr] 25 | | outgoing_txs: vec![], [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `UTXO` [INFO] [stderr] --> src/structural/decorator.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> Self { [INFO] [stderr] 23 | | UTXO { unspended: HashMap::new() } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/structural/decorator.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | / if self.unspended.contains_key(&otx.1) { [INFO] [stderr] 48 | | return Some("UTXO already contains outgoing transaction".into()); [INFO] [stderr] 49 | | } else { [INFO] [stderr] 50 | | self.unspended.insert(otx.1, otx.0); [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____________^ help: consider using: `self.unspended.entry(otx.1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Wallet` [INFO] [stderr] --> src/structural/flyweight.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / pub fn new() -> Self { [INFO] [stderr] 38 | | Wallet { currencies: HashMap::new() } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/structural/flyweight.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | self.currencies.get(¤cy).unwrap().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.currencies[¤cy]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `USDWallet` [INFO] [stderr] --> src/structural/adapter.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Self { [INFO] [stderr] 15 | | USDWallet { money: 0f32 } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `BitcoinWalletAdapter` [INFO] [stderr] --> src/structural/adapter.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / pub fn new() -> Self { [INFO] [stderr] 63 | | BitcoinWalletAdapter { btc_wallet: BitcoinWallet { bitcoins: 0f32 } } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | impl Default for BitcoinWalletAdapter { [INFO] [stderr] 62 | fn default() -> Self { [INFO] [stderr] 63 | Self::new() [INFO] [stderr] 64 | } [INFO] [stderr] 65 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/structural/adapter.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | for ref mut wallet in wallet_vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ ---------- help: try: `let wallet = &mut wallet_vec;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/behavioral/mediator.rs:19:16 [INFO] [stderr] | [INFO] [stderr] 19 | listeners: HashMap>>, EventHandler)>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Mediator` [INFO] [stderr] --> src/behavioral/mediator.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Self { [INFO] [stderr] 24 | | Mediator { listeners: HashMap::new() } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/behavioral/mediator.rs:60:33 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn block_created(_this: &mut Box, _block: &Block) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut EventListener` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/behavioral/mediator.rs:64:35 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn block_destroyed(_this: &mut Box, _block: &Block) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut EventListener` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/behavioral/mediator.rs:75:33 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn block_updated(_this: &mut Box, _block: &Block) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut EventListener` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Logger` [INFO] [stderr] --> src/behavioral/command.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Self { [INFO] [stderr] 21 | | Logger { state: LogState::On } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 19 | impl Default for Logger { [INFO] [stderr] 20 | fn default() -> Self { [INFO] [stderr] 21 | Self::new() [INFO] [stderr] 22 | } [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `BlockChain` [INFO] [stderr] --> src/behavioral/memento.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Self { [INFO] [stderr] 11 | | BlockChain { blocks: vec![Block(std::u64::MAX)] } [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/behavioral/memento.rs:22:15 [INFO] [stderr] | [INFO] [stderr] 22 | while self.blocks.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.blocks.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Debts` [INFO] [stderr] --> src/structural/proxy.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> Self { [INFO] [stderr] 34 | | Debts { [INFO] [stderr] 35 | | wallet: USDWallet(0f32), [INFO] [stderr] 36 | | debt: 0f32, [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | impl Default for Debts { [INFO] [stderr] 33 | fn default() -> Self { [INFO] [stderr] 34 | Self::new() [INFO] [stderr] 35 | } [INFO] [stderr] 36 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/behavioral/iterator.rs:45:27 [INFO] [stderr] | [INFO] [stderr] 45 | Transaction(0f32, 0x12345678), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/behavioral/iterator.rs:46:28 [INFO] [stderr] | [INFO] [stderr] 46 | Transaction(42f32, 0x12345677), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5677` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/behavioral/iterator.rs:47:29 [INFO] [stderr] | [INFO] [stderr] 47 | Transaction(100f32, 0x12345679), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5679` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/behavioral/iterator.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | for ref transaction in block.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ------------ help: try: `let transaction = &block.iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `UTXO` [INFO] [stderr] --> src/structural/decorator.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> Self { [INFO] [stderr] 23 | | UTXO { unspended: HashMap::new() } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/structural/decorator.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | / if self.unspended.contains_key(&otx.1) { [INFO] [stderr] 48 | | return Some("UTXO already contains outgoing transaction".into()); [INFO] [stderr] 49 | | } else { [INFO] [stderr] 50 | | self.unspended.insert(otx.1, otx.0); [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____________^ help: consider using: `self.unspended.entry(otx.1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/structural/composite.rs:54:42 [INFO] [stderr] | [INFO] [stderr] 54 | let mut tree1 = MerkleTree::new(Hash(0x12345678)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/structural/composite.rs:55:42 [INFO] [stderr] | [INFO] [stderr] 55 | let mut tree2 = MerkleTree::new(Hash(0x12345123)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5123` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/structural/composite.rs:58:19 [INFO] [stderr] | [INFO] [stderr] 58 | tree1 += Hash(0x12345679); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5679` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/structural/composite.rs:59:19 [INFO] [stderr] | [INFO] [stderr] 59 | tree2 += Hash(0x12345123); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5123` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/creational/prototype.rs:51:58 [INFO] [stderr] | [INFO] [stderr] 51 | .add_incoming_transaction(Transaction::new(5f32, 0x12345678)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/creational/prototype.rs:52:59 [INFO] [stderr] | [INFO] [stderr] 52 | .add_outgoing_transaction(Transaction::new(10f32, 0x12345678)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/creational/prototype.rs:55:33 [INFO] [stderr] | [INFO] [stderr] 55 | Transaction::new(42f32, 0x12345679), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5679` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Wallets` [INFO] [stderr] --> src/structural/facade.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Self { [INFO] [stderr] 19 | | Wallets { [INFO] [stderr] 20 | | usd_wallet: USDWallet(0f32), [INFO] [stderr] 21 | | btc_wallet: BitcoinWallet(0f32), [INFO] [stderr] 22 | | eth_wallet: EtheriumWallet(0f32), [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | impl Default for Wallets { [INFO] [stderr] 18 | fn default() -> Self { [INFO] [stderr] 19 | Self::new() [INFO] [stderr] 20 | } [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/behavioral/iterator.rs:45:27 [INFO] [stderr] | [INFO] [stderr] 45 | Transaction(0f32, 0x12345678), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/behavioral/iterator.rs:46:28 [INFO] [stderr] | [INFO] [stderr] 46 | Transaction(42f32, 0x12345677), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5677` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/behavioral/iterator.rs:47:29 [INFO] [stderr] | [INFO] [stderr] 47 | Transaction(100f32, 0x12345679), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5679` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/structural/composite.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / match self { [INFO] [stderr] 27 | | &MerkleTree::Leaf(oh) => oh, [INFO] [stderr] 28 | | &MerkleTree::Tree(oh, _, _) => oh, [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 26 | match *self { [INFO] [stderr] 27 | MerkleTree::Leaf(oh) => oh, [INFO] [stderr] 28 | MerkleTree::Tree(oh, _, _) => oh, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Block` [INFO] [stderr] --> src/creational/prototype.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> Self { [INFO] [stderr] 22 | | Block { [INFO] [stderr] 23 | | hash: 0u64, [INFO] [stderr] 24 | | incoming_txs: vec![], [INFO] [stderr] 25 | | outgoing_txs: vec![], [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/behavioral/iterator.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | for ref transaction in block.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ------------ help: try: `let transaction = &block.iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/behavioral/state.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | self.wallets.get_mut(self.index).unwrap().store(amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.wallets[self.index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/behavioral/mediator.rs:19:16 [INFO] [stderr] | [INFO] [stderr] 19 | listeners: HashMap>>, EventHandler)>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Mediator` [INFO] [stderr] --> src/behavioral/mediator.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Self { [INFO] [stderr] 24 | | Mediator { listeners: HashMap::new() } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/behavioral/mediator.rs:60:33 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn block_created(_this: &mut Box, _block: &Block) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut EventListener` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/behavioral/mediator.rs:64:35 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn block_destroyed(_this: &mut Box, _block: &Block) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut EventListener` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/behavioral/mediator.rs:75:33 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn block_updated(_this: &mut Box, _block: &Block) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut EventListener` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/creational/builder.rs:100:68 [INFO] [stderr] | [INFO] [stderr] 100 | let genesis = GenesisBlockBuilder::new(Transaction::new(42f32, 0x12345678)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/creational/builder.rs:101:59 [INFO] [stderr] | [INFO] [stderr] 101 | .add_incoming_transaction(Transaction::new(10f32, 0x12345678)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/creational/builder.rs:102:59 [INFO] [stderr] | [INFO] [stderr] 102 | .add_incoming_transaction(Transaction::new(20f32, 0x12345678)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/creational/builder.rs:107:59 [INFO] [stderr] | [INFO] [stderr] 107 | .add_incoming_transaction(Transaction::new(10f32, 0x12345678)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/creational/builder.rs:108:59 [INFO] [stderr] | [INFO] [stderr] 108 | .add_incoming_transaction(Transaction::new(20f32, 0x12345678)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/creational/builder.rs:109:59 [INFO] [stderr] | [INFO] [stderr] 109 | .add_outgoing_transaction(Transaction::new(30f32, 0x12345679)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5679` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `GenericBlockBuilder` [INFO] [stderr] --> src/creational/builder.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn new() -> Self { [INFO] [stderr] 33 | | GenericBlockBuilder { [INFO] [stderr] 34 | | incoming_txs: vec![], [INFO] [stderr] 35 | | outgoing_txs: vec![], [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Wallets` [INFO] [stderr] --> src/structural/facade.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Self { [INFO] [stderr] 19 | | Wallets { [INFO] [stderr] 20 | | usd_wallet: USDWallet(0f32), [INFO] [stderr] 21 | | btc_wallet: BitcoinWallet(0f32), [INFO] [stderr] 22 | | eth_wallet: EtheriumWallet(0f32), [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | impl Default for Wallets { [INFO] [stderr] 18 | fn default() -> Self { [INFO] [stderr] 19 | Self::new() [INFO] [stderr] 20 | } [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/creational/builder.rs:100:68 [INFO] [stderr] | [INFO] [stderr] 100 | let genesis = GenesisBlockBuilder::new(Transaction::new(42f32, 0x12345678)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/creational/builder.rs:101:59 [INFO] [stderr] | [INFO] [stderr] 101 | .add_incoming_transaction(Transaction::new(10f32, 0x12345678)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/creational/builder.rs:102:59 [INFO] [stderr] | [INFO] [stderr] 102 | .add_incoming_transaction(Transaction::new(20f32, 0x12345678)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/creational/builder.rs:107:59 [INFO] [stderr] | [INFO] [stderr] 107 | .add_incoming_transaction(Transaction::new(10f32, 0x12345678)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/creational/builder.rs:108:59 [INFO] [stderr] | [INFO] [stderr] 108 | .add_incoming_transaction(Transaction::new(20f32, 0x12345678)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/creational/builder.rs:109:59 [INFO] [stderr] | [INFO] [stderr] 109 | .add_outgoing_transaction(Transaction::new(30f32, 0x12345679)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5679` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `GenericBlockBuilder` [INFO] [stderr] --> src/creational/builder.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn new() -> Self { [INFO] [stderr] 33 | | GenericBlockBuilder { [INFO] [stderr] 34 | | incoming_txs: vec![], [INFO] [stderr] 35 | | outgoing_txs: vec![], [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/behavioral/chain_of_responsibility.rs:72:45 [INFO] [stderr] | [INFO] [stderr] 72 | Currency::Bitcoin(amount) => Ok(println!("BTC: {}", amount)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/behavioral/chain_of_responsibility.rs:88:46 [INFO] [stderr] | [INFO] [stderr] 88 | Currency::Etherium(amount) => Ok(println!("ETH: {:?}", amount)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/behavioral/chain_of_responsibility.rs:104:41 [INFO] [stderr] | [INFO] [stderr] 104 | Currency::USD(amount) => Ok(println!("USD: {:?}", amount)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Wallet` [INFO] [stderr] --> src/structural/flyweight.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / pub fn new() -> Self { [INFO] [stderr] 38 | | Wallet { currencies: HashMap::new() } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/structural/flyweight.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | self.currencies.get(¤cy).unwrap().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.currencies[¤cy]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `BlockChain` [INFO] [stderr] --> src/behavioral/memento.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Self { [INFO] [stderr] 11 | | BlockChain { blocks: vec![Block(std::u64::MAX)] } [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/behavioral/memento.rs:22:15 [INFO] [stderr] | [INFO] [stderr] 22 | while self.blocks.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.blocks.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `USDWallet` [INFO] [stderr] --> src/structural/adapter.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Self { [INFO] [stderr] 15 | | USDWallet { money: 0f32 } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `BitcoinWalletAdapter` [INFO] [stderr] --> src/structural/adapter.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / pub fn new() -> Self { [INFO] [stderr] 63 | | BitcoinWalletAdapter { btc_wallet: BitcoinWallet { bitcoins: 0f32 } } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | impl Default for BitcoinWalletAdapter { [INFO] [stderr] 62 | fn default() -> Self { [INFO] [stderr] 63 | Self::new() [INFO] [stderr] 64 | } [INFO] [stderr] 65 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/behavioral/state.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | self.wallets.get_mut(self.index).unwrap().store(amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.wallets[self.index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/structural/adapter.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | for ref mut wallet in wallet_vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ ---------- help: try: `let wallet = &mut wallet_vec;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/structural/composite.rs:54:42 [INFO] [stderr] | [INFO] [stderr] 54 | let mut tree1 = MerkleTree::new(Hash(0x12345678)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/structural/composite.rs:55:42 [INFO] [stderr] | [INFO] [stderr] 55 | let mut tree2 = MerkleTree::new(Hash(0x12345123)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5123` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/structural/composite.rs:58:19 [INFO] [stderr] | [INFO] [stderr] 58 | tree1 += Hash(0x12345679); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5679` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/structural/composite.rs:59:19 [INFO] [stderr] | [INFO] [stderr] 59 | tree2 += Hash(0x12345123); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5123` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/structural/composite.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / match self { [INFO] [stderr] 27 | | &MerkleTree::Leaf(oh) => oh, [INFO] [stderr] 28 | | &MerkleTree::Tree(oh, _, _) => oh, [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 26 | match *self { [INFO] [stderr] 27 | MerkleTree::Leaf(oh) => oh, [INFO] [stderr] 28 | MerkleTree::Tree(oh, _, _) => oh, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/behavioral/chain_of_responsibility.rs:72:45 [INFO] [stderr] | [INFO] [stderr] 72 | Currency::Bitcoin(amount) => Ok(println!("BTC: {}", amount)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/behavioral/chain_of_responsibility.rs:88:46 [INFO] [stderr] | [INFO] [stderr] 88 | Currency::Etherium(amount) => Ok(println!("ETH: {:?}", amount)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/behavioral/chain_of_responsibility.rs:104:41 [INFO] [stderr] | [INFO] [stderr] 104 | Currency::USD(amount) => Ok(println!("USD: {:?}", amount)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.92s [INFO] running `"docker" "inspect" "1668dac9903cb276da4b228788387bf85911cafa0972629a73cf27ff2c9e4fdb"` [INFO] running `"docker" "rm" "-f" "1668dac9903cb276da4b228788387bf85911cafa0972629a73cf27ff2c9e4fdb"` [INFO] [stdout] 1668dac9903cb276da4b228788387bf85911cafa0972629a73cf27ff2c9e4fdb