[INFO] updating cached repository alex/csv-sql [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/alex/csv-sql [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/alex/csv-sql" "work/ex/clippy-test-run/sources/stable/gh/alex/csv-sql"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/alex/csv-sql'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/alex/csv-sql" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alex/csv-sql"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alex/csv-sql'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 126a1c470a58ccdc0eecd175102354dfbfdfe1b6 [INFO] sha for GitHub repo alex/csv-sql: 126a1c470a58ccdc0eecd175102354dfbfdfe1b6 [INFO] validating manifest of alex/csv-sql on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of alex/csv-sql on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing alex/csv-sql [INFO] finished frobbing alex/csv-sql [INFO] frobbed toml for alex/csv-sql written to work/ex/clippy-test-run/sources/stable/gh/alex/csv-sql/Cargo.toml [INFO] started frobbing alex/csv-sql [INFO] finished frobbing alex/csv-sql [INFO] frobbed toml for alex/csv-sql written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alex/csv-sql/Cargo.toml [INFO] crate alex/csv-sql has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting alex/csv-sql against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/alex/csv-sql:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 63fdbf014813438d2f83e32b3f191bd8af420d5bc77b0f38d4e937d1ed847c08 [INFO] running `"docker" "start" "-a" "63fdbf014813438d2f83e32b3f191bd8af420d5bc77b0f38d4e937d1ed847c08"` [INFO] [stderr] Compiling libsqlite3-sys v0.11.0 [INFO] [stderr] Checking dirs v1.0.4 [INFO] [stderr] Checking time v0.1.41 [INFO] [stderr] Checking nix v0.11.0 [INFO] [stderr] Checking csv-core v0.1.5 [INFO] [stderr] Checking csv v1.0.5 [INFO] [stderr] Checking rusqlite v0.16.0 [INFO] [stderr] Checking prettytable-rs v0.8.0 [INFO] [stderr] Checking rustyline v3.0.0 [INFO] [stderr] Checking csvsql v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:141:38 [INFO] [stderr] | [INFO] [stderr] 141 | return SimpleWordCompleter { words: words }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `words` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:141:38 [INFO] [stderr] | [INFO] [stderr] 141 | return SimpleWordCompleter { words: words }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `words` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / return RE [INFO] [stderr] 17 | | .replace_all(col, "") [INFO] [stderr] 18 | | .to_lowercase() [INFO] [stderr] 19 | | .trim() [INFO] [stderr] 20 | | .replace(" ", "_") [INFO] [stderr] 21 | | .replace(".", "_") [INFO] [stderr] 22 | | .replace("?", ""); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 16 | RE [INFO] [stderr] 17 | .replace_all(col, "") [INFO] [stderr] 18 | .to_lowercase() [INFO] [stderr] 19 | .trim() [INFO] [stderr] 20 | .replace(" ", "_") [INFO] [stderr] 21 | .replace(".", "_") [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | return normalized_cols; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `normalized_cols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | return SimpleWordCompleter { words: words }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SimpleWordCompleter { words: words }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | return Ok((start, matches)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((start, matches))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:25:73 [INFO] [stderr] | [INFO] [stderr] 25 | fn _create_table(db: &mut rusqlite::Connection, table_name: &str, cols: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:41:11 [INFO] [stderr] | [INFO] [stderr] 41 | cols: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / return RE [INFO] [stderr] 17 | | .replace_all(col, "") [INFO] [stderr] 18 | | .to_lowercase() [INFO] [stderr] 19 | | .trim() [INFO] [stderr] 20 | | .replace(" ", "_") [INFO] [stderr] 21 | | .replace(".", "_") [INFO] [stderr] 22 | | .replace("?", ""); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 16 | RE [INFO] [stderr] 17 | .replace_all(col, "") [INFO] [stderr] 18 | .to_lowercase() [INFO] [stderr] 19 | .trim() [INFO] [stderr] 20 | .replace(" ", "_") [INFO] [stderr] 21 | .replace(".", "_") [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | return normalized_cols; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `normalized_cols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | return SimpleWordCompleter { words: words }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SimpleWordCompleter { words: words }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | return Ok((start, matches)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((start, matches))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:25:73 [INFO] [stderr] | [INFO] [stderr] 25 | fn _create_table(db: &mut rusqlite::Connection, table_name: &str, cols: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:41:11 [INFO] [stderr] | [INFO] [stderr] 41 | cols: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.83s [INFO] running `"docker" "inspect" "63fdbf014813438d2f83e32b3f191bd8af420d5bc77b0f38d4e937d1ed847c08"` [INFO] running `"docker" "rm" "-f" "63fdbf014813438d2f83e32b3f191bd8af420d5bc77b0f38d4e937d1ed847c08"` [INFO] [stdout] 63fdbf014813438d2f83e32b3f191bd8af420d5bc77b0f38d4e937d1ed847c08