[INFO] updating cached repository aleozlx/aml-grade [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aleozlx/aml-grade [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aleozlx/aml-grade" "work/ex/clippy-test-run/sources/stable/gh/aleozlx/aml-grade"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aleozlx/aml-grade'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aleozlx/aml-grade" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aleozlx/aml-grade"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aleozlx/aml-grade'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b958474e065869e0b8ae731eb8c3e336e58427f7 [INFO] sha for GitHub repo aleozlx/aml-grade: b958474e065869e0b8ae731eb8c3e336e58427f7 [INFO] validating manifest of aleozlx/aml-grade on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aleozlx/aml-grade on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aleozlx/aml-grade [INFO] finished frobbing aleozlx/aml-grade [INFO] frobbed toml for aleozlx/aml-grade written to work/ex/clippy-test-run/sources/stable/gh/aleozlx/aml-grade/Cargo.toml [INFO] started frobbing aleozlx/aml-grade [INFO] finished frobbing aleozlx/aml-grade [INFO] frobbed toml for aleozlx/aml-grade written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aleozlx/aml-grade/Cargo.toml [INFO] crate aleozlx/aml-grade has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aleozlx/aml-grade against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/aleozlx/aml-grade:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 476741426bb019f0886ebc9a80dd1d8220cf30a9deec6eedd7f65658b5100cdf [INFO] running `"docker" "start" "-a" "476741426bb019f0886ebc9a80dd1d8220cf30a9deec6eedd7f65658b5100cdf"` [INFO] [stderr] Compiling gio v0.5.0 [INFO] [stderr] Compiling gdk v0.9.0 [INFO] [stderr] Compiling gtk v0.5.0 [INFO] [stderr] Compiling glib-sys v0.7.0 [INFO] [stderr] Compiling gobject-sys v0.7.0 [INFO] [stderr] Compiling gio-sys v0.7.0 [INFO] [stderr] Compiling gdk-sys v0.7.0 [INFO] [stderr] Compiling gtk-sys v0.7.0 [INFO] [stderr] Compiling cairo-sys-rs v0.7.0 [INFO] [stderr] Compiling pango-sys v0.7.0 [INFO] [stderr] Compiling atk-sys v0.7.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.7.0 [INFO] [stderr] Compiling cairo-rs v0.5.0 [INFO] [stderr] Compiling gdk-pixbuf v0.5.0 [INFO] [stderr] Checking glib v0.6.0 [INFO] [stderr] Checking pango v0.5.0 [INFO] [stderr] Checking gobject-subclass v0.2.0 [INFO] [stderr] Checking aml-grade v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::io::BufReader` [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | use std::io::BufReader; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::BufReader` [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | use std::io::BufReader; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `window_weak` [INFO] [stderr] --> src/main.rs:86:39 [INFO] [stderr] | [INFO] [stderr] 86 | listbox.bind_model(&model, clone!(window_weak => move |item| { [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_window_weak` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/student.rs:134:57 [INFO] [stderr] | [INFO] [stderr] 134 | Property::Boolean("selected", ..) => Ok(self.selected.borrow().clone().to_value()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.selected.borrow()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/student.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | / fn new(&self, obj: &Object) -> Box> { [INFO] [stderr] 153 | | RowData::init(obj) [INFO] [stderr] 154 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/student.rs:164:1 [INFO] [stderr] | [INFO] [stderr] 164 | / glib_wrapper! { [INFO] [stderr] 165 | | pub struct RowData(Object): [INFO] [stderr] 166 | | [Object => InstanceStruct]; [INFO] [stderr] 167 | | [INFO] [stderr] ... | [INFO] [stderr] 170 | | } [INFO] [stderr] 171 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/student.rs:164:1 [INFO] [stderr] | [INFO] [stderr] 164 | / glib_wrapper! { [INFO] [stderr] 165 | | pub struct RowData(Object): [INFO] [stderr] 166 | | [Object => InstanceStruct]; [INFO] [stderr] 167 | | [INFO] [stderr] ... | [INFO] [stderr] 170 | | } [INFO] [stderr] 171 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/student.rs:164:1 [INFO] [stderr] | [INFO] [stderr] 164 | / glib_wrapper! { [INFO] [stderr] 165 | | pub struct RowData(Object): [INFO] [stderr] 166 | | [Object => InstanceStruct]; [INFO] [stderr] 167 | | [INFO] [stderr] ... | [INFO] [stderr] 170 | | } [INFO] [stderr] 171 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/student.rs:164:1 [INFO] [stderr] | [INFO] [stderr] 164 | / glib_wrapper! { [INFO] [stderr] 165 | | pub struct RowData(Object): [INFO] [stderr] 166 | | [Object => InstanceStruct]; [INFO] [stderr] 167 | | [INFO] [stderr] ... | [INFO] [stderr] 170 | | } [INFO] [stderr] 171 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:45:27 [INFO] [stderr] | [INFO] [stderr] 45 | str_components.extend(path.components().into_iter().map(|val| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `path.components()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / match p.exists() { [INFO] [stderr] 55 | | true => Some(p), [INFO] [stderr] 56 | | false => None [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if p.exists() { Some(p) } else { None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:165:29 [INFO] [stderr] | [INFO] [stderr] 165 | let ref jh = format!("http://localhost:8888/notebooks/{}/{}", line.unwrap(), notebook1.to_str().unwrap()); [INFO] [stderr] | ----^^^^^^------------------------------------------------------------------------------------------------ help: try: `let jh = &$ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) );` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:182:29 [INFO] [stderr] | [INFO] [stderr] 182 | let ref jh = format!("http://localhost:8888/notebooks/{}/{}", line.unwrap(), notebook2.to_str().unwrap()); [INFO] [stderr] | ----^^^^^^------------------------------------------------------------------------------------------------ help: try: `let jh = &$ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) );` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:199:29 [INFO] [stderr] | [INFO] [stderr] 199 | let ref jh = format!("http://localhost:8888/notebooks/{}/{}", line.unwrap(), notebook3.to_str().unwrap()); [INFO] [stderr] | ----^^^^^^------------------------------------------------------------------------------------------------ help: try: `let jh = &$ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) );` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: unused variable: `window_weak` [INFO] [stderr] --> src/main.rs:86:39 [INFO] [stderr] | [INFO] [stderr] 86 | listbox.bind_model(&model, clone!(window_weak => move |item| { [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_window_weak` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/student.rs:134:57 [INFO] [stderr] | [INFO] [stderr] 134 | Property::Boolean("selected", ..) => Ok(self.selected.borrow().clone().to_value()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.selected.borrow()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/student.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | / fn new(&self, obj: &Object) -> Box> { [INFO] [stderr] 153 | | RowData::init(obj) [INFO] [stderr] 154 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/student.rs:164:1 [INFO] [stderr] | [INFO] [stderr] 164 | / glib_wrapper! { [INFO] [stderr] 165 | | pub struct RowData(Object): [INFO] [stderr] 166 | | [Object => InstanceStruct]; [INFO] [stderr] 167 | | [INFO] [stderr] ... | [INFO] [stderr] 170 | | } [INFO] [stderr] 171 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/student.rs:164:1 [INFO] [stderr] | [INFO] [stderr] 164 | / glib_wrapper! { [INFO] [stderr] 165 | | pub struct RowData(Object): [INFO] [stderr] 166 | | [Object => InstanceStruct]; [INFO] [stderr] 167 | | [INFO] [stderr] ... | [INFO] [stderr] 170 | | } [INFO] [stderr] 171 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/student.rs:164:1 [INFO] [stderr] | [INFO] [stderr] 164 | / glib_wrapper! { [INFO] [stderr] 165 | | pub struct RowData(Object): [INFO] [stderr] 166 | | [Object => InstanceStruct]; [INFO] [stderr] 167 | | [INFO] [stderr] ... | [INFO] [stderr] 170 | | } [INFO] [stderr] 171 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/student.rs:164:1 [INFO] [stderr] | [INFO] [stderr] 164 | / glib_wrapper! { [INFO] [stderr] 165 | | pub struct RowData(Object): [INFO] [stderr] 166 | | [Object => InstanceStruct]; [INFO] [stderr] 167 | | [INFO] [stderr] ... | [INFO] [stderr] 170 | | } [INFO] [stderr] 171 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:45:27 [INFO] [stderr] | [INFO] [stderr] 45 | str_components.extend(path.components().into_iter().map(|val| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `path.components()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / match p.exists() { [INFO] [stderr] 55 | | true => Some(p), [INFO] [stderr] 56 | | false => None [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if p.exists() { Some(p) } else { None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:165:29 [INFO] [stderr] | [INFO] [stderr] 165 | let ref jh = format!("http://localhost:8888/notebooks/{}/{}", line.unwrap(), notebook1.to_str().unwrap()); [INFO] [stderr] | ----^^^^^^------------------------------------------------------------------------------------------------ help: try: `let jh = &$ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) );` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:182:29 [INFO] [stderr] | [INFO] [stderr] 182 | let ref jh = format!("http://localhost:8888/notebooks/{}/{}", line.unwrap(), notebook2.to_str().unwrap()); [INFO] [stderr] | ----^^^^^^------------------------------------------------------------------------------------------------ help: try: `let jh = &$ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) );` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:199:29 [INFO] [stderr] | [INFO] [stderr] 199 | let ref jh = format!("http://localhost:8888/notebooks/{}/{}", line.unwrap(), notebook3.to_str().unwrap()); [INFO] [stderr] | ----^^^^^^------------------------------------------------------------------------------------------------ help: try: `let jh = &$ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) );` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 48s [INFO] running `"docker" "inspect" "476741426bb019f0886ebc9a80dd1d8220cf30a9deec6eedd7f65658b5100cdf"` [INFO] running `"docker" "rm" "-f" "476741426bb019f0886ebc9a80dd1d8220cf30a9deec6eedd7f65658b5100cdf"` [INFO] [stdout] 476741426bb019f0886ebc9a80dd1d8220cf30a9deec6eedd7f65658b5100cdf