[INFO] updating cached repository alekratz/not-perl [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/alekratz/not-perl [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/alekratz/not-perl" "work/ex/clippy-test-run/sources/stable/gh/alekratz/not-perl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/alekratz/not-perl'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/alekratz/not-perl" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alekratz/not-perl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alekratz/not-perl'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2a308bceec453c7c1e3f510d69c6f5ddd13c1eb5 [INFO] sha for GitHub repo alekratz/not-perl: 2a308bceec453c7c1e3f510d69c6f5ddd13c1eb5 [INFO] validating manifest of alekratz/not-perl on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of alekratz/not-perl on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing alekratz/not-perl [INFO] finished frobbing alekratz/not-perl [INFO] frobbed toml for alekratz/not-perl written to work/ex/clippy-test-run/sources/stable/gh/alekratz/not-perl/Cargo.toml [INFO] started frobbing alekratz/not-perl [INFO] finished frobbing alekratz/not-perl [INFO] frobbed toml for alekratz/not-perl written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alekratz/not-perl/Cargo.toml [INFO] crate alekratz/not-perl has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting alekratz/not-perl against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/alekratz/not-perl:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e1972c43118fe570006ba4022022f44524ddb46c0381962dc85d54c24d172d47 [INFO] running `"docker" "start" "-a" "e1972c43118fe570006ba4022022f44524ddb46c0381962dc85d54c24d172d47"` [INFO] [stderr] Compiling enum-methods v0.0.8 [INFO] [stderr] Checking not-perl v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vm/storage.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | functions: functions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `functions` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vm/storage.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | functions: functions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `functions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/syntax/lexer.rs:289:13 [INFO] [stderr] | [INFO] [stderr] 289 | return Ok(Token::FloatLit(number)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::FloatLit(number))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/syntax/lexer.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | return Ok(Token::IntLit(number, radix)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::IntLit(number, radix))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ir/function.rs:67:47 [INFO] [stderr] | [INFO] [stderr] 67 | FunctionParam::Variable { symbol, ty: _, default: _ } => symbol.name(), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ir/function.rs:67:54 [INFO] [stderr] | [INFO] [stderr] 67 | FunctionParam::Variable { symbol, ty: _, default: _ } => symbol.name(), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Variable { symbol, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vm/value.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/repl.rs:4:19 [INFO] [stderr] | [INFO] [stderr] 4 | const REPL_NAME: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/compile/scope.rs:219:26 [INFO] [stderr] | [INFO] [stderr] 219 | const BUILTINS: &'static [vm::BuiltinTy] = &[ [INFO] [stderr] | -^^^^^^^---------------- help: consider removing `'static`: `&[vm::BuiltinTy]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/compile/state.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | operators: _, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `CompileState { body, ty_scope, function_scope, mut variable_scope, repl: _repl, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/compile/state.rs:322:43 [INFO] [stderr] | [INFO] [stderr] 322 | FunctionParam::Variable { symbol: _, ty, default } => { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Variable { ty, default, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/compile/state.rs:414:16 [INFO] [stderr] | [INFO] [stderr] 414 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 415 | | if lhs_context == ValueContext::Push { [INFO] [stderr] 416 | | // evaluate LHS, evaluate RHS, pop RHS into LHS ref [INFO] [stderr] 417 | | assign_body.push(Bc::PushValue(vm::Value::RefCanary)); [INFO] [stderr] ... | [INFO] [stderr] 424 | | } [INFO] [stderr] 425 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 414 | } else if lhs_context == ValueContext::Push { [INFO] [stderr] 415 | // evaluate LHS, evaluate RHS, pop RHS into LHS ref [INFO] [stderr] 416 | assign_body.push(Bc::PushValue(vm::Value::RefCanary)); [INFO] [stderr] 417 | assign_body.append(&mut self.compile_value(lhs, ValueContext::Push)?); [INFO] [stderr] 418 | assign_body.append(&mut self.compile_value(rhs, ValueContext::Push)?); [INFO] [stderr] 419 | assign_body.push(Bc::PopRefAndStore); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:75:12 [INFO] [stderr] | [INFO] [stderr] 75 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 76 | | if let Err(e) = exec(argv) { [INFO] [stderr] 77 | | eprintln!("{}", e); [INFO] [stderr] 78 | | process::exit(1); [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 75 | } else if let Err(e) = exec(argv) { [INFO] [stderr] 76 | eprintln!("{}", e); [INFO] [stderr] 77 | process::exit(1); [INFO] [stderr] 78 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/syntax/lexer.rs:289:13 [INFO] [stderr] | [INFO] [stderr] 289 | return Ok(Token::FloatLit(number)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::FloatLit(number))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/syntax/lexer.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | return Ok(Token::IntLit(number, radix)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::IntLit(number, radix))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ir/function.rs:67:47 [INFO] [stderr] | [INFO] [stderr] 67 | FunctionParam::Variable { symbol, ty: _, default: _ } => symbol.name(), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ir/function.rs:67:54 [INFO] [stderr] | [INFO] [stderr] 67 | FunctionParam::Variable { symbol, ty: _, default: _ } => symbol.name(), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Variable { symbol, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vm/value.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/repl.rs:4:19 [INFO] [stderr] | [INFO] [stderr] 4 | const REPL_NAME: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/compile/scope.rs:219:26 [INFO] [stderr] | [INFO] [stderr] 219 | const BUILTINS: &'static [vm::BuiltinTy] = &[ [INFO] [stderr] | -^^^^^^^---------------- help: consider removing `'static`: `&[vm::BuiltinTy]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/compile/state.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | operators: _, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `CompileState { body, ty_scope, function_scope, mut variable_scope, repl: _repl, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/compile/state.rs:322:43 [INFO] [stderr] | [INFO] [stderr] 322 | FunctionParam::Variable { symbol: _, ty, default } => { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Variable { ty, default, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/compile/state.rs:414:16 [INFO] [stderr] | [INFO] [stderr] 414 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 415 | | if lhs_context == ValueContext::Push { [INFO] [stderr] 416 | | // evaluate LHS, evaluate RHS, pop RHS into LHS ref [INFO] [stderr] 417 | | assign_body.push(Bc::PushValue(vm::Value::RefCanary)); [INFO] [stderr] ... | [INFO] [stderr] 424 | | } [INFO] [stderr] 425 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 414 | } else if lhs_context == ValueContext::Push { [INFO] [stderr] 415 | // evaluate LHS, evaluate RHS, pop RHS into LHS ref [INFO] [stderr] 416 | assign_body.push(Bc::PushValue(vm::Value::RefCanary)); [INFO] [stderr] 417 | assign_body.append(&mut self.compile_value(lhs, ValueContext::Push)?); [INFO] [stderr] 418 | assign_body.append(&mut self.compile_value(rhs, ValueContext::Push)?); [INFO] [stderr] 419 | assign_body.push(Bc::PopRefAndStore); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:75:12 [INFO] [stderr] | [INFO] [stderr] 75 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 76 | | if let Err(e) = exec(argv) { [INFO] [stderr] 77 | | eprintln!("{}", e); [INFO] [stderr] 78 | | process::exit(1); [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 75 | } else if let Err(e) = exec(argv) { [INFO] [stderr] 76 | eprintln!("{}", e); [INFO] [stderr] 77 | process::exit(1); [INFO] [stderr] 78 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/syntax/lexer.rs:326:9 [INFO] [stderr] | [INFO] [stderr] 326 | self.curr.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.curr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/syntax/parser.rs:206:26 [INFO] [stderr] | [INFO] [stderr] 206 | .map(|t| if let &Token::Op(ref op) = t.token() { [INFO] [stderr] | __________________________^ [INFO] [stderr] 207 | | top.contains(op) [INFO] [stderr] 208 | | } else { [INFO] [stderr] 209 | | false [INFO] [stderr] 210 | | }) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 206 | .map(|t| if let Token::Op(ref op) = *t.token() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/syntax/parser.rs:304:41 [INFO] [stderr] | [INFO] [stderr] 304 | return Err(self.err(format!("got 'self' keyword outside of type declaration"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"got 'self' keyword outside of type declaration".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/syntax/parser.rs:305:27 [INFO] [stderr] | [INFO] [stderr] 305 | } else if params.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/syntax/parser.rs:306:41 [INFO] [stderr] | [INFO] [stderr] 306 | return Err(self.err(format!("'self' parameter is only allowed as the first argument to a function"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"'self' parameter is only allowed as the first argument to a function".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/syntax/parser.rs:453:23 [INFO] [stderr] | [INFO] [stderr] 453 | fn is_token_match(&mut self, token: &Token) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/syntax/parser.rs:461:29 [INFO] [stderr] | [INFO] [stderr] 461 | fn is_lookahead(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/syntax/parser.rs:538:58 [INFO] [stderr] | [INFO] [stderr] 538 | got.map(|s| s.to_string()).unwrap_or("EOF".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "EOF".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/syntax/token.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | / pub fn from_str(other: impl AsRef) -> Option { [INFO] [stderr] 101 | | match other.as_ref() { [INFO] [stderr] 102 | | "=" => Some(AssignOp::Equals), [INFO] [stderr] 103 | | "+=" => Some(AssignOp::PlusEquals), [INFO] [stderr] ... | [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/syntax/token.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | / if let &Token::Op(_) = self { [INFO] [stderr] 199 | | true [INFO] [stderr] 200 | | } else { [INFO] [stderr] 201 | | false [INFO] [stderr] 202 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 198 | if let Token::Op(_) = *self { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/syntax/token.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | / if let &Token::AssignOp(_) = self { [INFO] [stderr] 215 | | true [INFO] [stderr] 216 | | } else { [INFO] [stderr] 217 | | false [INFO] [stderr] 218 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 214 | if let Token::AssignOp(_) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/syntax/token.rs:229:23 [INFO] [stderr] | [INFO] [stderr] 229 | 10 => format!("{}", i), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `i.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/syntax/tree.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | Assign(Expr<'n>, AssignOp, Expr<'n>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/syntax/tree.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | Assign(Expr<'n>, AssignOp, Expr<'n>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/ir/action.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Assign(Value<'n>, AssignOp, Value<'n>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/ir/action.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Assign(Value<'n>, AssignOp, Value<'n>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/ir/value.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | Err(_) => unimplemented!("bigint") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/vm/value.rs:59:32 [INFO] [stderr] | [INFO] [stderr] 59 | Value::Array(_) => format!("TODO : vm::Value array display string"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"TODO : vm::Value array display string".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vm/ty.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn name(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/vm/condition.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | _ => panic!("cannot convert IR op {:?} to VM comparison op"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::panic_params)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vm::storage::Storage` [INFO] [stderr] --> src/vm/storage.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn new() -> Self { [INFO] [stderr] 46 | | Storage { [INFO] [stderr] 47 | | scope_stack: vec![], [INFO] [stderr] 48 | | value_stack: vec![], [INFO] [stderr] ... | [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `vm::Vm` [INFO] [stderr] --> src/vm/mod.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn new() -> Self { [INFO] [stderr] 52 | | Vm { [INFO] [stderr] 53 | | storage: Storage::new(), [INFO] [stderr] 54 | | call_stack: vec![], [INFO] [stderr] ... | [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | impl Default for vm::Vm { [INFO] [stderr] 51 | fn default() -> Self { [INFO] [stderr] 52 | Self::new() [INFO] [stderr] 53 | } [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/vm/mod.rs:81:29 [INFO] [stderr] | [INFO] [stderr] 81 | let prev_scope = if prev_storage.scope_stack.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `prev_storage.scope_stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/vm/mod.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | let ref bc = block[pc]; [INFO] [stderr] | ----^^^^^^------------- help: try: `let bc = &block[pc];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `repl::Repl` [INFO] [stderr] --> src/repl.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Self { [INFO] [stderr] 13 | | let mut state = CompileState::repl(); [INFO] [stderr] 14 | | state.begin(); [INFO] [stderr] 15 | | Repl { [INFO] [stderr] ... | [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | impl Default for repl::Repl { [INFO] [stderr] 12 | fn default() -> Self { [INFO] [stderr] 13 | Self::new() [INFO] [stderr] 14 | } [INFO] [stderr] 15 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/compile/scope.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | / self.iter() [INFO] [stderr] 115 | | .filter(|t| (predicate)(&t)) [INFO] [stderr] 116 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|t| (predicate)(&t)).next()` with `find(|t| (predicate)(&t))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/compile/scope.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | / self.iter_local() [INFO] [stderr] 127 | | .filter(|t| (predicate)(&t)) [INFO] [stderr] 128 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|t| (predicate)(&t)).next()` with `find(|t| (predicate)(&t))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `compile::scope::TyScope` [INFO] [stderr] --> src/compile/scope.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | / pub fn new() -> Self { [INFO] [stderr] 212 | | TyScope { [INFO] [stderr] 213 | | scope: Scope::empty(TySymbolAlloc::new()), [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 210 | impl Default for compile::scope::TyScope { [INFO] [stderr] 211 | fn default() -> Self { [INFO] [stderr] 212 | Self::new() [INFO] [stderr] 213 | } [INFO] [stderr] 214 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `compile::scope::FunctionScope` [INFO] [stderr] --> src/compile/scope.rs:286:5 [INFO] [stderr] | [INFO] [stderr] 286 | / pub fn new() -> Self { [INFO] [stderr] 287 | | FunctionScope { [INFO] [stderr] 288 | | scope: Scope::empty(FunctionSymbolAlloc::new()), [INFO] [stderr] 289 | | vm_functions: vec![], [INFO] [stderr] 290 | | } [INFO] [stderr] 291 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 285 | impl Default for compile::scope::FunctionScope { [INFO] [stderr] 286 | fn default() -> Self { [INFO] [stderr] 287 | Self::new() [INFO] [stderr] 288 | } [INFO] [stderr] 289 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/compile/scope.rs:301:56 [INFO] [stderr] | [INFO] [stderr] 301 | return_ty: ir::TyExpr::from_builtin_ty(function.return_ty.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `function.return_ty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/compile/scope.rs:319:9 [INFO] [stderr] | [INFO] [stderr] 319 | / self.vm_functions.iter() [INFO] [stderr] 320 | | .filter(|function| function.is_builtin() && function.name() == name) [INFO] [stderr] 321 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|function| function.is_builtin() && function.name() == name).next()` with `find(|function| function.is_builtin() && function.name() == name)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `compile::scope::VariableScope` [INFO] [stderr] --> src/compile/scope.rs:349:5 [INFO] [stderr] | [INFO] [stderr] 349 | / pub fn new() -> Self { [INFO] [stderr] 350 | | VariableScope { [INFO] [stderr] 351 | | scope: Scope::empty(VariableSymbolAlloc::new()), [INFO] [stderr] 352 | | } [INFO] [stderr] 353 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 348 | impl Default for compile::scope::VariableScope { [INFO] [stderr] 349 | fn default() -> Self { [INFO] [stderr] 350 | Self::new() [INFO] [stderr] 351 | } [INFO] [stderr] 352 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `compile::symbol::SymbolAlloc` [INFO] [stderr] --> src/compile/symbol.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | / pub fn new() -> Self { [INFO] [stderr] 120 | | SymbolAlloc { reserve_next: T::Symbol::default() } [INFO] [stderr] 121 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 86 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `compile::symbol::VariableSymbolAlloc` [INFO] [stderr] --> src/compile/symbol.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | / pub fn new() -> Self { [INFO] [stderr] 162 | | VariableSymbolAlloc { [INFO] [stderr] 163 | | reserve_next: VariableSymbol::default(), [INFO] [stderr] 164 | | locals: vec![], [INFO] [stderr] 165 | | } [INFO] [stderr] 166 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 126 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `compile::state::CompileState` [INFO] [stderr] --> src/compile/state.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Self { [INFO] [stderr] 35 | | let builtin_functions = vm::BUILTIN_FUNCTIONS.iter() [INFO] [stderr] 36 | | .cloned() [INFO] [stderr] 37 | | .chain(vm::BUILTIN_OPERATORS.iter().map(|(_, f)| f).cloned()) [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | impl Default for compile::state::CompileState { [INFO] [stderr] 34 | fn default() -> Self { [INFO] [stderr] 35 | Self::new() [INFO] [stderr] 36 | } [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/compile/state.rs:217:30 [INFO] [stderr] | [INFO] [stderr] 217 | let user_predicate = udt_scope.iter() [INFO] [stderr] | ______________________________^ [INFO] [stderr] 218 | | .filter(|f| f.name == "is?") [INFO] [stderr] 219 | | .next(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|f| f.name == "is?").next()` with `find(|f| f.name == "is?")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/syntax/lexer.rs:326:9 [INFO] [stderr] | [INFO] [stderr] 326 | self.curr.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.curr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/compile/state.rs:303:22 [INFO] [stderr] | [INFO] [stderr] 303 | .expect(&format!("symbol for function {} (param count {}) was expected to exist, but does not", [INFO] [stderr] | ______________________^ [INFO] [stderr] 304 | | name, function.params.len())) [INFO] [stderr] | |__________________________________________________________________^ help: try this: `unwrap_or_else(|| panic!("symbol for function {} (param count {}) was expected to exist, but does not", name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/compile/state.rs:361:14 [INFO] [stderr] | [INFO] [stderr] 361 | .ok_or(format!("undefined type: {}", function.return_ty))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("undefined type: {}", function.return_ty))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compile/state.rs:390:44 [INFO] [stderr] | [INFO] [stderr] 390 | Symbol::Variable(s) => self.lookup_or_insert_local_variable(s).clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.lookup_or_insert_local_variable(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compile/state.rs:439:27 [INFO] [stderr] | [INFO] [stderr] 439 | let sym = self.lookup_or_insert_local_variable(value.as_inner().name()) [INFO] [stderr] | ___________________________^ [INFO] [stderr] 440 | | .clone(); [INFO] [stderr] | |____________________________^ help: try removing the `clone` call: `self.lookup_or_insert_local_variable(value.as_inner().name())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/compile/state.rs:455:30 [INFO] [stderr] | [INFO] [stderr] 455 | .ok_or(format!("unknown function `{}`", s))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("unknown function `{}`", s))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compile/state.rs:467:38 [INFO] [stderr] | [INFO] [stderr] 467 | let symbol = self.lookup_or_insert_local_variable(s).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.lookup_or_insert_local_variable(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compile/state.rs:488:91 [INFO] [stderr] | [INFO] [stderr] 488 | expr_body.append(&mut self.compile_value(lhs, ValueContext::StoreInto(lhs_sym.clone()))?); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `lhs_sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compile/state.rs:497:91 [INFO] [stderr] | [INFO] [stderr] 497 | expr_body.append(&mut self.compile_value(rhs, ValueContext::StoreInto(rhs_sym.clone()))?); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rhs_sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compile/state.rs:573:88 [INFO] [stderr] | [INFO] [stderr] 573 | let mut body = self.compile_value(lhs, ValueContext::StoreInto(lhs_sym.clone()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `lhs_sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compile/state.rs:574:90 [INFO] [stderr] | [INFO] [stderr] 574 | body.append(&mut self.compile_value(rhs, ValueContext::StoreInto(rhs_sym.clone()))?); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rhs_sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compile/state.rs:582:96 [INFO] [stderr] | [INFO] [stderr] 582 | let mut value_body = self.compile_value(value, ValueContext::StoreInto(result_sym.clone()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `result_sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compile/state.rs:592:88 [INFO] [stderr] | [INFO] [stderr] 592 | let mut value_body = self.compile_value(value, ValueContext::StoreInto(result_sym.clone()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `result_sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | write!(stdout, " > "); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:57:12 [INFO] [stderr] | [INFO] [stderr] 57 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/syntax/parser.rs:206:26 [INFO] [stderr] | [INFO] [stderr] 206 | .map(|t| if let &Token::Op(ref op) = t.token() { [INFO] [stderr] | __________________________^ [INFO] [stderr] 207 | | top.contains(op) [INFO] [stderr] 208 | | } else { [INFO] [stderr] 209 | | false [INFO] [stderr] 210 | | }) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 206 | .map(|t| if let Token::Op(ref op) = *t.token() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/syntax/parser.rs:304:41 [INFO] [stderr] | [INFO] [stderr] 304 | return Err(self.err(format!("got 'self' keyword outside of type declaration"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"got 'self' keyword outside of type declaration".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/syntax/parser.rs:305:27 [INFO] [stderr] | [INFO] [stderr] 305 | } else if params.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/syntax/parser.rs:306:41 [INFO] [stderr] | [INFO] [stderr] 306 | return Err(self.err(format!("'self' parameter is only allowed as the first argument to a function"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"'self' parameter is only allowed as the first argument to a function".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/syntax/parser.rs:453:23 [INFO] [stderr] | [INFO] [stderr] 453 | fn is_token_match(&mut self, token: &Token) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/syntax/parser.rs:461:29 [INFO] [stderr] | [INFO] [stderr] 461 | fn is_lookahead(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/syntax/parser.rs:538:58 [INFO] [stderr] | [INFO] [stderr] 538 | got.map(|s| s.to_string()).unwrap_or("EOF".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "EOF".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/syntax/token.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | / pub fn from_str(other: impl AsRef) -> Option { [INFO] [stderr] 101 | | match other.as_ref() { [INFO] [stderr] 102 | | "=" => Some(AssignOp::Equals), [INFO] [stderr] 103 | | "+=" => Some(AssignOp::PlusEquals), [INFO] [stderr] ... | [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/syntax/token.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | / if let &Token::Op(_) = self { [INFO] [stderr] 199 | | true [INFO] [stderr] 200 | | } else { [INFO] [stderr] 201 | | false [INFO] [stderr] 202 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 198 | if let Token::Op(_) = *self { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/syntax/token.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | / if let &Token::AssignOp(_) = self { [INFO] [stderr] 215 | | true [INFO] [stderr] 216 | | } else { [INFO] [stderr] 217 | | false [INFO] [stderr] 218 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 214 | if let Token::AssignOp(_) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/syntax/token.rs:229:23 [INFO] [stderr] | [INFO] [stderr] 229 | 10 => format!("{}", i), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `i.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/syntax/tree.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | Assign(Expr<'n>, AssignOp, Expr<'n>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/syntax/tree.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | Assign(Expr<'n>, AssignOp, Expr<'n>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/ir/action.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Assign(Value<'n>, AssignOp, Value<'n>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/ir/action.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Assign(Value<'n>, AssignOp, Value<'n>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/ir/value.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | Err(_) => unimplemented!("bigint") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/vm/value.rs:59:32 [INFO] [stderr] | [INFO] [stderr] 59 | Value::Array(_) => format!("TODO : vm::Value array display string"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"TODO : vm::Value array display string".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vm/ty.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn name(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/vm/condition.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | _ => panic!("cannot convert IR op {:?} to VM comparison op"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::panic_params)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vm::storage::Storage` [INFO] [stderr] --> src/vm/storage.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn new() -> Self { [INFO] [stderr] 46 | | Storage { [INFO] [stderr] 47 | | scope_stack: vec![], [INFO] [stderr] 48 | | value_stack: vec![], [INFO] [stderr] ... | [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `vm::Vm` [INFO] [stderr] --> src/vm/mod.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn new() -> Self { [INFO] [stderr] 52 | | Vm { [INFO] [stderr] 53 | | storage: Storage::new(), [INFO] [stderr] 54 | | call_stack: vec![], [INFO] [stderr] ... | [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | impl Default for vm::Vm { [INFO] [stderr] 51 | fn default() -> Self { [INFO] [stderr] 52 | Self::new() [INFO] [stderr] 53 | } [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/vm/mod.rs:81:29 [INFO] [stderr] | [INFO] [stderr] 81 | let prev_scope = if prev_storage.scope_stack.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `prev_storage.scope_stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/vm/mod.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | let ref bc = block[pc]; [INFO] [stderr] | ----^^^^^^------------- help: try: `let bc = &block[pc];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `repl::Repl` [INFO] [stderr] --> src/repl.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Self { [INFO] [stderr] 13 | | let mut state = CompileState::repl(); [INFO] [stderr] 14 | | state.begin(); [INFO] [stderr] 15 | | Repl { [INFO] [stderr] ... | [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | impl Default for repl::Repl { [INFO] [stderr] 12 | fn default() -> Self { [INFO] [stderr] 13 | Self::new() [INFO] [stderr] 14 | } [INFO] [stderr] 15 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/compile/scope.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | / self.iter() [INFO] [stderr] 115 | | .filter(|t| (predicate)(&t)) [INFO] [stderr] 116 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|t| (predicate)(&t)).next()` with `find(|t| (predicate)(&t))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/compile/scope.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | / self.iter_local() [INFO] [stderr] 127 | | .filter(|t| (predicate)(&t)) [INFO] [stderr] 128 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|t| (predicate)(&t)).next()` with `find(|t| (predicate)(&t))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `compile::scope::TyScope` [INFO] [stderr] --> src/compile/scope.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | / pub fn new() -> Self { [INFO] [stderr] 212 | | TyScope { [INFO] [stderr] 213 | | scope: Scope::empty(TySymbolAlloc::new()), [INFO] [stderr] 214 | | } [INFO] [stderr] 215 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 210 | impl Default for compile::scope::TyScope { [INFO] [stderr] 211 | fn default() -> Self { [INFO] [stderr] 212 | Self::new() [INFO] [stderr] 213 | } [INFO] [stderr] 214 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `compile::scope::FunctionScope` [INFO] [stderr] --> src/compile/scope.rs:286:5 [INFO] [stderr] | [INFO] [stderr] 286 | / pub fn new() -> Self { [INFO] [stderr] 287 | | FunctionScope { [INFO] [stderr] 288 | | scope: Scope::empty(FunctionSymbolAlloc::new()), [INFO] [stderr] 289 | | vm_functions: vec![], [INFO] [stderr] 290 | | } [INFO] [stderr] 291 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 285 | impl Default for compile::scope::FunctionScope { [INFO] [stderr] 286 | fn default() -> Self { [INFO] [stderr] 287 | Self::new() [INFO] [stderr] 288 | } [INFO] [stderr] 289 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/compile/scope.rs:301:56 [INFO] [stderr] | [INFO] [stderr] 301 | return_ty: ir::TyExpr::from_builtin_ty(function.return_ty.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `function.return_ty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/compile/scope.rs:319:9 [INFO] [stderr] | [INFO] [stderr] 319 | / self.vm_functions.iter() [INFO] [stderr] 320 | | .filter(|function| function.is_builtin() && function.name() == name) [INFO] [stderr] 321 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|function| function.is_builtin() && function.name() == name).next()` with `find(|function| function.is_builtin() && function.name() == name)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `compile::scope::VariableScope` [INFO] [stderr] --> src/compile/scope.rs:349:5 [INFO] [stderr] | [INFO] [stderr] 349 | / pub fn new() -> Self { [INFO] [stderr] 350 | | VariableScope { [INFO] [stderr] 351 | | scope: Scope::empty(VariableSymbolAlloc::new()), [INFO] [stderr] 352 | | } [INFO] [stderr] 353 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 348 | impl Default for compile::scope::VariableScope { [INFO] [stderr] 349 | fn default() -> Self { [INFO] [stderr] 350 | Self::new() [INFO] [stderr] 351 | } [INFO] [stderr] 352 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `compile::symbol::SymbolAlloc` [INFO] [stderr] --> src/compile/symbol.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | / pub fn new() -> Self { [INFO] [stderr] 120 | | SymbolAlloc { reserve_next: T::Symbol::default() } [INFO] [stderr] 121 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 86 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `compile::symbol::VariableSymbolAlloc` [INFO] [stderr] --> src/compile/symbol.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | / pub fn new() -> Self { [INFO] [stderr] 162 | | VariableSymbolAlloc { [INFO] [stderr] 163 | | reserve_next: VariableSymbol::default(), [INFO] [stderr] 164 | | locals: vec![], [INFO] [stderr] 165 | | } [INFO] [stderr] 166 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 126 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `compile::state::CompileState` [INFO] [stderr] --> src/compile/state.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Self { [INFO] [stderr] 35 | | let builtin_functions = vm::BUILTIN_FUNCTIONS.iter() [INFO] [stderr] 36 | | .cloned() [INFO] [stderr] 37 | | .chain(vm::BUILTIN_OPERATORS.iter().map(|(_, f)| f).cloned()) [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | impl Default for compile::state::CompileState { [INFO] [stderr] 34 | fn default() -> Self { [INFO] [stderr] 35 | Self::new() [INFO] [stderr] 36 | } [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/compile/state.rs:217:30 [INFO] [stderr] | [INFO] [stderr] 217 | let user_predicate = udt_scope.iter() [INFO] [stderr] | ______________________________^ [INFO] [stderr] 218 | | .filter(|f| f.name == "is?") [INFO] [stderr] 219 | | .next(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|f| f.name == "is?").next()` with `find(|f| f.name == "is?")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/compile/state.rs:303:22 [INFO] [stderr] | [INFO] [stderr] 303 | .expect(&format!("symbol for function {} (param count {}) was expected to exist, but does not", [INFO] [stderr] | ______________________^ [INFO] [stderr] 304 | | name, function.params.len())) [INFO] [stderr] | |__________________________________________________________________^ help: try this: `unwrap_or_else(|| panic!("symbol for function {} (param count {}) was expected to exist, but does not", name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/compile/state.rs:361:14 [INFO] [stderr] | [INFO] [stderr] 361 | .ok_or(format!("undefined type: {}", function.return_ty))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("undefined type: {}", function.return_ty))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compile/state.rs:390:44 [INFO] [stderr] | [INFO] [stderr] 390 | Symbol::Variable(s) => self.lookup_or_insert_local_variable(s).clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.lookup_or_insert_local_variable(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compile/state.rs:439:27 [INFO] [stderr] | [INFO] [stderr] 439 | let sym = self.lookup_or_insert_local_variable(value.as_inner().name()) [INFO] [stderr] | ___________________________^ [INFO] [stderr] 440 | | .clone(); [INFO] [stderr] | |____________________________^ help: try removing the `clone` call: `self.lookup_or_insert_local_variable(value.as_inner().name())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/compile/state.rs:455:30 [INFO] [stderr] | [INFO] [stderr] 455 | .ok_or(format!("unknown function `{}`", s))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("unknown function `{}`", s))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compile/state.rs:467:38 [INFO] [stderr] | [INFO] [stderr] 467 | let symbol = self.lookup_or_insert_local_variable(s).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.lookup_or_insert_local_variable(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compile/state.rs:488:91 [INFO] [stderr] | [INFO] [stderr] 488 | expr_body.append(&mut self.compile_value(lhs, ValueContext::StoreInto(lhs_sym.clone()))?); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `lhs_sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compile/state.rs:497:91 [INFO] [stderr] | [INFO] [stderr] 497 | expr_body.append(&mut self.compile_value(rhs, ValueContext::StoreInto(rhs_sym.clone()))?); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rhs_sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compile/state.rs:573:88 [INFO] [stderr] | [INFO] [stderr] 573 | let mut body = self.compile_value(lhs, ValueContext::StoreInto(lhs_sym.clone()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `lhs_sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compile/state.rs:574:90 [INFO] [stderr] | [INFO] [stderr] 574 | body.append(&mut self.compile_value(rhs, ValueContext::StoreInto(rhs_sym.clone()))?); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `rhs_sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compile/state.rs:582:96 [INFO] [stderr] | [INFO] [stderr] 582 | let mut value_body = self.compile_value(value, ValueContext::StoreInto(result_sym.clone()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `result_sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compile/state.rs:592:88 [INFO] [stderr] | [INFO] [stderr] 592 | let mut value_body = self.compile_value(value, ValueContext::StoreInto(result_sym.clone()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `result_sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | write!(stdout, " > "); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:57:12 [INFO] [stderr] | [INFO] [stderr] 57 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.87s [INFO] running `"docker" "inspect" "e1972c43118fe570006ba4022022f44524ddb46c0381962dc85d54c24d172d47"` [INFO] running `"docker" "rm" "-f" "e1972c43118fe570006ba4022022f44524ddb46c0381962dc85d54c24d172d47"` [INFO] [stdout] e1972c43118fe570006ba4022022f44524ddb46c0381962dc85d54c24d172d47