[INFO] updating cached repository alanwilhelm/hydra-agent [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/alanwilhelm/hydra-agent [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/alanwilhelm/hydra-agent" "work/ex/clippy-test-run/sources/stable/gh/alanwilhelm/hydra-agent"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/alanwilhelm/hydra-agent'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/alanwilhelm/hydra-agent" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alanwilhelm/hydra-agent"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alanwilhelm/hydra-agent'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0e8ed3336347237df9f55f2d872d578137d11e99 [INFO] sha for GitHub repo alanwilhelm/hydra-agent: 0e8ed3336347237df9f55f2d872d578137d11e99 [INFO] validating manifest of alanwilhelm/hydra-agent on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of alanwilhelm/hydra-agent on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing alanwilhelm/hydra-agent [INFO] finished frobbing alanwilhelm/hydra-agent [INFO] frobbed toml for alanwilhelm/hydra-agent written to work/ex/clippy-test-run/sources/stable/gh/alanwilhelm/hydra-agent/Cargo.toml [INFO] started frobbing alanwilhelm/hydra-agent [INFO] finished frobbing alanwilhelm/hydra-agent [INFO] frobbed toml for alanwilhelm/hydra-agent written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alanwilhelm/hydra-agent/Cargo.toml [INFO] crate alanwilhelm/hydra-agent has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting alanwilhelm/hydra-agent against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/alanwilhelm/hydra-agent:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a97f0cbce1be4475c91d153585d0a7dfc02a42e84d3fbd775572edbb76b6d25a [INFO] running `"docker" "start" "-a" "a97f0cbce1be4475c91d153585d0a7dfc02a42e84d3fbd775572edbb76b6d25a"` [INFO] [stderr] Compiling miniz-sys v0.1.9 [INFO] [stderr] Compiling sys-info v0.5.1 [INFO] [stderr] Checking unix_socket v0.5.0 [INFO] [stderr] Checking jed v0.1.2 [INFO] [stderr] Checking uuid v0.2.3 [INFO] [stderr] Checking tar v0.3.4 [INFO] [stderr] Checking hyper v0.10.13 [INFO] [stderr] Compiling serde_derive v1.0.12 [INFO] [stderr] Checking url v0.5.10 [INFO] [stderr] Checking flate2 v0.2.19 [INFO] [stderr] Checking hyper-openssl v0.2.7 [INFO] [stderr] Checking hyperlocal v0.3.0 [INFO] [stderr] Checking shiplift v0.3.2 [INFO] [stderr] Checking hydra_agent v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/profiler/mod.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | cpu_speed: cpu_speed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cpu_speed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/profiler/mod.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | hostname: hostname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `hostname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/profiler/mod.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | os_type: os_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `os_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/profiler/mod.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | os_release: os_release, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `os_release` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:21:42 [INFO] [stderr] | [INFO] [stderr] 21 | Err(e) => println!("{}", "{\"error\" : \"error\"}"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:23:34 [INFO] [stderr] | [INFO] [stderr] 23 | Err(e) => println!("{}", "{\"error\" : \"error\"}"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/profiler/mod.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | cpu_speed: cpu_speed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cpu_speed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/profiler/mod.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | hostname: hostname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `hostname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/profiler/mod.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | os_type: os_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `os_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/profiler/mod.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | os_release: os_release, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `os_release` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:21:42 [INFO] [stderr] | [INFO] [stderr] 21 | Err(e) => println!("{}", "{\"error\" : \"error\"}"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:23:34 [INFO] [stderr] | [INFO] [stderr] 23 | Err(e) => println!("{}", "{\"error\" : \"error\"}"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `ErrorKind` [INFO] [stderr] --> src/profiler/mod.rs:3:22 [INFO] [stderr] | [INFO] [stderr] 3 | use std::io::{Error, ErrorKind}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `ErrorKind` [INFO] [stderr] --> src/git/mod.rs:3:22 [INFO] [stderr] | [INFO] [stderr] 3 | use std::io::{Error, ErrorKind}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `ErrorKind` [INFO] [stderr] --> src/profiler/mod.rs:3:22 [INFO] [stderr] | [INFO] [stderr] 3 | use std::io::{Error, ErrorKind}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `ErrorKind` [INFO] [stderr] --> src/git/mod.rs:3:22 [INFO] [stderr] | [INFO] [stderr] 3 | use std::io::{Error, ErrorKind}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/serializer/mod.rs:8:13 [INFO] [stderr] | [INFO] [stderr] 8 | let mut s: String = String::new(); [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `z` [INFO] [stderr] --> src/profiler/mod.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | let z: u32 = u32::min_value(); [INFO] [stderr] | ^ help: consider using `_z` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/profiler/mod.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | Err(e) => undef.clone(), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/profiler/mod.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | Err(e) => json_z.clone(), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/profiler/mod.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | Err(e) => undef.clone(), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/profiler/mod.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | Err(e) => undef.clone(), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/profiler/mod.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | Err(e) => undef.clone(), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `repo` [INFO] [stderr] --> src/git/mod.rs:11:7 [INFO] [stderr] | [INFO] [stderr] 11 | let repo = match Repository::clone(url, ".hydra") { [INFO] [stderr] | ^^^^ help: consider using `_repo` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `remote_repo` [INFO] [stderr] --> src/git/mod.rs:7:26 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn clone_remote_repo(remote_repo: &str) -> Result<(String), Error>{ [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_remote_repo` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/main.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | Err(e) => println!("{}", "{\"error\" : \"error\"}"), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/main.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | Err(e) => println!("{}", "{\"error\" : \"error\"}"), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/serializer/mod.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | let mut s: String = String::new(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `status` [INFO] [stderr] --> src/docker/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn status() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `clone_remote_repo` [INFO] [stderr] --> src/git/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn clone_remote_repo(remote_repo: &str) -> Result<(String), Error>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/serializer/mod.rs:8:13 [INFO] [stderr] | [INFO] [stderr] 8 | let mut s: String = String::new(); [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `z` [INFO] [stderr] --> src/profiler/mod.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | let z: u32 = u32::min_value(); [INFO] [stderr] | ^ help: consider using `_z` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/profiler/mod.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | Err(e) => undef.clone(), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/profiler/mod.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | Err(e) => json_z.clone(), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/profiler/mod.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | Err(e) => undef.clone(), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/profiler/mod.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | Err(e) => undef.clone(), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/profiler/mod.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | Err(e) => undef.clone(), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `repo` [INFO] [stderr] --> src/git/mod.rs:11:7 [INFO] [stderr] | [INFO] [stderr] 11 | let repo = match Repository::clone(url, ".hydra") { [INFO] [stderr] | ^^^^ help: consider using `_repo` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `remote_repo` [INFO] [stderr] --> src/git/mod.rs:7:26 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn clone_remote_repo(remote_repo: &str) -> Result<(String), Error>{ [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_remote_repo` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/main.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | Err(e) => println!("{}", "{\"error\" : \"error\"}"), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/main.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | Err(e) => println!("{}", "{\"error\" : \"error\"}"), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/serializer/mod.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | let mut s: String = String::new(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `status` [INFO] [stderr] --> src/docker/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn status() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `clone_remote_repo` [INFO] [stderr] --> src/git/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn clone_remote_repo(remote_repo: &str) -> Result<(String), Error>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.93s [INFO] running `"docker" "inspect" "a97f0cbce1be4475c91d153585d0a7dfc02a42e84d3fbd775572edbb76b6d25a"` [INFO] running `"docker" "rm" "-f" "a97f0cbce1be4475c91d153585d0a7dfc02a42e84d3fbd775572edbb76b6d25a"` [INFO] [stdout] a97f0cbce1be4475c91d153585d0a7dfc02a42e84d3fbd775572edbb76b6d25a