[INFO] updating cached repository alan-andrade/snake2-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/alan-andrade/snake2-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/alan-andrade/snake2-rs" "work/ex/clippy-test-run/sources/stable/gh/alan-andrade/snake2-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/alan-andrade/snake2-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/alan-andrade/snake2-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alan-andrade/snake2-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alan-andrade/snake2-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5af6c7f15c188e19486ded2092e914d067d99427 [INFO] sha for GitHub repo alan-andrade/snake2-rs: 5af6c7f15c188e19486ded2092e914d067d99427 [INFO] validating manifest of alan-andrade/snake2-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of alan-andrade/snake2-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing alan-andrade/snake2-rs [INFO] finished frobbing alan-andrade/snake2-rs [INFO] frobbed toml for alan-andrade/snake2-rs written to work/ex/clippy-test-run/sources/stable/gh/alan-andrade/snake2-rs/Cargo.toml [INFO] started frobbing alan-andrade/snake2-rs [INFO] finished frobbing alan-andrade/snake2-rs [INFO] frobbed toml for alan-andrade/snake2-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/alan-andrade/snake2-rs/Cargo.toml [INFO] crate alan-andrade/snake2-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting alan-andrade/snake2-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/alan-andrade/snake2-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4632f27016fbcf297b17cca81a1a87a7adea9371b90df90b8ff98d8363ef20c0 [INFO] running `"docker" "start" "-a" "4632f27016fbcf297b17cca81a1a87a7adea9371b90df90b8ff98d8363ef20c0"` [INFO] [stderr] Checking snake2-rs v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | / match object { [INFO] [stderr] 33 | | &Object::W => { print!("#"); } [INFO] [stderr] 34 | | &Object::F => { print!(" ") } [INFO] [stderr] 35 | | &Object::H => { print!("O") } [INFO] [stderr] 36 | | &Object::B => { print!("o") } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *object { [INFO] [stderr] 33 | Object::W => { print!("#"); } [INFO] [stderr] 34 | Object::F => { print!(" ") } [INFO] [stderr] 35 | Object::H => { print!("O") } [INFO] [stderr] 36 | Object::B => { print!("o") } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | / match object { [INFO] [stderr] 33 | | &Object::W => { print!("#"); } [INFO] [stderr] 34 | | &Object::F => { print!(" ") } [INFO] [stderr] 35 | | &Object::H => { print!("O") } [INFO] [stderr] 36 | | &Object::B => { print!("o") } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *object { [INFO] [stderr] 33 | Object::W => { print!("#"); } [INFO] [stderr] 34 | Object::F => { print!(" ") } [INFO] [stderr] 35 | Object::H => { print!("O") } [INFO] [stderr] 36 | Object::B => { print!("o") } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.86s [INFO] running `"docker" "inspect" "4632f27016fbcf297b17cca81a1a87a7adea9371b90df90b8ff98d8363ef20c0"` [INFO] running `"docker" "rm" "-f" "4632f27016fbcf297b17cca81a1a87a7adea9371b90df90b8ff98d8363ef20c0"` [INFO] [stdout] 4632f27016fbcf297b17cca81a1a87a7adea9371b90df90b8ff98d8363ef20c0