[INFO] updating cached repository akuraj/learn_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/akuraj/learn_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/akuraj/learn_rust" "work/ex/clippy-test-run/sources/stable/gh/akuraj/learn_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/akuraj/learn_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/akuraj/learn_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/akuraj/learn_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/akuraj/learn_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8e11f859728e5a1c5cd657f5ddcb7c2ba8bc1f50 [INFO] sha for GitHub repo akuraj/learn_rust: 8e11f859728e5a1c5cd657f5ddcb7c2ba8bc1f50 [INFO] validating manifest of akuraj/learn_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of akuraj/learn_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing akuraj/learn_rust [INFO] finished frobbing akuraj/learn_rust [INFO] frobbed toml for akuraj/learn_rust written to work/ex/clippy-test-run/sources/stable/gh/akuraj/learn_rust/Cargo.toml [INFO] started frobbing akuraj/learn_rust [INFO] finished frobbing akuraj/learn_rust [INFO] frobbed toml for akuraj/learn_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/akuraj/learn_rust/Cargo.toml [INFO] crate akuraj/learn_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting akuraj/learn_rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/akuraj/learn_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6a261eb47faf8b10e7027c9fc4d25f4ebd3c494c48b92fc1d991d910ad3d99a5 [INFO] running `"docker" "start" "-a" "6a261eb47faf8b10e7027c9fc4d25f4ebd3c494c48b92fc1d991d910ad3d99a5"` [INFO] [stderr] Checking learn_rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:24:45 [INFO] [stderr] | [INFO] [stderr] 24 | let mut new_head = Box::new( Node { value: value, next: self.head.take() } ); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:66:45 [INFO] [stderr] | [INFO] [stderr] 66 | let mut new_tail = Box::new( Node { value: value, next: None } ); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:24:45 [INFO] [stderr] | [INFO] [stderr] 24 | let mut new_head = Box::new( Node { value: value, next: self.head.take() } ); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lists.rs:66:45 [INFO] [stderr] | [INFO] [stderr] 66 | let mut new_tail = Box::new( Node { value: value, next: None } ); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/test_lifetimes.rs:1:34 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn foo< 'c, 'b, 'a/*: 'b*/>( x: &'a u32, y: &'b u32, z: &'c u32 ) -> &'b u32 { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `z` [INFO] [stderr] --> src/test_lifetimes.rs:1:58 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn foo< 'c, 'b, 'a/*: 'b*/>( x: &'a u32, y: &'b u32, z: &'c u32 ) -> &'b u32 { [INFO] [stderr] | ^ help: consider using `_z` instead [INFO] [stderr] [INFO] [stderr] warning: variable `a` is assigned to, but never used [INFO] [stderr] --> src/test_lifetimes.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | let a: &u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_a` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `a` is never read [INFO] [stderr] --> src/test_lifetimes.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | a = { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `lists::List` [INFO] [stderr] --> src/lists.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | List { head: None, tail: ptr::null_mut() } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | impl Default for lists::List { [INFO] [stderr] 15 | fn default() -> Self { [INFO] [stderr] 16 | Self::new() [INFO] [stderr] 17 | } [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lists.rs:52:47 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn find( &self, value: &T ) -> Option<&Box>> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&Node` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/y_combinator.rs:43:38 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn y( f: Box R, T ) -> R> ) -> Box R> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/test_lifetimes.rs:1:34 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn foo< 'c, 'b, 'a/*: 'b*/>( x: &'a u32, y: &'b u32, z: &'c u32 ) -> &'b u32 { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `z` [INFO] [stderr] --> src/test_lifetimes.rs:1:58 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn foo< 'c, 'b, 'a/*: 'b*/>( x: &'a u32, y: &'b u32, z: &'c u32 ) -> &'b u32 { [INFO] [stderr] | ^ help: consider using `_z` instead [INFO] [stderr] [INFO] [stderr] warning: variable `a` is assigned to, but never used [INFO] [stderr] --> src/test_lifetimes.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | let a: &u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_a` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `a` is never read [INFO] [stderr] --> src/test_lifetimes.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | a = { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `lists::List` [INFO] [stderr] --> src/lists.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | List { head: None, tail: ptr::null_mut() } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | impl Default for lists::List { [INFO] [stderr] 15 | fn default() -> Self { [INFO] [stderr] 16 | Self::new() [INFO] [stderr] 17 | } [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lists.rs:52:47 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn find( &self, value: &T ) -> Option<&Box>> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&Node` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/y_combinator.rs:43:38 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn y( f: Box R, T ) -> R> ) -> Box R> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.17s [INFO] running `"docker" "inspect" "6a261eb47faf8b10e7027c9fc4d25f4ebd3c494c48b92fc1d991d910ad3d99a5"` [INFO] running `"docker" "rm" "-f" "6a261eb47faf8b10e7027c9fc4d25f4ebd3c494c48b92fc1d991d910ad3d99a5"` [INFO] [stdout] 6a261eb47faf8b10e7027c9fc4d25f4ebd3c494c48b92fc1d991d910ad3d99a5