[INFO] updating cached repository aktzk/sph_rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aktzk/sph_rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aktzk/sph_rs" "work/ex/clippy-test-run/sources/stable/gh/aktzk/sph_rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aktzk/sph_rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aktzk/sph_rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aktzk/sph_rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aktzk/sph_rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3c58b4814379c2083e8a94172e1ddc523c88476d [INFO] sha for GitHub repo aktzk/sph_rs: 3c58b4814379c2083e8a94172e1ddc523c88476d [INFO] validating manifest of aktzk/sph_rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aktzk/sph_rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aktzk/sph_rs [INFO] finished frobbing aktzk/sph_rs [INFO] frobbed toml for aktzk/sph_rs written to work/ex/clippy-test-run/sources/stable/gh/aktzk/sph_rs/Cargo.toml [INFO] started frobbing aktzk/sph_rs [INFO] finished frobbing aktzk/sph_rs [INFO] frobbed toml for aktzk/sph_rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aktzk/sph_rs/Cargo.toml [INFO] crate aktzk/sph_rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aktzk/sph_rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/aktzk/sph_rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 37e9d1329e4ea1a3abc85a07a1c4db8ff6a0b3b6aa7151d38e65c3148415fa9e [INFO] running `"docker" "start" "-a" "37e9d1329e4ea1a3abc85a07a1c4db8ff6a0b3b6aa7151d38e65c3148415fa9e"` [INFO] [stderr] Checking cgmath v0.14.1 [INFO] [stderr] Checking gfx_core v0.5.1 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Checking pistoncore-event_loop v0.27.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.33.0 [INFO] [stderr] Checking piston v0.27.0 [INFO] [stderr] Checking image v0.12.4 [INFO] [stderr] Checking gfx v0.13.0 [INFO] [stderr] Checking gfx_device_gl v0.12.0 [INFO] [stderr] Checking piston-gfx_texture v0.20.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.35.0 [INFO] [stderr] Checking piston_window v0.61.0 [INFO] [stderr] Checking sph_rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/particle.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/particle.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | mass: mass, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sph.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | particles: particles, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `particles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sph.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | grid: grid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sph_renderer.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/particle.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/particle.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | mass: mass, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sph.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | particles: particles, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `particles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sph.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | grid: grid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sph_renderer.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/particle.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | self.position = self.position + self.velocity * (damp - 1.0) * bounce; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.position += self.velocity * (damp - 1.0) * bounce` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/particle.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | self.velocity.x = -1.0 * self.velocity.x; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.velocity.x *= -1.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/particle.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | self.velocity = self.velocity * damp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.velocity *= damp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/particle.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | self.position =self.position + self.velocity * (damp - 1.0) * bounce; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.position += self.velocity * (damp - 1.0) * bounce` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/particle.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | self.velocity.y = -1.0 * self.velocity.y; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.velocity.y *= -1.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/particle.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | self.velocity = self.velocity * damp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.velocity *= damp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/sph.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | let ref neighbors = self.neighborhoods[i]; [INFO] [stderr] | ----^^^^^^^^^^^^^------------------------- help: try: `let neighbors = &self.neighborhoods[i];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `n` is only used to index `neighbors`. [INFO] [stderr] --> src/sph.rs:76:22 [INFO] [stderr] | [INFO] [stderr] 76 | for n in 0..neighbors.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 76 | for in &neighbors { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/sph.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | let ref neighbors = self.neighborhoods[i]; [INFO] [stderr] | ----^^^^^^^^^^^^^------------------------- help: try: `let neighbors = &self.neighborhoods[i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/grid.rs:30:41 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn update(&mut self, particles: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Particle]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `particles` [INFO] [stderr] --> src/grid.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | for i in 0..particles.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 32 | for (i, ) in particles.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/grid.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | let ref p = particles[i]; [INFO] [stderr] | ----^^^^^---------------- help: try: `let p = &particles[i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/grid.rs:35:62 [INFO] [stderr] | [INFO] [stderr] 35 | self.cells.entry((cell.x as i64, cell.y as i64)).or_insert(Vec::new()).push(i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/particle.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | self.position = self.position + self.velocity * (damp - 1.0) * bounce; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.position += self.velocity * (damp - 1.0) * bounce` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/particle.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | self.velocity.x = -1.0 * self.velocity.x; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.velocity.x *= -1.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/particle.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | self.velocity = self.velocity * damp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.velocity *= damp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/particle.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | self.position =self.position + self.velocity * (damp - 1.0) * bounce; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.position += self.velocity * (damp - 1.0) * bounce` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/particle.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | self.velocity.y = -1.0 * self.velocity.y; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.velocity.y *= -1.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/particle.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | self.velocity = self.velocity * damp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.velocity *= damp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/sph.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | let ref neighbors = self.neighborhoods[i]; [INFO] [stderr] | ----^^^^^^^^^^^^^------------------------- help: try: `let neighbors = &self.neighborhoods[i];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `n` is only used to index `neighbors`. [INFO] [stderr] --> src/sph.rs:76:22 [INFO] [stderr] | [INFO] [stderr] 76 | for n in 0..neighbors.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 76 | for in &neighbors { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/sph.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | let ref neighbors = self.neighborhoods[i]; [INFO] [stderr] | ----^^^^^^^^^^^^^------------------------- help: try: `let neighbors = &self.neighborhoods[i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/grid.rs:30:41 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn update(&mut self, particles: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Particle]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `particles` [INFO] [stderr] --> src/grid.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | for i in 0..particles.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 32 | for (i, ) in particles.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/grid.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | let ref p = particles[i]; [INFO] [stderr] | ----^^^^^---------------- help: try: `let p = &particles[i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/grid.rs:35:62 [INFO] [stderr] | [INFO] [stderr] 35 | self.cells.entry((cell.x as i64, cell.y as i64)).or_insert(Vec::new()).push(i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 43.86s [INFO] running `"docker" "inspect" "37e9d1329e4ea1a3abc85a07a1c4db8ff6a0b3b6aa7151d38e65c3148415fa9e"` [INFO] running `"docker" "rm" "-f" "37e9d1329e4ea1a3abc85a07a1c4db8ff6a0b3b6aa7151d38e65c3148415fa9e"` [INFO] [stdout] 37e9d1329e4ea1a3abc85a07a1c4db8ff6a0b3b6aa7151d38e65c3148415fa9e