[INFO] updating cached repository akritrime/cargo-wasm-tool [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/akritrime/cargo-wasm-tool [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/akritrime/cargo-wasm-tool" "work/ex/clippy-test-run/sources/stable/gh/akritrime/cargo-wasm-tool"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/akritrime/cargo-wasm-tool'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/akritrime/cargo-wasm-tool" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/akritrime/cargo-wasm-tool"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/akritrime/cargo-wasm-tool'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 45fb2292d5424871294185c22ea1da40ee3b63a5 [INFO] sha for GitHub repo akritrime/cargo-wasm-tool: 45fb2292d5424871294185c22ea1da40ee3b63a5 [INFO] validating manifest of akritrime/cargo-wasm-tool on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of akritrime/cargo-wasm-tool on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing akritrime/cargo-wasm-tool [INFO] finished frobbing akritrime/cargo-wasm-tool [INFO] frobbed toml for akritrime/cargo-wasm-tool written to work/ex/clippy-test-run/sources/stable/gh/akritrime/cargo-wasm-tool/Cargo.toml [INFO] started frobbing akritrime/cargo-wasm-tool [INFO] finished frobbing akritrime/cargo-wasm-tool [INFO] frobbed toml for akritrime/cargo-wasm-tool written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/akritrime/cargo-wasm-tool/Cargo.toml [INFO] crate akritrime/cargo-wasm-tool has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting akritrime/cargo-wasm-tool against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/akritrime/cargo-wasm-tool:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 07e77a6a66979ae56f559a524b403b029f2b88e0f49d7f2df0d839384cb3f47d [INFO] running `"docker" "start" "-a" "07e77a6a66979ae56f559a524b403b029f2b88e0f49d7f2df0d839384cb3f47d"` [INFO] [stderr] Checking semver v0.9.0 [INFO] [stderr] Compiling serde_derive_internals v0.23.0 [INFO] [stderr] Compiling serde_derive v1.0.37 [INFO] [stderr] Checking cargo_metadata v0.5.4 [INFO] [stderr] Checking cargo-wasm-tool v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/utils.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | let name = if !(pkg.targets[0].kind[0] == "bin") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pkg.targets[0].kind[0] != "bin"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils.rs:100:23 [INFO] [stderr] | [INFO] [stderr] 100 | ", bin_name.split(".").next().unwrap()); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/utils.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | asset.write(content).expect(&format!("Could not write to {}", asset_name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/utils.rs:140:30 [INFO] [stderr] | [INFO] [stderr] 140 | asset.write(content).expect(&format!("Could not write to {}", asset_name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not write to {}", asset_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cargo-wasm-tool`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/utils.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | let name = if !(pkg.targets[0].kind[0] == "bin") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pkg.targets[0].kind[0] != "bin"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils.rs:100:23 [INFO] [stderr] | [INFO] [stderr] 100 | ", bin_name.split(".").next().unwrap()); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/utils.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | asset.write(content).expect(&format!("Could not write to {}", asset_name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/utils.rs:140:30 [INFO] [stderr] | [INFO] [stderr] 140 | asset.write(content).expect(&format!("Could not write to {}", asset_name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not write to {}", asset_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cargo-wasm-tool`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "07e77a6a66979ae56f559a524b403b029f2b88e0f49d7f2df0d839384cb3f47d"` [INFO] running `"docker" "rm" "-f" "07e77a6a66979ae56f559a524b403b029f2b88e0f49d7f2df0d839384cb3f47d"` [INFO] [stdout] 07e77a6a66979ae56f559a524b403b029f2b88e0f49d7f2df0d839384cb3f47d