[INFO] updating cached repository akky2501/mincaml-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/akky2501/mincaml-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/akky2501/mincaml-rust" "work/ex/clippy-test-run/sources/stable/gh/akky2501/mincaml-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/akky2501/mincaml-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/akky2501/mincaml-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/akky2501/mincaml-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/akky2501/mincaml-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b8295cf3166d850c830ed45b1330d7f8230eb119 [INFO] sha for GitHub repo akky2501/mincaml-rust: b8295cf3166d850c830ed45b1330d7f8230eb119 [INFO] validating manifest of akky2501/mincaml-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of akky2501/mincaml-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing akky2501/mincaml-rust [INFO] finished frobbing akky2501/mincaml-rust [INFO] frobbed toml for akky2501/mincaml-rust written to work/ex/clippy-test-run/sources/stable/gh/akky2501/mincaml-rust/Cargo.toml [INFO] started frobbing akky2501/mincaml-rust [INFO] finished frobbing akky2501/mincaml-rust [INFO] frobbed toml for akky2501/mincaml-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/akky2501/mincaml-rust/Cargo.toml [INFO] crate akky2501/mincaml-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting akky2501/mincaml-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/akky2501/mincaml-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a22069d8ff03d03e5264f32cc2fa3161915f3a92fb5db11e2052e7fb08ad930f [INFO] running `"docker" "start" "-a" "a22069d8ff03d03e5264f32cc2fa3161915f3a92fb5db11e2052e7fb08ad930f"` [INFO] [stderr] Checking nom v2.2.0 [INFO] [stderr] Checking mincaml-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/typing.rs:100:21 [INFO] [stderr] | [INFO] [stderr] 100 | TypeScheme{ bind: bind, body: self.clone() } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/knormal.rs:163:28 [INFO] [stderr] | [INFO] [stderr] 163 | Ast::Eq(l, r) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/knormal.rs:176:28 [INFO] [stderr] | [INFO] [stderr] 176 | Ast::LE(l, r) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/knormal.rs:275:23 [INFO] [stderr] | [INFO] [stderr] 275 | IfEq(a, b, t, f) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/knormal.rs:280:23 [INFO] [stderr] | [INFO] [stderr] 280 | IfLE(a, b, t, f) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/closure.rs:59:40 [INFO] [stderr] | [INFO] [stderr] 59 | IfEq(ref i, ref j, ref t, ref f) | [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/closure.rs:59:47 [INFO] [stderr] | [INFO] [stderr] 59 | IfEq(ref i, ref j, ref t, ref f) | [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/closure.rs:125:15 [INFO] [stderr] | [INFO] [stderr] 125 | Program { decls: decls, code: code } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `decls` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/closure.rs:125:29 [INFO] [stderr] | [INFO] [stderr] 125 | Program { decls: decls, code: code } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/closure.rs:180:88 [INFO] [stderr] | [INFO] [stderr] 180 | let f = Function{ entry: (Label(name.0.clone()), ty), free_variables: fvt, args: args, body: Box::new(body) }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/codegen.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / r" [INFO] [stderr] 10 | | #include [INFO] [stderr] 11 | | #include [INFO] [stderr] 12 | | #include [INFO] [stderr] ... | [INFO] [stderr] 101 | | [INFO] [stderr] 102 | | " [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/codegen.rs:114:1 [INFO] [stderr] | [INFO] [stderr] 114 | / r" [INFO] [stderr] 115 | | void print_result(void){ [INFO] [stderr] 116 | | struct value r = pop(); [INFO] [stderr] 117 | | " [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/codegen.rs:124:1 [INFO] [stderr] | [INFO] [stderr] 124 | / r" [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | [INFO] [stderr] 127 | | int main(void){ [INFO] [stderr] ... | [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | " [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/typing.rs:100:21 [INFO] [stderr] | [INFO] [stderr] 100 | TypeScheme{ bind: bind, body: self.clone() } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/knormal.rs:163:28 [INFO] [stderr] | [INFO] [stderr] 163 | Ast::Eq(l, r) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/knormal.rs:176:28 [INFO] [stderr] | [INFO] [stderr] 176 | Ast::LE(l, r) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/knormal.rs:275:23 [INFO] [stderr] | [INFO] [stderr] 275 | IfEq(a, b, t, f) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/knormal.rs:280:23 [INFO] [stderr] | [INFO] [stderr] 280 | IfLE(a, b, t, f) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/closure.rs:59:40 [INFO] [stderr] | [INFO] [stderr] 59 | IfEq(ref i, ref j, ref t, ref f) | [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/closure.rs:59:47 [INFO] [stderr] | [INFO] [stderr] 59 | IfEq(ref i, ref j, ref t, ref f) | [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/closure.rs:125:15 [INFO] [stderr] | [INFO] [stderr] 125 | Program { decls: decls, code: code } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `decls` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/closure.rs:125:29 [INFO] [stderr] | [INFO] [stderr] 125 | Program { decls: decls, code: code } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/closure.rs:180:88 [INFO] [stderr] | [INFO] [stderr] 180 | let f = Function{ entry: (Label(name.0.clone()), ty), free_variables: fvt, args: args, body: Box::new(body) }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/codegen.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / r" [INFO] [stderr] 10 | | #include [INFO] [stderr] 11 | | #include [INFO] [stderr] 12 | | #include [INFO] [stderr] ... | [INFO] [stderr] 101 | | [INFO] [stderr] 102 | | " [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/codegen.rs:114:1 [INFO] [stderr] | [INFO] [stderr] 114 | / r" [INFO] [stderr] 115 | | void print_result(void){ [INFO] [stderr] 116 | | struct value r = pop(); [INFO] [stderr] 117 | | " [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/codegen.rs:124:1 [INFO] [stderr] | [INFO] [stderr] 124 | / r" [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | [INFO] [stderr] 127 | | int main(void){ [INFO] [stderr] ... | [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | " [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/closure.rs:72:46 [INFO] [stderr] | [INFO] [stderr] 72 | MakeClosure(ref i, Closure { entry: _, free_variables: ref v }, ref e1) => { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Closure { free_variables: ref v, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/closure.rs:72:46 [INFO] [stderr] | [INFO] [stderr] 72 | MakeClosure(ref i, Closure { entry: _, free_variables: ref v }, ref e1) => { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Closure { free_variables: ref v, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ty` [INFO] [stderr] --> src/codegen.rs:254:13 [INFO] [stderr] | [INFO] [stderr] 254 | fn gen_type(ty: &Type) { [INFO] [stderr] | ^^ help: consider using `_ty` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ty` [INFO] [stderr] --> src/codegen.rs:257:20 [INFO] [stderr] | [INFO] [stderr] 257 | fn gen_print_value(ty: &Type) { [INFO] [stderr] | ^^ help: consider using `_ty` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ty` [INFO] [stderr] --> src/codegen.rs:254:13 [INFO] [stderr] | [INFO] [stderr] 254 | fn gen_type(ty: &Type) { [INFO] [stderr] | ^^ help: consider using `_ty` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ty` [INFO] [stderr] --> src/codegen.rs:257:20 [INFO] [stderr] | [INFO] [stderr] 257 | fn gen_print_value(ty: &Type) { [INFO] [stderr] | ^^ help: consider using `_ty` instead [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `id::VarGenerater` [INFO] [stderr] --> src/id.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Self { [INFO] [stderr] 18 | | VarGenerater{ next_var: 0 } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/typing.rs:24:25 [INFO] [stderr] | [INFO] [stderr] 24 | for ref x in l.iter() { [INFO] [stderr] | ^^^^^ -------- help: try: `let x = &l.iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/typing.rs:30:25 [INFO] [stderr] | [INFO] [stderr] 30 | for ref x in t.iter() { [INFO] [stderr] | ^^^^^ -------- help: try: `let x = &t.iter();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/typing.rs:49:25 [INFO] [stderr] | [INFO] [stderr] 49 | for ref mut i in l.iter_mut() { [INFO] [stderr] | ^^^^^^^^^ ------------ help: try: `let i = &mut l.iter_mut();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/typing.rs:71:25 [INFO] [stderr] | [INFO] [stderr] 71 | for ref mut i in l.iter_mut() { [INFO] [stderr] | ^^^^^^^^^ ------------ help: try: `let i = &mut l.iter_mut();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `typing::TypeEnv` [INFO] [stderr] --> src/typing.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | / pub fn new() -> Self { [INFO] [stderr] 144 | | TypeEnv{ seq: Vec::new() } [INFO] [stderr] 145 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 138 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `typing::TypeSubst` [INFO] [stderr] --> src/typing.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | / pub fn new() -> Self { [INFO] [stderr] 190 | | TypeSubst{ equations: vec![] } [INFO] [stderr] 191 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 184 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the `t @ _` pattern can be written as just `t` [INFO] [stderr] --> src/typing.rs:215:28 [INFO] [stderr] | [INFO] [stderr] 215 | (Type::Var(x), t@_) | [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `t @ _` pattern can be written as just `t` [INFO] [stderr] --> src/typing.rs:216:14 [INFO] [stderr] | [INFO] [stderr] 216 | (t@_, Type::Var(x)) => { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `e @ _` pattern can be written as just `e` [INFO] [stderr] --> src/parser.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | e@_ => { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/knormal.rs:86:46 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn knormal_transform(ast: Ast, env: &mut HashMap, vg: &mut VarGenerater) -> (Syntax, Type) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 86 | pub fn knormal_transform(ast: Ast, env: &mut HashMap, vg: &mut VarGenerater) -> (Syntax, Type) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/knormal.rs:86:1 [INFO] [stderr] | [INFO] [stderr] 86 | / pub fn knormal_transform(ast: Ast, env: &mut HashMap, vg: &mut VarGenerater) -> (Syntax, Type) { [INFO] [stderr] 87 | | use self::Syntax::*; [INFO] [stderr] 88 | | [INFO] [stderr] 89 | | macro_rules! knormal_transform { [INFO] [stderr] ... | [INFO] [stderr] 258 | | } [INFO] [stderr] 259 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `id::VarGenerater` [INFO] [stderr] --> src/id.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Self { [INFO] [stderr] 18 | | VarGenerater{ next_var: 0 } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/typing.rs:24:25 [INFO] [stderr] | [INFO] [stderr] 24 | for ref x in l.iter() { [INFO] [stderr] | ^^^^^ -------- help: try: `let x = &l.iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/typing.rs:30:25 [INFO] [stderr] | [INFO] [stderr] 30 | for ref x in t.iter() { [INFO] [stderr] | ^^^^^ -------- help: try: `let x = &t.iter();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/typing.rs:49:25 [INFO] [stderr] | [INFO] [stderr] 49 | for ref mut i in l.iter_mut() { [INFO] [stderr] | ^^^^^^^^^ ------------ help: try: `let i = &mut l.iter_mut();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/typing.rs:71:25 [INFO] [stderr] | [INFO] [stderr] 71 | for ref mut i in l.iter_mut() { [INFO] [stderr] | ^^^^^^^^^ ------------ help: try: `let i = &mut l.iter_mut();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `typing::TypeEnv` [INFO] [stderr] --> src/typing.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | / pub fn new() -> Self { [INFO] [stderr] 144 | | TypeEnv{ seq: Vec::new() } [INFO] [stderr] 145 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 138 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the `v @ _` pattern can be written as just `v` [INFO] [stderr] --> src/knormal.rs:294:17 [INFO] [stderr] | [INFO] [stderr] 294 | v@_ => { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `typing::TypeSubst` [INFO] [stderr] --> src/typing.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | / pub fn new() -> Self { [INFO] [stderr] 190 | | TypeSubst{ equations: vec![] } [INFO] [stderr] 191 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 184 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the `t @ _` pattern can be written as just `t` [INFO] [stderr] --> src/typing.rs:215:28 [INFO] [stderr] | [INFO] [stderr] 215 | (Type::Var(x), t@_) | [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `t @ _` pattern can be written as just `t` [INFO] [stderr] --> src/typing.rs:216:14 [INFO] [stderr] | [INFO] [stderr] 216 | (t@_, Type::Var(x)) => { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/codegen.rs:144:19 [INFO] [stderr] | [INFO] [stderr] 144 | let mut fvs = f.free_variables.keys().into_iter().collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `f.free_variables.keys()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: the `e @ _` pattern can be written as just `e` [INFO] [stderr] --> src/parser.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | e@_ => { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/knormal.rs:86:46 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn knormal_transform(ast: Ast, env: &mut HashMap, vg: &mut VarGenerater) -> (Syntax, Type) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 86 | pub fn knormal_transform(ast: Ast, env: &mut HashMap, vg: &mut VarGenerater) -> (Syntax, Type) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/knormal.rs:86:1 [INFO] [stderr] | [INFO] [stderr] 86 | / pub fn knormal_transform(ast: Ast, env: &mut HashMap, vg: &mut VarGenerater) -> (Syntax, Type) { [INFO] [stderr] 87 | | use self::Syntax::*; [INFO] [stderr] 88 | | [INFO] [stderr] 89 | | macro_rules! knormal_transform { [INFO] [stderr] ... | [INFO] [stderr] 258 | | } [INFO] [stderr] 259 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the `v @ _` pattern can be written as just `v` [INFO] [stderr] --> src/knormal.rs:294:17 [INFO] [stderr] | [INFO] [stderr] 294 | v@_ => { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/codegen.rs:144:19 [INFO] [stderr] | [INFO] [stderr] 144 | let mut fvs = f.free_variables.keys().into_iter().collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `f.free_variables.keys()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.81s [INFO] running `"docker" "inspect" "a22069d8ff03d03e5264f32cc2fa3161915f3a92fb5db11e2052e7fb08ad930f"` [INFO] running `"docker" "rm" "-f" "a22069d8ff03d03e5264f32cc2fa3161915f3a92fb5db11e2052e7fb08ad930f"` [INFO] [stdout] a22069d8ff03d03e5264f32cc2fa3161915f3a92fb5db11e2052e7fb08ad930f