[INFO] updating cached repository ak1r4/aoc2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ak1r4/aoc2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ak1r4/aoc2018" "work/ex/clippy-test-run/sources/stable/gh/ak1r4/aoc2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ak1r4/aoc2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ak1r4/aoc2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ak1r4/aoc2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ak1r4/aoc2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fe76c963812cb277cc4afcc0993f1a9decc66c1c [INFO] sha for GitHub repo ak1r4/aoc2018: fe76c963812cb277cc4afcc0993f1a9decc66c1c [INFO] validating manifest of ak1r4/aoc2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ak1r4/aoc2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ak1r4/aoc2018 [INFO] finished frobbing ak1r4/aoc2018 [INFO] frobbed toml for ak1r4/aoc2018 written to work/ex/clippy-test-run/sources/stable/gh/ak1r4/aoc2018/Cargo.toml [INFO] started frobbing ak1r4/aoc2018 [INFO] finished frobbing ak1r4/aoc2018 [INFO] frobbed toml for ak1r4/aoc2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ak1r4/aoc2018/Cargo.toml [INFO] crate ak1r4/aoc2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ak1r4/aoc2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ak1r4/aoc2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c3e693b1aaa0b466fdae5e2cccacb4d458482e315e3d7bb7b9b98f7569f48c22 [INFO] running `"docker" "start" "-a" "c3e693b1aaa0b466fdae5e2cccacb4d458482e315e3d7bb7b9b98f7569f48c22"` [INFO] [stderr] Checking aoc_2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day_4.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | guard_id: guard_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `guard_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day_4.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | action: action [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `action` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day_4.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | guard_id: guard_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `guard_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day_4.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | action: action [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `action` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/day_2.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | / match is_differ_by_1(id_a, id_b) { [INFO] [stderr] 66 | | Some(common) => return common, [INFO] [stderr] 67 | | None => (), [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(common) = is_differ_by_1(id_a, id_b) { return common }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/day_2.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | / match is_differ_by_1(id_a, id_b) { [INFO] [stderr] 66 | | Some(common) => return common, [INFO] [stderr] 67 | | None => (), [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(common) = is_differ_by_1(id_a, id_b) { return common }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.78s [INFO] running `"docker" "inspect" "c3e693b1aaa0b466fdae5e2cccacb4d458482e315e3d7bb7b9b98f7569f48c22"` [INFO] running `"docker" "rm" "-f" "c3e693b1aaa0b466fdae5e2cccacb4d458482e315e3d7bb7b9b98f7569f48c22"` [INFO] [stdout] c3e693b1aaa0b466fdae5e2cccacb4d458482e315e3d7bb7b9b98f7569f48c22