[INFO] updating cached repository ajoabraham/hulk [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ajoabraham/hulk [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ajoabraham/hulk" "work/ex/clippy-test-run/sources/stable/gh/ajoabraham/hulk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ajoabraham/hulk'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ajoabraham/hulk" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajoabraham/hulk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajoabraham/hulk'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7cd9e0ff9bb869fc46e6b5890654e42d257ad928 [INFO] sha for GitHub repo ajoabraham/hulk: 7cd9e0ff9bb869fc46e6b5890654e42d257ad928 [INFO] validating manifest of ajoabraham/hulk on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ajoabraham/hulk on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ajoabraham/hulk [INFO] finished frobbing ajoabraham/hulk [INFO] frobbed toml for ajoabraham/hulk written to work/ex/clippy-test-run/sources/stable/gh/ajoabraham/hulk/Cargo.toml [INFO] started frobbing ajoabraham/hulk [INFO] finished frobbing ajoabraham/hulk [INFO] frobbed toml for ajoabraham/hulk written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajoabraham/hulk/Cargo.toml [INFO] crate ajoabraham/hulk has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ajoabraham/hulk against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ajoabraham/hulk:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 765826ce8a176f08f7f21eb015f5e2821ffd9e7f829c3beb86ecb7e713d36b31 [INFO] running `"docker" "start" "-a" "765826ce8a176f08f7f21eb015f5e2821ffd9e7f829c3beb86ecb7e713d36b31"` [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking hulk v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olap/cube.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | Cube { name: name, columns: HashMap::new(), row_count: row_count } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olap/cube.rs:16:53 [INFO] [stderr] | [INFO] [stderr] 16 | Cube { name: name, columns: HashMap::new(), row_count: row_count } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `row_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olap/cube.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olap/cube.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | data_type: data_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olap/cube.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | column_type: column_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `column_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olap/cube.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | agg: agg, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `agg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olap/mod.rs:49:3 [INFO] [stderr] | [INFO] [stderr] 49 | cube: cube, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cube` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olap/cube.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | Cube { name: name, columns: HashMap::new(), row_count: row_count } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olap/cube.rs:16:53 [INFO] [stderr] | [INFO] [stderr] 16 | Cube { name: name, columns: HashMap::new(), row_count: row_count } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `row_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olap/cube.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olap/cube.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | data_type: data_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olap/cube.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | column_type: column_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `column_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olap/cube.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | agg: agg, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `agg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olap/mod.rs:49:3 [INFO] [stderr] | [INFO] [stderr] 49 | cube: cube, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cube` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/olap/mod.rs:27:16 [INFO] [stderr] | [INFO] [stderr] 27 | if c.store.len() ==0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `c.store.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/olap/mod.rs:34:10 [INFO] [stderr] | [INFO] [stderr] 34 | if self.select.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.select.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:21:3 [INFO] [stderr] | [INFO] [stderr] 21 | let b: i32; [INFO] [stderr] | _________^ [INFO] [stderr] 22 | | if rng.gen() { // random bool [INFO] [stderr] 23 | | b = rng.gen::(); [INFO] [stderr] 24 | | }else{ [INFO] [stderr] 25 | | b = i; [INFO] [stderr] 26 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let b = if rng.gen() { rng.gen::() } else { i };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:31:8 [INFO] [stderr] | [INFO] [stderr] 31 | s = String::from(format!("test{}",5)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("test{}",5)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:33:11 [INFO] [stderr] | [INFO] [stderr] 33 | s = String::from(format!("test{}",10)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("test{}",10)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/olap/mod.rs:27:16 [INFO] [stderr] | [INFO] [stderr] 27 | if c.store.len() ==0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `c.store.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/olap/mod.rs:34:10 [INFO] [stderr] | [INFO] [stderr] 34 | if self.select.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.select.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:21:3 [INFO] [stderr] | [INFO] [stderr] 21 | let b: i32; [INFO] [stderr] | _________^ [INFO] [stderr] 22 | | if rng.gen() { // random bool [INFO] [stderr] 23 | | b = rng.gen::(); [INFO] [stderr] 24 | | }else{ [INFO] [stderr] 25 | | b = i; [INFO] [stderr] 26 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let b = if rng.gen() { rng.gen::() } else { i };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:31:8 [INFO] [stderr] | [INFO] [stderr] 31 | s = String::from(format!("test{}",5)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("test{}",5)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:33:11 [INFO] [stderr] | [INFO] [stderr] 33 | s = String::from(format!("test{}",10)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("test{}",10)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.21s [INFO] running `"docker" "inspect" "765826ce8a176f08f7f21eb015f5e2821ffd9e7f829c3beb86ecb7e713d36b31"` [INFO] running `"docker" "rm" "-f" "765826ce8a176f08f7f21eb015f5e2821ffd9e7f829c3beb86ecb7e713d36b31"` [INFO] [stdout] 765826ce8a176f08f7f21eb015f5e2821ffd9e7f829c3beb86ecb7e713d36b31