[INFO] updating cached repository ajmorton/rust_crypto [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ajmorton/rust_crypto [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ajmorton/rust_crypto" "work/ex/clippy-test-run/sources/stable/gh/ajmorton/rust_crypto"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ajmorton/rust_crypto'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ajmorton/rust_crypto" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajmorton/rust_crypto"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajmorton/rust_crypto'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8332c6aa8633f36fd895a5edad684b1bb1fb0337 [INFO] sha for GitHub repo ajmorton/rust_crypto: 8332c6aa8633f36fd895a5edad684b1bb1fb0337 [INFO] validating manifest of ajmorton/rust_crypto on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ajmorton/rust_crypto on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ajmorton/rust_crypto [INFO] finished frobbing ajmorton/rust_crypto [INFO] frobbed toml for ajmorton/rust_crypto written to work/ex/clippy-test-run/sources/stable/gh/ajmorton/rust_crypto/Cargo.toml [INFO] started frobbing ajmorton/rust_crypto [INFO] finished frobbing ajmorton/rust_crypto [INFO] frobbed toml for ajmorton/rust_crypto written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajmorton/rust_crypto/Cargo.toml [INFO] crate ajmorton/rust_crypto has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ajmorton/rust_crypto against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ajmorton/rust_crypto:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 55f5604ec53b9924276b34199cd1ca6587b6b43e03c8901c0217f765250667be [INFO] running `"docker" "start" "-a" "55f5604ec53b9924276b34199cd1ca6587b6b43e03c8901c0217f765250667be"` [INFO] [stderr] Checking rust_crypto v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/monoalphabetic/helper/read/freqs.rs:77:23 [INFO] [stderr] | [INFO] [stderr] 77 | let c = &alphabet[i..i+1]; [INFO] [stderr] | ^^^^^^ help: use: `i..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/monoalphabetic/helper/write/mod.rs:17:32 [INFO] [stderr] | [INFO] [stderr] 17 | letter_map.insert(&encrypt[i..i+1], &decrypt[i..i+1]); [INFO] [stderr] | ^^^^^^ help: use: `i..=i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/monoalphabetic/helper/write/mod.rs:17:50 [INFO] [stderr] | [INFO] [stderr] 17 | letter_map.insert(&encrypt[i..i+1], &decrypt[i..i+1]); [INFO] [stderr] | ^^^^^^ help: use: `i..=i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/monoalphabetic/helper/write/mod.rs:21:50 [INFO] [stderr] | [INFO] [stderr] 21 | write!(f_out, "{}", letter_map.entry(&cipher[i..i+1]).or_insert(&cipher[i..i+1])).unwrap(); [INFO] [stderr] | ^^^^^^ help: use: `i..=i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/monoalphabetic/helper/write/mod.rs:21:77 [INFO] [stderr] | [INFO] [stderr] 21 | write!(f_out, "{}", letter_map.entry(&cipher[i..i+1]).or_insert(&cipher[i..i+1])).unwrap(); [INFO] [stderr] | ^^^^^^ help: use: `i..=i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/monoalphabetic/affine/mod.rs:13:54 [INFO] [stderr] | [INFO] [stderr] 13 | let plain : Vec = plaintext[0..2].chars().map(|c| num(c)).collect(); [INFO] [stderr] | ^^^^^^^^^^ help: remove closure as shown: `num` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/monoalphabetic/affine/mod.rs:14:54 [INFO] [stderr] | [INFO] [stderr] 14 | let ciph : Vec = cipher[0..2].chars().map(|c| num(c)).collect(); [INFO] [stderr] | ^^^^^^^^^^ help: remove closure as shown: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/monoalphabetic/polynomial/mod.rs:10:43 [INFO] [stderr] | [INFO] [stderr] 10 | let nums : Vec = alpha.chars().map(|c| num(c)).collect(); [INFO] [stderr] | ^^^^^^^^^^ help: remove closure as shown: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/monoalphabetic/polynomial/mod.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | fn all_unique(v: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/monoalphabetic/helper/read/freqs.rs:77:23 [INFO] [stderr] | [INFO] [stderr] 77 | let c = &alphabet[i..i+1]; [INFO] [stderr] | ^^^^^^ help: use: `i..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/monoalphabetic/helper/write/mod.rs:17:32 [INFO] [stderr] | [INFO] [stderr] 17 | letter_map.insert(&encrypt[i..i+1], &decrypt[i..i+1]); [INFO] [stderr] | ^^^^^^ help: use: `i..=i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/monoalphabetic/helper/write/mod.rs:17:50 [INFO] [stderr] | [INFO] [stderr] 17 | letter_map.insert(&encrypt[i..i+1], &decrypt[i..i+1]); [INFO] [stderr] | ^^^^^^ help: use: `i..=i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/monoalphabetic/helper/write/mod.rs:21:50 [INFO] [stderr] | [INFO] [stderr] 21 | write!(f_out, "{}", letter_map.entry(&cipher[i..i+1]).or_insert(&cipher[i..i+1])).unwrap(); [INFO] [stderr] | ^^^^^^ help: use: `i..=i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/monoalphabetic/helper/write/mod.rs:21:77 [INFO] [stderr] | [INFO] [stderr] 21 | write!(f_out, "{}", letter_map.entry(&cipher[i..i+1]).or_insert(&cipher[i..i+1])).unwrap(); [INFO] [stderr] | ^^^^^^ help: use: `i..=i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/monoalphabetic/affine/mod.rs:13:54 [INFO] [stderr] | [INFO] [stderr] 13 | let plain : Vec = plaintext[0..2].chars().map(|c| num(c)).collect(); [INFO] [stderr] | ^^^^^^^^^^ help: remove closure as shown: `num` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/monoalphabetic/affine/mod.rs:14:54 [INFO] [stderr] | [INFO] [stderr] 14 | let ciph : Vec = cipher[0..2].chars().map(|c| num(c)).collect(); [INFO] [stderr] | ^^^^^^^^^^ help: remove closure as shown: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/monoalphabetic/polynomial/mod.rs:10:43 [INFO] [stderr] | [INFO] [stderr] 10 | let nums : Vec = alpha.chars().map(|c| num(c)).collect(); [INFO] [stderr] | ^^^^^^^^^^ help: remove closure as shown: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/monoalphabetic/polynomial/mod.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | fn all_unique(v: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/math/mod.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | t.1 = t.1 % t.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `t.1 %= t.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/math/mod.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | t.1 = t.1 % t.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `t.1 %= t.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused import: `rust_crypto::math` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use rust_crypto::math; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `rust_crypto::math` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use rust_crypto::math; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.89s [INFO] running `"docker" "inspect" "55f5604ec53b9924276b34199cd1ca6587b6b43e03c8901c0217f765250667be"` [INFO] running `"docker" "rm" "-f" "55f5604ec53b9924276b34199cd1ca6587b6b43e03c8901c0217f765250667be"` [INFO] [stdout] 55f5604ec53b9924276b34199cd1ca6587b6b43e03c8901c0217f765250667be