[INFO] updating cached repository ajm012/eecs-495-hw4 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ajm012/eecs-495-hw4 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ajm012/eecs-495-hw4" "work/ex/clippy-test-run/sources/stable/gh/ajm012/eecs-495-hw4"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ajm012/eecs-495-hw4'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ajm012/eecs-495-hw4" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajm012/eecs-495-hw4"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajm012/eecs-495-hw4'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c7c5f8b6a62f2e0942a67714424ce7e133c483f3 [INFO] sha for GitHub repo ajm012/eecs-495-hw4: c7c5f8b6a62f2e0942a67714424ce7e133c483f3 [INFO] validating manifest of ajm012/eecs-495-hw4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ajm012/eecs-495-hw4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ajm012/eecs-495-hw4 [INFO] finished frobbing ajm012/eecs-495-hw4 [INFO] frobbed toml for ajm012/eecs-495-hw4 written to work/ex/clippy-test-run/sources/stable/gh/ajm012/eecs-495-hw4/Cargo.toml [INFO] started frobbing ajm012/eecs-495-hw4 [INFO] finished frobbing ajm012/eecs-495-hw4 [INFO] frobbed toml for ajm012/eecs-495-hw4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajm012/eecs-495-hw4/Cargo.toml [INFO] crate ajm012/eecs-495-hw4 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ajm012/eecs-495-hw4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ajm012/eecs-495-hw4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8606bd3f35a8142065e6fe7507f10751e8d3f78850d704cb4d8ecab7f614bdb0 [INFO] running `"docker" "start" "-a" "8606bd3f35a8142065e6fe7507f10751e8d3f78850d704cb4d8ecab7f614bdb0"` [INFO] [stderr] Checking thread-id v3.0.0 [INFO] [stderr] Checking thread_local v0.3.3 [INFO] [stderr] Checking regex v0.2.1 [INFO] [stderr] Checking eecs-495-hw4 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server_handler.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | return req_str.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `req_str.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server_handler.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | return "Error".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Error".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server_handler.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/server_handler.rs:114:21 [INFO] [stderr] | [INFO] [stderr] 114 | let text_type = match is_html { [INFO] [stderr] | _____________________^ [INFO] [stderr] 115 | | true => "html", [INFO] [stderr] 116 | | false => "plain" [INFO] [stderr] 117 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if is_html { "html" } else { "plain" }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | log_file_guard.write(output.as_bytes()).expect("Failed to log response"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `eecs-495-hw4`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server_handler.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | return req_str.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `req_str.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server_handler.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | return "Error".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Error".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server_handler.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file` [INFO] [stderr] --> src/server_handler.rs:232:17 [INFO] [stderr] | [INFO] [stderr] 232 | let file = File::create(filename); [INFO] [stderr] | ^^^^ help: consider using `_file` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file` [INFO] [stderr] --> src/server_handler.rs:235:14 [INFO] [stderr] | [INFO] [stderr] 235 | let (file, extension) = get_file(&PathBuf::from(filename)).unwrap(); [INFO] [stderr] | ^^^^ help: consider using `_file` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file` [INFO] [stderr] --> src/server_handler.rs:265:17 [INFO] [stderr] | [INFO] [stderr] 265 | let file = File::create(filename); [INFO] [stderr] | ^^^^ help: consider using `_file` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file` [INFO] [stderr] --> src/server_handler.rs:268:14 [INFO] [stderr] | [INFO] [stderr] 268 | let (file, extension) = get_directory_index_file(&PathBuf::from(directory)).unwrap(); [INFO] [stderr] | ^^^^ help: consider using `_file` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file` [INFO] [stderr] --> src/server_handler.rs:281:17 [INFO] [stderr] | [INFO] [stderr] 281 | let file = File::create(filename); [INFO] [stderr] | ^^^^ help: consider using `_file` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file` [INFO] [stderr] --> src/server_handler.rs:284:14 [INFO] [stderr] | [INFO] [stderr] 284 | let (file, extension) = get_directory_index_file(&PathBuf::from(directory)).unwrap(); [INFO] [stderr] | ^^^^ help: consider using `_file` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file` [INFO] [stderr] --> src/server_handler.rs:297:17 [INFO] [stderr] | [INFO] [stderr] 297 | let file = File::create(filename); [INFO] [stderr] | ^^^^ help: consider using `_file` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file` [INFO] [stderr] --> src/server_handler.rs:300:14 [INFO] [stderr] | [INFO] [stderr] 300 | let (file, extension) = get_directory_index_file(&PathBuf::from(directory)).unwrap(); [INFO] [stderr] | ^^^^ help: consider using `_file` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file` [INFO] [stderr] --> src/server_handler.rs:313:17 [INFO] [stderr] | [INFO] [stderr] 313 | let file = File::create(filename); [INFO] [stderr] | ^^^^ help: consider using `_file` instead [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/server_handler.rs:114:21 [INFO] [stderr] | [INFO] [stderr] 114 | let text_type = match is_html { [INFO] [stderr] | _____________________^ [INFO] [stderr] 115 | | true => "html", [INFO] [stderr] 116 | | false => "plain" [INFO] [stderr] 117 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if is_html { "html" } else { "plain" }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/server_handler.rs:238:9 [INFO] [stderr] | [INFO] [stderr] 238 | remove_dir_all("./test4/"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/server_handler.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | remove_dir_all("./test5/"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/server_handler.rs:271:9 [INFO] [stderr] | [INFO] [stderr] 271 | remove_dir_all("./test/"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/server_handler.rs:287:9 [INFO] [stderr] | [INFO] [stderr] 287 | remove_dir_all("./test1/"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/server_handler.rs:303:9 [INFO] [stderr] | [INFO] [stderr] 303 | remove_dir_all("./test2/"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/server_handler.rs:317:9 [INFO] [stderr] | [INFO] [stderr] 317 | remove_dir_all("./test3/"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/server_handler.rs:333:13 [INFO] [stderr] | [INFO] [stderr] 333 | file.write(contents.as_bytes()).expect("Failed to write to file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/server_handler.rs:338:9 [INFO] [stderr] | [INFO] [stderr] 338 | remove_file(filename); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | log_file_guard.write(output.as_bytes()).expect("Failed to log response"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `eecs-495-hw4`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8606bd3f35a8142065e6fe7507f10751e8d3f78850d704cb4d8ecab7f614bdb0"` [INFO] running `"docker" "rm" "-f" "8606bd3f35a8142065e6fe7507f10751e8d3f78850d704cb4d8ecab7f614bdb0"` [INFO] [stdout] 8606bd3f35a8142065e6fe7507f10751e8d3f78850d704cb4d8ecab7f614bdb0