[INFO] updating cached repository ajkavanagh/rust-mandelbrot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ajkavanagh/rust-mandelbrot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ajkavanagh/rust-mandelbrot" "work/ex/clippy-test-run/sources/stable/gh/ajkavanagh/rust-mandelbrot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ajkavanagh/rust-mandelbrot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ajkavanagh/rust-mandelbrot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajkavanagh/rust-mandelbrot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajkavanagh/rust-mandelbrot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ec7818b5393b92b637e823009fead47008fc0c1e [INFO] sha for GitHub repo ajkavanagh/rust-mandelbrot: ec7818b5393b92b637e823009fead47008fc0c1e [INFO] validating manifest of ajkavanagh/rust-mandelbrot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ajkavanagh/rust-mandelbrot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ajkavanagh/rust-mandelbrot [INFO] finished frobbing ajkavanagh/rust-mandelbrot [INFO] frobbed toml for ajkavanagh/rust-mandelbrot written to work/ex/clippy-test-run/sources/stable/gh/ajkavanagh/rust-mandelbrot/Cargo.toml [INFO] started frobbing ajkavanagh/rust-mandelbrot [INFO] finished frobbing ajkavanagh/rust-mandelbrot [INFO] frobbed toml for ajkavanagh/rust-mandelbrot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajkavanagh/rust-mandelbrot/Cargo.toml [INFO] crate ajkavanagh/rust-mandelbrot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ajkavanagh/rust-mandelbrot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ajkavanagh/rust-mandelbrot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fd2796aa801d1b585ae4c2a85ec178bf7c06661cdd10ba67ff0508b32afe7032 [INFO] running `"docker" "start" "-a" "fd2796aa801d1b585ae4c2a85ec178bf7c06661cdd10ba67ff0508b32afe7032"` [INFO] [stderr] Checking num-bigint v0.1.39 [INFO] [stderr] Checking docopt v0.8.1 [INFO] [stderr] Checking num-rational v0.1.38 [INFO] [stderr] Checking num v0.1.39 [INFO] [stderr] Checking image v0.14.0 [INFO] [stderr] Checking mandelbrot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | let mut z = a.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | let mut z = a.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | let mut z = a.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:60:19 [INFO] [stderr] | [INFO] [stderr] 60 | min + (step * (i as f64)) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | let ref mut fout = File::create(&Path::new("fractal.png")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^---------------------------------------------------- help: try: `let fout = &mut File::create(&Path::new("fractal.png")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:130:37 [INFO] [stderr] | [INFO] [stderr] 130 | let s = (std::f64::consts::PI / (c as f64) * 2.0 * (i as f64) + phase).sin(); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:130:56 [INFO] [stderr] | [INFO] [stderr] 130 | let s = (std::f64::consts::PI / (c as f64) * 2.0 * (i as f64) + phase).sin(); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | let mut z = a.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:60:19 [INFO] [stderr] | [INFO] [stderr] 60 | min + (step * (i as f64)) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | let ref mut fout = File::create(&Path::new("fractal.png")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^---------------------------------------------------- help: try: `let fout = &mut File::create(&Path::new("fractal.png")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:130:37 [INFO] [stderr] | [INFO] [stderr] 130 | let s = (std::f64::consts::PI / (c as f64) * 2.0 * (i as f64) + phase).sin(); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:130:56 [INFO] [stderr] | [INFO] [stderr] 130 | let s = (std::f64::consts::PI / (c as f64) * 2.0 * (i as f64) + phase).sin(); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.62s [INFO] running `"docker" "inspect" "fd2796aa801d1b585ae4c2a85ec178bf7c06661cdd10ba67ff0508b32afe7032"` [INFO] running `"docker" "rm" "-f" "fd2796aa801d1b585ae4c2a85ec178bf7c06661cdd10ba67ff0508b32afe7032"` [INFO] [stdout] fd2796aa801d1b585ae4c2a85ec178bf7c06661cdd10ba67ff0508b32afe7032