[INFO] updating cached repository ajkavanagh/rbacklight [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ajkavanagh/rbacklight [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ajkavanagh/rbacklight" "work/ex/clippy-test-run/sources/stable/gh/ajkavanagh/rbacklight"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ajkavanagh/rbacklight'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ajkavanagh/rbacklight" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajkavanagh/rbacklight"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajkavanagh/rbacklight'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1b6d7295937526a8b648b4b4b352793ab7ab24ea [INFO] sha for GitHub repo ajkavanagh/rbacklight: 1b6d7295937526a8b648b4b4b352793ab7ab24ea [INFO] validating manifest of ajkavanagh/rbacklight on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ajkavanagh/rbacklight on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ajkavanagh/rbacklight [INFO] finished frobbing ajkavanagh/rbacklight [INFO] frobbed toml for ajkavanagh/rbacklight written to work/ex/clippy-test-run/sources/stable/gh/ajkavanagh/rbacklight/Cargo.toml [INFO] started frobbing ajkavanagh/rbacklight [INFO] finished frobbing ajkavanagh/rbacklight [INFO] frobbed toml for ajkavanagh/rbacklight written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajkavanagh/rbacklight/Cargo.toml [INFO] crate ajkavanagh/rbacklight has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ajkavanagh/rbacklight against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ajkavanagh/rbacklight:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4abf4983598d3799c2bbe5dd9e10e293b9778803a218e112eb4a84b1658d144d [INFO] running `"docker" "start" "-a" "4abf4983598d3799c2bbe5dd9e10e293b9778803a218e112eb4a84b1658d144d"` [INFO] [stderr] Checking rbacklight v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:40:35 [INFO] [stderr] | [INFO] [stderr] 40 | return Ok(Config {command: command, value: DEFAULT_SET}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:42:35 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(Config {command: command, value: DEFAULT_DELTA}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:47:28 [INFO] [stderr] | [INFO] [stderr] 47 | Ok(Config {command: command, value: v}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:40:35 [INFO] [stderr] | [INFO] [stderr] 40 | return Ok(Config {command: command, value: DEFAULT_SET}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:42:35 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(Config {command: command, value: DEFAULT_DELTA}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:47:28 [INFO] [stderr] | [INFO] [stderr] 47 | Ok(Config {command: command, value: v}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:13:20 [INFO] [stderr] | [INFO] [stderr] 13 | const BRIGHTNESS: &'static str = "/sys/class/backlight/intel_backlight/brightness"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:14:24 [INFO] [stderr] | [INFO] [stderr] 14 | const MAX_BRIGHTNESS: &'static str = "/sys/class/backlight/intel_backlight/max_brightness"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | const VALID_COMMANDS: &[&'static str] = &["get", "set", "inc", "dec", "help"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:13:20 [INFO] [stderr] | [INFO] [stderr] 13 | const BRIGHTNESS: &'static str = "/sys/class/backlight/intel_backlight/brightness"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:14:24 [INFO] [stderr] | [INFO] [stderr] 14 | const MAX_BRIGHTNESS: &'static str = "/sys/class/backlight/intel_backlight/max_brightness"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | const VALID_COMMANDS: &[&'static str] = &["get", "set", "inc", "dec", "help"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.95s [INFO] running `"docker" "inspect" "4abf4983598d3799c2bbe5dd9e10e293b9778803a218e112eb4a84b1658d144d"` [INFO] running `"docker" "rm" "-f" "4abf4983598d3799c2bbe5dd9e10e293b9778803a218e112eb4a84b1658d144d"` [INFO] [stdout] 4abf4983598d3799c2bbe5dd9e10e293b9778803a218e112eb4a84b1658d144d