[INFO] updating cached repository ajbowen249/home_event_client [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ajbowen249/home_event_client [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ajbowen249/home_event_client" "work/ex/clippy-test-run/sources/stable/gh/ajbowen249/home_event_client"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ajbowen249/home_event_client'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ajbowen249/home_event_client" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajbowen249/home_event_client"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajbowen249/home_event_client'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5b726aa8bcb82a7e1dbee834c0b5315fee368121 [INFO] sha for GitHub repo ajbowen249/home_event_client: 5b726aa8bcb82a7e1dbee834c0b5315fee368121 [INFO] validating manifest of ajbowen249/home_event_client on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ajbowen249/home_event_client on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ajbowen249/home_event_client [INFO] finished frobbing ajbowen249/home_event_client [INFO] frobbed toml for ajbowen249/home_event_client written to work/ex/clippy-test-run/sources/stable/gh/ajbowen249/home_event_client/Cargo.toml [INFO] started frobbing ajbowen249/home_event_client [INFO] finished frobbing ajbowen249/home_event_client [INFO] frobbed toml for ajbowen249/home_event_client written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ajbowen249/home_event_client/Cargo.toml [INFO] crate ajbowen249/home_event_client has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ajbowen249/home_event_client against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ajbowen249/home_event_client:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b30a374f60b6692bc7f62771bfe44c8429e6a44839026fd3e1105a4b509bd62b [INFO] running `"docker" "start" "-a" "b30a374f60b6692bc7f62771bfe44c8429e6a44839026fd3e1105a4b509bd62b"` [INFO] [stderr] Checking hyper v0.9.12 [INFO] [stderr] Checking home_event_client v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/web_wrappers.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return (result.status, response_body); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(result.status, response_body)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/web_wrappers.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | return (result.status, response_body); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(result.status, response_body)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/event_server_api.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | return status == hyper::Ok; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `status == hyper::Ok` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/event_server_api.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | / return if result.result.len() > 0 { [INFO] [stderr] 34 | | Some(result.result) [INFO] [stderr] 35 | | } else { [INFO] [stderr] 36 | | None [INFO] [stderr] 37 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | if result.result.len() > 0 { [INFO] [stderr] 34 | Some(result.result) [INFO] [stderr] 35 | } else { [INFO] [stderr] 36 | None [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/event_server_api.rs:39:14 [INFO] [stderr] | [INFO] [stderr] 39 | _ => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/event_server_api.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | return Some(result.result.sequenceNumber); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(result.result.sequenceNumber)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/event_server_api.rs:58:14 [INFO] [stderr] | [INFO] [stderr] 58 | _ => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/web_wrappers.rs:5:30 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn post_request(address: &String, body: &String) -> (hyper::status::StatusCode, String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/web_wrappers.rs:5:45 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn post_request(address: &String, body: &String) -> (hyper::status::StatusCode, String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/web_wrappers.rs:18:29 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn put_request(address: &String, body: &String) -> (hyper::status::StatusCode, String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/web_wrappers.rs:18:44 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn put_request(address: &String, body: &String) -> (hyper::status::StatusCode, String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/event_server_api.rs:33:23 [INFO] [stderr] | [INFO] [stderr] 33 | return if result.result.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!result.result.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / match ping_result { [INFO] [stderr] 27 | | true => println!("success!"), [INFO] [stderr] 28 | | false => { [INFO] [stderr] 29 | | println!("failure :("); [INFO] [stderr] ... | [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 26 | if ping_result { println!("success!") } else { [INFO] [stderr] 27 | println!("failure :("); [INFO] [stderr] 28 | println!("Exiting"); [INFO] [stderr] 29 | return; [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/main.rs:47:25 [INFO] [stderr] | [INFO] [stderr] 47 | let quit = Arc::new(Mutex::new(false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | / match get_chunk_of_events(sequence_number) { [INFO] [stderr] 63 | | Some(vec) => { [INFO] [stderr] 64 | | for item in &vec { [INFO] [stderr] 65 | | process_event(item); [INFO] [stderr] ... | [INFO] [stderr] 70 | | _ => {} [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | if let Some(vec) = get_chunk_of_events(sequence_number) { [INFO] [stderr] 63 | for item in &vec { [INFO] [stderr] 64 | process_event(item); [INFO] [stderr] 65 | } [INFO] [stderr] 66 | [INFO] [stderr] 67 | sequence_number = vec[vec.len() - 1].sequenceNumber; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | io::stdout().flush().ok().expect("Could not flush stdout"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/web_wrappers.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return (result.status, response_body); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(result.status, response_body)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/web_wrappers.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | return (result.status, response_body); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(result.status, response_body)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/event_server_api.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | return status == hyper::Ok; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `status == hyper::Ok` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/event_server_api.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | / return if result.result.len() > 0 { [INFO] [stderr] 34 | | Some(result.result) [INFO] [stderr] 35 | | } else { [INFO] [stderr] 36 | | None [INFO] [stderr] 37 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | if result.result.len() > 0 { [INFO] [stderr] 34 | Some(result.result) [INFO] [stderr] 35 | } else { [INFO] [stderr] 36 | None [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/event_server_api.rs:39:14 [INFO] [stderr] | [INFO] [stderr] 39 | _ => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/event_server_api.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | return Some(result.result.sequenceNumber); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(result.result.sequenceNumber)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/event_server_api.rs:58:14 [INFO] [stderr] | [INFO] [stderr] 58 | _ => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/web_wrappers.rs:5:30 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn post_request(address: &String, body: &String) -> (hyper::status::StatusCode, String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/web_wrappers.rs:5:45 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn post_request(address: &String, body: &String) -> (hyper::status::StatusCode, String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/web_wrappers.rs:18:29 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn put_request(address: &String, body: &String) -> (hyper::status::StatusCode, String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/web_wrappers.rs:18:44 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn put_request(address: &String, body: &String) -> (hyper::status::StatusCode, String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/event_server_api.rs:33:23 [INFO] [stderr] | [INFO] [stderr] 33 | return if result.result.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!result.result.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / match ping_result { [INFO] [stderr] 27 | | true => println!("success!"), [INFO] [stderr] 28 | | false => { [INFO] [stderr] 29 | | println!("failure :("); [INFO] [stderr] ... | [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 26 | if ping_result { println!("success!") } else { [INFO] [stderr] 27 | println!("failure :("); [INFO] [stderr] 28 | println!("Exiting"); [INFO] [stderr] 29 | return; [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/main.rs:47:25 [INFO] [stderr] | [INFO] [stderr] 47 | let quit = Arc::new(Mutex::new(false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | / match get_chunk_of_events(sequence_number) { [INFO] [stderr] 63 | | Some(vec) => { [INFO] [stderr] 64 | | for item in &vec { [INFO] [stderr] 65 | | process_event(item); [INFO] [stderr] ... | [INFO] [stderr] 70 | | _ => {} [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | if let Some(vec) = get_chunk_of_events(sequence_number) { [INFO] [stderr] 63 | for item in &vec { [INFO] [stderr] 64 | process_event(item); [INFO] [stderr] 65 | } [INFO] [stderr] 66 | [INFO] [stderr] 67 | sequence_number = vec[vec.len() - 1].sequenceNumber; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | io::stdout().flush().ok().expect("Could not flush stdout"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.42s [INFO] running `"docker" "inspect" "b30a374f60b6692bc7f62771bfe44c8429e6a44839026fd3e1105a4b509bd62b"` [INFO] running `"docker" "rm" "-f" "b30a374f60b6692bc7f62771bfe44c8429e6a44839026fd3e1105a4b509bd62b"` [INFO] [stdout] b30a374f60b6692bc7f62771bfe44c8429e6a44839026fd3e1105a4b509bd62b