[INFO] updating cached repository ahwatts/graphplay3-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ahwatts/graphplay3-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ahwatts/graphplay3-rs" "work/ex/clippy-test-run/sources/stable/gh/ahwatts/graphplay3-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ahwatts/graphplay3-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ahwatts/graphplay3-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahwatts/graphplay3-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahwatts/graphplay3-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 80a46f66ddc26114f562b052ec07481b08366ddf [INFO] sha for GitHub repo ahwatts/graphplay3-rs: 80a46f66ddc26114f562b052ec07481b08366ddf [INFO] validating manifest of ahwatts/graphplay3-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ahwatts/graphplay3-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ahwatts/graphplay3-rs [INFO] finished frobbing ahwatts/graphplay3-rs [INFO] frobbed toml for ahwatts/graphplay3-rs written to work/ex/clippy-test-run/sources/stable/gh/ahwatts/graphplay3-rs/Cargo.toml [INFO] started frobbing ahwatts/graphplay3-rs [INFO] finished frobbing ahwatts/graphplay3-rs [INFO] frobbed toml for ahwatts/graphplay3-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahwatts/graphplay3-rs/Cargo.toml [INFO] crate ahwatts/graphplay3-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ahwatts/graphplay3-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ahwatts/graphplay3-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 34a44d2695022b7167cc9b36e6317941846b4130b6fb513c20a485ff641a9511 [INFO] running `"docker" "start" "-a" "34a44d2695022b7167cc9b36e6317941846b4130b6fb513c20a485ff641a9511"` [INFO] [stderr] Compiling log v0.4.1 [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Compiling glutin v0.14.0 [INFO] [stderr] Checking gfx_device_gl v0.15.2 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_window_glutin v0.22.0 [INFO] [stderr] Checking graphplay3 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: struct is never constructed: `Geometry` [INFO] [stderr] --> src/gpgfx/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub struct Geometry, R: Resources> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/gpgfx/mod.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new(factory: &mut F, vertices: &[V], elems: I) -> Geometry [INFO] [stderr] 14 | | where F: FactoryExt, I: IntoIndexBuffer [INFO] [stderr] 15 | | { [INFO] [stderr] 16 | | let (vbuf, elems) = factory.create_vertex_buffer_with_slice(vertices, elems); [INFO] [stderr] ... | [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | width as f32 / height as f32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:101:24 [INFO] [stderr] | [INFO] [stderr] 101 | width as f32 / height as f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/main.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | 3.14 / 6.0, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | / match event { [INFO] [stderr] 136 | | WindowEvent { event: window_event, .. } => { [INFO] [stderr] 137 | | use glutin::WindowEvent::*; [INFO] [stderr] 138 | | match window_event { [INFO] [stderr] ... | [INFO] [stderr] 159 | | _ => {}, [INFO] [stderr] 160 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 135 | if let WindowEvent { event: window_event, .. } = event { [INFO] [stderr] 136 | use glutin::WindowEvent::*; [INFO] [stderr] 137 | match window_event { [INFO] [stderr] 138 | KeyboardInput { input: glutin::KeyboardInput { virtual_keycode: Some(VirtualKeyCode::Escape), .. }, .. } => { [INFO] [stderr] 139 | running = false; [INFO] [stderr] 140 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:149:33 [INFO] [stderr] | [INFO] [stderr] 149 | width as f32 / height as f32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:149:48 [INFO] [stderr] | [INFO] [stderr] 149 | width as f32 / height as f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/main.rs:150:33 [INFO] [stderr] | [INFO] [stderr] 150 | 3.14 / 6.0, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: The function/method `clear` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:169:23 [INFO] [stderr] | [INFO] [stderr] 169 | encoder.clear(&mut data.out_color, [0.0, 0.0, 0.0, 1.0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `clear_depth` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:170:29 [INFO] [stderr] | [INFO] [stderr] 170 | encoder.clear_depth(&mut data.out_depth, 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `graphplay3`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: struct is never constructed: `Geometry` [INFO] [stderr] --> src/gpgfx/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub struct Geometry, R: Resources> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/gpgfx/mod.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new(factory: &mut F, vertices: &[V], elems: I) -> Geometry [INFO] [stderr] 14 | | where F: FactoryExt, I: IntoIndexBuffer [INFO] [stderr] 15 | | { [INFO] [stderr] 16 | | let (vbuf, elems) = factory.create_vertex_buffer_with_slice(vertices, elems); [INFO] [stderr] ... | [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | width as f32 / height as f32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:101:24 [INFO] [stderr] | [INFO] [stderr] 101 | width as f32 / height as f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/main.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | 3.14 / 6.0, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | / match event { [INFO] [stderr] 136 | | WindowEvent { event: window_event, .. } => { [INFO] [stderr] 137 | | use glutin::WindowEvent::*; [INFO] [stderr] 138 | | match window_event { [INFO] [stderr] ... | [INFO] [stderr] 159 | | _ => {}, [INFO] [stderr] 160 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 135 | if let WindowEvent { event: window_event, .. } = event { [INFO] [stderr] 136 | use glutin::WindowEvent::*; [INFO] [stderr] 137 | match window_event { [INFO] [stderr] 138 | KeyboardInput { input: glutin::KeyboardInput { virtual_keycode: Some(VirtualKeyCode::Escape), .. }, .. } => { [INFO] [stderr] 139 | running = false; [INFO] [stderr] 140 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:149:33 [INFO] [stderr] | [INFO] [stderr] 149 | width as f32 / height as f32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:149:48 [INFO] [stderr] | [INFO] [stderr] 149 | width as f32 / height as f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/main.rs:150:33 [INFO] [stderr] | [INFO] [stderr] 150 | 3.14 / 6.0, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: The function/method `clear` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:169:23 [INFO] [stderr] | [INFO] [stderr] 169 | encoder.clear(&mut data.out_color, [0.0, 0.0, 0.0, 1.0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `clear_depth` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:170:29 [INFO] [stderr] | [INFO] [stderr] 170 | encoder.clear_depth(&mut data.out_depth, 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `graphplay3`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "34a44d2695022b7167cc9b36e6317941846b4130b6fb513c20a485ff641a9511"` [INFO] running `"docker" "rm" "-f" "34a44d2695022b7167cc9b36e6317941846b4130b6fb513c20a485ff641a9511"` [INFO] [stdout] 34a44d2695022b7167cc9b36e6317941846b4130b6fb513c20a485ff641a9511