[INFO] updating cached repository ahwatts/graphplay2-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ahwatts/graphplay2-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ahwatts/graphplay2-rs" "work/ex/clippy-test-run/sources/stable/gh/ahwatts/graphplay2-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ahwatts/graphplay2-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ahwatts/graphplay2-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahwatts/graphplay2-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahwatts/graphplay2-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6d968b9013554384669df1b29f4fefe393ebc171 [INFO] sha for GitHub repo ahwatts/graphplay2-rs: 6d968b9013554384669df1b29f4fefe393ebc171 [INFO] validating manifest of ahwatts/graphplay2-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ahwatts/graphplay2-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ahwatts/graphplay2-rs [INFO] finished frobbing ahwatts/graphplay2-rs [INFO] frobbed toml for ahwatts/graphplay2-rs written to work/ex/clippy-test-run/sources/stable/gh/ahwatts/graphplay2-rs/Cargo.toml [INFO] started frobbing ahwatts/graphplay2-rs [INFO] finished frobbing ahwatts/graphplay2-rs [INFO] frobbed toml for ahwatts/graphplay2-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahwatts/graphplay2-rs/Cargo.toml [INFO] crate ahwatts/graphplay2-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ahwatts/graphplay2-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ahwatts/graphplay2-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e04073abecea8887ed8b4bad5c5b7300c430a77fbfeb3b4e06ffcd425743695f [INFO] running `"docker" "start" "-a" "e04073abecea8887ed8b4bad5c5b7300c430a77fbfeb3b4e06ffcd425743695f"` [INFO] [stderr] Checking graphplay2 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | up: up, [INFO] [stderr] | ^^^^^^ help: replace it with: `up` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | geometry: geometry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `geometry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | model: model, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | model_normal: model_normal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `model_normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/physics/body.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | states: states, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `states` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ply.rs:356:9 [INFO] [stderr] | [INFO] [stderr] 356 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ply.rs:374:13 [INFO] [stderr] | [INFO] [stderr] 374 | value_type: value_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ply.rs:387:13 [INFO] [stderr] | [INFO] [stderr] 387 | value_type: value_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scene.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | camera: camera, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `camera` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scene.rs:47:50 [INFO] [stderr] | [INFO] [stderr] 47 | viewport: Rect { left: 0, bottom: 0, width: width, height: height }, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scene.rs:47:64 [INFO] [stderr] | [INFO] [stderr] 47 | viewport: Rect { left: 0, bottom: 0, width: width, height: height }, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shaders/mod.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | enabled: enabled, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `enabled` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shaders/mod.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shaders/mod.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shaders/mod.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | specular_exp: specular_exp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `specular_exp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | up: up, [INFO] [stderr] | ^^^^^^ help: replace it with: `up` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | geometry: geometry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `geometry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | model: model, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mesh.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | model_normal: model_normal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `model_normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/physics/body.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | states: states, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `states` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ply.rs:356:9 [INFO] [stderr] | [INFO] [stderr] 356 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ply.rs:374:13 [INFO] [stderr] | [INFO] [stderr] 374 | value_type: value_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ply.rs:387:13 [INFO] [stderr] | [INFO] [stderr] 387 | value_type: value_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scene.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | camera: camera, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `camera` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scene.rs:47:50 [INFO] [stderr] | [INFO] [stderr] 47 | viewport: Rect { left: 0, bottom: 0, width: width, height: height }, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scene.rs:47:64 [INFO] [stderr] | [INFO] [stderr] 47 | viewport: Rect { left: 0, bottom: 0, width: width, height: height }, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shaders/mod.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | enabled: enabled, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `enabled` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shaders/mod.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shaders/mod.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shaders/mod.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | specular_exp: specular_exp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `specular_exp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:117:93 [INFO] [stderr] | [INFO] [stderr] 117 | PCNVertex { position: [ 1.0, 1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, 0.577350269, 0.577350269 ] }, // 0 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:117:108 [INFO] [stderr] | [INFO] [stderr] 117 | PCNVertex { position: [ 1.0, 1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, 0.577350269, 0.577350269 ] }, // 0 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:117:123 [INFO] [stderr] | [INFO] [stderr] 117 | PCNVertex { position: [ 1.0, 1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, 0.577350269, 0.577350269 ] }, // 0 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:118:93 [INFO] [stderr] | [INFO] [stderr] 118 | PCNVertex { position: [ 1.0, 1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, 0.577350269, -0.577350269 ] }, // 1 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:118:108 [INFO] [stderr] | [INFO] [stderr] 118 | PCNVertex { position: [ 1.0, 1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, 0.577350269, -0.577350269 ] }, // 1 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:118:123 [INFO] [stderr] | [INFO] [stderr] 118 | PCNVertex { position: [ 1.0, 1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, 0.577350269, -0.577350269 ] }, // 1 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:119:93 [INFO] [stderr] | [INFO] [stderr] 119 | PCNVertex { position: [ 1.0, -1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, -0.577350269, 0.577350269 ] }, // 2 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:119:108 [INFO] [stderr] | [INFO] [stderr] 119 | PCNVertex { position: [ 1.0, -1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, -0.577350269, 0.577350269 ] }, // 2 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:119:123 [INFO] [stderr] | [INFO] [stderr] 119 | PCNVertex { position: [ 1.0, -1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, -0.577350269, 0.577350269 ] }, // 2 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:120:93 [INFO] [stderr] | [INFO] [stderr] 120 | PCNVertex { position: [ 1.0, -1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, -0.577350269, -0.577350269 ] }, // 3 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:120:108 [INFO] [stderr] | [INFO] [stderr] 120 | PCNVertex { position: [ 1.0, -1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, -0.577350269, -0.577350269 ] }, // 3 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:120:123 [INFO] [stderr] | [INFO] [stderr] 120 | PCNVertex { position: [ 1.0, -1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, -0.577350269, -0.577350269 ] }, // 3 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:121:93 [INFO] [stderr] | [INFO] [stderr] 121 | PCNVertex { position: [ -1.0, 1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, 0.577350269, 0.577350269 ] }, // 4 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:121:108 [INFO] [stderr] | [INFO] [stderr] 121 | PCNVertex { position: [ -1.0, 1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, 0.577350269, 0.577350269 ] }, // 4 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:121:123 [INFO] [stderr] | [INFO] [stderr] 121 | PCNVertex { position: [ -1.0, 1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, 0.577350269, 0.577350269 ] }, // 4 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:122:93 [INFO] [stderr] | [INFO] [stderr] 122 | PCNVertex { position: [ -1.0, 1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, 0.577350269, -0.577350269 ] }, // 5 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:122:108 [INFO] [stderr] | [INFO] [stderr] 122 | PCNVertex { position: [ -1.0, 1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, 0.577350269, -0.577350269 ] }, // 5 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:122:123 [INFO] [stderr] | [INFO] [stderr] 122 | PCNVertex { position: [ -1.0, 1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, 0.577350269, -0.577350269 ] }, // 5 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:123:93 [INFO] [stderr] | [INFO] [stderr] 123 | PCNVertex { position: [ -1.0, -1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, -0.577350269, 0.577350269 ] }, // 6 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:123:108 [INFO] [stderr] | [INFO] [stderr] 123 | PCNVertex { position: [ -1.0, -1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, -0.577350269, 0.577350269 ] }, // 6 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:123:123 [INFO] [stderr] | [INFO] [stderr] 123 | PCNVertex { position: [ -1.0, -1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, -0.577350269, 0.577350269 ] }, // 6 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:124:93 [INFO] [stderr] | [INFO] [stderr] 124 | PCNVertex { position: [ -1.0, -1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, -0.577350269, -0.577350269 ] }, // 7 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:124:108 [INFO] [stderr] | [INFO] [stderr] 124 | PCNVertex { position: [ -1.0, -1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, -0.577350269, -0.577350269 ] }, // 7 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:124:123 [INFO] [stderr] | [INFO] [stderr] 124 | PCNVertex { position: [ -1.0, -1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, -0.577350269, -0.577350269 ] }, // 7 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/ply.rs:145:81 [INFO] [stderr] | [INFO] [stderr] 145 | let element = try!(elements.last_mut().ok_or(other_io_error(("Tried to add a property but there's no current element")))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/ply.rs:145:81 [INFO] [stderr] | [INFO] [stderr] 145 | let element = try!(elements.last_mut().ok_or(other_io_error(("Tried to add a property but there's no current element")))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:117:93 [INFO] [stderr] | [INFO] [stderr] 117 | PCNVertex { position: [ 1.0, 1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, 0.577350269, 0.577350269 ] }, // 0 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:117:108 [INFO] [stderr] | [INFO] [stderr] 117 | PCNVertex { position: [ 1.0, 1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, 0.577350269, 0.577350269 ] }, // 0 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:117:123 [INFO] [stderr] | [INFO] [stderr] 117 | PCNVertex { position: [ 1.0, 1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, 0.577350269, 0.577350269 ] }, // 0 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:118:93 [INFO] [stderr] | [INFO] [stderr] 118 | PCNVertex { position: [ 1.0, 1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, 0.577350269, -0.577350269 ] }, // 1 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:118:108 [INFO] [stderr] | [INFO] [stderr] 118 | PCNVertex { position: [ 1.0, 1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, 0.577350269, -0.577350269 ] }, // 1 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:118:123 [INFO] [stderr] | [INFO] [stderr] 118 | PCNVertex { position: [ 1.0, 1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, 0.577350269, -0.577350269 ] }, // 1 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:119:93 [INFO] [stderr] | [INFO] [stderr] 119 | PCNVertex { position: [ 1.0, -1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, -0.577350269, 0.577350269 ] }, // 2 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:119:108 [INFO] [stderr] | [INFO] [stderr] 119 | PCNVertex { position: [ 1.0, -1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, -0.577350269, 0.577350269 ] }, // 2 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:119:123 [INFO] [stderr] | [INFO] [stderr] 119 | PCNVertex { position: [ 1.0, -1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, -0.577350269, 0.577350269 ] }, // 2 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:120:93 [INFO] [stderr] | [INFO] [stderr] 120 | PCNVertex { position: [ 1.0, -1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, -0.577350269, -0.577350269 ] }, // 3 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:120:108 [INFO] [stderr] | [INFO] [stderr] 120 | PCNVertex { position: [ 1.0, -1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, -0.577350269, -0.577350269 ] }, // 3 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:120:123 [INFO] [stderr] | [INFO] [stderr] 120 | PCNVertex { position: [ 1.0, -1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, -0.577350269, -0.577350269 ] }, // 3 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:121:93 [INFO] [stderr] | [INFO] [stderr] 121 | PCNVertex { position: [ -1.0, 1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, 0.577350269, 0.577350269 ] }, // 4 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:121:108 [INFO] [stderr] | [INFO] [stderr] 121 | PCNVertex { position: [ -1.0, 1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, 0.577350269, 0.577350269 ] }, // 4 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:121:123 [INFO] [stderr] | [INFO] [stderr] 121 | PCNVertex { position: [ -1.0, 1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, 0.577350269, 0.577350269 ] }, // 4 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:122:93 [INFO] [stderr] | [INFO] [stderr] 122 | PCNVertex { position: [ -1.0, 1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, 0.577350269, -0.577350269 ] }, // 5 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:122:108 [INFO] [stderr] | [INFO] [stderr] 122 | PCNVertex { position: [ -1.0, 1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, 0.577350269, -0.577350269 ] }, // 5 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:122:123 [INFO] [stderr] | [INFO] [stderr] 122 | PCNVertex { position: [ -1.0, 1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, 0.577350269, -0.577350269 ] }, // 5 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:123:93 [INFO] [stderr] | [INFO] [stderr] 123 | PCNVertex { position: [ -1.0, -1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, -0.577350269, 0.577350269 ] }, // 6 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:123:108 [INFO] [stderr] | [INFO] [stderr] 123 | PCNVertex { position: [ -1.0, -1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, -0.577350269, 0.577350269 ] }, // 6 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:123:123 [INFO] [stderr] | [INFO] [stderr] 123 | PCNVertex { position: [ -1.0, -1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, -0.577350269, 0.577350269 ] }, // 6 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:124:93 [INFO] [stderr] | [INFO] [stderr] 124 | PCNVertex { position: [ -1.0, -1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, -0.577350269, -0.577350269 ] }, // 7 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:124:108 [INFO] [stderr] | [INFO] [stderr] 124 | PCNVertex { position: [ -1.0, -1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, -0.577350269, -0.577350269 ] }, // 7 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geometry.rs:124:123 [INFO] [stderr] | [INFO] [stderr] 124 | PCNVertex { position: [ -1.0, -1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, -0.577350269, -0.577350269 ] }, // 7 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.577_350_269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/ply.rs:145:81 [INFO] [stderr] | [INFO] [stderr] 145 | let element = try!(elements.last_mut().ok_or(other_io_error(("Tried to add a property but there's no current element")))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/ply.rs:145:81 [INFO] [stderr] | [INFO] [stderr] 145 | let element = try!(elements.last_mut().ok_or(other_io_error(("Tried to add a property but there's no current element")))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:117:93 [INFO] [stderr] | [INFO] [stderr] 117 | PCNVertex { position: [ 1.0, 1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, 0.577350269, 0.577350269 ] }, // 0 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:117:108 [INFO] [stderr] | [INFO] [stderr] 117 | PCNVertex { position: [ 1.0, 1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, 0.577350269, 0.577350269 ] }, // 0 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:117:123 [INFO] [stderr] | [INFO] [stderr] 117 | PCNVertex { position: [ 1.0, 1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, 0.577350269, 0.577350269 ] }, // 0 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:118:93 [INFO] [stderr] | [INFO] [stderr] 118 | PCNVertex { position: [ 1.0, 1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, 0.577350269, -0.577350269 ] }, // 1 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:118:108 [INFO] [stderr] | [INFO] [stderr] 118 | PCNVertex { position: [ 1.0, 1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, 0.577350269, -0.577350269 ] }, // 1 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:118:123 [INFO] [stderr] | [INFO] [stderr] 118 | PCNVertex { position: [ 1.0, 1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, 0.577350269, -0.577350269 ] }, // 1 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:119:93 [INFO] [stderr] | [INFO] [stderr] 119 | PCNVertex { position: [ 1.0, -1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, -0.577350269, 0.577350269 ] }, // 2 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:119:108 [INFO] [stderr] | [INFO] [stderr] 119 | PCNVertex { position: [ 1.0, -1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, -0.577350269, 0.577350269 ] }, // 2 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:119:123 [INFO] [stderr] | [INFO] [stderr] 119 | PCNVertex { position: [ 1.0, -1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, -0.577350269, 0.577350269 ] }, // 2 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:120:93 [INFO] [stderr] | [INFO] [stderr] 120 | PCNVertex { position: [ 1.0, -1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, -0.577350269, -0.577350269 ] }, // 3 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:120:108 [INFO] [stderr] | [INFO] [stderr] 120 | PCNVertex { position: [ 1.0, -1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, -0.577350269, -0.577350269 ] }, // 3 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:120:123 [INFO] [stderr] | [INFO] [stderr] 120 | PCNVertex { position: [ 1.0, -1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, -0.577350269, -0.577350269 ] }, // 3 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:121:93 [INFO] [stderr] | [INFO] [stderr] 121 | PCNVertex { position: [ -1.0, 1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, 0.577350269, 0.577350269 ] }, // 4 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:121:108 [INFO] [stderr] | [INFO] [stderr] 121 | PCNVertex { position: [ -1.0, 1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, 0.577350269, 0.577350269 ] }, // 4 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:121:123 [INFO] [stderr] | [INFO] [stderr] 121 | PCNVertex { position: [ -1.0, 1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, 0.577350269, 0.577350269 ] }, // 4 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:122:93 [INFO] [stderr] | [INFO] [stderr] 122 | PCNVertex { position: [ -1.0, 1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, 0.577350269, -0.577350269 ] }, // 5 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:122:108 [INFO] [stderr] | [INFO] [stderr] 122 | PCNVertex { position: [ -1.0, 1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, 0.577350269, -0.577350269 ] }, // 5 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:122:123 [INFO] [stderr] | [INFO] [stderr] 122 | PCNVertex { position: [ -1.0, 1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, 0.577350269, -0.577350269 ] }, // 5 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:123:93 [INFO] [stderr] | [INFO] [stderr] 123 | PCNVertex { position: [ -1.0, -1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, -0.577350269, 0.577350269 ] }, // 6 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:123:108 [INFO] [stderr] | [INFO] [stderr] 123 | PCNVertex { position: [ -1.0, -1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, -0.577350269, 0.577350269 ] }, // 6 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:123:123 [INFO] [stderr] | [INFO] [stderr] 123 | PCNVertex { position: [ -1.0, -1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, -0.577350269, 0.577350269 ] }, // 6 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:124:93 [INFO] [stderr] | [INFO] [stderr] 124 | PCNVertex { position: [ -1.0, -1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, -0.577350269, -0.577350269 ] }, // 7 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:124:108 [INFO] [stderr] | [INFO] [stderr] 124 | PCNVertex { position: [ -1.0, -1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, -0.577350269, -0.577350269 ] }, // 7 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:124:123 [INFO] [stderr] | [INFO] [stderr] 124 | PCNVertex { position: [ -1.0, -1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, -0.577350269, -0.577350269 ] }, // 7 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `physics::body::Body` [INFO] [stderr] --> src/physics/body.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Body { [INFO] [stderr] 35 | | let initial_phase = Phase { [INFO] [stderr] 36 | | position: Vector3::new(0.0, 0.0, 0.0), [INFO] [stderr] 37 | | momentum: Vector3::new(0.0, 0.0, 0.0), [INFO] [stderr] ... | [INFO] [stderr] 55 | | Body(Rc::new(RefCell::new(inner))) [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | impl Default for physics::body::Body { [INFO] [stderr] 34 | fn default() -> Self { [INFO] [stderr] 35 | Self::new() [INFO] [stderr] 36 | } [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `physics::system::System` [INFO] [stderr] --> src/physics/system.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> System { [INFO] [stderr] 11 | | System { [INFO] [stderr] 12 | | bodies: Vec::new(), [INFO] [stderr] 13 | | hangover_time: 0.0, [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ply.rs:54:19 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn is_int(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ply.rs:61:22 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn byte_size(&self) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ply.rs:71:34 [INFO] [stderr] | [INFO] [stderr] 71 | fn read_int(&self, reader: &mut R, format: &Format) -> io::Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ply.rs:71:65 [INFO] [stderr] | [INFO] [stderr] 71 | fn read_int(&self, reader: &mut R, format: &Format) -> io::Result { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ply.rs:76:51 [INFO] [stderr] | [INFO] [stderr] 76 | (Int8, _) => reader.read_i8().map(|i| i as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ply.rs:77:52 [INFO] [stderr] | [INFO] [stderr] 77 | (Uint8, _) => reader.read_u8().map(|i| i as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ply.rs:79:87 [INFO] [stderr] | [INFO] [stderr] 79 | (Int16, BinaryLittleEndian) => reader.read_i16::().map(|i| i as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ply.rs:80:87 [INFO] [stderr] | [INFO] [stderr] 80 | (Int16, BinaryBigEndian) => reader.read_i16::() .map(|i| i as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ply.rs:81:87 [INFO] [stderr] | [INFO] [stderr] 81 | (Uint16, BinaryLittleEndian) => reader.read_u16::().map(|i| i as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ply.rs:82:87 [INFO] [stderr] | [INFO] [stderr] 82 | (Uint16, BinaryBigEndian) => reader.read_u16::() .map(|i| i as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ply.rs:84:87 [INFO] [stderr] | [INFO] [stderr] 84 | (Int32, BinaryLittleEndian) => reader.read_i32::().map(|i| i as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ply.rs:85:87 [INFO] [stderr] | [INFO] [stderr] 85 | (Int32, BinaryBigEndian) => reader.read_i32::() .map(|i| i as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ply.rs:86:87 [INFO] [stderr] | [INFO] [stderr] 86 | (Uint32, BinaryLittleEndian) => reader.read_u32::().map(|i| i as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ply.rs:87:87 [INFO] [stderr] | [INFO] [stderr] 87 | (Uint32, BinaryBigEndian) => reader.read_u32::() .map(|i| i as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ply.rs:93:36 [INFO] [stderr] | [INFO] [stderr] 93 | fn read_float(&self, reader: &mut R, format: &Format) -> io::Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ply.rs:93:67 [INFO] [stderr] | [INFO] [stderr] 93 | fn read_float(&self, reader: &mut R, format: &Format) -> io::Result { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ply.rs:98:88 [INFO] [stderr] | [INFO] [stderr] 98 | (Float32, BinaryLittleEndian) => reader.read_f32::().map(|i| i as f64), [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ply.rs:99:88 [INFO] [stderr] | [INFO] [stderr] 99 | (Float32, BinaryBigEndian) => reader.read_f32::() .map(|i| i as f64), [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ply.rs:137:51 [INFO] [stderr] | [INFO] [stderr] 137 | let tokens: Vec<&str> = (&line).split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:139:39 [INFO] [stderr] | [INFO] [stderr] 139 | match *try!(tokens.get(0).ok_or(other_io_error(&format!("No tokens on line?! (line = {:?})", line)))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error(&format!("No tokens on line?! (line = {:?})", line)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:145:60 [INFO] [stderr] | [INFO] [stderr] 145 | let element = try!(elements.last_mut().ok_or(other_io_error(("Tried to add a property but there's no current element")))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error(("Tried to add a property but there's no current element")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ply.rs:335:23 [INFO] [stderr] | [INFO] [stderr] 335 | fn parse_format(toks: &Vec<&str>) -> io::Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:336:40 [INFO] [stderr] | [INFO] [stderr] 336 | Format::from_str(*try!(toks.get(1).ok_or(other_io_error("Not enough tokens for ply format")))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error("Not enough tokens for ply format"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ply.rs:339:24 [INFO] [stderr] | [INFO] [stderr] 339 | fn parse_comment(toks: &Vec<&str>) -> io::Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ply.rs:349:24 [INFO] [stderr] | [INFO] [stderr] 349 | fn parse_element(toks: &Vec<&str>) -> io::Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:350:34 [INFO] [stderr] | [INFO] [stderr] 350 | let name = *try!(toks.get(1).ok_or(other_io_error("Not enough tokens for ply element name"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error("Not enough tokens for ply element name"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:351:39 [INFO] [stderr] | [INFO] [stderr] 351 | let count_str = *try!(toks.get(2).ok_or(other_io_error("Not enough tokens for ply element count"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error("Not enough tokens for ply element count"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ply.rs:361:25 [INFO] [stderr] | [INFO] [stderr] 361 | fn parse_property(toks: &Vec<&str>) -> io::Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:362:39 [INFO] [stderr] | [INFO] [stderr] 362 | let prop_type = *try!(toks.get(1).ok_or(other_io_error("Not enough tokens for ply property type"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error("Not enough tokens for ply property type"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:365:48 [INFO] [stderr] | [INFO] [stderr] 365 | let count_type_str = *try!(toks.get(2).ok_or(other_io_error("Not enough tokens for ply list property count type"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error("Not enough tokens for ply list property count type"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:366:48 [INFO] [stderr] | [INFO] [stderr] 366 | let value_type_str = *try!(toks.get(3).ok_or(other_io_error("Not enough tokens for ply list property value type"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error("Not enough tokens for ply list property value type"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:367:38 [INFO] [stderr] | [INFO] [stderr] 367 | let name = *try!(toks.get(4).ok_or(other_io_error("Not enough tokens for ply list property name"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error("Not enough tokens for ply list property name"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/ply.rs:376:19 [INFO] [stderr] | [INFO] [stderr] 376 | data: match value_type.is_int() { [INFO] [stderr] | ___________________^ [INFO] [stderr] 377 | | true => PropertyValue::IntList(vec![]), [INFO] [stderr] 378 | | false => PropertyValue::FloatList(vec![]), [INFO] [stderr] 379 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if value_type.is_int() { PropertyValue::IntList(vec![]) } else { PropertyValue::FloatList(vec![]) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:382:38 [INFO] [stderr] | [INFO] [stderr] 382 | let name = *try!(toks.get(2).ok_or(other_io_error("Not enough tokens for ply property name"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error("Not enough tokens for ply property name"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/ply.rs:389:19 [INFO] [stderr] | [INFO] [stderr] 389 | data: match value_type.is_int() { [INFO] [stderr] | ___________________^ [INFO] [stderr] 390 | | true => PropertyValue::IntScalar(vec![]), [INFO] [stderr] 391 | | false => PropertyValue::FloatScalar(vec![]), [INFO] [stderr] 392 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if value_type.is_int() { PropertyValue::IntScalar(vec![]) } else { PropertyValue::FloatScalar(vec![]) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ply.rs:400:35 [INFO] [stderr] | [INFO] [stderr] 400 | let mut toks = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:404:50 [INFO] [stderr] | [INFO] [stderr] 404 | let count_str = try!(toks.next().ok_or(other_io_error("Not enough tokens for ply list property count"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error("Not enough tokens for ply list property count"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:413:54 [INFO] [stderr] | [INFO] [stderr] 413 | value_toks.push(try!(toks.next().ok_or(other_io_error("Not enough tokens for ply list property value")))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error("Not enough tokens for ply list property value"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:418:50 [INFO] [stderr] | [INFO] [stderr] 418 | let value_str = try!(toks.next().ok_or(other_io_error("Not enough tokens for ply scalar property value"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error("Not enough tokens for ply scalar property value"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ply.rs:466:21 [INFO] [stderr] | [INFO] [stderr] 466 | / match &mut property.data { [INFO] [stderr] 467 | | &mut IntScalar(ref mut ivals) => ivals.push(value), [INFO] [stderr] 468 | | _ => return Err(other_io_error("Error parsing scalar value")), [INFO] [stderr] 469 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 466 | match *(&mut property.data) { [INFO] [stderr] 467 | IntScalar(ref mut ivals) => ivals.push(value), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ply.rs:472:21 [INFO] [stderr] | [INFO] [stderr] 472 | / match &mut property.data { [INFO] [stderr] 473 | | &mut FloatScalar(ref mut fvals) => fvals.push(value), [INFO] [stderr] 474 | | _ => return Err(other_io_error("Error parsing float value")), [INFO] [stderr] 475 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 472 | match *(&mut property.data) { [INFO] [stderr] 473 | FloatScalar(ref mut fvals) => fvals.push(value), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: reference to zeroed memory [INFO] [stderr] --> src/shaders/mod.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | implement_uniform_block!(ViewAndProjectionBlock, view, view_inv, projection); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::invalid_ref)] on by default [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: reference to uninitialized memory [INFO] [stderr] --> src/shaders/mod.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | implement_uniform_block!(ViewAndProjectionBlock, view, view_inv, projection); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: reference to zeroed memory [INFO] [stderr] --> src/shaders/mod.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | implement_uniform_block!(ViewAndProjectionBlock, view, view_inv, projection); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: reference to zeroed memory [INFO] [stderr] --> src/shaders/mod.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | implement_uniform_block!(ViewAndProjectionBlock, view, view_inv, projection); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: reference to zeroed memory [INFO] [stderr] --> src/shaders/mod.rs:75:1 [INFO] [stderr] | [INFO] [stderr] 75 | implement_uniform_block!(LightProperties, position, specular_exp, color, enabled); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: reference to uninitialized memory [INFO] [stderr] --> src/shaders/mod.rs:75:1 [INFO] [stderr] | [INFO] [stderr] 75 | implement_uniform_block!(LightProperties, position, specular_exp, color, enabled); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: reference to zeroed memory [INFO] [stderr] --> src/shaders/mod.rs:75:1 [INFO] [stderr] | [INFO] [stderr] 75 | implement_uniform_block!(LightProperties, position, specular_exp, color, enabled); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: reference to zeroed memory [INFO] [stderr] --> src/shaders/mod.rs:84:1 [INFO] [stderr] | [INFO] [stderr] 84 | implement_uniform_block!(LightListBlock, lights); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: reference to uninitialized memory [INFO] [stderr] --> src/shaders/mod.rs:84:1 [INFO] [stderr] | [INFO] [stderr] 84 | implement_uniform_block!(LightListBlock, lights); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: reference to zeroed memory [INFO] [stderr] --> src/shaders/mod.rs:84:1 [INFO] [stderr] | [INFO] [stderr] 84 | implement_uniform_block!(LightListBlock, lights); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:117:93 [INFO] [stderr] | [INFO] [stderr] 117 | PCNVertex { position: [ 1.0, 1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, 0.577350269, 0.577350269 ] }, // 0 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:117:108 [INFO] [stderr] | [INFO] [stderr] 117 | PCNVertex { position: [ 1.0, 1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, 0.577350269, 0.577350269 ] }, // 0 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:117:123 [INFO] [stderr] | [INFO] [stderr] 117 | PCNVertex { position: [ 1.0, 1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, 0.577350269, 0.577350269 ] }, // 0 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:118:93 [INFO] [stderr] | [INFO] [stderr] 118 | PCNVertex { position: [ 1.0, 1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, 0.577350269, -0.577350269 ] }, // 1 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:118:108 [INFO] [stderr] | [INFO] [stderr] 118 | PCNVertex { position: [ 1.0, 1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, 0.577350269, -0.577350269 ] }, // 1 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:118:123 [INFO] [stderr] | [INFO] [stderr] 118 | PCNVertex { position: [ 1.0, 1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, 0.577350269, -0.577350269 ] }, // 1 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:119:93 [INFO] [stderr] | [INFO] [stderr] 119 | PCNVertex { position: [ 1.0, -1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, -0.577350269, 0.577350269 ] }, // 2 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:119:108 [INFO] [stderr] | [INFO] [stderr] 119 | PCNVertex { position: [ 1.0, -1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, -0.577350269, 0.577350269 ] }, // 2 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:119:123 [INFO] [stderr] | [INFO] [stderr] 119 | PCNVertex { position: [ 1.0, -1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, -0.577350269, 0.577350269 ] }, // 2 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:120:93 [INFO] [stderr] | [INFO] [stderr] 120 | PCNVertex { position: [ 1.0, -1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, -0.577350269, -0.577350269 ] }, // 3 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:120:108 [INFO] [stderr] | [INFO] [stderr] 120 | PCNVertex { position: [ 1.0, -1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, -0.577350269, -0.577350269 ] }, // 3 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:120:123 [INFO] [stderr] | [INFO] [stderr] 120 | PCNVertex { position: [ 1.0, -1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ 0.577350269, -0.577350269, -0.577350269 ] }, // 3 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:121:93 [INFO] [stderr] | [INFO] [stderr] 121 | PCNVertex { position: [ -1.0, 1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, 0.577350269, 0.577350269 ] }, // 4 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:121:108 [INFO] [stderr] | [INFO] [stderr] 121 | PCNVertex { position: [ -1.0, 1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, 0.577350269, 0.577350269 ] }, // 4 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:121:123 [INFO] [stderr] | [INFO] [stderr] 121 | PCNVertex { position: [ -1.0, 1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, 0.577350269, 0.577350269 ] }, // 4 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:122:93 [INFO] [stderr] | [INFO] [stderr] 122 | PCNVertex { position: [ -1.0, 1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, 0.577350269, -0.577350269 ] }, // 5 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:122:108 [INFO] [stderr] | [INFO] [stderr] 122 | PCNVertex { position: [ -1.0, 1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, 0.577350269, -0.577350269 ] }, // 5 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:122:123 [INFO] [stderr] | [INFO] [stderr] 122 | PCNVertex { position: [ -1.0, 1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, 0.577350269, -0.577350269 ] }, // 5 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:123:93 [INFO] [stderr] | [INFO] [stderr] 123 | PCNVertex { position: [ -1.0, -1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, -0.577350269, 0.577350269 ] }, // 6 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:123:108 [INFO] [stderr] | [INFO] [stderr] 123 | PCNVertex { position: [ -1.0, -1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, -0.577350269, 0.577350269 ] }, // 6 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:123:123 [INFO] [stderr] | [INFO] [stderr] 123 | PCNVertex { position: [ -1.0, -1.0, 1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, -0.577350269, 0.577350269 ] }, // 6 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:124:93 [INFO] [stderr] | [INFO] [stderr] 124 | PCNVertex { position: [ -1.0, -1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, -0.577350269, -0.577350269 ] }, // 7 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:124:108 [INFO] [stderr] | [INFO] [stderr] 124 | PCNVertex { position: [ -1.0, -1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, -0.577350269, -0.577350269 ] }, // 7 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/geometry.rs:124:123 [INFO] [stderr] | [INFO] [stderr] 124 | PCNVertex { position: [ -1.0, -1.0, -1.0 ], color: [ 1.0, 1.0, 1.0, 1.0 ], normal: [ -0.577350269, -0.577350269, -0.577350269 ] }, // 7 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.577_350_26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: aborting due to 10 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `graphplay2`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider adding a `Default` implementation for `physics::body::Body` [INFO] [stderr] --> src/physics/body.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Body { [INFO] [stderr] 35 | | let initial_phase = Phase { [INFO] [stderr] 36 | | position: Vector3::new(0.0, 0.0, 0.0), [INFO] [stderr] 37 | | momentum: Vector3::new(0.0, 0.0, 0.0), [INFO] [stderr] ... | [INFO] [stderr] 55 | | Body(Rc::new(RefCell::new(inner))) [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | impl Default for physics::body::Body { [INFO] [stderr] 34 | fn default() -> Self { [INFO] [stderr] 35 | Self::new() [INFO] [stderr] 36 | } [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `physics::system::System` [INFO] [stderr] --> src/physics/system.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> System { [INFO] [stderr] 11 | | System { [INFO] [stderr] 12 | | bodies: Vec::new(), [INFO] [stderr] 13 | | hangover_time: 0.0, [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ply.rs:54:19 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn is_int(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ply.rs:61:22 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn byte_size(&self) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ply.rs:71:34 [INFO] [stderr] | [INFO] [stderr] 71 | fn read_int(&self, reader: &mut R, format: &Format) -> io::Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ply.rs:71:65 [INFO] [stderr] | [INFO] [stderr] 71 | fn read_int(&self, reader: &mut R, format: &Format) -> io::Result { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ply.rs:76:51 [INFO] [stderr] | [INFO] [stderr] 76 | (Int8, _) => reader.read_i8().map(|i| i as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ply.rs:77:52 [INFO] [stderr] | [INFO] [stderr] 77 | (Uint8, _) => reader.read_u8().map(|i| i as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ply.rs:79:87 [INFO] [stderr] | [INFO] [stderr] 79 | (Int16, BinaryLittleEndian) => reader.read_i16::().map(|i| i as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ply.rs:80:87 [INFO] [stderr] | [INFO] [stderr] 80 | (Int16, BinaryBigEndian) => reader.read_i16::() .map(|i| i as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ply.rs:81:87 [INFO] [stderr] | [INFO] [stderr] 81 | (Uint16, BinaryLittleEndian) => reader.read_u16::().map(|i| i as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ply.rs:82:87 [INFO] [stderr] | [INFO] [stderr] 82 | (Uint16, BinaryBigEndian) => reader.read_u16::() .map(|i| i as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ply.rs:84:87 [INFO] [stderr] | [INFO] [stderr] 84 | (Int32, BinaryLittleEndian) => reader.read_i32::().map(|i| i as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ply.rs:85:87 [INFO] [stderr] | [INFO] [stderr] 85 | (Int32, BinaryBigEndian) => reader.read_i32::() .map(|i| i as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ply.rs:86:87 [INFO] [stderr] | [INFO] [stderr] 86 | (Uint32, BinaryLittleEndian) => reader.read_u32::().map(|i| i as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ply.rs:87:87 [INFO] [stderr] | [INFO] [stderr] 87 | (Uint32, BinaryBigEndian) => reader.read_u32::() .map(|i| i as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ply.rs:93:36 [INFO] [stderr] | [INFO] [stderr] 93 | fn read_float(&self, reader: &mut R, format: &Format) -> io::Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ply.rs:93:67 [INFO] [stderr] | [INFO] [stderr] 93 | fn read_float(&self, reader: &mut R, format: &Format) -> io::Result { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ply.rs:98:88 [INFO] [stderr] | [INFO] [stderr] 98 | (Float32, BinaryLittleEndian) => reader.read_f32::().map(|i| i as f64), [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ply.rs:99:88 [INFO] [stderr] | [INFO] [stderr] 99 | (Float32, BinaryBigEndian) => reader.read_f32::() .map(|i| i as f64), [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ply.rs:137:51 [INFO] [stderr] | [INFO] [stderr] 137 | let tokens: Vec<&str> = (&line).split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:139:39 [INFO] [stderr] | [INFO] [stderr] 139 | match *try!(tokens.get(0).ok_or(other_io_error(&format!("No tokens on line?! (line = {:?})", line)))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error(&format!("No tokens on line?! (line = {:?})", line)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:145:60 [INFO] [stderr] | [INFO] [stderr] 145 | let element = try!(elements.last_mut().ok_or(other_io_error(("Tried to add a property but there's no current element")))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error(("Tried to add a property but there's no current element")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ply.rs:335:23 [INFO] [stderr] | [INFO] [stderr] 335 | fn parse_format(toks: &Vec<&str>) -> io::Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:336:40 [INFO] [stderr] | [INFO] [stderr] 336 | Format::from_str(*try!(toks.get(1).ok_or(other_io_error("Not enough tokens for ply format")))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error("Not enough tokens for ply format"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ply.rs:339:24 [INFO] [stderr] | [INFO] [stderr] 339 | fn parse_comment(toks: &Vec<&str>) -> io::Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ply.rs:349:24 [INFO] [stderr] | [INFO] [stderr] 349 | fn parse_element(toks: &Vec<&str>) -> io::Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:350:34 [INFO] [stderr] | [INFO] [stderr] 350 | let name = *try!(toks.get(1).ok_or(other_io_error("Not enough tokens for ply element name"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error("Not enough tokens for ply element name"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:351:39 [INFO] [stderr] | [INFO] [stderr] 351 | let count_str = *try!(toks.get(2).ok_or(other_io_error("Not enough tokens for ply element count"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error("Not enough tokens for ply element count"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ply.rs:361:25 [INFO] [stderr] | [INFO] [stderr] 361 | fn parse_property(toks: &Vec<&str>) -> io::Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:362:39 [INFO] [stderr] | [INFO] [stderr] 362 | let prop_type = *try!(toks.get(1).ok_or(other_io_error("Not enough tokens for ply property type"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error("Not enough tokens for ply property type"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:365:48 [INFO] [stderr] | [INFO] [stderr] 365 | let count_type_str = *try!(toks.get(2).ok_or(other_io_error("Not enough tokens for ply list property count type"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error("Not enough tokens for ply list property count type"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:366:48 [INFO] [stderr] | [INFO] [stderr] 366 | let value_type_str = *try!(toks.get(3).ok_or(other_io_error("Not enough tokens for ply list property value type"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error("Not enough tokens for ply list property value type"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:367:38 [INFO] [stderr] | [INFO] [stderr] 367 | let name = *try!(toks.get(4).ok_or(other_io_error("Not enough tokens for ply list property name"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error("Not enough tokens for ply list property name"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/ply.rs:376:19 [INFO] [stderr] | [INFO] [stderr] 376 | data: match value_type.is_int() { [INFO] [stderr] | ___________________^ [INFO] [stderr] 377 | | true => PropertyValue::IntList(vec![]), [INFO] [stderr] 378 | | false => PropertyValue::FloatList(vec![]), [INFO] [stderr] 379 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if value_type.is_int() { PropertyValue::IntList(vec![]) } else { PropertyValue::FloatList(vec![]) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:382:38 [INFO] [stderr] | [INFO] [stderr] 382 | let name = *try!(toks.get(2).ok_or(other_io_error("Not enough tokens for ply property name"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error("Not enough tokens for ply property name"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/ply.rs:389:19 [INFO] [stderr] | [INFO] [stderr] 389 | data: match value_type.is_int() { [INFO] [stderr] | ___________________^ [INFO] [stderr] 390 | | true => PropertyValue::IntScalar(vec![]), [INFO] [stderr] 391 | | false => PropertyValue::FloatScalar(vec![]), [INFO] [stderr] 392 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if value_type.is_int() { PropertyValue::IntScalar(vec![]) } else { PropertyValue::FloatScalar(vec![]) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ply.rs:400:35 [INFO] [stderr] | [INFO] [stderr] 400 | let mut toks = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:404:50 [INFO] [stderr] | [INFO] [stderr] 404 | let count_str = try!(toks.next().ok_or(other_io_error("Not enough tokens for ply list property count"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error("Not enough tokens for ply list property count"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:413:54 [INFO] [stderr] | [INFO] [stderr] 413 | value_toks.push(try!(toks.next().ok_or(other_io_error("Not enough tokens for ply list property value")))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error("Not enough tokens for ply list property value"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ply.rs:418:50 [INFO] [stderr] | [INFO] [stderr] 418 | let value_str = try!(toks.next().ok_or(other_io_error("Not enough tokens for ply scalar property value"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| other_io_error("Not enough tokens for ply scalar property value"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ply.rs:466:21 [INFO] [stderr] | [INFO] [stderr] 466 | / match &mut property.data { [INFO] [stderr] 467 | | &mut IntScalar(ref mut ivals) => ivals.push(value), [INFO] [stderr] 468 | | _ => return Err(other_io_error("Error parsing scalar value")), [INFO] [stderr] 469 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 466 | match *(&mut property.data) { [INFO] [stderr] 467 | IntScalar(ref mut ivals) => ivals.push(value), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ply.rs:472:21 [INFO] [stderr] | [INFO] [stderr] 472 | / match &mut property.data { [INFO] [stderr] 473 | | &mut FloatScalar(ref mut fvals) => fvals.push(value), [INFO] [stderr] 474 | | _ => return Err(other_io_error("Error parsing float value")), [INFO] [stderr] 475 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 472 | match *(&mut property.data) { [INFO] [stderr] 473 | FloatScalar(ref mut fvals) => fvals.push(value), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: reference to zeroed memory [INFO] [stderr] --> src/shaders/mod.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | implement_uniform_block!(ViewAndProjectionBlock, view, view_inv, projection); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::invalid_ref)] on by default [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: reference to uninitialized memory [INFO] [stderr] --> src/shaders/mod.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | implement_uniform_block!(ViewAndProjectionBlock, view, view_inv, projection); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: reference to zeroed memory [INFO] [stderr] --> src/shaders/mod.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | implement_uniform_block!(ViewAndProjectionBlock, view, view_inv, projection); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: reference to zeroed memory [INFO] [stderr] --> src/shaders/mod.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | implement_uniform_block!(ViewAndProjectionBlock, view, view_inv, projection); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: reference to zeroed memory [INFO] [stderr] --> src/shaders/mod.rs:75:1 [INFO] [stderr] | [INFO] [stderr] 75 | implement_uniform_block!(LightProperties, position, specular_exp, color, enabled); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: reference to uninitialized memory [INFO] [stderr] --> src/shaders/mod.rs:75:1 [INFO] [stderr] | [INFO] [stderr] 75 | implement_uniform_block!(LightProperties, position, specular_exp, color, enabled); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: reference to zeroed memory [INFO] [stderr] --> src/shaders/mod.rs:75:1 [INFO] [stderr] | [INFO] [stderr] 75 | implement_uniform_block!(LightProperties, position, specular_exp, color, enabled); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: reference to zeroed memory [INFO] [stderr] --> src/shaders/mod.rs:84:1 [INFO] [stderr] | [INFO] [stderr] 84 | implement_uniform_block!(LightListBlock, lights); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: reference to uninitialized memory [INFO] [stderr] --> src/shaders/mod.rs:84:1 [INFO] [stderr] | [INFO] [stderr] 84 | implement_uniform_block!(LightListBlock, lights); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: reference to zeroed memory [INFO] [stderr] --> src/shaders/mod.rs:84:1 [INFO] [stderr] | [INFO] [stderr] 84 | implement_uniform_block!(LightListBlock, lights); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 10 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `graphplay2`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e04073abecea8887ed8b4bad5c5b7300c430a77fbfeb3b4e06ffcd425743695f"` [INFO] running `"docker" "rm" "-f" "e04073abecea8887ed8b4bad5c5b7300c430a77fbfeb3b4e06ffcd425743695f"` [INFO] [stdout] e04073abecea8887ed8b4bad5c5b7300c430a77fbfeb3b4e06ffcd425743695f