[INFO] updating cached repository ahmad2smile/redux-duck [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ahmad2smile/redux-duck [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ahmad2smile/redux-duck" "work/ex/clippy-test-run/sources/stable/gh/ahmad2smile/redux-duck"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ahmad2smile/redux-duck'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ahmad2smile/redux-duck" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahmad2smile/redux-duck"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahmad2smile/redux-duck'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f30373dbfd343aca7f1b3b5a2aaf53276a6af5ea [INFO] sha for GitHub repo ahmad2smile/redux-duck: f30373dbfd343aca7f1b3b5a2aaf53276a6af5ea [INFO] validating manifest of ahmad2smile/redux-duck on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ahmad2smile/redux-duck on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ahmad2smile/redux-duck [INFO] finished frobbing ahmad2smile/redux-duck [INFO] frobbed toml for ahmad2smile/redux-duck written to work/ex/clippy-test-run/sources/stable/gh/ahmad2smile/redux-duck/Cargo.toml [INFO] started frobbing ahmad2smile/redux-duck [INFO] finished frobbing ahmad2smile/redux-duck [INFO] frobbed toml for ahmad2smile/redux-duck written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahmad2smile/redux-duck/Cargo.toml [INFO] crate ahmad2smile/redux-duck has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ahmad2smile/redux-duck against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ahmad2smile/redux-duck:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] be51d87ceeacf82ffd530a316e9b11f6d6e9b25b783b346da7a92bdf538dd480 [INFO] running `"docker" "start" "-a" "be51d87ceeacf82ffd530a316e9b11f6d6e9b25b783b346da7a92bdf538dd480"` [INFO] [stderr] Checking redux-duck v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/arguments.rs:15:4 [INFO] [stderr] | [INFO] [stderr] 15 | return Err("Please provide a DUCK name!"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Please provide a DUCK name!")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/arguments.rs:17:4 [INFO] [stderr] | [INFO] [stderr] 17 | return Ok(Arguments { [INFO] [stderr] | _____________^ [INFO] [stderr] 18 | | duck: args [INFO] [stderr] 19 | | .iter() [INFO] [stderr] 20 | | .filter(|arg| !arg.contains("-js")) [INFO] [stderr] ... | [INFO] [stderr] 23 | | extension: ".js".to_string(), [INFO] [stderr] 24 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 17 | Ok(Arguments { [INFO] [stderr] 18 | duck: args [INFO] [stderr] 19 | .iter() [INFO] [stderr] 20 | .filter(|arg| !arg.contains("-js")) [INFO] [stderr] 21 | .cloned() [INFO] [stderr] 22 | .collect(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/arguments.rs:27:4 [INFO] [stderr] | [INFO] [stderr] 27 | return Err("help"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("help")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/arguments.rs:29:4 [INFO] [stderr] | [INFO] [stderr] 29 | return Ok(Arguments { [INFO] [stderr] | _____________^ [INFO] [stderr] 30 | | duck: args.to_vec(), [INFO] [stderr] 31 | | extension: ".ts".to_string(), [INFO] [stderr] 32 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 29 | Ok(Arguments { [INFO] [stderr] 30 | duck: args.to_vec(), [INFO] [stderr] 31 | extension: ".ts".to_string(), [INFO] [stderr] 32 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/arguments.rs:12:6 [INFO] [stderr] | [INFO] [stderr] 12 | if args.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/arguments.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | } else if args.clone().iter().any(|x| x == "-js") { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 16 | } else if &(*args).clone().iter().any(|x| x == "-js") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 16 | } else if &[std::string::String]::clone(args).iter().any(|x| x == "-js") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/arguments.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | } else if args.clone().iter().any(|x| x == "-h" || x == "--help") { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 25 | } else if &(*args).clone().iter().any(|x| x == "-h" || x == "--help") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 25 | } else if &[std::string::String]::clone(args).iter().any(|x| x == "-h" || x == "--help") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:27:25 [INFO] [stderr] | [INFO] [stderr] 27 | let duck_file_path = path.clone() + &"/" + &redux_paths[path_index]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^------------------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `redux_paths[path_index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:27:25 [INFO] [stderr] | [INFO] [stderr] 27 | let duck_file_path = path.clone() + &"/" + &redux_paths[path_index]; [INFO] [stderr] | ^^^^^^^^^^^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"/"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:31:20 [INFO] [stderr] | [INFO] [stderr] 31 | let duck_file = duck_file_path + &"/" + &duck + redux_files[path_index] + &extension; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"/"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `redux-duck`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/arguments.rs:15:4 [INFO] [stderr] | [INFO] [stderr] 15 | return Err("Please provide a DUCK name!"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Please provide a DUCK name!")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/arguments.rs:17:4 [INFO] [stderr] | [INFO] [stderr] 17 | return Ok(Arguments { [INFO] [stderr] | _____________^ [INFO] [stderr] 18 | | duck: args [INFO] [stderr] 19 | | .iter() [INFO] [stderr] 20 | | .filter(|arg| !arg.contains("-js")) [INFO] [stderr] ... | [INFO] [stderr] 23 | | extension: ".js".to_string(), [INFO] [stderr] 24 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 17 | Ok(Arguments { [INFO] [stderr] 18 | duck: args [INFO] [stderr] 19 | .iter() [INFO] [stderr] 20 | .filter(|arg| !arg.contains("-js")) [INFO] [stderr] 21 | .cloned() [INFO] [stderr] 22 | .collect(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/arguments.rs:27:4 [INFO] [stderr] | [INFO] [stderr] 27 | return Err("help"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("help")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/arguments.rs:29:4 [INFO] [stderr] | [INFO] [stderr] 29 | return Ok(Arguments { [INFO] [stderr] | _____________^ [INFO] [stderr] 30 | | duck: args.to_vec(), [INFO] [stderr] 31 | | extension: ".ts".to_string(), [INFO] [stderr] 32 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 29 | Ok(Arguments { [INFO] [stderr] 30 | duck: args.to_vec(), [INFO] [stderr] 31 | extension: ".ts".to_string(), [INFO] [stderr] 32 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/arguments.rs:12:6 [INFO] [stderr] | [INFO] [stderr] 12 | if args.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/arguments.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | } else if args.clone().iter().any(|x| x == "-js") { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 16 | } else if &(*args).clone().iter().any(|x| x == "-js") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 16 | } else if &[std::string::String]::clone(args).iter().any(|x| x == "-js") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/arguments.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | } else if args.clone().iter().any(|x| x == "-h" || x == "--help") { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 25 | } else if &(*args).clone().iter().any(|x| x == "-h" || x == "--help") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 25 | } else if &[std::string::String]::clone(args).iter().any(|x| x == "-h" || x == "--help") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:27:25 [INFO] [stderr] | [INFO] [stderr] 27 | let duck_file_path = path.clone() + &"/" + &redux_paths[path_index]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^------------------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `redux_paths[path_index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:27:25 [INFO] [stderr] | [INFO] [stderr] 27 | let duck_file_path = path.clone() + &"/" + &redux_paths[path_index]; [INFO] [stderr] | ^^^^^^^^^^^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"/"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:31:20 [INFO] [stderr] | [INFO] [stderr] 31 | let duck_file = duck_file_path + &"/" + &duck + redux_files[path_index] + &extension; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"/"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `redux-duck`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "be51d87ceeacf82ffd530a316e9b11f6d6e9b25b783b346da7a92bdf538dd480"` [INFO] running `"docker" "rm" "-f" "be51d87ceeacf82ffd530a316e9b11f6d6e9b25b783b346da7a92bdf538dd480"` [INFO] [stdout] be51d87ceeacf82ffd530a316e9b11f6d6e9b25b783b346da7a92bdf538dd480