[INFO] updating cached repository ahenshaw/mpsparser [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ahenshaw/mpsparser [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ahenshaw/mpsparser" "work/ex/clippy-test-run/sources/stable/gh/ahenshaw/mpsparser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ahenshaw/mpsparser'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ahenshaw/mpsparser" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahenshaw/mpsparser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahenshaw/mpsparser'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8f5dcaf3e473890efc5d8cd7b6d416584d3319ec [INFO] sha for GitHub repo ahenshaw/mpsparser: 8f5dcaf3e473890efc5d8cd7b6d416584d3319ec [INFO] validating manifest of ahenshaw/mpsparser on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ahenshaw/mpsparser on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ahenshaw/mpsparser [INFO] finished frobbing ahenshaw/mpsparser [INFO] frobbed toml for ahenshaw/mpsparser written to work/ex/clippy-test-run/sources/stable/gh/ahenshaw/mpsparser/Cargo.toml [INFO] started frobbing ahenshaw/mpsparser [INFO] finished frobbing ahenshaw/mpsparser [INFO] frobbed toml for ahenshaw/mpsparser written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahenshaw/mpsparser/Cargo.toml [INFO] crate ahenshaw/mpsparser has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ahenshaw/mpsparser against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ahenshaw/mpsparser:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 85463e860c87417f0e86b456d46a4109add7d012534f18f31a8bd8a578f477cd [INFO] running `"docker" "start" "-a" "85463e860c87417f0e86b456d46a4109add7d012534f18f31a8bd8a578f477cd"` [INFO] [stderr] Checking memchr v2.1.0 [INFO] [stderr] Checking nom v4.0.0 [INFO] [stderr] Checking mpsparser v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:156:48 [INFO] [stderr] | [INFO] [stderr] 156 | let mut sgn = if *mul < 0.0 {"-"} else {if eqn.len() > 0 {"+"} else {""}}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if eqn.len() > 0 {"+"} else {""}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:156:48 [INFO] [stderr] | [INFO] [stderr] 156 | let mut sgn = if *mul < 0.0 {"-"} else {if eqn.len() > 0 {"+"} else {""}}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if eqn.len() > 0 {"+"} else {""}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:36:34 [INFO] [stderr] | [INFO] [stderr] 36 | if !line.starts_with(" ") { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:118:18 [INFO] [stderr] | [INFO] [stderr] 118 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:119:37 [INFO] [stderr] | [INFO] [stderr] 119 | .push((var.clone(), multiplier.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*multiplier` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:132:25 [INFO] [stderr] | [INFO] [stderr] 132 | let etype = self.etypes.get(label).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.etypes[label]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:152:19 [INFO] [stderr] | [INFO] [stderr] 152 | fn make_eqn(terms:&TermList) -> String { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | / let mut mult = String::new(); [INFO] [stderr] 158 | | if mul.abs() != 1.0 { [INFO] [stderr] 159 | | mult = format!("{}*", mul.abs()).clone(); [INFO] [stderr] 160 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let mult = if mul.abs() != 1.0 { format!("{}*", mul.abs()).clone() } else { String::new() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:156:52 [INFO] [stderr] | [INFO] [stderr] 156 | let mut sgn = if *mul < 0.0 {"-"} else {if eqn.len() > 0 {"+"} else {""}}; [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!eqn.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | if mul.abs() != 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(mul.abs() - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | if mul.abs() != 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `mpsparser`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:36:34 [INFO] [stderr] | [INFO] [stderr] 36 | if !line.starts_with(" ") { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:118:18 [INFO] [stderr] | [INFO] [stderr] 118 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:119:37 [INFO] [stderr] | [INFO] [stderr] 119 | .push((var.clone(), multiplier.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*multiplier` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:132:25 [INFO] [stderr] | [INFO] [stderr] 132 | let etype = self.etypes.get(label).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.etypes[label]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:152:19 [INFO] [stderr] | [INFO] [stderr] 152 | fn make_eqn(terms:&TermList) -> String { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | / let mut mult = String::new(); [INFO] [stderr] 158 | | if mul.abs() != 1.0 { [INFO] [stderr] 159 | | mult = format!("{}*", mul.abs()).clone(); [INFO] [stderr] 160 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let mult = if mul.abs() != 1.0 { format!("{}*", mul.abs()).clone() } else { String::new() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:156:52 [INFO] [stderr] | [INFO] [stderr] 156 | let mut sgn = if *mul < 0.0 {"-"} else {if eqn.len() > 0 {"+"} else {""}}; [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!eqn.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | if mul.abs() != 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(mul.abs() - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | if mul.abs() != 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `mpsparser`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "85463e860c87417f0e86b456d46a4109add7d012534f18f31a8bd8a578f477cd"` [INFO] running `"docker" "rm" "-f" "85463e860c87417f0e86b456d46a4109add7d012534f18f31a8bd8a578f477cd"` [INFO] [stdout] 85463e860c87417f0e86b456d46a4109add7d012534f18f31a8bd8a578f477cd