[INFO] updating cached repository ahenry/udp-replicator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ahenry/udp-replicator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ahenry/udp-replicator" "work/ex/clippy-test-run/sources/stable/gh/ahenry/udp-replicator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ahenry/udp-replicator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ahenry/udp-replicator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahenry/udp-replicator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahenry/udp-replicator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1d6935a9c11ca332993a07f9deae54c74dfed0a6 [INFO] sha for GitHub repo ahenry/udp-replicator: 1d6935a9c11ca332993a07f9deae54c74dfed0a6 [INFO] validating manifest of ahenry/udp-replicator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ahenry/udp-replicator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ahenry/udp-replicator [INFO] finished frobbing ahenry/udp-replicator [INFO] frobbed toml for ahenry/udp-replicator written to work/ex/clippy-test-run/sources/stable/gh/ahenry/udp-replicator/Cargo.toml [INFO] started frobbing ahenry/udp-replicator [INFO] finished frobbing ahenry/udp-replicator [INFO] frobbed toml for ahenry/udp-replicator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahenry/udp-replicator/Cargo.toml [INFO] crate ahenry/udp-replicator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ahenry/udp-replicator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ahenry/udp-replicator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b979d97a79ca9e4048a45af0f7a708d3997b1e52d72968d8d361ebe0492f1a77 [INFO] running `"docker" "start" "-a" "b979d97a79ca9e4048a45af0f7a708d3997b1e52d72968d8d361ebe0492f1a77"` [INFO] [stderr] Compiling memchr v2.0.1 [INFO] [stderr] Checking pnet_sys v0.21.0 [INFO] [stderr] Compiling log v0.3.9 [INFO] [stderr] Compiling thread_local v0.3.5 [INFO] [stderr] Checking serde_yaml v0.7.4 [INFO] [stderr] Compiling serde_derive v1.0.63 [INFO] [stderr] Compiling syntex_errors v0.42.0 [INFO] [stderr] Compiling aho-corasick v0.6.4 [INFO] [stderr] Checking pnet_datalink v0.21.0 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Compiling syntex_syntax v0.42.0 [INFO] [stderr] Compiling syntex v0.42.2 [INFO] [stderr] Compiling pnet_macros v0.21.0 [INFO] [stderr] Compiling pnet_packet v0.21.0 [INFO] [stderr] Checking pnet_transport v0.21.0 [INFO] [stderr] Checking pnet v0.21.0 [INFO] [stderr] Checking udp-proxy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: variant is never constructed: `V6` [INFO] [stderr] --> src/main.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | V6(&'p Ipv6Packet<'p>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:30:47 [INFO] [stderr] | [INFO] [stderr] 30 | fn next_destinations(&self, destinations: &Vec) -> Vec; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Destination]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | / match dest { [INFO] [stderr] 49 | | &Destination::Address(sa) => ret.push(sa), [INFO] [stderr] 50 | | &Destination::Group(ref group) => ret.extend(group.get_balance_result()), [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | match *dest { [INFO] [stderr] 49 | Destination::Address(sa) => ret.push(sa), [INFO] [stderr] 50 | Destination::Group(ref group) => ret.extend(group.get_balance_result()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | / match dest { [INFO] [stderr] 89 | | &Destination::Address(sa) => ret.push(sa), [INFO] [stderr] 90 | | &Destination::Group(ref group) => ret.extend(group.get_balance_result()), [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 88 | match *dest { [INFO] [stderr] 89 | Destination::Address(sa) => ret.push(sa), [INFO] [stderr] 90 | Destination::Group(ref group) => ret.extend(group.get_balance_result()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `V6` [INFO] [stderr] --> src/main.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | V6(&'p Ipv6Packet<'p>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:30:47 [INFO] [stderr] | [INFO] [stderr] 30 | fn next_destinations(&self, destinations: &Vec) -> Vec; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Destination]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | / match dest { [INFO] [stderr] 49 | | &Destination::Address(sa) => ret.push(sa), [INFO] [stderr] 50 | | &Destination::Group(ref group) => ret.extend(group.get_balance_result()), [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | match *dest { [INFO] [stderr] 49 | Destination::Address(sa) => ret.push(sa), [INFO] [stderr] 50 | Destination::Group(ref group) => ret.extend(group.get_balance_result()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | / match dest { [INFO] [stderr] 89 | | &Destination::Address(sa) => ret.push(sa), [INFO] [stderr] 90 | | &Destination::Group(ref group) => ret.extend(group.get_balance_result()), [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 88 | match *dest { [INFO] [stderr] 89 | Destination::Address(sa) => ret.push(sa), [INFO] [stderr] 90 | Destination::Group(ref group) => ret.extend(group.get_balance_result()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 09s [INFO] running `"docker" "inspect" "b979d97a79ca9e4048a45af0f7a708d3997b1e52d72968d8d361ebe0492f1a77"` [INFO] running `"docker" "rm" "-f" "b979d97a79ca9e4048a45af0f7a708d3997b1e52d72968d8d361ebe0492f1a77"` [INFO] [stdout] b979d97a79ca9e4048a45af0f7a708d3997b1e52d72968d8d361ebe0492f1a77