[INFO] updating cached repository aheart/molecule-parser [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aheart/molecule-parser [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aheart/molecule-parser" "work/ex/clippy-test-run/sources/stable/gh/aheart/molecule-parser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aheart/molecule-parser'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aheart/molecule-parser" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aheart/molecule-parser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aheart/molecule-parser'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f2906c02ff4012176602e7e7d0dd75b3154402c2 [INFO] sha for GitHub repo aheart/molecule-parser: f2906c02ff4012176602e7e7d0dd75b3154402c2 [INFO] validating manifest of aheart/molecule-parser on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aheart/molecule-parser on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aheart/molecule-parser [INFO] finished frobbing aheart/molecule-parser [INFO] frobbed toml for aheart/molecule-parser written to work/ex/clippy-test-run/sources/stable/gh/aheart/molecule-parser/Cargo.toml [INFO] started frobbing aheart/molecule-parser [INFO] finished frobbing aheart/molecule-parser [INFO] frobbed toml for aheart/molecule-parser written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aheart/molecule-parser/Cargo.toml [INFO] crate aheart/molecule-parser has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aheart/molecule-parser against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/aheart/molecule-parser:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1e350e280ac1d914d2b3bd95dc2890981ac3befe65b165666d4cdf17b4c54459 [INFO] running `"docker" "start" "-a" "1e350e280ac1d914d2b3bd95dc2890981ac3befe65b165666d4cdf17b4c54459"` [INFO] [stderr] Checking molecule_parser v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/model.rs:17:31 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn mul_molecule(molecule: &Molecule, multiplier: usize) -> Molecule { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:54:26 [INFO] [stderr] | [INFO] [stderr] 54 | fn merge_atoms(molecule: &Molecule) -> Molecule { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/model.rs:17:31 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn mul_molecule(molecule: &Molecule, multiplier: usize) -> Molecule { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:54:26 [INFO] [stderr] | [INFO] [stderr] 54 | fn merge_atoms(molecule: &Molecule) -> Molecule { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:246:30 [INFO] [stderr] | [INFO] [stderr] 246 | fn molecules_compare(va: &Vec<(String, usize)>, vb: &Vec<(&str, usize)>) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, usize)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:246:57 [INFO] [stderr] | [INFO] [stderr] 246 | fn molecules_compare(va: &Vec<(String, usize)>, vb: &Vec<(&str, usize)>) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, usize)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.10s [INFO] running `"docker" "inspect" "1e350e280ac1d914d2b3bd95dc2890981ac3befe65b165666d4cdf17b4c54459"` [INFO] running `"docker" "rm" "-f" "1e350e280ac1d914d2b3bd95dc2890981ac3befe65b165666d4cdf17b4c54459"` [INFO] [stdout] 1e350e280ac1d914d2b3bd95dc2890981ac3befe65b165666d4cdf17b4c54459