[INFO] updating cached repository ahcometrue/rust-db [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ahcometrue/rust-db [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ahcometrue/rust-db" "work/ex/clippy-test-run/sources/stable/gh/ahcometrue/rust-db"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ahcometrue/rust-db'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ahcometrue/rust-db" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahcometrue/rust-db"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahcometrue/rust-db'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6df8b7e58210e8a37844f9db1d4cd7e9905c287d [INFO] sha for GitHub repo ahcometrue/rust-db: 6df8b7e58210e8a37844f9db1d4cd7e9905c287d [INFO] validating manifest of ahcometrue/rust-db on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ahcometrue/rust-db on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ahcometrue/rust-db [INFO] finished frobbing ahcometrue/rust-db [INFO] frobbed toml for ahcometrue/rust-db written to work/ex/clippy-test-run/sources/stable/gh/ahcometrue/rust-db/Cargo.toml [INFO] started frobbing ahcometrue/rust-db [INFO] finished frobbing ahcometrue/rust-db [INFO] frobbed toml for ahcometrue/rust-db written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ahcometrue/rust-db/Cargo.toml [INFO] crate ahcometrue/rust-db has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ahcometrue/rust-db against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ahcometrue/rust-db:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 361ba39e0e1e1feabfcc32a4f5687b0b5ccd154c096166d8e7b67506bb3b40f9 [INFO] running `"docker" "start" "-a" "361ba39e0e1e1feabfcc32a4f5687b0b5ccd154c096166d8e7b67506bb3b40f9"` [INFO] [stderr] Compiling serde v1.0.62 [INFO] [stderr] Checking rust-ini v0.11.0 [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Checking atoi v0.2.3 [INFO] [stderr] Checking twox-hash v1.1.0 [INFO] [stderr] Checking nix v0.10.0 [INFO] [stderr] Checking serde_json v1.0.18 [INFO] [stderr] Checking mysql_common v0.7.0 [INFO] [stderr] Checking mysql v13.1.0 [INFO] [stderr] Checking rust_db v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/conf/env.rs:8:21 [INFO] [stderr] | [INFO] [stderr] 8 | const CONFIG_DIR : &'static str = "config/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/conf/config.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn new () -> Result { [INFO] [stderr] 29 | | let mut builder = OptsBuilder::new(); [INFO] [stderr] 30 | | [INFO] [stderr] 31 | | let _section_name = get_env() + ":common"; [INFO] [stderr] ... | [INFO] [stderr] 49 | | Ok(builder.into()) [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/conf/env.rs:8:21 [INFO] [stderr] | [INFO] [stderr] 8 | const CONFIG_DIR : &'static str = "config/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/conf/config.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn new () -> Result { [INFO] [stderr] 29 | | let mut builder = OptsBuilder::new(); [INFO] [stderr] 30 | | [INFO] [stderr] 31 | | let _section_name = get_env() + ":common"; [INFO] [stderr] ... | [INFO] [stderr] 49 | | Ok(builder.into()) [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 43.78s [INFO] running `"docker" "inspect" "361ba39e0e1e1feabfcc32a4f5687b0b5ccd154c096166d8e7b67506bb3b40f9"` [INFO] running `"docker" "rm" "-f" "361ba39e0e1e1feabfcc32a4f5687b0b5ccd154c096166d8e7b67506bb3b40f9"` [INFO] [stdout] 361ba39e0e1e1feabfcc32a4f5687b0b5ccd154c096166d8e7b67506bb3b40f9