[INFO] updating cached repository agmcleod/sc-predictions-server [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/agmcleod/sc-predictions-server [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/agmcleod/sc-predictions-server" "work/ex/clippy-test-run/sources/stable/gh/agmcleod/sc-predictions-server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/agmcleod/sc-predictions-server'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/agmcleod/sc-predictions-server" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/agmcleod/sc-predictions-server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/agmcleod/sc-predictions-server'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] be9b3129a5a314b3118b1a70f10c2b69293fe760 [INFO] sha for GitHub repo agmcleod/sc-predictions-server: be9b3129a5a314b3118b1a70f10c2b69293fe760 [INFO] validating manifest of agmcleod/sc-predictions-server on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of agmcleod/sc-predictions-server on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing agmcleod/sc-predictions-server [INFO] finished frobbing agmcleod/sc-predictions-server [INFO] frobbed toml for agmcleod/sc-predictions-server written to work/ex/clippy-test-run/sources/stable/gh/agmcleod/sc-predictions-server/Cargo.toml [INFO] started frobbing agmcleod/sc-predictions-server [INFO] finished frobbing agmcleod/sc-predictions-server [INFO] frobbed toml for agmcleod/sc-predictions-server written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/agmcleod/sc-predictions-server/Cargo.toml [INFO] crate agmcleod/sc-predictions-server has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting agmcleod/sc-predictions-server against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/agmcleod/sc-predictions-server:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3eb2910799007b5656c8aaf30024423b072263a58b4cd64093c70cde2927da5e [INFO] running `"docker" "start" "-a" "3eb2910799007b5656c8aaf30024423b072263a58b4cd64093c70cde2927da5e"` [INFO] [stderr] warning: dependency (chrono) specified without providing a local path, Git repository, or version to use. This will be considered an error in future versions [INFO] [stderr] warning: unused manifest key: dependencies.chrono.versiob [INFO] [stderr] Checking radix v0.4.1 [INFO] [stderr] Compiling actix-web v0.7.12 [INFO] [stderr] Checking crossbeam-epoch v0.5.2 [INFO] [stderr] Checking crossbeam-epoch v0.6.0 [INFO] [stderr] Checking ring v0.13.2 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Compiling postgres-mapper-derive v0.1.0 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking regex v1.0.5 [INFO] [stderr] Checking postgres-protocol v0.3.2 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking crossbeam-deque v0.6.1 [INFO] [stderr] Checking tokio-threadpool v0.1.7 [INFO] [stderr] Checking postgres-shared v0.4.2 [INFO] [stderr] Checking cookie v0.11.0 [INFO] [stderr] Checking tokio-uds v0.2.2 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-signal v0.2.5 [INFO] [stderr] Checking dotenv v0.9.0 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking trust-dns-proto v0.4.3 [INFO] [stderr] Checking trust-dns-proto v0.5.0-alpha.3 [INFO] [stderr] Checking postgres v0.15.2 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Checking postgres-mapper v0.1.0 [INFO] [stderr] Checking r2d2_postgres v0.14.0 [INFO] [stderr] Checking trust-dns-resolver v0.9.1 [INFO] [stderr] Checking trust-dns-resolver v0.10.0-alpha.3 [INFO] [stderr] Checking actix v0.7.5 [INFO] [stderr] Checking actix-net v0.1.1 [INFO] [stderr] Checking sc-predictions-server v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `TimeZone`, `Utc` [INFO] [stderr] --> src/routes/games/create.rs:56:18 [INFO] [stderr] | [INFO] [stderr] 56 | use chrono::{TimeZone, Utc}; [INFO] [stderr] | ^^^^^^^^ ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils/mod.rs:40:40 [INFO] [stderr] | [INFO] [stderr] 40 | let slug = create_slug_from_id(439483745); [INFO] [stderr] | ^^^^^^^^^ help: consider: `439_483_745` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `HttpMessage` [INFO] [stderr] --> src/main.rs:70:45 [INFO] [stderr] | [INFO] [stderr] 70 | use actix_web::{http, test::TestServer, HttpMessage}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `create` [INFO] [stderr] --> src/db/models/game_question.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn create(conn: &PgConnection, game_id: i32, question_id: i32) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `NoRecord` [INFO] [stderr] --> src/errors.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | NoRecord, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `join_ids` [INFO] [stderr] --> src/routes/games/create.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | join_ids: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/db/models/question.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | .map(|row| Question::from_postgres_row(row)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Question::from_postgres_row` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/errors.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / match self { [INFO] [stderr] 21 | | &Error::DBError(ref err) => write!(f, "DB Error: {:?}", err), [INFO] [stderr] 22 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 20 | match *self { [INFO] [stderr] 21 | Error::DBError(ref err) => write!(f, "DB Error: {:?}", err), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: method is never used: `create` [INFO] [stderr] --> src/db/models/game_question.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn create(conn: &PgConnection, game_id: i32, question_id: i32) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `NoRecord` [INFO] [stderr] --> src/errors.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | NoRecord, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `join_ids` [INFO] [stderr] --> src/routes/games/create.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | join_ids: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/db/models/question.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | .map(|row| Question::from_postgres_row(row)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Question::from_postgres_row` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/errors.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / match self { [INFO] [stderr] 21 | | &Error::DBError(ref err) => write!(f, "DB Error: {:?}", err), [INFO] [stderr] 22 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 20 | match *self { [INFO] [stderr] 21 | Error::DBError(ref err) => write!(f, "DB Error: {:?}", err), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | env_logger::try_init(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 22s [INFO] running `"docker" "inspect" "3eb2910799007b5656c8aaf30024423b072263a58b4cd64093c70cde2927da5e"` [INFO] running `"docker" "rm" "-f" "3eb2910799007b5656c8aaf30024423b072263a58b4cd64093c70cde2927da5e"` [INFO] [stdout] 3eb2910799007b5656c8aaf30024423b072263a58b4cd64093c70cde2927da5e