[INFO] updating cached repository aergonaut/artifice
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/aergonaut/artifice
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/aergonaut/artifice" "work/ex/clippy-test-run/sources/stable/gh/aergonaut/artifice"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aergonaut/artifice'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/aergonaut/artifice" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aergonaut/artifice"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aergonaut/artifice'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c9ccab771ea7f0756a9e0b89f478ef9b7a9c7276
[INFO] sha for GitHub repo aergonaut/artifice: c9ccab771ea7f0756a9e0b89f478ef9b7a9c7276
[INFO] validating manifest of aergonaut/artifice on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of aergonaut/artifice on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing aergonaut/artifice
[INFO] finished frobbing aergonaut/artifice
[INFO] frobbed toml for aergonaut/artifice written to work/ex/clippy-test-run/sources/stable/gh/aergonaut/artifice/Cargo.toml
[INFO] started frobbing aergonaut/artifice
[INFO] finished frobbing aergonaut/artifice
[INFO] frobbed toml for aergonaut/artifice written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aergonaut/artifice/Cargo.toml
[INFO] crate aergonaut/artifice has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting aergonaut/artifice against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/aergonaut/artifice:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 277d3c3b30f583f7e2a225d9815d7130c9f73ff92973e5e6e3fd3d34cf9efab9
[INFO] running `"docker" "start" "-a" "277d3c3b30f583f7e2a225d9815d7130c9f73ff92973e5e6e3fd3d34cf9efab9"`
[INFO] [stderr]    Compiling cmake v0.1.29
[INFO] [stderr]     Checking toml v0.4.5
[INFO] [stderr]     Checking fern v0.5.5
[INFO] [stderr]     Checking prettytable-rs v0.6.7
[INFO] [stderr]    Compiling curl-sys v0.4.1
[INFO] [stderr]     Checking serde_urlencoded v0.5.1
[INFO] [stderr]    Compiling structopt-derive v0.2.6
[INFO] [stderr]    Compiling libssh2-sys v0.2.6
[INFO] [stderr]    Compiling libgit2-sys v0.7.1
[INFO] [stderr]     Checking reqwest v0.8.5
[INFO] [stderr]     Checking structopt v0.2.6
[INFO] [stderr]     Checking git2 v0.7.1
[INFO] [stderr]     Checking artifice v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/jira.rs:19:16
[INFO] [stderr]    |
[INFO] [stderr] 19 |         Jira { config: config }
[INFO] [stderr]    |                ^^^^^^^^^^^^^^ help: replace it with: `config`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/jira.rs:19:16
[INFO] [stderr]    |
[INFO] [stderr] 19 |         Jira { config: config }
[INFO] [stderr]    |                ^^^^^^^^^^^^^^ help: replace it with: `config`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/commands/start.rs:69:9
[INFO] [stderr]    |
[INFO] [stderr] 69 |         return Err(format_err!("HEAD is not a branch"));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("HEAD is not a branch"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/jira.rs:7:29
[INFO] [stderr]   |
[INFO] [stderr] 7 | pub const OPEN_ISSUES_JQL: &'static str = r#"
[INFO] [stderr]   |                            -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/jira.rs:11:43
[INFO] [stderr]    |
[INFO] [stderr] 11 | pub const PROPAGATION_SUBTASK_ISSUETYPE: &'static str = "10600";
[INFO] [stderr]    |                                          -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/config.rs:41:24
[INFO] [stderr]    |
[INFO] [stderr] 41 |         let home_dir = std::env::home_dir().ok_or(err_msg("Could not find user's home directory"))?;
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/commands/start.rs:69:9
[INFO] [stderr]    |
[INFO] [stderr] 69 |         return Err(format_err!("HEAD is not a branch"));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("HEAD is not a branch"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/jira.rs:7:29
[INFO] [stderr]   |
[INFO] [stderr] 7 | pub const OPEN_ISSUES_JQL: &'static str = r#"
[INFO] [stderr]   |                            -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/jira.rs:11:43
[INFO] [stderr]    |
[INFO] [stderr] 11 | pub const PROPAGATION_SUBTASK_ISSUETYPE: &'static str = "10600";
[INFO] [stderr]    |                                          -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/config.rs:41:24
[INFO] [stderr]    |
[INFO] [stderr] 41 |         let home_dir = std::env::home_dir().ok_or(err_msg("Could not find user's home directory"))?;
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/commands/start.rs:30:5
[INFO] [stderr]    |
[INFO] [stderr] 30 |     let _ = checkout_branch(&repo, &new_branch)?;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/commands/start.rs:61:1
[INFO] [stderr]    |
[INFO] [stderr] 61 | / fn get_current_branch_name<'repo>(repo: &'repo git2::Repository) -> Result<String, Error> {
[INFO] [stderr] 62 | |     let head_ref = repo.head()?;
[INFO] [stderr] 63 | |     if head_ref.is_branch() {
[INFO] [stderr] 64 | |         head_ref
[INFO] [stderr] ...  |
[INFO] [stderr] 70 | |     }
[INFO] [stderr] 71 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/commands/start.rs:121:19
[INFO] [stderr]     |
[INFO] [stderr] 121 |         return Ok(repo.set_head(&ref_name)?);
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 121 |         return Ok(());
[INFO] [stderr]     |                   ^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/config.rs:25:27
[INFO] [stderr]    |
[INFO] [stderr] 25 |           let config_path = match path {
[INFO] [stderr]    |  ___________________________^
[INFO] [stderr] 26 | |             &Some(ref path) => path.clone(),
[INFO] [stderr] 27 | |             &None => Config::default_config()?,
[INFO] [stderr] 28 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 25 |         let config_path = match *path {
[INFO] [stderr] 26 |             Some(ref path) => path.clone(),
[INFO] [stderr] 27 |             None => Config::default_config()?,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/config.rs:41:45
[INFO] [stderr]    |
[INFO] [stderr] 41 |         let home_dir = std::env::home_dir().ok_or(err_msg("Could not find user's home directory"))?;
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("Could not find user's home directory"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/commands/start.rs:30:5
[INFO] [stderr]    |
[INFO] [stderr] 30 |     let _ = checkout_branch(&repo, &new_branch)?;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/commands/start.rs:61:1
[INFO] [stderr]    |
[INFO] [stderr] 61 | / fn get_current_branch_name<'repo>(repo: &'repo git2::Repository) -> Result<String, Error> {
[INFO] [stderr] 62 | |     let head_ref = repo.head()?;
[INFO] [stderr] 63 | |     if head_ref.is_branch() {
[INFO] [stderr] 64 | |         head_ref
[INFO] [stderr] ...  |
[INFO] [stderr] 70 | |     }
[INFO] [stderr] 71 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/commands/start.rs:121:19
[INFO] [stderr]     |
[INFO] [stderr] 121 |         return Ok(repo.set_head(&ref_name)?);
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 121 |         return Ok(());
[INFO] [stderr]     |                   ^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/config.rs:25:27
[INFO] [stderr]    |
[INFO] [stderr] 25 |           let config_path = match path {
[INFO] [stderr]    |  ___________________________^
[INFO] [stderr] 26 | |             &Some(ref path) => path.clone(),
[INFO] [stderr] 27 | |             &None => Config::default_config()?,
[INFO] [stderr] 28 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 25 |         let config_path = match *path {
[INFO] [stderr] 26 |             Some(ref path) => path.clone(),
[INFO] [stderr] 27 |             None => Config::default_config()?,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/config.rs:41:45
[INFO] [stderr]    |
[INFO] [stderr] 41 |         let home_dir = std::env::home_dir().ok_or(err_msg("Could not find user's home directory"))?;
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("Could not find user's home directory"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3m 36s
[INFO] running `"docker" "inspect" "277d3c3b30f583f7e2a225d9815d7130c9f73ff92973e5e6e3fd3d34cf9efab9"`
[INFO] running `"docker" "rm" "-f" "277d3c3b30f583f7e2a225d9815d7130c9f73ff92973e5e6e3fd3d34cf9efab9"`
[INFO] [stdout] 277d3c3b30f583f7e2a225d9815d7130c9f73ff92973e5e6e3fd3d34cf9efab9