[INFO] updating cached repository aechan/rust-sort [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aechan/rust-sort [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aechan/rust-sort" "work/ex/clippy-test-run/sources/stable/gh/aechan/rust-sort"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aechan/rust-sort'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aechan/rust-sort" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aechan/rust-sort"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aechan/rust-sort'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d75364cb33ae2607b37789bdb8387b136e59d45c [INFO] sha for GitHub repo aechan/rust-sort: d75364cb33ae2607b37789bdb8387b136e59d45c [INFO] validating manifest of aechan/rust-sort on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aechan/rust-sort on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aechan/rust-sort [INFO] finished frobbing aechan/rust-sort [INFO] frobbed toml for aechan/rust-sort written to work/ex/clippy-test-run/sources/stable/gh/aechan/rust-sort/Cargo.toml [INFO] started frobbing aechan/rust-sort [INFO] finished frobbing aechan/rust-sort [INFO] frobbed toml for aechan/rust-sort written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aechan/rust-sort/Cargo.toml [INFO] crate aechan/rust-sort has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aechan/rust-sort against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/aechan/rust-sort:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4827e4042fd979600d0cd7688b746f12e5ec4ceadd407672978ecafb68294c5d [INFO] running `"docker" "start" "-a" "4827e4042fd979600d0cd7688b746f12e5ec4ceadd407672978ecafb68294c5d"` [INFO] [stderr] Checking hello v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | SortData { data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | SortData { data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | j=j-1; [INFO] [stderr] | ^^^^^ help: replace it with: `j -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `input` manually [INFO] [stderr] --> src/main.rs:60:21 [INFO] [stderr] | [INFO] [stderr] 60 | / let temp = input[j]; [INFO] [stderr] 61 | | input[j] = input[j+1]; [INFO] [stderr] 62 | | input[j+1] = temp; [INFO] [stderr] | |_____________________________________^ help: try: `input.swap(j, j+1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | j=j-1; [INFO] [stderr] | ^^^^^ help: replace it with: `j -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `input` manually [INFO] [stderr] --> src/main.rs:60:21 [INFO] [stderr] | [INFO] [stderr] 60 | / let temp = input[j]; [INFO] [stderr] 61 | | input[j] = input[j+1]; [INFO] [stderr] 62 | | input[j+1] = temp; [INFO] [stderr] | |_____________________________________^ help: try: `input.swap(j, j+1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.04s [INFO] running `"docker" "inspect" "4827e4042fd979600d0cd7688b746f12e5ec4ceadd407672978ecafb68294c5d"` [INFO] running `"docker" "rm" "-f" "4827e4042fd979600d0cd7688b746f12e5ec4ceadd407672978ecafb68294c5d"` [INFO] [stdout] 4827e4042fd979600d0cd7688b746f12e5ec4ceadd407672978ecafb68294c5d