[INFO] updating cached repository adventofjuan/AdventOfCode2018-Day04 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/adventofjuan/AdventOfCode2018-Day04 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/adventofjuan/AdventOfCode2018-Day04" "work/ex/clippy-test-run/sources/stable/gh/adventofjuan/AdventOfCode2018-Day04"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/adventofjuan/AdventOfCode2018-Day04'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/adventofjuan/AdventOfCode2018-Day04" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adventofjuan/AdventOfCode2018-Day04"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adventofjuan/AdventOfCode2018-Day04'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c089fafc05e90e062f91f05f4a718bcc6f8865f3 [INFO] sha for GitHub repo adventofjuan/AdventOfCode2018-Day04: c089fafc05e90e062f91f05f4a718bcc6f8865f3 [INFO] validating manifest of adventofjuan/AdventOfCode2018-Day04 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of adventofjuan/AdventOfCode2018-Day04 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing adventofjuan/AdventOfCode2018-Day04 [INFO] finished frobbing adventofjuan/AdventOfCode2018-Day04 [INFO] frobbed toml for adventofjuan/AdventOfCode2018-Day04 written to work/ex/clippy-test-run/sources/stable/gh/adventofjuan/AdventOfCode2018-Day04/Cargo.toml [INFO] started frobbing adventofjuan/AdventOfCode2018-Day04 [INFO] finished frobbing adventofjuan/AdventOfCode2018-Day04 [INFO] frobbed toml for adventofjuan/AdventOfCode2018-Day04 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adventofjuan/AdventOfCode2018-Day04/Cargo.toml [INFO] crate adventofjuan/AdventOfCode2018-Day04 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting adventofjuan/AdventOfCode2018-Day04 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/adventofjuan/AdventOfCode2018-Day04:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9f6510761e93488e9fd1836768626f3e175e5b3499e59ccdd21dee1cfac22772 [INFO] running `"docker" "start" "-a" "9f6510761e93488e9fd1836768626f3e175e5b3499e59ccdd21dee1cfac22772"` [INFO] [stderr] Checking advent04 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | id [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:18:14 [INFO] [stderr] | [INFO] [stderr] 18 | let id = split[0].parse::().expect("Could not parse id"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:17:27 [INFO] [stderr] | [INFO] [stderr] 17 | let split = val.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `minutes_arr` [INFO] [stderr] --> src/main.rs:89:14 [INFO] [stderr] | [INFO] [stderr] 89 | for i in 0..minutes_arr.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 89 | for (i, ) in minutes_arr.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `minutes_arr` [INFO] [stderr] --> src/main.rs:106:18 [INFO] [stderr] | [INFO] [stderr] 106 | for i in 0..minutes_arr.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 106 | for (i, ) in minutes_arr.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | id [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:18:14 [INFO] [stderr] | [INFO] [stderr] 18 | let id = split[0].parse::().expect("Could not parse id"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:17:27 [INFO] [stderr] | [INFO] [stderr] 17 | let split = val.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `minutes_arr` [INFO] [stderr] --> src/main.rs:89:14 [INFO] [stderr] | [INFO] [stderr] 89 | for i in 0..minutes_arr.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 89 | for (i, ) in minutes_arr.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `minutes_arr` [INFO] [stderr] --> src/main.rs:106:18 [INFO] [stderr] | [INFO] [stderr] 106 | for i in 0..minutes_arr.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 106 | for (i, ) in minutes_arr.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.44s [INFO] running `"docker" "inspect" "9f6510761e93488e9fd1836768626f3e175e5b3499e59ccdd21dee1cfac22772"` [INFO] running `"docker" "rm" "-f" "9f6510761e93488e9fd1836768626f3e175e5b3499e59ccdd21dee1cfac22772"` [INFO] [stdout] 9f6510761e93488e9fd1836768626f3e175e5b3499e59ccdd21dee1cfac22772