[INFO] updating cached repository adventofjuan/AdventOfCode2018-Day02 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/adventofjuan/AdventOfCode2018-Day02 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/adventofjuan/AdventOfCode2018-Day02" "work/ex/clippy-test-run/sources/stable/gh/adventofjuan/AdventOfCode2018-Day02"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/adventofjuan/AdventOfCode2018-Day02'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/adventofjuan/AdventOfCode2018-Day02" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adventofjuan/AdventOfCode2018-Day02"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adventofjuan/AdventOfCode2018-Day02'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4f1ec6d1080d1c7549902295aa13266d3b162b8a [INFO] sha for GitHub repo adventofjuan/AdventOfCode2018-Day02: 4f1ec6d1080d1c7549902295aa13266d3b162b8a [INFO] validating manifest of adventofjuan/AdventOfCode2018-Day02 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of adventofjuan/AdventOfCode2018-Day02 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing adventofjuan/AdventOfCode2018-Day02 [INFO] finished frobbing adventofjuan/AdventOfCode2018-Day02 [INFO] frobbed toml for adventofjuan/AdventOfCode2018-Day02 written to work/ex/clippy-test-run/sources/stable/gh/adventofjuan/AdventOfCode2018-Day02/Cargo.toml [INFO] started frobbing adventofjuan/AdventOfCode2018-Day02 [INFO] finished frobbing adventofjuan/AdventOfCode2018-Day02 [INFO] frobbed toml for adventofjuan/AdventOfCode2018-Day02 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adventofjuan/AdventOfCode2018-Day02/Cargo.toml [INFO] crate adventofjuan/AdventOfCode2018-Day02 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting adventofjuan/AdventOfCode2018-Day02 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/adventofjuan/AdventOfCode2018-Day02:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b12af89593432052a506daa6e7682e33e7207dad0d554289a20f6e5146119a07 [INFO] running `"docker" "start" "-a" "b12af89593432052a506daa6e7682e33e7207dad0d554289a20f6e5146119a07"` [INFO] [stderr] Checking advent02 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:14:20 [INFO] [stderr] | [INFO] [stderr] 14 | fn part01(values : &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/main.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | / if count.contains_key(&c) { [INFO] [stderr] 22 | | let entry = count.entry(c).or_insert(0); [INFO] [stderr] 23 | | *entry += 1; [INFO] [stderr] 24 | | } else { [INFO] [stderr] 25 | | count.insert(c, 1); [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____________^ help: consider using: `count.entry(c)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/main.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | for (_, cnt) in &count { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 31 | for cnt in count.values() { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:45:20 [INFO] [stderr] | [INFO] [stderr] 45 | fn part02(values : &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `partner_idx` is used to index `values` [INFO] [stderr] --> src/main.rs:54:28 [INFO] [stderr] | [INFO] [stderr] 54 | for partner_idx in (line_idx+1)..values.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 54 | for (partner_idx, ) in values.iter().enumerate().skip((line_idx+1)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/main.rs:57:20 [INFO] [stderr] | [INFO] [stderr] 57 | if &line[chr..chr+1] == &partner[chr..chr+1] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 57 | if line[chr..chr+1] == partner[chr..chr+1] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:57:26 [INFO] [stderr] | [INFO] [stderr] 57 | if &line[chr..chr+1] == &partner[chr..chr+1] { [INFO] [stderr] | ^^^^^^^^^^ help: use: `chr..=chr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:57:50 [INFO] [stderr] | [INFO] [stderr] 57 | if &line[chr..chr+1] == &partner[chr..chr+1] { [INFO] [stderr] | ^^^^^^^^^^ help: use: `chr..=chr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/main.rs:73:12 [INFO] [stderr] | [INFO] [stderr] 73 | if &line[chr..chr+1] == &partner[chr..chr+1] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 73 | if line[chr..chr+1] == partner[chr..chr+1] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:73:18 [INFO] [stderr] | [INFO] [stderr] 73 | if &line[chr..chr+1] == &partner[chr..chr+1] { [INFO] [stderr] | ^^^^^^^^^^ help: use: `chr..=chr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:73:42 [INFO] [stderr] | [INFO] [stderr] 73 | if &line[chr..chr+1] == &partner[chr..chr+1] { [INFO] [stderr] | ^^^^^^^^^^ help: use: `chr..=chr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:74:32 [INFO] [stderr] | [INFO] [stderr] 74 | print!("{}", &line[chr..chr+1]); [INFO] [stderr] | ^^^^^^^^^^ help: use: `chr..=chr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:14:20 [INFO] [stderr] | [INFO] [stderr] 14 | fn part01(values : &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/main.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | / if count.contains_key(&c) { [INFO] [stderr] 22 | | let entry = count.entry(c).or_insert(0); [INFO] [stderr] 23 | | *entry += 1; [INFO] [stderr] 24 | | } else { [INFO] [stderr] 25 | | count.insert(c, 1); [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____________^ help: consider using: `count.entry(c)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/main.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | for (_, cnt) in &count { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 31 | for cnt in count.values() { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:45:20 [INFO] [stderr] | [INFO] [stderr] 45 | fn part02(values : &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `partner_idx` is used to index `values` [INFO] [stderr] --> src/main.rs:54:28 [INFO] [stderr] | [INFO] [stderr] 54 | for partner_idx in (line_idx+1)..values.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 54 | for (partner_idx, ) in values.iter().enumerate().skip((line_idx+1)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/main.rs:57:20 [INFO] [stderr] | [INFO] [stderr] 57 | if &line[chr..chr+1] == &partner[chr..chr+1] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 57 | if line[chr..chr+1] == partner[chr..chr+1] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:57:26 [INFO] [stderr] | [INFO] [stderr] 57 | if &line[chr..chr+1] == &partner[chr..chr+1] { [INFO] [stderr] | ^^^^^^^^^^ help: use: `chr..=chr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:57:50 [INFO] [stderr] | [INFO] [stderr] 57 | if &line[chr..chr+1] == &partner[chr..chr+1] { [INFO] [stderr] | ^^^^^^^^^^ help: use: `chr..=chr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/main.rs:73:12 [INFO] [stderr] | [INFO] [stderr] 73 | if &line[chr..chr+1] == &partner[chr..chr+1] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 73 | if line[chr..chr+1] == partner[chr..chr+1] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:73:18 [INFO] [stderr] | [INFO] [stderr] 73 | if &line[chr..chr+1] == &partner[chr..chr+1] { [INFO] [stderr] | ^^^^^^^^^^ help: use: `chr..=chr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:73:42 [INFO] [stderr] | [INFO] [stderr] 73 | if &line[chr..chr+1] == &partner[chr..chr+1] { [INFO] [stderr] | ^^^^^^^^^^ help: use: `chr..=chr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:74:32 [INFO] [stderr] | [INFO] [stderr] 74 | print!("{}", &line[chr..chr+1]); [INFO] [stderr] | ^^^^^^^^^^ help: use: `chr..=chr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.02s [INFO] running `"docker" "inspect" "b12af89593432052a506daa6e7682e33e7207dad0d554289a20f6e5146119a07"` [INFO] running `"docker" "rm" "-f" "b12af89593432052a506daa6e7682e33e7207dad0d554289a20f6e5146119a07"` [INFO] [stdout] b12af89593432052a506daa6e7682e33e7207dad0d554289a20f6e5146119a07