[INFO] updating cached repository adumbidiot/scratch-native [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/adumbidiot/scratch-native [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/adumbidiot/scratch-native" "work/ex/clippy-test-run/sources/stable/gh/adumbidiot/scratch-native"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/adumbidiot/scratch-native'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/adumbidiot/scratch-native" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adumbidiot/scratch-native"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adumbidiot/scratch-native'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] aa1c590358918be0982e89773f5ffe2f5b434da4 [INFO] sha for GitHub repo adumbidiot/scratch-native: aa1c590358918be0982e89773f5ffe2f5b434da4 [INFO] validating manifest of adumbidiot/scratch-native on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of adumbidiot/scratch-native on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing adumbidiot/scratch-native [INFO] finished frobbing adumbidiot/scratch-native [INFO] frobbed toml for adumbidiot/scratch-native written to work/ex/clippy-test-run/sources/stable/gh/adumbidiot/scratch-native/Cargo.toml [INFO] started frobbing adumbidiot/scratch-native [INFO] finished frobbing adumbidiot/scratch-native [INFO] frobbed toml for adumbidiot/scratch-native written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adumbidiot/scratch-native/Cargo.toml [INFO] crate adumbidiot/scratch-native has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting adumbidiot/scratch-native against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/adumbidiot/scratch-native:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d22063c4cd1cc16462a0a4f1519fa46434e497c1dffd4bf86397510727f2e1c0 [INFO] running `"docker" "start" "-a" "d22063c4cd1cc16462a0a4f1519fa46434e497c1dffd4bf86397510727f2e1c0"` [INFO] [stderr] Checking socket2 v0.3.8 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking curl v0.4.19 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Checking tokio-signal v0.2.7 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking tokio-process v0.2.3 [INFO] [stderr] Checking hyper v0.12.16 [INFO] [stderr] Checking scratch-native v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Future`, `self` [INFO] [stderr] --> src/main.rs:13:17 [INFO] [stderr] | [INFO] [stderr] 13 | use hyper::rt::{self, Future}; [INFO] [stderr] | ^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/scratch/templates.rs:3:32 [INFO] [stderr] | [INFO] [stderr] 3 | const PISTON_TEMPLATE_FRAG_1: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/scratch/templates.rs:11:32 [INFO] [stderr] | [INFO] [stderr] 11 | const PISTON_TEMPLATE_FRAG_2: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Serialize`, `Serializer` [INFO] [stderr] --> src/scratch/api/types/json.rs:1:40 [INFO] [stderr] | [INFO] [stderr] 1 | use serde::{Deserializer, Deserialize, Serialize, Serializer}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `PlaySoundAndWait` [INFO] [stderr] --> src/scratch/api/types/json.rs:8:20 [INFO] [stderr] | [INFO] [stderr] 8 | use super::{Block, PlaySoundAndWait}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/scratch/api/types/json.rs:156:18 [INFO] [stderr] | [INFO] [stderr] 156 | const FIELDS: &'static [&'static str] = &["x", "y", "blocks"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/scratch/api/types/json.rs:156:28 [INFO] [stderr] | [INFO] [stderr] 156 | const FIELDS: &'static [&'static str] = &["x", "y", "blocks"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/json.rs:176:3 [INFO] [stderr] | [INFO] [stderr] 176 | return Ok(ScriptJson{ [INFO] [stderr] | _________^ [INFO] [stderr] 177 | | x, [INFO] [stderr] 178 | | y, [INFO] [stderr] 179 | | blocks, [INFO] [stderr] 180 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 176 | Ok(ScriptJson{ [INFO] [stderr] 177 | x, [INFO] [stderr] 178 | y, [INFO] [stderr] 179 | blocks, [INFO] [stderr] 180 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/json.rs:223:9 [INFO] [stderr] | [INFO] [stderr] 223 | / return Ok(ScriptJson{ [INFO] [stderr] 224 | | x, [INFO] [stderr] 225 | | y, [INFO] [stderr] 226 | | blocks, [INFO] [stderr] 227 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 223 | Ok(ScriptJson{ [INFO] [stderr] 224 | x, [INFO] [stderr] 225 | y, [INFO] [stderr] 226 | blocks, [INFO] [stderr] 227 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/block.rs:57:3 [INFO] [stderr] | [INFO] [stderr] 57 | return match elements [INFO] [stderr] | _________^ [INFO] [stderr] 58 | | .get(0) [INFO] [stderr] 59 | | .ok_or(serde::de::Error::invalid_length(0, &self))? [INFO] [stderr] 60 | | .as_str(){ [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 57 | match elements [INFO] [stderr] 58 | .get(0) [INFO] [stderr] 59 | .ok_or(serde::de::Error::invalid_length(0, &self))? [INFO] [stderr] 60 | .as_str(){ [INFO] [stderr] 61 | "whenGreenFlag" => { [INFO] [stderr] 62 | Ok(Block::WhenStart) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/block.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | return Ok(Block::WhenStart); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Block::WhenStart)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/block.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | return Err(serde::de::Error::invalid_value(serde::de::Unexpected::Str(v), &self)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(serde::de::Error::invalid_value(serde::de::Unexpected::Str(v), &self))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/block.rs:108:3 [INFO] [stderr] | [INFO] [stderr] 108 | return Ok(Block::WhenStart); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Block::WhenStart)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/mod.rs:48:3 [INFO] [stderr] | [INFO] [stderr] 48 | return Ok(project); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(project)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/mod.rs:52:3 [INFO] [stderr] | [INFO] [stderr] 52 | return Some(self.name.get_or_insert("scratch_".to_string() + self.code.as_ref()?)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.name.get_or_insert("scratch_".to_string() + self.code.as_ref()?))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/mod.rs:58:3 [INFO] [stderr] | [INFO] [stderr] 58 | return path; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/mod.rs:128:3 [INFO] [stderr] | [INFO] [stderr] 128 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/mod.rs:137:3 [INFO] [stderr] | [INFO] [stderr] 137 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/mod.rs:146:3 [INFO] [stderr] | [INFO] [stderr] 146 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/mod.rs:155:3 [INFO] [stderr] | [INFO] [stderr] 155 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/mod.rs:163:3 [INFO] [stderr] | [INFO] [stderr] 163 | return p; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/targets.rs:114:3 [INFO] [stderr] | [INFO] [stderr] 114 | return main_js; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `main_js` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/targets.rs:127:3 [INFO] [stderr] | [INFO] [stderr] 127 | return total; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/targets.rs:146:3 [INFO] [stderr] | [INFO] [stderr] 146 | return total; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/targets.rs:152:3 [INFO] [stderr] | [INFO] [stderr] 152 | return "js"; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `"js"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/targets.rs:236:3 [INFO] [stderr] | [INFO] [stderr] 236 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/targets.rs:240:3 [INFO] [stderr] | [INFO] [stderr] 240 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/targets.rs:261:3 [INFO] [stderr] | [INFO] [stderr] 261 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/mod.rs:13:3 [INFO] [stderr] | [INFO] [stderr] 13 | return Self { [INFO] [stderr] | _________^ [INFO] [stderr] 14 | | handle: Easy2::new(BufferBody::new()) [INFO] [stderr] 15 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 13 | Self { [INFO] [stderr] 14 | handle: Easy2::new(BufferBody::new()) [INFO] [stderr] 15 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/mod.rs:25:3 [INFO] [stderr] | [INFO] [stderr] 25 | return Ok(body); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(body)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/mod.rs:32:3 [INFO] [stderr] | [INFO] [stderr] 32 | return Ok(stats); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(stats)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/mod.rs:39:3 [INFO] [stderr] | [INFO] [stderr] 39 | return Ok(project_json); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(project_json)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/mod.rs:50:3 [INFO] [stderr] | [INFO] [stderr] 50 | return Ok(project); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(project)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/mod.rs:55:3 [INFO] [stderr] | [INFO] [stderr] 55 | return self.get_url(&url); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_url(&url)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/mod.rs:85:3 [INFO] [stderr] | [INFO] [stderr] 85 | return Self { [INFO] [stderr] | _________^ [INFO] [stderr] 86 | | buffer: Vec::new(), [INFO] [stderr] 87 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 85 | Self { [INFO] [stderr] 86 | buffer: Vec::new(), [INFO] [stderr] 87 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/mod.rs:93:3 [INFO] [stderr] | [INFO] [stderr] 93 | return buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/mod.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | return Ok(data.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(data.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/utils.rs:9:3 [INFO] [stderr] | [INFO] [stderr] 9 | return Self { [INFO] [stderr] | _________^ [INFO] [stderr] 10 | | path [INFO] [stderr] 11 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 9 | Self { [INFO] [stderr] 10 | path [INFO] [stderr] 11 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/utils.rs:16:3 [INFO] [stderr] | [INFO] [stderr] 16 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/utils.rs:21:3 [INFO] [stderr] | [INFO] [stderr] 21 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/utils.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | return std::fs::create_dir(&self.path).map(|_| self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `std::fs::create_dir(&self.path).map(|_| self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/utils.rs:34:3 [INFO] [stderr] | [INFO] [stderr] 34 | return ret.map(|_| self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ret.map(|_| self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Future`, `self` [INFO] [stderr] --> src/main.rs:13:17 [INFO] [stderr] | [INFO] [stderr] 13 | use hyper::rt::{self, Future}; [INFO] [stderr] | ^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/scratch/templates.rs:3:32 [INFO] [stderr] | [INFO] [stderr] 3 | const PISTON_TEMPLATE_FRAG_1: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/scratch/templates.rs:11:32 [INFO] [stderr] | [INFO] [stderr] 11 | const PISTON_TEMPLATE_FRAG_2: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Serialize`, `Serializer` [INFO] [stderr] --> src/scratch/api/types/json.rs:1:40 [INFO] [stderr] | [INFO] [stderr] 1 | use serde::{Deserializer, Deserialize, Serialize, Serializer}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `PlaySoundAndWait` [INFO] [stderr] --> src/scratch/api/types/json.rs:8:20 [INFO] [stderr] | [INFO] [stderr] 8 | use super::{Block, PlaySoundAndWait}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/scratch/api/types/json.rs:156:18 [INFO] [stderr] | [INFO] [stderr] 156 | const FIELDS: &'static [&'static str] = &["x", "y", "blocks"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/scratch/api/types/json.rs:156:28 [INFO] [stderr] | [INFO] [stderr] 156 | const FIELDS: &'static [&'static str] = &["x", "y", "blocks"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/json.rs:176:3 [INFO] [stderr] | [INFO] [stderr] 176 | return Ok(ScriptJson{ [INFO] [stderr] | _________^ [INFO] [stderr] 177 | | x, [INFO] [stderr] 178 | | y, [INFO] [stderr] 179 | | blocks, [INFO] [stderr] 180 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 176 | Ok(ScriptJson{ [INFO] [stderr] 177 | x, [INFO] [stderr] 178 | y, [INFO] [stderr] 179 | blocks, [INFO] [stderr] 180 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/json.rs:223:9 [INFO] [stderr] | [INFO] [stderr] 223 | / return Ok(ScriptJson{ [INFO] [stderr] 224 | | x, [INFO] [stderr] 225 | | y, [INFO] [stderr] 226 | | blocks, [INFO] [stderr] 227 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 223 | Ok(ScriptJson{ [INFO] [stderr] 224 | x, [INFO] [stderr] 225 | y, [INFO] [stderr] 226 | blocks, [INFO] [stderr] 227 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/block.rs:57:3 [INFO] [stderr] | [INFO] [stderr] 57 | return match elements [INFO] [stderr] | _________^ [INFO] [stderr] 58 | | .get(0) [INFO] [stderr] 59 | | .ok_or(serde::de::Error::invalid_length(0, &self))? [INFO] [stderr] 60 | | .as_str(){ [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 57 | match elements [INFO] [stderr] 58 | .get(0) [INFO] [stderr] 59 | .ok_or(serde::de::Error::invalid_length(0, &self))? [INFO] [stderr] 60 | .as_str(){ [INFO] [stderr] 61 | "whenGreenFlag" => { [INFO] [stderr] 62 | Ok(Block::WhenStart) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/block.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | return Ok(Block::WhenStart); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Block::WhenStart)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/block.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | return Err(serde::de::Error::invalid_value(serde::de::Unexpected::Str(v), &self)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(serde::de::Error::invalid_value(serde::de::Unexpected::Str(v), &self))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/block.rs:108:3 [INFO] [stderr] | [INFO] [stderr] 108 | return Ok(Block::WhenStart); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Block::WhenStart)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/mod.rs:48:3 [INFO] [stderr] | [INFO] [stderr] 48 | return Ok(project); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(project)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/mod.rs:52:3 [INFO] [stderr] | [INFO] [stderr] 52 | return Some(self.name.get_or_insert("scratch_".to_string() + self.code.as_ref()?)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.name.get_or_insert("scratch_".to_string() + self.code.as_ref()?))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/mod.rs:58:3 [INFO] [stderr] | [INFO] [stderr] 58 | return path; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/mod.rs:128:3 [INFO] [stderr] | [INFO] [stderr] 128 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/mod.rs:137:3 [INFO] [stderr] | [INFO] [stderr] 137 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/mod.rs:146:3 [INFO] [stderr] | [INFO] [stderr] 146 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/mod.rs:155:3 [INFO] [stderr] | [INFO] [stderr] 155 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/types/mod.rs:163:3 [INFO] [stderr] | [INFO] [stderr] 163 | return p; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/targets.rs:114:3 [INFO] [stderr] | [INFO] [stderr] 114 | return main_js; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `main_js` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/targets.rs:127:3 [INFO] [stderr] | [INFO] [stderr] 127 | return total; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/targets.rs:146:3 [INFO] [stderr] | [INFO] [stderr] 146 | return total; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/targets.rs:152:3 [INFO] [stderr] | [INFO] [stderr] 152 | return "js"; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `"js"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/targets.rs:236:3 [INFO] [stderr] | [INFO] [stderr] 236 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/targets.rs:240:3 [INFO] [stderr] | [INFO] [stderr] 240 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/targets.rs:261:3 [INFO] [stderr] | [INFO] [stderr] 261 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/mod.rs:13:3 [INFO] [stderr] | [INFO] [stderr] 13 | return Self { [INFO] [stderr] | _________^ [INFO] [stderr] 14 | | handle: Easy2::new(BufferBody::new()) [INFO] [stderr] 15 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 13 | Self { [INFO] [stderr] 14 | handle: Easy2::new(BufferBody::new()) [INFO] [stderr] 15 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/mod.rs:25:3 [INFO] [stderr] | [INFO] [stderr] 25 | return Ok(body); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(body)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/mod.rs:32:3 [INFO] [stderr] | [INFO] [stderr] 32 | return Ok(stats); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(stats)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/mod.rs:39:3 [INFO] [stderr] | [INFO] [stderr] 39 | return Ok(project_json); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(project_json)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/mod.rs:50:3 [INFO] [stderr] | [INFO] [stderr] 50 | return Ok(project); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(project)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/mod.rs:55:3 [INFO] [stderr] | [INFO] [stderr] 55 | return self.get_url(&url); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_url(&url)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/mod.rs:85:3 [INFO] [stderr] | [INFO] [stderr] 85 | return Self { [INFO] [stderr] | _________^ [INFO] [stderr] 86 | | buffer: Vec::new(), [INFO] [stderr] 87 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 85 | Self { [INFO] [stderr] 86 | buffer: Vec::new(), [INFO] [stderr] 87 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/mod.rs:93:3 [INFO] [stderr] | [INFO] [stderr] 93 | return buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/api/mod.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | return Ok(data.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(data.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/utils.rs:9:3 [INFO] [stderr] | [INFO] [stderr] 9 | return Self { [INFO] [stderr] | _________^ [INFO] [stderr] 10 | | path [INFO] [stderr] 11 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 9 | Self { [INFO] [stderr] 10 | path [INFO] [stderr] 11 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/utils.rs:16:3 [INFO] [stderr] | [INFO] [stderr] 16 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/utils.rs:21:3 [INFO] [stderr] | [INFO] [stderr] 21 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/utils.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | return std::fs::create_dir(&self.path).map(|_| self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `std::fs::create_dir(&self.path).map(|_| self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scratch/utils.rs:34:3 [INFO] [stderr] | [INFO] [stderr] 34 | return ret.map(|_| self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ret.map(|_| self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/main.rs:131:2 [INFO] [stderr] | [INFO] [stderr] 131 | print!("Building Project... "); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/main.rs:131:2 [INFO] [stderr] | [INFO] [stderr] 131 | print!("Building Project... "); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/scratch/api/types/block.rs:108:3 [INFO] [stderr] | [INFO] [stderr] 108 | return Ok(Block::WhenStart); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/main.rs:105:8 [INFO] [stderr] | [INFO] [stderr] 105 | let path = PathBuf::from(matches.value_of("path").expect("No path specified")); [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `matches` [INFO] [stderr] --> src/main.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | ("old_main", Some(matches)) => { [INFO] [stderr] | ^^^^^^^ help: consider using `_matches` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/scratch/error.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | fn from(err: ()) -> Error { [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `asset_buf` is never read [INFO] [stderr] --> src/scratch/api/types/mod.rs:97:11 [INFO] [stderr] | [INFO] [stderr] 97 | let mut asset_buf = Vec::new(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `project` [INFO] [stderr] --> src/scratch/api/targets.rs:239:22 [INFO] [stderr] | [INFO] [stderr] 239 | fn build(&mut self, project: &mut Project, path: &PathBuf) -> TargetResult<()>{ [INFO] [stderr] | ^^^^^^^ help: consider using `_project` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/scratch/api/targets.rs:239:45 [INFO] [stderr] | [INFO] [stderr] 239 | fn build(&mut self, project: &mut Project, path: &PathBuf) -> TargetResult<()>{ [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `command` [INFO] [stderr] --> src/scratch/api/targets.rs:244:7 [INFO] [stderr] | [INFO] [stderr] 244 | let command = if cfg!(target_os = "windows"){ [INFO] [stderr] | ^^^^^^^ help: consider using `_command` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `project` [INFO] [stderr] --> src/scratch/api/targets.rs:243:21 [INFO] [stderr] | [INFO] [stderr] 243 | fn test(&mut self, project: &mut Project, path: &PathBuf) -> TargetResult<()>{ [INFO] [stderr] | ^^^^^^^ help: consider using `_project` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/scratch/api/mod.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | fn from(err: curl::Error) -> Self { [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/scratch/api/mod.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | fn from(err: std::string::FromUtf8Error) -> Self { [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:84:11 [INFO] [stderr] | [INFO] [stderr] 84 | let mut project = api.get_project(code).expect("Error getting project json"); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:88:11 [INFO] [stderr] | [INFO] [stderr] 88 | let mut project = api.get_project_json(code).expect("Error getting project json"); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | let mut project = api.get_stats(code).expect("Error getting project json"); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/scratch/api/types/block.rs:108:3 [INFO] [stderr] | [INFO] [stderr] 108 | return Ok(Block::WhenStart); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/scratch/api/types/mod.rs:61:47 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn init(&mut self, api: &mut super::Api, mut path: PathBuf) -> ApiResult<()>{ [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/main.rs:105:8 [INFO] [stderr] | [INFO] [stderr] 105 | let path = PathBuf::from(matches.value_of("path").expect("No path specified")); [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `matches` [INFO] [stderr] --> src/main.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | ("old_main", Some(matches)) => { [INFO] [stderr] | ^^^^^^^ help: consider using `_matches` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/scratch/error.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | fn from(err: ()) -> Error { [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `asset_buf` is never read [INFO] [stderr] --> src/scratch/api/types/mod.rs:97:11 [INFO] [stderr] | [INFO] [stderr] 97 | let mut asset_buf = Vec::new(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `project` [INFO] [stderr] --> src/scratch/api/targets.rs:239:22 [INFO] [stderr] | [INFO] [stderr] 239 | fn build(&mut self, project: &mut Project, path: &PathBuf) -> TargetResult<()>{ [INFO] [stderr] | ^^^^^^^ help: consider using `_project` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/scratch/api/targets.rs:239:45 [INFO] [stderr] | [INFO] [stderr] 239 | fn build(&mut self, project: &mut Project, path: &PathBuf) -> TargetResult<()>{ [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `command` [INFO] [stderr] --> src/scratch/api/targets.rs:244:7 [INFO] [stderr] | [INFO] [stderr] 244 | let command = if cfg!(target_os = "windows"){ [INFO] [stderr] | ^^^^^^^ help: consider using `_command` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `project` [INFO] [stderr] --> src/scratch/api/targets.rs:243:21 [INFO] [stderr] | [INFO] [stderr] 243 | fn test(&mut self, project: &mut Project, path: &PathBuf) -> TargetResult<()>{ [INFO] [stderr] | ^^^^^^^ help: consider using `_project` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/scratch/api/mod.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | fn from(err: curl::Error) -> Self { [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/scratch/api/mod.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | fn from(err: std::string::FromUtf8Error) -> Self { [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:84:11 [INFO] [stderr] | [INFO] [stderr] 84 | let mut project = api.get_project(code).expect("Error getting project json"); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:88:11 [INFO] [stderr] | [INFO] [stderr] 88 | let mut project = api.get_project_json(code).expect("Error getting project json"); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | let mut project = api.get_stats(code).expect("Error getting project json"); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/scratch/api/types/mod.rs:61:47 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn init(&mut self, api: &mut super::Api, mut path: PathBuf) -> ApiResult<()>{ [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/scratch/api/targets.rs:98:7 [INFO] [stderr] | [INFO] [stderr] 98 | let mut body = project [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PISTON_TEMPLATE_FRAG_1` [INFO] [stderr] --> src/scratch/templates.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | / const PISTON_TEMPLATE_FRAG_1: &'static str = r#" [INFO] [stderr] 4 | | extern crate scratch_ui; [INFO] [stderr] 5 | | use scratch_ui::{App, Sprite}; [INFO] [stderr] 6 | | [INFO] [stderr] 7 | | fn main() { [INFO] [stderr] 8 | | let mut app = scratch_ui::PistonApp::new(); [INFO] [stderr] 9 | | app.init();"#; [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PISTON_TEMPLATE_FRAG_2` [INFO] [stderr] --> src/scratch/templates.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / const PISTON_TEMPLATE_FRAG_2: &'static str = r#" [INFO] [stderr] 12 | | app.main_loop(); [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | "#; [INFO] [stderr] | |___^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_piston_app` [INFO] [stderr] --> src/scratch/templates.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn get_piston_app(input: &str) -> String{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_sprite` [INFO] [stderr] --> src/scratch/templates.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn get_sprite(s: &SpriteJson) -> String{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Custom` [INFO] [stderr] --> src/scratch/api/types/block.rs:8:2 [INFO] [stderr] | [INFO] [stderr] 8 | Custom { [INFO] [stderr] | _____^ [INFO] [stderr] 9 | | arr: Vec [INFO] [stderr] 10 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write_file` [INFO] [stderr] --> src/scratch/api/targets.rs:36:2 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn write_file(path: &PathBuf, data: &[u8]) -> Result<(), std::io::Error>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/scratch/api/types/json.rs:173:31 [INFO] [stderr] | [INFO] [stderr] 173 | let x = seq.next_element()?.ok_or(serde::de::Error::invalid_length(0, &self))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| serde::de::Error::invalid_length(0, &self))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/scratch/api/types/json.rs:174:31 [INFO] [stderr] | [INFO] [stderr] 174 | let y = seq.next_element()?.ok_or(serde::de::Error::invalid_length(1, &self))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| serde::de::Error::invalid_length(1, &self))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/scratch/api/types/json.rs:175:36 [INFO] [stderr] | [INFO] [stderr] 175 | let blocks = seq.next_element()?.ok_or(serde::de::Error::invalid_length(2, &self))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| serde::de::Error::invalid_length(2, &self))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/scratch/api/types/block.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | .ok_or(serde::de::Error::invalid_length(0, &self))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| serde::de::Error::invalid_length(0, &self))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/scratch/api/types/block.rs:66:52 [INFO] [stderr] | [INFO] [stderr] 66 | std::mem::swap(&mut music, elements.get_mut(1).ok_or(serde::de::Error::invalid_length(1, &self))?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| serde::de::Error::invalid_length(1, &self))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/scratch/api/types/block.rs:96:35 [INFO] [stderr] | [INFO] [stderr] 96 | let key: &str = map.next_key()?.ok_or(serde::de::Error::invalid_length(0, &self))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| serde::de::Error::invalid_length(0, &self))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/scratch/api/types/block.rs:101:7 [INFO] [stderr] | [INFO] [stderr] 101 | .ok_or(serde::de::Error::invalid_length(0, &self))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| serde::de::Error::invalid_length(0, &self))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/scratch/api/targets.rs:98:7 [INFO] [stderr] | [INFO] [stderr] 98 | let mut body = project [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/scratch/api/types/mod.rs:145:3 [INFO] [stderr] | [INFO] [stderr] 145 | target.build(self, &path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/scratch/api/types/mod.rs:154:3 [INFO] [stderr] | [INFO] [stderr] 154 | target.test(self, &path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PISTON_TEMPLATE_FRAG_1` [INFO] [stderr] --> src/scratch/templates.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | / const PISTON_TEMPLATE_FRAG_1: &'static str = r#" [INFO] [stderr] 4 | | extern crate scratch_ui; [INFO] [stderr] 5 | | use scratch_ui::{App, Sprite}; [INFO] [stderr] 6 | | [INFO] [stderr] 7 | | fn main() { [INFO] [stderr] 8 | | let mut app = scratch_ui::PistonApp::new(); [INFO] [stderr] 9 | | app.init();"#; [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PISTON_TEMPLATE_FRAG_2` [INFO] [stderr] --> src/scratch/templates.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / const PISTON_TEMPLATE_FRAG_2: &'static str = r#" [INFO] [stderr] 12 | | app.main_loop(); [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | "#; [INFO] [stderr] | |___^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_piston_app` [INFO] [stderr] --> src/scratch/templates.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn get_piston_app(input: &str) -> String{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_sprite` [INFO] [stderr] --> src/scratch/templates.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn get_sprite(s: &SpriteJson) -> String{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Custom` [INFO] [stderr] --> src/scratch/api/types/block.rs:8:2 [INFO] [stderr] | [INFO] [stderr] 8 | Custom { [INFO] [stderr] | _____^ [INFO] [stderr] 9 | | arr: Vec [INFO] [stderr] 10 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write_file` [INFO] [stderr] --> src/scratch/api/targets.rs:36:2 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn write_file(path: &PathBuf, data: &[u8]) -> Result<(), std::io::Error>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/scratch/api/targets.rs:177:19 [INFO] [stderr] | [INFO] [stderr] 177 | let server_js = format!(r#"let express = require("express"); [INFO] [stderr] | _________________________^ [INFO] [stderr] 178 | | let path = require("path"); [INFO] [stderr] 179 | | let app = express(); [INFO] [stderr] 180 | | let PORT = 3001; [INFO] [stderr] ... | [INFO] [stderr] 190 | | }}); [INFO] [stderr] 191 | | "#); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 177 | let server_js = r#"let express = require("express"); [INFO] [stderr] 178 | let path = require("path"); [INFO] [stderr] 179 | let app = express(); [INFO] [stderr] 180 | let PORT = 3001; [INFO] [stderr] 181 | app.use(express.static("./")); [INFO] [stderr] 182 | app.get("/js/scratch-js.js", function(req, res){{ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:117:2 [INFO] [stderr] | [INFO] [stderr] 117 | std::fs::remove_dir_all("projects/scratch_239742347/target/js"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/scratch/api/types/json.rs:173:31 [INFO] [stderr] | [INFO] [stderr] 173 | let x = seq.next_element()?.ok_or(serde::de::Error::invalid_length(0, &self))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| serde::de::Error::invalid_length(0, &self))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/scratch/api/types/json.rs:174:31 [INFO] [stderr] | [INFO] [stderr] 174 | let y = seq.next_element()?.ok_or(serde::de::Error::invalid_length(1, &self))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| serde::de::Error::invalid_length(1, &self))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/scratch/api/types/json.rs:175:36 [INFO] [stderr] | [INFO] [stderr] 175 | let blocks = seq.next_element()?.ok_or(serde::de::Error::invalid_length(2, &self))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| serde::de::Error::invalid_length(2, &self))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/scratch/api/types/block.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | .ok_or(serde::de::Error::invalid_length(0, &self))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| serde::de::Error::invalid_length(0, &self))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/scratch/api/types/block.rs:66:52 [INFO] [stderr] | [INFO] [stderr] 66 | std::mem::swap(&mut music, elements.get_mut(1).ok_or(serde::de::Error::invalid_length(1, &self))?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| serde::de::Error::invalid_length(1, &self))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/scratch/api/types/block.rs:96:35 [INFO] [stderr] | [INFO] [stderr] 96 | let key: &str = map.next_key()?.ok_or(serde::de::Error::invalid_length(0, &self))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| serde::de::Error::invalid_length(0, &self))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/scratch/api/types/block.rs:101:7 [INFO] [stderr] | [INFO] [stderr] 101 | .ok_or(serde::de::Error::invalid_length(0, &self))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| serde::de::Error::invalid_length(0, &self))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/scratch/api/types/mod.rs:145:3 [INFO] [stderr] | [INFO] [stderr] 145 | target.build(self, &path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/scratch/api/types/mod.rs:154:3 [INFO] [stderr] | [INFO] [stderr] 154 | target.test(self, &path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/scratch/api/targets.rs:177:19 [INFO] [stderr] | [INFO] [stderr] 177 | let server_js = format!(r#"let express = require("express"); [INFO] [stderr] | _________________________^ [INFO] [stderr] 178 | | let path = require("path"); [INFO] [stderr] 179 | | let app = express(); [INFO] [stderr] 180 | | let PORT = 3001; [INFO] [stderr] ... | [INFO] [stderr] 190 | | }}); [INFO] [stderr] 191 | | "#); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 177 | let server_js = r#"let express = require("express"); [INFO] [stderr] 178 | let path = require("path"); [INFO] [stderr] 179 | let app = express(); [INFO] [stderr] 180 | let PORT = 3001; [INFO] [stderr] 181 | app.use(express.static("./")); [INFO] [stderr] 182 | app.get("/js/scratch-js.js", function(req, res){{ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:117:2 [INFO] [stderr] | [INFO] [stderr] 117 | std::fs::remove_dir_all("projects/scratch_239742347/target/js"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 30.65s [INFO] running `"docker" "inspect" "d22063c4cd1cc16462a0a4f1519fa46434e497c1dffd4bf86397510727f2e1c0"` [INFO] running `"docker" "rm" "-f" "d22063c4cd1cc16462a0a4f1519fa46434e497c1dffd4bf86397510727f2e1c0"` [INFO] [stdout] d22063c4cd1cc16462a0a4f1519fa46434e497c1dffd4bf86397510727f2e1c0