[INFO] updating cached repository adumbidiot/quarky [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/adumbidiot/quarky [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/adumbidiot/quarky" "work/ex/clippy-test-run/sources/stable/gh/adumbidiot/quarky"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/adumbidiot/quarky'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/adumbidiot/quarky" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adumbidiot/quarky"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adumbidiot/quarky'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0715a4314d2ea490f21e6b6b79bfdf68328e5c17 [INFO] sha for GitHub repo adumbidiot/quarky: 0715a4314d2ea490f21e6b6b79bfdf68328e5c17 [INFO] validating manifest of adumbidiot/quarky on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of adumbidiot/quarky on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing adumbidiot/quarky [INFO] finished frobbing adumbidiot/quarky [INFO] frobbed toml for adumbidiot/quarky written to work/ex/clippy-test-run/sources/stable/gh/adumbidiot/quarky/Cargo.toml [INFO] started frobbing adumbidiot/quarky [INFO] finished frobbing adumbidiot/quarky [INFO] frobbed toml for adumbidiot/quarky written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adumbidiot/quarky/Cargo.toml [INFO] crate adumbidiot/quarky has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting adumbidiot/quarky against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/adumbidiot/quarky:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 786002de1f8c204f73ac187858adaf0f716395cc50cb8430e62bbd3b533ece0c [INFO] running `"docker" "start" "-a" "786002de1f8c204f73ac187858adaf0f716395cc50cb8430e62bbd3b533ece0c"` [INFO] [stderr] Checking base64 v0.8.0 [INFO] [stderr] Checking serde_json v1.0.33 [INFO] [stderr] Checking clokwerk v0.1.0 [INFO] [stderr] Checking multipart v0.13.6 [INFO] [stderr] Checking evzht9h3nznqzwl v0.0.3 [INFO] [stderr] Checking serenity v0.5.10 [INFO] [stderr] Checking quarky v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/ping.rs:19:3 [INFO] [stderr] | [INFO] [stderr] 19 | return cmd; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `cmd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/ping.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/ping.rs:30:3 [INFO] [stderr] | [INFO] [stderr] 30 | return self.options.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.options.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/announce.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | return cmd; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `cmd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/announce.rs:34:3 [INFO] [stderr] | [INFO] [stderr] 34 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/announce.rs:38:3 [INFO] [stderr] | [INFO] [stderr] 38 | return self.options.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.options.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/main.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Read` [INFO] [stderr] --> src/main.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | use std::io::Read; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:72:2 [INFO] [stderr] | [INFO] [stderr] 72 | return Some(config); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(config)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/ping.rs:19:3 [INFO] [stderr] | [INFO] [stderr] 19 | return cmd; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `cmd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/ping.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/ping.rs:30:3 [INFO] [stderr] | [INFO] [stderr] 30 | return self.options.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.options.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/announce.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | return cmd; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `cmd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/announce.rs:34:3 [INFO] [stderr] | [INFO] [stderr] 34 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/announce.rs:38:3 [INFO] [stderr] | [INFO] [stderr] 38 | return self.options.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.options.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/main.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Read` [INFO] [stderr] --> src/main.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | use std::io::Read; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:72:2 [INFO] [stderr] | [INFO] [stderr] 72 | return Some(config); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(config)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `event_thread_handle` [INFO] [stderr] --> src/main.rs:127:6 [INFO] [stderr] | [INFO] [stderr] 127 | let event_thread_handle = scheduler.watch_thread(Duration::from_secs(60 * 5)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using `_event_thread_handle` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `msg` [INFO] [stderr] --> src/commands/announce.rs:31:37 [INFO] [stderr] | [INFO] [stderr] 31 | fn execute(&self, _: &mut Context, msg: &Message, mut args: Args) -> Result<(), serenity::framework::standard::CommandError> { [INFO] [stderr] | ^^^ help: consider using `_msg` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/main.rs:55:20 [INFO] [stderr] | [INFO] [stderr] 55 | fn message(&self, ctx: Context, msg: Message){ [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `msg` [INFO] [stderr] --> src/main.rs:55:34 [INFO] [stderr] | [INFO] [stderr] 55 | fn message(&self, ctx: Context, msg: Message){ [INFO] [stderr] | ^^^ help: consider using `_msg` instead [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/commands/announce.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | if guilds.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!guilds.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused variable: `event_thread_handle` [INFO] [stderr] --> src/main.rs:127:6 [INFO] [stderr] | [INFO] [stderr] 127 | let event_thread_handle = scheduler.watch_thread(Duration::from_secs(60 * 5)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using `_event_thread_handle` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `msg` [INFO] [stderr] --> src/commands/announce.rs:31:37 [INFO] [stderr] | [INFO] [stderr] 31 | fn execute(&self, _: &mut Context, msg: &Message, mut args: Args) -> Result<(), serenity::framework::standard::CommandError> { [INFO] [stderr] | ^^^ help: consider using `_msg` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/main.rs:55:20 [INFO] [stderr] | [INFO] [stderr] 55 | fn message(&self, ctx: Context, msg: Message){ [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `msg` [INFO] [stderr] --> src/main.rs:55:34 [INFO] [stderr] | [INFO] [stderr] 55 | fn message(&self, ctx: Context, msg: Message){ [INFO] [stderr] | ^^^ help: consider using `_msg` instead [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/commands/announce.rs:51:6 [INFO] [stderr] | [INFO] [stderr] 51 | channel.say(announcement); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/commands/announce.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | if guilds.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!guilds.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/commands/announce.rs:51:6 [INFO] [stderr] | [INFO] [stderr] 51 | channel.say(announcement); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 30.54s [INFO] running `"docker" "inspect" "786002de1f8c204f73ac187858adaf0f716395cc50cb8430e62bbd3b533ece0c"` [INFO] running `"docker" "rm" "-f" "786002de1f8c204f73ac187858adaf0f716395cc50cb8430e62bbd3b533ece0c"` [INFO] [stdout] 786002de1f8c204f73ac187858adaf0f716395cc50cb8430e62bbd3b533ece0c