[INFO] updating cached repository adolfosilva/vcrust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/adolfosilva/vcrust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/adolfosilva/vcrust" "work/ex/clippy-test-run/sources/stable/gh/adolfosilva/vcrust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/adolfosilva/vcrust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/adolfosilva/vcrust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adolfosilva/vcrust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adolfosilva/vcrust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5be43fade21a56d8f69c8f0f5a928fdc99cea47f [INFO] sha for GitHub repo adolfosilva/vcrust: 5be43fade21a56d8f69c8f0f5a928fdc99cea47f [INFO] validating manifest of adolfosilva/vcrust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of adolfosilva/vcrust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing adolfosilva/vcrust [INFO] finished frobbing adolfosilva/vcrust [INFO] frobbed toml for adolfosilva/vcrust written to work/ex/clippy-test-run/sources/stable/gh/adolfosilva/vcrust/Cargo.toml [INFO] started frobbing adolfosilva/vcrust [INFO] finished frobbing adolfosilva/vcrust [INFO] frobbed toml for adolfosilva/vcrust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adolfosilva/vcrust/Cargo.toml [INFO] crate adolfosilva/vcrust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting adolfosilva/vcrust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/adolfosilva/vcrust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 450987b8ac376ad5060ea31845ba1c5743416acb770be02ce772ace08644c27f [INFO] running `"docker" "start" "-a" "450987b8ac376ad5060ea31845ba1c5743416acb770be02ce772ace08644c27f"` [INFO] [stderr] Compiling gcc v0.3.44 [INFO] [stderr] Compiling vcrust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:219:16 [INFO] [stderr] | [INFO] [stderr] 219 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:219:16 [INFO] [stderr] | [INFO] [stderr] 219 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::iter::repeat` [INFO] [stderr] --> src/ops.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::iter::repeat; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `ImageType` [INFO] [stderr] --> src/ops.rs:2:20 [INFO] [stderr] | [INFO] [stderr] 2 | use image::{Image, ImageType, Channel}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/image.rs:263:13 [INFO] [stderr] | [INFO] [stderr] 263 | let mut bits = bytes.map(|b| b.unwrap()).collect::>(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: item `image::Image` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/image.rs:89:1 [INFO] [stderr] | [INFO] [stderr] 89 | / impl Image { [INFO] [stderr] 90 | | pub fn new>>(width: usize, height: usize, typ: ImageType, data: T) -> Image { [INFO] [stderr] 91 | | Image { [INFO] [stderr] 92 | | typ: typ, [INFO] [stderr] ... | [INFO] [stderr] 410 | | */ [INFO] [stderr] 411 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/image.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | let _ = Image::skip_until_newline(&mut bytes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/image.rs:254:9 [INFO] [stderr] | [INFO] [stderr] 254 | let _ = Image::skip_until_newline(&mut bytes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/image.rs:295:9 [INFO] [stderr] | [INFO] [stderr] 295 | bytes.map(|b| b.unwrap()).take_while(|b| *b != b'\n').collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/image.rs:295:9 [INFO] [stderr] | [INFO] [stderr] 295 | bytes.map(|b| b.unwrap()).take_while(|b| *b != b'\n').collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops.rs:6:26 [INFO] [stderr] | [INFO] [stderr] 6 | image.data[i] = (image.data[i] as f32 * (1.0 - percentage)) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(image.data[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops.rs:22:26 [INFO] [stderr] | [INFO] [stderr] 22 | image.data[i] = (image.data[i] as f32 * (1.0 + percentage)) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(image.data[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `image.data` manually [INFO] [stderr] --> src/ops.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | / let tmp = image.data[pos + i]; [INFO] [stderr] 112 | | image.data[pos + i] = image.data[pos + j]; [INFO] [stderr] 113 | | image.data[pos + j] = tmp; [INFO] [stderr] | |_____________________________________^ help: try: `image.data.swap(pos + i, pos + j)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/image.rs:263:13 [INFO] [stderr] | [INFO] [stderr] 263 | let mut bits = bytes.map(|b| b.unwrap()).collect::>(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: item `image::Image` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/image.rs:89:1 [INFO] [stderr] | [INFO] [stderr] 89 | / impl Image { [INFO] [stderr] 90 | | pub fn new>>(width: usize, height: usize, typ: ImageType, data: T) -> Image { [INFO] [stderr] 91 | | Image { [INFO] [stderr] 92 | | typ: typ, [INFO] [stderr] ... | [INFO] [stderr] 410 | | */ [INFO] [stderr] 411 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/image.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | let _ = Image::skip_until_newline(&mut bytes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/image.rs:254:9 [INFO] [stderr] | [INFO] [stderr] 254 | let _ = Image::skip_until_newline(&mut bytes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/image.rs:295:9 [INFO] [stderr] | [INFO] [stderr] 295 | bytes.map(|b| b.unwrap()).take_while(|b| *b != b'\n').collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/image.rs:295:9 [INFO] [stderr] | [INFO] [stderr] 295 | bytes.map(|b| b.unwrap()).take_while(|b| *b != b'\n').collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/image.rs:429:5 [INFO] [stderr] | [INFO] [stderr] 429 | img.write("image/barbara2.pgm"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops.rs:6:26 [INFO] [stderr] | [INFO] [stderr] 6 | image.data[i] = (image.data[i] as f32 * (1.0 - percentage)) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(image.data[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/ops.rs:22:26 [INFO] [stderr] | [INFO] [stderr] 22 | image.data[i] = (image.data[i] as f32 * (1.0 + percentage)) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(image.data[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `image.data` manually [INFO] [stderr] --> src/ops.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | / let tmp = image.data[pos + i]; [INFO] [stderr] 112 | | image.data[pos + i] = image.data[pos + j]; [INFO] [stderr] 113 | | image.data[pos + j] = tmp; [INFO] [stderr] | |_____________________________________^ help: try: `image.data.swap(pos + i, pos + j)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.76s [INFO] running `"docker" "inspect" "450987b8ac376ad5060ea31845ba1c5743416acb770be02ce772ace08644c27f"` [INFO] running `"docker" "rm" "-f" "450987b8ac376ad5060ea31845ba1c5743416acb770be02ce772ace08644c27f"` [INFO] [stdout] 450987b8ac376ad5060ea31845ba1c5743416acb770be02ce772ace08644c27f