[INFO] updating cached repository adnelson/nix-browse [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/adnelson/nix-browse [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/adnelson/nix-browse" "work/ex/clippy-test-run/sources/stable/gh/adnelson/nix-browse"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/adnelson/nix-browse'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/adnelson/nix-browse" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adnelson/nix-browse"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adnelson/nix-browse'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 921245482ae7056849f6f575b7d630c170dc2a23 [INFO] sha for GitHub repo adnelson/nix-browse: 921245482ae7056849f6f575b7d630c170dc2a23 [INFO] validating manifest of adnelson/nix-browse on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of adnelson/nix-browse on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing adnelson/nix-browse [INFO] finished frobbing adnelson/nix-browse [INFO] frobbed toml for adnelson/nix-browse written to work/ex/clippy-test-run/sources/stable/gh/adnelson/nix-browse/Cargo.toml [INFO] started frobbing adnelson/nix-browse [INFO] finished frobbing adnelson/nix-browse [INFO] frobbed toml for adnelson/nix-browse written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adnelson/nix-browse/Cargo.toml [INFO] crate adnelson/nix-browse has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting adnelson/nix-browse against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/adnelson/nix-browse:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 342e0e785e6fc7abdea0b02d0a3bf50e90fd0c7651cbb3c02edfa0aa3caef1ea [INFO] running `"docker" "start" "-a" "342e0e785e6fc7abdea0b02d0a3bf50e90fd0c7651cbb3c02edfa0aa3caef1ea"` [INFO] [stderr] Checking unescape v0.1.0 [INFO] [stderr] Checking nix-browse v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `regex::Regex` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use regex::Regex; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `FromIterator` [INFO] [stderr] --> src/parse_nix_instantiate.rs:6:27 [INFO] [stderr] | [INFO] [stderr] 6 | use std::iter::{Peekable, FromIterator}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::slice` [INFO] [stderr] --> src/parse_nix_instantiate.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::slice; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `regex::Regex` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use regex::Regex; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::slice` [INFO] [stderr] --> src/parse_nix_instantiate.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::slice; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parse_nix_instantiate.rs:53:32 [INFO] [stderr] | [INFO] [stderr] 53 | s if s.starts_with("\"") => [INFO] [stderr] | ^^^^ help: try using a char instead: `'\"'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parse_nix_instantiate.rs:57:32 [INFO] [stderr] | [INFO] [stderr] 57 | s if s.starts_with("/") => Path(PathBuf::from(s)), [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/parse_nix_instantiate.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | let _ = parse_token(tokens, Token::Equals)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/parse_nix_instantiate.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | let _ = parse_token(tokens, Token::Semi)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parse_nix_instantiate.rs:236:35 [INFO] [stderr] | [INFO] [stderr] 236 | args: &Vec<(String, String)>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, String)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parse_nix_instantiate.rs:53:32 [INFO] [stderr] | [INFO] [stderr] 53 | s if s.starts_with("\"") => [INFO] [stderr] | ^^^^ help: try using a char instead: `'\"'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parse_nix_instantiate.rs:57:32 [INFO] [stderr] | [INFO] [stderr] 57 | s if s.starts_with("/") => Path(PathBuf::from(s)), [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/parse_nix_instantiate.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | let _ = parse_token(tokens, Token::Equals)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/parse_nix_instantiate.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | let _ = parse_token(tokens, Token::Semi)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parse_nix_instantiate.rs:236:35 [INFO] [stderr] | [INFO] [stderr] 236 | args: &Vec<(String, String)>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, String)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.69s [INFO] running `"docker" "inspect" "342e0e785e6fc7abdea0b02d0a3bf50e90fd0c7651cbb3c02edfa0aa3caef1ea"` [INFO] running `"docker" "rm" "-f" "342e0e785e6fc7abdea0b02d0a3bf50e90fd0c7651cbb3c02edfa0aa3caef1ea"` [INFO] [stdout] 342e0e785e6fc7abdea0b02d0a3bf50e90fd0c7651cbb3c02edfa0aa3caef1ea