[INFO] updating cached repository adetaylor/cpptors [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/adetaylor/cpptors [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/adetaylor/cpptors" "work/ex/clippy-test-run/sources/stable/gh/adetaylor/cpptors"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/adetaylor/cpptors'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/adetaylor/cpptors" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adetaylor/cpptors"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adetaylor/cpptors'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8e81c95bf9cf8d591a0d0f625595bc4eb2f7e243 [INFO] sha for GitHub repo adetaylor/cpptors: 8e81c95bf9cf8d591a0d0f625595bc4eb2f7e243 [INFO] validating manifest of adetaylor/cpptors on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of adetaylor/cpptors on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing adetaylor/cpptors [INFO] finished frobbing adetaylor/cpptors [INFO] frobbed toml for adetaylor/cpptors written to work/ex/clippy-test-run/sources/stable/gh/adetaylor/cpptors/Cargo.toml [INFO] started frobbing adetaylor/cpptors [INFO] finished frobbing adetaylor/cpptors [INFO] frobbed toml for adetaylor/cpptors written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adetaylor/cpptors/Cargo.toml [INFO] crate adetaylor/cpptors has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting adetaylor/cpptors against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/adetaylor/cpptors:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 603b876170a2ed21c12d2b51d51a3c171fad4e0d5558cd581c27e1e38166fd28 [INFO] running `"docker" "start" "-a" "603b876170a2ed21c12d2b51d51a3c171fad4e0d5558cd581c27e1e38166fd28"` [INFO] [stderr] Checking serde_xml v0.9.1 [INFO] [stderr] Checking tempfile v3.0.5 [INFO] [stderr] Checking cpptors v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/main.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | ModifyExpr(ModifyExpr), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/main.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | ModifyExpr(ModifyExpr), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | / match x { [INFO] [stderr] 220 | | CodeFeature::Function(f) => dump_function(&f, &feature_by_id), [INFO] [stderr] 221 | | _ => {} [INFO] [stderr] 222 | | } [INFO] [stderr] | |_________^ help: try this: `if let CodeFeature::Function(f) = x { dump_function(&f, &feature_by_id) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | / match x { [INFO] [stderr] 220 | | CodeFeature::Function(f) => dump_function(&f, &feature_by_id), [INFO] [stderr] 221 | | _ => {} [INFO] [stderr] 222 | | } [INFO] [stderr] | |_________^ help: try this: `if let CodeFeature::Function(f) = x { dump_function(&f, &feature_by_id) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.33s [INFO] running `"docker" "inspect" "603b876170a2ed21c12d2b51d51a3c171fad4e0d5558cd581c27e1e38166fd28"` [INFO] running `"docker" "rm" "-f" "603b876170a2ed21c12d2b51d51a3c171fad4e0d5558cd581c27e1e38166fd28"` [INFO] [stdout] 603b876170a2ed21c12d2b51d51a3c171fad4e0d5558cd581c27e1e38166fd28