[INFO] updating cached repository addonovan/addonovan.com [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/addonovan/addonovan.com [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/addonovan/addonovan.com" "work/ex/clippy-test-run/sources/stable/gh/addonovan/addonovan.com"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/addonovan/addonovan.com'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/addonovan/addonovan.com" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/addonovan/addonovan.com"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/addonovan/addonovan.com'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 56b45c1dd133202a139d14661e51ac5c70bd8f4e [INFO] sha for GitHub repo addonovan/addonovan.com: 56b45c1dd133202a139d14661e51ac5c70bd8f4e [INFO] validating manifest of addonovan/addonovan.com on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of addonovan/addonovan.com on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing addonovan/addonovan.com [INFO] finished frobbing addonovan/addonovan.com [INFO] frobbed toml for addonovan/addonovan.com written to work/ex/clippy-test-run/sources/stable/gh/addonovan/addonovan.com/Cargo.toml [INFO] started frobbing addonovan/addonovan.com [INFO] finished frobbing addonovan/addonovan.com [INFO] frobbed toml for addonovan/addonovan.com written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/addonovan/addonovan.com/Cargo.toml [INFO] crate addonovan/addonovan.com has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting addonovan/addonovan.com against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/addonovan/addonovan.com:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 13372a27a94fb8520a25dacab3b253c5931624d438cab28dde95acd4d975174f [INFO] running `"docker" "start" "-a" "13372a27a94fb8520a25dacab3b253c5931624d438cab28dde95acd4d975174f"` [INFO] [stderr] Compiling serde v1.0.66 [INFO] [stderr] Compiling actix-web v0.7.3 [INFO] [stderr] Compiling ring v0.13.2 [INFO] [stderr] Checking socket2 v0.3.6 [INFO] [stderr] Checking crossbeam-epoch v0.5.2 [INFO] [stderr] Compiling quote v0.6.3 [INFO] [stderr] Checking lock_api v0.1.3 [INFO] [stderr] Checking http v0.1.8 [INFO] [stderr] Checking mio-uds v0.6.6 [INFO] [stderr] Checking flate2 v1.0.2 [INFO] [stderr] Checking tokio-threadpool v0.1.4 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Compiling syn v0.14.7 [INFO] [stderr] Checking parking_lot v0.6.3 [INFO] [stderr] Checking crossbeam-channel v0.2.4 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio-signal v0.2.1 [INFO] [stderr] Checking tokio-fs v0.1.0 [INFO] [stderr] Checking trust-dns-proto v0.4.0 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking h2 v0.1.9 [INFO] [stderr] Checking cookie v0.11.0 [INFO] [stderr] Checking trust-dns-resolver v0.9.0 [INFO] [stderr] Checking serde_json v1.0.20 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling actix_derive v0.3.0 [INFO] [stderr] Compiling serde_derive v1.0.66 [INFO] [stderr] Checking handlebars v1.0.0 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking actix v0.7.3 [INFO] [stderr] Checking website v2.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cache/mod.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | mod cache; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:3:26 [INFO] [stderr] | [INFO] [stderr] 3 | pub const TEMPLATE_DIR: &'static str = "template"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:5:22 [INFO] [stderr] | [INFO] [stderr] 5 | pub const MAIN_DIR: &'static str = "content/main"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:6:21 [INFO] [stderr] | [INFO] [stderr] 6 | pub const RAW_DIR: &'static str = "content/raw"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:7:28 [INFO] [stderr] | [INFO] [stderr] 7 | pub const EXPERIMENT_DIR: &'static str = "content/experiment"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:8:22 [INFO] [stderr] | [INFO] [stderr] 8 | pub const BLOG_DIR: &'static str = "content/blog"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | pub const STYLE_LINK: &'static str = "/raw/style"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/controller/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | mod controller; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/decorator/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod decorator; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/decorator/file_resolver.rs:5:29 [INFO] [stderr] | [INFO] [stderr] 5 | const EXTENSION_PRIORITY: [&'static str; 2] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/decorator/substitution.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util/functions.rs:27:16 [INFO] [stderr] | [INFO] [stderr] 27 | (seconds * 1000000000) + nanos [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util/page_builder/builder.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cache/mod.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | mod cache; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:3:26 [INFO] [stderr] | [INFO] [stderr] 3 | pub const TEMPLATE_DIR: &'static str = "template"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:5:22 [INFO] [stderr] | [INFO] [stderr] 5 | pub const MAIN_DIR: &'static str = "content/main"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:6:21 [INFO] [stderr] | [INFO] [stderr] 6 | pub const RAW_DIR: &'static str = "content/raw"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:7:28 [INFO] [stderr] | [INFO] [stderr] 7 | pub const EXPERIMENT_DIR: &'static str = "content/experiment"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:8:22 [INFO] [stderr] | [INFO] [stderr] 8 | pub const BLOG_DIR: &'static str = "content/blog"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | pub const STYLE_LINK: &'static str = "/raw/style"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/controller/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | mod controller; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/decorator/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod decorator; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/decorator/file_resolver.rs:5:29 [INFO] [stderr] | [INFO] [stderr] 5 | const EXTENSION_PRIORITY: [&'static str; 2] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/decorator/substitution.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util/functions.rs:27:16 [INFO] [stderr] | [INFO] [stderr] 27 | (seconds * 1000000000) + nanos [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util/page_builder/builder.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/cache/refresh_state.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / fn ne<'a>(&self, other: &'a RefreshState) -> bool { [INFO] [stderr] 35 | | !self.eq(other) [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util/functions.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | let nanos = elapsed.subsec_nanos() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/cache/refresh_state.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / fn ne<'a>(&self, other: &'a RefreshState) -> bool { [INFO] [stderr] 35 | | !self.eq(other) [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util/functions.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | let nanos = elapsed.subsec_nanos() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 00s [INFO] running `"docker" "inspect" "13372a27a94fb8520a25dacab3b253c5931624d438cab28dde95acd4d975174f"` [INFO] running `"docker" "rm" "-f" "13372a27a94fb8520a25dacab3b253c5931624d438cab28dde95acd4d975174f"` [INFO] [stdout] 13372a27a94fb8520a25dacab3b253c5931624d438cab28dde95acd4d975174f