[INFO] updating cached repository adambrenecki/yorick [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/adambrenecki/yorick [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/adambrenecki/yorick" "work/ex/clippy-test-run/sources/stable/gh/adambrenecki/yorick"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/adambrenecki/yorick'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/adambrenecki/yorick" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adambrenecki/yorick"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adambrenecki/yorick'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] aee35e5509473e7671dd4eb192c1b7ba1a93b720 [INFO] sha for GitHub repo adambrenecki/yorick: aee35e5509473e7671dd4eb192c1b7ba1a93b720 [INFO] validating manifest of adambrenecki/yorick on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of adambrenecki/yorick on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing adambrenecki/yorick [INFO] finished frobbing adambrenecki/yorick [INFO] frobbed toml for adambrenecki/yorick written to work/ex/clippy-test-run/sources/stable/gh/adambrenecki/yorick/Cargo.toml [INFO] started frobbing adambrenecki/yorick [INFO] finished frobbing adambrenecki/yorick [INFO] frobbed toml for adambrenecki/yorick written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adambrenecki/yorick/Cargo.toml [INFO] crate adambrenecki/yorick has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting adambrenecki/yorick against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/adambrenecki/yorick:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7a38790d7c52379fa15686c2a670f67c51ae9e166c9d0abe2b066aac22c3d4e5 [INFO] running `"docker" "start" "-a" "7a38790d7c52379fa15686c2a670f67c51ae9e166c9d0abe2b066aac22c3d4e5"` [INFO] [stderr] Checking maplit v1.0.0 [INFO] [stderr] Checking tempdir v0.3.5 [INFO] [stderr] Checking yorick v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Write` [INFO] [stderr] --> src/skeleton.rs:3:40 [INFO] [stderr] | [INFO] [stderr] 3 | use std::io::{BufReader, Read, Result, Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `create_dir` [INFO] [stderr] --> src/skeleton.rs:4:21 [INFO] [stderr] | [INFO] [stderr] 4 | use std::fs::{File, create_dir}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/skeleton.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `tempdir::TempDir` [INFO] [stderr] --> src/skeleton.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use tempdir::TempDir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/skeleton.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / return Box::new( [INFO] [stderr] 29 | | WalkDir::new(self.root.as_path()) [INFO] [stderr] 30 | | .into_iter() [INFO] [stderr] 31 | | .map(|entry| entry.unwrap()) [INFO] [stderr] ... | [INFO] [stderr] 39 | | }), [INFO] [stderr] 40 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 28 | Box::new( [INFO] [stderr] 29 | WalkDir::new(self.root.as_path()) [INFO] [stderr] 30 | .into_iter() [INFO] [stderr] 31 | .map(|entry| entry.unwrap()) [INFO] [stderr] 32 | .filter(|entry| entry.file_type().is_file()) [INFO] [stderr] 33 | .map(move |entry| { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/output.rs:2:30 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::{Result, Write, Read}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `tempdir::TempDir` [INFO] [stderr] --> src/output.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use tempdir::TempDir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Deserialize`, `Deserializer`, `self` [INFO] [stderr] --> src/config.rs:1:17 [INFO] [stderr] | [INFO] [stderr] 1 | use serde::de::{self, Deserialize, Deserializer}; [INFO] [stderr] | ^^^^ ^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `toml` [INFO] [stderr] --> src/config.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use toml; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/skeleton.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / return Box::new( [INFO] [stderr] 29 | | WalkDir::new(self.root.as_path()) [INFO] [stderr] 30 | | .into_iter() [INFO] [stderr] 31 | | .map(|entry| entry.unwrap()) [INFO] [stderr] ... | [INFO] [stderr] 39 | | }), [INFO] [stderr] 40 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 28 | Box::new( [INFO] [stderr] 29 | WalkDir::new(self.root.as_path()) [INFO] [stderr] 30 | .into_iter() [INFO] [stderr] 31 | .map(|entry| entry.unwrap()) [INFO] [stderr] 32 | .filter(|entry| entry.file_type().is_file()) [INFO] [stderr] 33 | .map(move |entry| { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Deserialize`, `Deserializer`, `self` [INFO] [stderr] --> src/config.rs:1:17 [INFO] [stderr] | [INFO] [stderr] 1 | use serde::de::{self, Deserialize, Deserializer}; [INFO] [stderr] | ^^^^ ^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | file.contents().unwrap().read(contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | writer.write(b"Hello!"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/skeleton.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | file1.write(b"FOO").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/skeleton.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | file1.write(b"QUX").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/skeleton.rs:81:16 [INFO] [stderr] | [INFO] [stderr] 81 | assert_eq!(file_map.get(Path::new("foo")).unwrap().as_slice(), b"FOO"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&file_map[Path::new("foo")]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/skeleton.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | file_map.get(Path::new("bar/baz")).unwrap().as_slice(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&file_map[Path::new("bar/baz")]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/output.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | writer.write(b"FOO").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/output.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | writer.write(b"QUX").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | file.contents().unwrap().read(contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | writer.write(b"Hello!"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `yorick`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7a38790d7c52379fa15686c2a670f67c51ae9e166c9d0abe2b066aac22c3d4e5"` [INFO] running `"docker" "rm" "-f" "7a38790d7c52379fa15686c2a670f67c51ae9e166c9d0abe2b066aac22c3d4e5"` [INFO] [stdout] 7a38790d7c52379fa15686c2a670f67c51ae9e166c9d0abe2b066aac22c3d4e5