[INFO] updating cached repository adam-mcdaniel/parkinglot-generator-optimizer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/adam-mcdaniel/parkinglot-generator-optimizer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/adam-mcdaniel/parkinglot-generator-optimizer" "work/ex/clippy-test-run/sources/stable/gh/adam-mcdaniel/parkinglot-generator-optimizer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/adam-mcdaniel/parkinglot-generator-optimizer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/adam-mcdaniel/parkinglot-generator-optimizer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adam-mcdaniel/parkinglot-generator-optimizer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adam-mcdaniel/parkinglot-generator-optimizer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ac4391480658f0bba08eb343db1a6cf963298e59 [INFO] sha for GitHub repo adam-mcdaniel/parkinglot-generator-optimizer: ac4391480658f0bba08eb343db1a6cf963298e59 [INFO] validating manifest of adam-mcdaniel/parkinglot-generator-optimizer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of adam-mcdaniel/parkinglot-generator-optimizer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing adam-mcdaniel/parkinglot-generator-optimizer [INFO] finished frobbing adam-mcdaniel/parkinglot-generator-optimizer [INFO] frobbed toml for adam-mcdaniel/parkinglot-generator-optimizer written to work/ex/clippy-test-run/sources/stable/gh/adam-mcdaniel/parkinglot-generator-optimizer/Cargo.toml [INFO] started frobbing adam-mcdaniel/parkinglot-generator-optimizer [INFO] finished frobbing adam-mcdaniel/parkinglot-generator-optimizer [INFO] frobbed toml for adam-mcdaniel/parkinglot-generator-optimizer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adam-mcdaniel/parkinglot-generator-optimizer/Cargo.toml [INFO] crate adam-mcdaniel/parkinglot-generator-optimizer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting adam-mcdaniel/parkinglot-generator-optimizer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/adam-mcdaniel/parkinglot-generator-optimizer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 80886f33c608f3f10e50a9977332e0a3897840a4afde616193829a1c8a19ba35 [INFO] running `"docker" "start" "-a" "80886f33c608f3f10e50a9977332e0a3897840a4afde616193829a1c8a19ba35"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] [stderr] Checking pathfinding v1.0.3 [INFO] [stderr] Checking parking v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/astar.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/astar.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/optimize.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | return score; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/optimize.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | return best_lot; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `best_lot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/optimize.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | return new_lot; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_lot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/optimize.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | return new_lot; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_lot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/optimize.rs:188:5 [INFO] [stderr] | [INFO] [stderr] 188 | / return match new_lot.get_exits() == lot.get_exits() { [INFO] [stderr] 189 | | true => new_lot.clone(), [INFO] [stderr] 190 | | false => lot.clone() [INFO] [stderr] 191 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 188 | match new_lot.get_exits() == lot.get_exits() { [INFO] [stderr] 189 | true => new_lot.clone(), [INFO] [stderr] 190 | false => lot.clone() [INFO] [stderr] 191 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/optimize.rs:227:5 [INFO] [stderr] | [INFO] [stderr] 227 | return average_distance; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `average_distance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/optimize.rs:253:5 [INFO] [stderr] | [INFO] [stderr] 253 | return lot; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `lot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/optimize.rs:290:5 [INFO] [stderr] | [INFO] [stderr] 290 | return new_lot; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_lot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/parkinglot.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | return self.lot[y as usize][x as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.lot[y as usize][x as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/parkinglot.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | return OUT_OF_BOUNDS; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `OUT_OF_BOUNDS` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/parkinglot.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | return exits; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `exits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/parkinglot.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | return spaces; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `spaces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/parkinglot.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | return i; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/parkinglot.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | return result.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | return optimize(&lot); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `optimize(&lot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/astar.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/astar.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/optimize.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | return score; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/optimize.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | return best_lot; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `best_lot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/optimize.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | return new_lot; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_lot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/optimize.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | return new_lot; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_lot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/optimize.rs:188:5 [INFO] [stderr] | [INFO] [stderr] 188 | / return match new_lot.get_exits() == lot.get_exits() { [INFO] [stderr] 189 | | true => new_lot.clone(), [INFO] [stderr] 190 | | false => lot.clone() [INFO] [stderr] 191 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 188 | match new_lot.get_exits() == lot.get_exits() { [INFO] [stderr] 189 | true => new_lot.clone(), [INFO] [stderr] 190 | false => lot.clone() [INFO] [stderr] 191 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/optimize.rs:227:5 [INFO] [stderr] | [INFO] [stderr] 227 | return average_distance; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `average_distance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/optimize.rs:253:5 [INFO] [stderr] | [INFO] [stderr] 253 | return lot; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `lot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/optimize.rs:290:5 [INFO] [stderr] | [INFO] [stderr] 290 | return new_lot; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_lot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/parkinglot.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | return self.lot[y as usize][x as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.lot[y as usize][x as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/parkinglot.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | return OUT_OF_BOUNDS; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `OUT_OF_BOUNDS` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/parkinglot.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | return exits; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `exits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/parkinglot.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | return spaces; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `spaces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/parkinglot.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | return i; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate/parkinglot.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | return result.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | return optimize(&lot); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `optimize(&lot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/generate/optimize.rs:188:12 [INFO] [stderr] | [INFO] [stderr] 188 | return match new_lot.get_exits() == lot.get_exits() { [INFO] [stderr] | ____________^ [INFO] [stderr] 189 | | true => new_lot.clone(), [INFO] [stderr] 190 | | false => lot.clone() [INFO] [stderr] 191 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if new_lot.get_exits() == lot.get_exits() { new_lot.clone() } else { lot.clone() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/generate/optimize.rs:277:17 [INFO] [stderr] | [INFO] [stderr] 277 | / match get_path(Pos(x, y), exit, &new_lot) { [INFO] [stderr] 278 | | Some(_) => {available_exits += 1;} [INFO] [stderr] 279 | | None => {} [INFO] [stderr] 280 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(_) = get_path(Pos(x, y), exit, &new_lot) {available_exits += 1;}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/generate/parkinglot.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | / match self.position(x, y) { [INFO] [stderr] 60 | | EXIT => { [INFO] [stderr] 61 | | exits.push(Pos(x, y)); [INFO] [stderr] 62 | | }, [INFO] [stderr] 63 | | _ => {} [INFO] [stderr] 64 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 59 | if let EXIT = self.position(x, y) { [INFO] [stderr] 60 | exits.push(Pos(x, y)); [INFO] [stderr] 61 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/generate/parkinglot.rs:77:17 [INFO] [stderr] | [INFO] [stderr] 77 | / match self.position(x, y) { [INFO] [stderr] 78 | | SPACE => { [INFO] [stderr] 79 | | spaces.push(Pos(x, y)); [INFO] [stderr] 80 | | }, [INFO] [stderr] 81 | | _ => {} [INFO] [stderr] 82 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 77 | if let SPACE = self.position(x, y) { [INFO] [stderr] 78 | spaces.push(Pos(x, y)); [INFO] [stderr] 79 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/generate/parkinglot.rs:134:27 [INFO] [stderr] | [INFO] [stderr] 134 | match column.clone() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*column` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/generate/parkinglot.rs:157:33 [INFO] [stderr] | [INFO] [stderr] 157 | result += match column.clone() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in threads.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:73:14 [INFO] [stderr] | [INFO] [stderr] 73 | for t in threads { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/generate/optimize.rs:188:12 [INFO] [stderr] | [INFO] [stderr] 188 | return match new_lot.get_exits() == lot.get_exits() { [INFO] [stderr] | ____________^ [INFO] [stderr] 189 | | true => new_lot.clone(), [INFO] [stderr] 190 | | false => lot.clone() [INFO] [stderr] 191 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if new_lot.get_exits() == lot.get_exits() { new_lot.clone() } else { lot.clone() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/generate/optimize.rs:277:17 [INFO] [stderr] | [INFO] [stderr] 277 | / match get_path(Pos(x, y), exit, &new_lot) { [INFO] [stderr] 278 | | Some(_) => {available_exits += 1;} [INFO] [stderr] 279 | | None => {} [INFO] [stderr] 280 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(_) = get_path(Pos(x, y), exit, &new_lot) {available_exits += 1;}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/generate/parkinglot.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | / match self.position(x, y) { [INFO] [stderr] 60 | | EXIT => { [INFO] [stderr] 61 | | exits.push(Pos(x, y)); [INFO] [stderr] 62 | | }, [INFO] [stderr] 63 | | _ => {} [INFO] [stderr] 64 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 59 | if let EXIT = self.position(x, y) { [INFO] [stderr] 60 | exits.push(Pos(x, y)); [INFO] [stderr] 61 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/generate/parkinglot.rs:77:17 [INFO] [stderr] | [INFO] [stderr] 77 | / match self.position(x, y) { [INFO] [stderr] 78 | | SPACE => { [INFO] [stderr] 79 | | spaces.push(Pos(x, y)); [INFO] [stderr] 80 | | }, [INFO] [stderr] 81 | | _ => {} [INFO] [stderr] 82 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 77 | if let SPACE = self.position(x, y) { [INFO] [stderr] 78 | spaces.push(Pos(x, y)); [INFO] [stderr] 79 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/generate/parkinglot.rs:134:27 [INFO] [stderr] | [INFO] [stderr] 134 | match column.clone() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*column` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/generate/parkinglot.rs:157:33 [INFO] [stderr] | [INFO] [stderr] 157 | result += match column.clone() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in threads.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:73:14 [INFO] [stderr] | [INFO] [stderr] 73 | for t in threads { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.90s [INFO] running `"docker" "inspect" "80886f33c608f3f10e50a9977332e0a3897840a4afde616193829a1c8a19ba35"` [INFO] running `"docker" "rm" "-f" "80886f33c608f3f10e50a9977332e0a3897840a4afde616193829a1c8a19ba35"` [INFO] [stdout] 80886f33c608f3f10e50a9977332e0a3897840a4afde616193829a1c8a19ba35