[INFO] updating cached repository acris17/site
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/acris17/site
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/acris17/site" "work/ex/clippy-test-run/sources/stable/gh/acris17/site"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/acris17/site'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/acris17/site" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/acris17/site"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/acris17/site'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 7cd44352b6f9a23bb6cacb9b5716e6a9437e77c9
[INFO] sha for GitHub repo acris17/site: 7cd44352b6f9a23bb6cacb9b5716e6a9437e77c9
[INFO] validating manifest of acris17/site on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of acris17/site on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing acris17/site
[INFO] finished frobbing acris17/site
[INFO] frobbed toml for acris17/site written to work/ex/clippy-test-run/sources/stable/gh/acris17/site/Cargo.toml
[INFO] started frobbing acris17/site
[INFO] finished frobbing acris17/site
[INFO] frobbed toml for acris17/site written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/acris17/site/Cargo.toml
[INFO] crate acris17/site has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting acris17/site against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/acris17/site:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d06323b6db44ffc01cc9d4d88c4166980362110626db44f0272c1765eedb84f4
[INFO] running `"docker" "start" "-a" "d06323b6db44ffc01cc9d4d88c4166980362110626db44f0272c1765eedb84f4"`
[INFO] [stderr]     Checking toml v0.4.6
[INFO] [stderr]     Checking site v0.3.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/args.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 |     matches
[INFO] [stderr]    |     ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/args.rs:5:19
[INFO] [stderr]    |
[INFO] [stderr] 5  |       let matches = App::new(env!("CARGO_PKG_NAME"))
[INFO] [stderr]    |  ___________________^
[INFO] [stderr] 6  | |         .version(env!("CARGO_PKG_VERSION"))
[INFO] [stderr] 7  | |         .about(env!("CARGO_PKG_DESCRIPTION"))
[INFO] [stderr] 8  | |
[INFO] [stderr] ...  |
[INFO] [stderr] 18 | |             .index(1))
[INFO] [stderr] 19 | |         .get_matches();
[INFO] [stderr]    | |______________________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/support.rs:17:11
[INFO] [stderr]    |
[INFO] [stderr] 17 |     match std::env::home_dir() {
[INFO] [stderr]    |           ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/args.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 |     matches
[INFO] [stderr]    |     ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/args.rs:5:19
[INFO] [stderr]    |
[INFO] [stderr] 5  |       let matches = App::new(env!("CARGO_PKG_NAME"))
[INFO] [stderr]    |  ___________________^
[INFO] [stderr] 6  | |         .version(env!("CARGO_PKG_VERSION"))
[INFO] [stderr] 7  | |         .about(env!("CARGO_PKG_DESCRIPTION"))
[INFO] [stderr] 8  | |
[INFO] [stderr] ...  |
[INFO] [stderr] 18 | |             .index(1))
[INFO] [stderr] 19 | |         .get_matches();
[INFO] [stderr]    | |______________________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/support.rs:17:11
[INFO] [stderr]    |
[INFO] [stderr] 17 |     match std::env::home_dir() {
[INFO] [stderr]    |           ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/support.rs:48:9
[INFO] [stderr]    |
[INFO] [stderr] 48 | /         match is_path(&support_path) {
[INFO] [stderr] 49 | |             true  => Ok(()),
[INFO] [stderr] 50 | |             false => std::fs::create_dir(support_path)
[INFO] [stderr] 51 | |         }
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if is_path(&support_path) { Ok(()) } else { std::fs::create_dir(support_path) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/support.rs:58:9
[INFO] [stderr]    |
[INFO] [stderr] 58 | /         match is_path(&container_path) {
[INFO] [stderr] 59 | |             true  => Ok(()),
[INFO] [stderr] 60 | |             false => std::fs::create_dir(container_path)
[INFO] [stderr] 61 | |         }
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if is_path(&container_path) { Ok(()) } else { std::fs::create_dir(container_path) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/support.rs:68:9
[INFO] [stderr]    |
[INFO] [stderr] 68 | /         match is_path(&config_path) {
[INFO] [stderr] 69 | |             true  => Ok(()),
[INFO] [stderr] 70 | |             false => make_file(&config_path)
[INFO] [stderr] 71 | |         }
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if is_path(&config_path) { Ok(()) } else { make_file(&config_path) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/support.rs:77:5
[INFO] [stderr]    |
[INFO] [stderr] 77 | /     match std::fs::File::create(path).is_ok() {
[INFO] [stderr] 78 | |         true  => Ok(()),
[INFO] [stderr] 79 | |         false => Err(Error::new(ErrorKind::Other, "Could not create file"))
[INFO] [stderr] 80 | |     }
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if std::fs::File::create(path).is_ok() { Ok(()) } else { Err(Error::new(ErrorKind::Other, "Could not create file")) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/support.rs:48:9
[INFO] [stderr]    |
[INFO] [stderr] 48 | /         match is_path(&support_path) {
[INFO] [stderr] 49 | |             true  => Ok(()),
[INFO] [stderr] 50 | |             false => std::fs::create_dir(support_path)
[INFO] [stderr] 51 | |         }
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if is_path(&support_path) { Ok(()) } else { std::fs::create_dir(support_path) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/support.rs:58:9
[INFO] [stderr]    |
[INFO] [stderr] 58 | /         match is_path(&container_path) {
[INFO] [stderr] 59 | |             true  => Ok(()),
[INFO] [stderr] 60 | |             false => std::fs::create_dir(container_path)
[INFO] [stderr] 61 | |         }
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if is_path(&container_path) { Ok(()) } else { std::fs::create_dir(container_path) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/support.rs:68:9
[INFO] [stderr]    |
[INFO] [stderr] 68 | /         match is_path(&config_path) {
[INFO] [stderr] 69 | |             true  => Ok(()),
[INFO] [stderr] 70 | |             false => make_file(&config_path)
[INFO] [stderr] 71 | |         }
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if is_path(&config_path) { Ok(()) } else { make_file(&config_path) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/support.rs:77:5
[INFO] [stderr]    |
[INFO] [stderr] 77 | /     match std::fs::File::create(path).is_ok() {
[INFO] [stderr] 78 | |         true  => Ok(()),
[INFO] [stderr] 79 | |         false => Err(Error::new(ErrorKind::Other, "Could not create file"))
[INFO] [stderr] 80 | |     }
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if std::fs::File::create(path).is_ok() { Ok(()) } else { Err(Error::new(ErrorKind::Other, "Could not create file")) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 5.38s
[INFO] running `"docker" "inspect" "d06323b6db44ffc01cc9d4d88c4166980362110626db44f0272c1765eedb84f4"`
[INFO] running `"docker" "rm" "-f" "d06323b6db44ffc01cc9d4d88c4166980362110626db44f0272c1765eedb84f4"`
[INFO] [stdout] d06323b6db44ffc01cc9d4d88c4166980362110626db44f0272c1765eedb84f4